biz-a-cli 2.3.80-15227 → 2.3.80-15230

package/engine/bpm/bpm-agent.js

@@ -2,6 +2,7 @@ import {
 	executeEffect,
 	executeTimerJob,
 	executeBackgroundTransition,
+	initiate,
 } from "./workflow-runtime.js";
 import {
 	queryData,
@@ -65,6 +66,18 @@ export function initBpmAgent(broker, services = "") {
 		}
 	});
 
+	broker.on("bpm:initiate", async (payload) => {
+		try {
+			const { entityType, entityId } = payload || {};
+			await initiate({ ...payload, apiConfig: getGlobalConfig() });
+			console.log(
+				`[BPM Agent] Initiated workflow for ${entityType} ${entityId}.`,
+			);
+		} catch (error) {
+			console.error(`[BPM Agent] Initiate Failed:`, error.message);
+		}
+	});
+
 	broker.on("bpm:effect", async (payload, ackCallback) => {
 		if (!payload || (!payload.id && !payload.ID)) {
 			pollEffects();

package/engine/bpm/workflow-runtime.js

@@ -1227,10 +1227,25 @@ export async function executeEffect(effectData) {
 
 		if (effectType === "CLI_SCRIPT") {
 			console.log(`[BPM Engine] Bridging Script: ${eventName}`);
+			// Auto-inject the effect's own instanceId so the CLI script knows which workflow
+			// instance triggered it (per the BPM spec's payload-injection contract). Without
+			// this, a script that keys off scriptData.instanceId has no way to identify the
+			// instance when the effect carries no payloadTemplate.
+			const scriptData = Object.assign(
+				{},
+				parsedPayload && typeof parsedPayload === "object" && !Array.isArray(parsedPayload)
+					? parsedPayload
+					: {},
+				{
+					instanceId:
+						effectData.sys$bpm_wf_instance_id ||
+						effectData.SYS$BPM_WF_INSTANCE_ID,
+				},
+			);
 			const scriptResult = await execCLIScriptWorker(
 				apiConfig,
 				eventName,
-				parsedPayload,
+				scriptData,
 			);
 
 			// --- if cliScript of Effect need to run executeTransition ---

package/engine/domain/appConfig.js

@@ -429,12 +429,10 @@ const isFirebird25NotNullCheckForColumn = (check, columnName) => {
 		.replace(/^CHECK\s*/i, "")
 		.replace(/"/g, "")
 		.replace(/\s+/g, "")
-		.toUpperCase();
+		.toUpperCase()
+		.replace(/^\(+|\)+$/g, "");
 	const normalizedColumnName = toConstraintIdentifierPart(columnName);
-	return (
-		expression === `${normalizedColumnName}ISNOTNULL` ||
-		expression === `(${normalizedColumnName}ISNOTNULL)`
-	);
+	return expression === `${normalizedColumnName}ISNOTNULL`;
 };
 
 const resolveFirebird25NotNullCheckState = (tableName, columnName, actual) => {
@@ -451,6 +449,9 @@ const resolveFirebird25NotNullCheckState = (tableName, columnName, actual) => {
 	};
 };
 
+const getNotNullChecksForColumn = (actual, columnName) =>
+	(actual.checks ?? []).filter((check) => isFirebird25NotNullCheckForColumn(check, columnName));
+
 const describeColumnDependency = (dependency) => {
 	const dependentName = dependency.dependentName || "unnamed object";
 	return `dependency ${dependentName} (type ${dependency.dependentType})`;
@@ -588,11 +589,34 @@ export const buildTableSyncPlan = (expected, actual, options) => {
 	const migrationMode = options?.migrationMode ?? "safe";
 	const allowDestructiveChanges = migrationMode === "aggressive";
 	const compare = compareTableStructure(expected, actual);
-	if (compare.isSame) {
+	const expectedColumnsForCleanup = new Map(
+		(expected.columns ?? []).map((column) => [column.name.trim().toUpperCase(), column]),
+	);
+	const actualColumnsForCleanup = new Map(
+		(actual.columns ?? []).map((column) => [column.name.trim().toUpperCase(), column]),
+	);
+	const notNullChecksToDrop = [];
+	const seenNotNullChecks = new Set();
+	for (const [columnName, expectedColumn] of expectedColumnsForCleanup.entries()) {
+		if (expectedColumn.nullable === false || !actualColumnsForCleanup.has(columnName)) {
+			continue;
+		}
+		for (const check of getNotNullChecksForColumn(actual, expectedColumn.name)) {
+			const constraintName = String(check?.name ?? "").trim();
+			const constraintKey = constraintName.toUpperCase();
+			if (constraintName && !seenNotNullChecks.has(constraintKey)) {
+				seenNotNullChecks.add(constraintKey);
+				notNullChecksToDrop.push(constraintName);
+			}
+		}
+	}
+	if (compare.isSame && notNullChecksToDrop.length === 0) {
 		return { statements: [], warnings: [], differences: [] };
 	}
 
-	const statements = [];
+	const statements = notNullChecksToDrop.map(
+		(constraintName) => `ALTER TABLE ${expected.name} DROP CONSTRAINT ${constraintName};`,
+	);
 	const warnings = [];
 
 	const expectedColumns = new Map();
@@ -1236,6 +1260,11 @@ const buildEntityTable = (entityName, entity, defaultDbIndex) => {
 	const columns = attributeEntries.map((entry) => entry.column);
 	ensureIdentityPrimaryColumn(columns, entity?.identity);
 	const primaryKey = resolvePrimaryKey(entity, columns);
+	const identityPrimaryKey = toDbName(entity?.identity?.primaryKey ?? "");
+	const identityColumn = columns.find((column) => column.name === identityPrimaryKey);
+	if (identityColumn) {
+		identityColumn.nullable = false;
+	}
 	const uniqueKeys = buildUniqueKeys(tableName, attributeEntries, primaryKey);
 	const indexes = buildAttributeIndexes(tableName, attributeEntries, primaryKey, uniqueKeys);
 

package/engine/domain/applicationConfig.js

@@ -627,18 +627,52 @@ export const publishApplicationConfig = async (payload = {}, argv = {}) => {
 	}
 	const parsedApplicationConfig = parseConfigData(appRow.data) ?? {};
 
-	const domainConfigName = String(payload?.domainConfigName ?? "").trim();
-	const domainConfigVersion = String(payload?.domainConfigVersion ?? "").trim();
-	let parsedDomainConfig = {};
-	if (domainConfigName && domainConfigVersion) {
-		const domainRows = await queryData(getConfigByNameVersionParameters(domainConfigName, domainConfigVersion), config);
-		const domainRow = domainRows?.[0];
-		if (domainRow?.data) {
-			parsedDomainConfig = parseConfigData(domainRow.data) ?? {};
+	/* An app bundle publish is a full replace (addApp() rebuilds the whole bundle from scratch every call), so
+	   template.js scaffolding must be generated for EVERY domain registered in application.js's `domains` map, not
+	   just whichever one this particular publish call cares about -- otherwise every other domain's screens silently
+	   drop out of the bundle on the next publish. Real incident: Supertail's own runtime-domain publish passed only
+	   `supertailruntime` as the domain to scan, which wiped out all 21 of supertailsetup's template files (they'd
+	   only ever been generated because the Admin's own editor happened to have supertailsetup loaded). */
+	const domainMap =
+		parsedApplicationConfig?.domains && typeof parsedApplicationConfig.domains === "object" ? parsedApplicationConfig.domains : {};
+	const domainsToScan = new Map();
+	for (const [domainKey, domainDef] of Object.entries(domainMap)) {
+		const source = String(domainDef?.source ?? "").trim();
+		const [sourceName, sourceVersion] = source.split("@").map((part) => String(part ?? "").trim());
+		if (sourceName && sourceVersion) {
+			domainsToScan.set(domainKey, { domainConfigName: sourceName, domainConfigVersion: sourceVersion });
+		}
+	}
+	const explicitDomainConfigName = String(payload?.domainConfigName ?? "").trim();
+	const explicitDomainConfigVersion = String(payload?.domainConfigVersion ?? "").trim();
+	if (explicitDomainConfigName && explicitDomainConfigVersion && !domainsToScan.has(explicitDomainConfigName)) {
+		domainsToScan.set(explicitDomainConfigName, { domainConfigName: explicitDomainConfigName, domainConfigVersion: explicitDomainConfigVersion });
+	}
+
+	const mergedFileList = [];
+	const seenFileNames = new Set();
+	const addFilesToMergedList = (fileList) => {
+		for (const file of fileList) {
+			if (seenFileNames.has(file.name)) {
+				continue;
+			}
+			seenFileNames.add(file.name);
+			mergedFileList.push(file);
+		}
+	};
+
+	if (domainsToScan.size === 0) {
+		addFilesToMergedList(buildPublishBodyFromConfigs(parsedApplicationConfig, {}, "").fileList);
+	} else {
+		for (const [domainKey, { domainConfigName, domainConfigVersion }] of domainsToScan) {
+			const domainRows = await queryData(getConfigByNameVersionParameters(domainConfigName, domainConfigVersion), config);
+			const domainRow = domainRows?.[0];
+			const parsedDomainConfig = domainRow?.data ? (parseConfigData(domainRow.data) ?? {}) : {};
+			addFilesToMergedList(buildPublishBodyFromConfigs(parsedApplicationConfig, parsedDomainConfig, domainKey).fileList);
 		}
 	}
 
-	const publishBody = buildPublishBodyFromConfigs(parsedApplicationConfig, parsedDomainConfig, domainConfigName);
+	const publishBody = { verbose: false, fileList: mergedFileList };
 
 	const response = await publishApp(
 		{

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "biz-a-cli",
-	"version": "2.3.80-15227",
+	"version": "2.3.80-15230",
 	"description": "",
 	"main": "bin/index.js",
 	"type": "module",