bits-to-dead-trees 2.0.0 → 2.0.1

package/CHANGELOG.md

@@ -1,5 +1,12 @@
 # bits-to-dead-trees
 
+## 2.0.1
+
+### Patch Changes
+
+- 57d032f: Don't close browser if it's currently creating a PDF. We've added smoke tests, so
+  this shouldn't happen again. Sorry!
+
 ## 2.0.0
 
 ### Major Changes

package/app.js

@@ -54,10 +54,10 @@ const createPDF = async (
 
     const response = await page.goto(url, gotoOptions);
     if (response?.ok()) {
-      return page.pdf(pdfOptions);
+      return await page.pdf(pdfOptions);
     }
 
-    return Promise.reject({
+    return await Promise.reject({
       error: true,
       message: await response?.text(),
       status: response?.status(),

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bits-to-dead-trees",
   "author": "Robin Mehner <robin@coding-robin.de>",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "Turn HTML into PDF files",
   "repository": "github:rmehner/bits-to-dead-trees",
   "license": "Apache-2.0",
@@ -36,13 +36,13 @@
   "devDependencies": {
     "@changesets/cli": "^2.26.0",
     "@types/lodash": "^4.14.191",
-    "eslint": "^8.32.0",
+    "eslint": "^8.33.0",
     "eslint-config-prettier": "^8.6.0",
     "nodemon": "^2.0.20",
     "pino-pretty": "^9.1.1",
     "prettier": "^2.8.3",
-    "tslib": "^2.4.1",
+    "tslib": "^2.5.0",
     "typescript-json-schema": "^0.55.0",
-    "vitest": "^0.28.2"
+    "vitest": "^0.28.3"
   }
 }

package/test/app.test.ts

@@ -50,7 +50,6 @@ describe("POST /pdf", () => {
     pdf = vi.fn().mockResolvedValue(Buffer.from("pdf"));
     newPage = vi.fn().mockResolvedValue({ goto: gotoMethod, pdf });
     newContext = vi.fn().mockResolvedValue({ newPage });
-    close = vi.fn();
 
     (chromium.launch as Mock<any[], any>).mockResolvedValue({
       newContext,
@@ -223,4 +222,28 @@ describe("POST /pdf", () => {
 
     expect(close).toHaveBeenCalled();
   });
+
+  it("generates the pdf before closing the browser", async () => {
+    let i = 0;
+
+    pdf.mockImplementation(async () => {
+      await new Promise((r) => setTimeout(r, 100));
+
+      return i++;
+    });
+
+    close.mockImplementation(() => {
+      return i++;
+    });
+
+    await app.inject({
+      method: "POST",
+      url: "/pdf",
+      payload: {
+        url: "https://google.com",
+      },
+    });
+
+    expect(pdf.mock.results[0].value).toBeLessThan(close.mock.results[0].value);
+  });
 });

package/test/smoke.test.js

@@ -0,0 +1,36 @@
+import { describe, expect, it } from "vitest";
+
+import build from "../app";
+const app = build();
+
+describe("Smoke tests", () => {
+  it("sends the PDF on the success case", async () => {
+    const response = await app.inject({
+      method: "POST",
+      url: "/pdf",
+      payload: { url: "https://coding-robin.de" },
+    });
+
+    expect(response.payload.startsWith("%PDF")).toBeTruthy();
+  });
+
+  it("returns an error object when the page could not be loaded", async () => {
+    const response = await app.inject({
+      method: "POST",
+      url: "/pdf",
+      payload: {
+        url: "http://httpbin.org/status/404",
+      },
+    });
+
+    expect(response.statusCode).toEqual(404);
+    const error = JSON.parse(response.body);
+
+    expect(error).toMatchObject({
+      error: true,
+      status: 404,
+      statusText: "NOT FOUND",
+      message: "",
+    });
+  });
+});