bitmovin-player-ui 3.76.0 → 3.78.0

package/dist/js/framework/components/container.js

@@ -103,10 +103,10 @@ var Container = /** @class */ (function (_super) {
          * the DOM, their content gets preserved in all browsers.
          */
         var component;
-        while (component = this.componentsToRemove.shift()) {
+        while ((component = this.componentsToRemove.shift()) !== undefined) {
             component.getDomElement().remove();
         }
-        while (component = this.componentsToAdd.shift()) {
+        while ((component = this.componentsToAdd.shift()) !== undefined) {
             this.innerContainerElement.append(component.getDomElement());
         }
     };

package/dist/js/framework/components/listselector.js

@@ -49,9 +49,9 @@ var ListSelector = /** @class */ (function (_super) {
         return _this;
     }
     ListSelector.prototype.getItemIndex = function (key) {
-        for (var index in this.items) {
-            if (key === this.items[index].key) {
-                return parseInt(index);
+        for (var i = 0; i < this.items.length; i++) {
+            if (this.items[i].key === key) {
+                return i;
             }
         }
         return -1;

package/dist/js/framework/components/playbacktimelabel.js

@@ -173,8 +173,7 @@ var PlaybackTimeLabel = /** @class */ (function (_super) {
                 this.setText("".concat(currentTime, " / ").concat(totalTime));
                 break;
             case PlaybackTimeLabelMode.RemainingTime:
-                var remainingTime = stringutils_1.StringUtils.secondsToTime(durationSeconds - playbackSeconds, this.timeFormat);
-                this.setText("".concat(remainingTime));
+                this.setText("".concat(stringutils_1.StringUtils.secondsToTime(durationSeconds - playbackSeconds, this.timeFormat)));
                 break;
         }
     };

package/dist/js/framework/components/seekbarcontroller.js

@@ -42,9 +42,11 @@ var SeekBarController = /** @class */ (function () {
     };
     SeekBarController.prototype.seekBarControls = function (type) {
         if (type === SeekBarType.Live) {
+            // eslint-disable-next-line @typescript-eslint/unbound-method
             return this.arrowKeyControls(this.player.getTimeShift(), { min: this.player.getMaxTimeShift(), max: 0 }, this.player.timeShift);
         }
         else if (type === SeekBarType.Vod) {
+            // eslint-disable-next-line @typescript-eslint/unbound-method
             return this.arrowKeyControls(this.player.getCurrentTime(), { min: 0, max: this.player.getDuration() }, this.player.seek);
         }
         else if (type === SeekBarType.Volume && this.volumeController != null) {

package/dist/js/framework/components/settingspanel.js

@@ -305,6 +305,7 @@ var SettingsPanel = exports.SettingsPanel = /** @class */ (function (_super) {
     SettingsPanel.prototype.forceBrowserReflow = function () {
         // Force the browser to reflow the layout
         // https://gist.github.com/paulirish/5d52fb081b3570c81e3a
+        // eslint-disable-next-line @typescript-eslint/no-unused-expressions
         this.getDomElement().get(0).offsetLeft;
     };
     /**

package/dist/js/framework/localization/i18n.js

@@ -84,6 +84,7 @@ var I18n = /** @class */ (function () {
         }
         return matches
             .map(function (m) { return ({ match: m, key: m.slice(1, -1) }); })
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-call
             .reduce(function (str, _a) {
             var key = _a.key, match = _a.match;
             return config.hasOwnProperty(key) ? str.replace(match, config[key]) : str;

package/dist/js/framework/main.js

@@ -16,7 +16,7 @@ var __exportStar = (this && this.__exportStar) || function(m, exports) {
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ClickOverlay = exports.VolumeControlButton = exports.TitleBar = exports.SubtitleSelectBox = exports.SubtitleOverlay = exports.SeekBarLabel = exports.RecommendationOverlay = exports.ErrorMessageOverlay = exports.Component = exports.CastToggleButton = exports.CastStatusOverlay = exports.AudioTrackSelectBox = exports.AudioQualitySelectBox = exports.Label = exports.Container = exports.UIContainer = exports.Watermark = exports.VRToggleButton = exports.VolumeToggleButton = exports.VideoQualitySelectBox = exports.ToggleButton = exports.SettingsToggleButton = exports.SettingsPanel = exports.ItemSelectionList = exports.SelectBox = exports.SeekBar = exports.PlaybackToggleButton = exports.PlaybackTimeLabelMode = exports.PlaybackTimeLabel = exports.HugePlaybackToggleButton = exports.FullscreenToggleButton = exports.ControlBar = exports.Button = exports.ListOrientation = exports.ListNavigationGroup = exports.RootNavigationGroup = exports.NavigationGroup = exports.SpatialNavigation = exports.I18n = exports.i18n = exports.ErrorUtils = exports.StorageUtils = exports.BrowserUtils = exports.UIUtils = exports.PlayerUtils = exports.StringUtils = exports.ArrayUtils = exports.DemoFactory = exports.UIFactory = exports.version = void 0;
 exports.ListSelector = exports.QuickSeekButton = exports.ReplayButton = exports.SettingsPanelItem = exports.SubtitleSettingsPanelPage = exports.SettingsPanelPageOpenButton = exports.SettingsPanelPageBackButton = exports.SettingsPanelPage = exports.AudioTrackListBox = exports.SubtitleListBox = exports.ListBox = exports.SubtitleSettingsResetButton = exports.WindowOpacitySelectBox = exports.WindowColorSelectBox = exports.SubtitleSettingsLabel = exports.SubtitleSettingSelectBox = exports.FontSizeSelectBox = exports.FontOpacitySelectBox = exports.FontFamilySelectBox = exports.FontColorSelectBox = exports.CharacterEdgeSelectBox = exports.BackgroundOpacitySelectBox = exports.BackgroundColorSelectBox = exports.Spacer = exports.PictureInPictureToggleButton = exports.VolumeSlider = exports.AirPlayToggleButton = exports.MetadataLabelContent = exports.MetadataLabel = exports.CloseButton = exports.PlaybackToggleOverlay = exports.CastUIContainer = exports.BufferingOverlay = exports.HugeReplayButton = exports.PlaybackSpeedSelectBox = exports.AdClickOverlay = exports.AdMessageLabel = exports.AdSkipButton = void 0;
-exports.version = '3.76.0';
+exports.version = '3.78.0';
 // Management
 __exportStar(require("./uimanager"), exports);
 __exportStar(require("./uiconfig"), exports);

package/dist/js/framework/spatialnavigation/navigationgroup.js

@@ -89,6 +89,7 @@ var NavigationGroup = /** @class */ (function () {
             }
             return;
         }
+        // eslint-disable-next-line @typescript-eslint/unbound-method
         this.handleInput(direction, this.defaultNavigationHandler, this.onNavigation);
     };
     /**
@@ -97,6 +98,7 @@ var NavigationGroup = /** @class */ (function () {
      * @param action The action of the event
      */
     NavigationGroup.prototype.handleAction = function (action) {
+        // eslint-disable-next-line @typescript-eslint/unbound-method
         this.handleInput(action, this.defaultActionHandler, this.onAction);
     };
     /**

package/dist/js/framework/uimanager.js

@@ -730,6 +730,7 @@ var PlayerWrapper = /** @class */ (function () {
         var _loop_1 = function (method) {
             wrapper[method] = function () {
                 // console.log('called ' + member); // track method calls on the player
+                // eslint-disable-next-line @typescript-eslint/no-unsafe-call
                 return player[method].apply(player, arguments);
             };
         };

package/eslint.config.mjs

@@ -0,0 +1,49 @@
+// @ts-check
+
+import { dirname } from 'node:path';
+import { fileURLToPath } from 'node:url';
+import eslint from '@eslint/js';
+import tseslint from 'typescript-eslint';
+
+const __dirname = dirname(fileURLToPath(import.meta.url));
+
+export default tseslint.config({
+  files: [
+    'src/**/*.ts',
+    'spec/**/*.ts',
+  ],
+  extends: [
+    eslint.configs.recommended,
+    ...tseslint.configs.recommendedTypeChecked,
+    {
+      languageOptions: {
+        parserOptions: {
+          projectService: true,
+          tsconfigRootDir: __dirname,
+        },
+      },
+    },
+  ],
+  rules: {
+    'no-prototype-builtins': 'off',
+    'prefer-const': 'off', // TODO: enable rule and run autofix
+    'prefer-rest-params': 'off',
+    '@typescript-eslint/ban-ts-comment': 'off',
+    '@typescript-eslint/no-explicit-any': 'off',
+    '@typescript-eslint/no-namespace': 'off',
+    '@typescript-eslint/no-empty-object-type': 'off',
+    '@typescript-eslint/no-wrapper-object-types': 'off',
+    '@typescript-eslint/no-unused-vars': 'off',
+    '@typescript-eslint/no-unnecessary-type-assertion': 'off',
+    '@typescript-eslint/no-unsafe-enum-comparison': 'off',
+    '@typescript-eslint/no-unsafe-member-access': 'off',
+    '@typescript-eslint/no-unsafe-return': 'off',
+    '@typescript-eslint/no-unsafe-assignment': 'off',
+    '@typescript-eslint/no-unsafe-argument': 'off',
+    '@typescript-eslint/no-redundant-type-constituents': 'off',
+    '@typescript-eslint/no-floating-promises': 'off',
+    '@typescript-eslint/no-unused-expressions': ['error', {
+      allowTernary: true,
+    }]
+  },
+});

package/gulpfile.js

@@ -7,7 +7,7 @@ var cssBase64 = require('gulp-css-base64');
 var postcss = require('gulp-postcss');
 var uglify = require('gulp-uglify');
 var rename = require('gulp-rename');
-var tslint = require('gulp-tslint');
+var gulpESLintNew = require('gulp-eslint-new');
 var sassLint = require('gulp-sass-lint');
 var ts = require('gulp-typescript');
 var replace = require('gulp-replace');
@@ -29,7 +29,6 @@ var buffer = require('vinyl-buffer');
 var del = require('del');
 var browserSync = require('browser-sync');
 var merge = require('merge2');
-var nativeTslint = require('tslint');
 var npmPackage = require('./package.json');
 var path = require('path');
 var combine = require('stream-combiner2');
@@ -93,18 +92,10 @@ gulp.task('copy-json', function() {
 
 // TypeScript linting
 gulp.task('lint-ts', function() {
-  // The program is required for type checking rules to work: https://palantir.github.io/tslint/usage/type-checking/
-  var program = nativeTslint.Linter.createProgram("./tsconfig.json");
-
   return gulp.src(paths.source.ts)
-  .pipe(tslint({
-    formatter: 'verbose',
-    program: program,
-  }))
-  .pipe(tslint.report({
-    // Print just the number of errors (instead of printing all errors again)
-    summarizeFailureOutput: true
-  }))
+    .pipe(gulpESLintNew())
+    .pipe(gulpESLintNew.format())           // Output lint results to the console.
+    .pipe(gulpESLintNew.failAfterError());
 });
 
 // Sass/SCSS linting

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bitmovin-player-ui",
-  "version": "3.76.0",
+  "version": "3.78.0",
   "description": "Bitmovin Player UI Framework",
   "main": "./dist/js/framework/main.js",
   "types": "./dist/js/framework/main.d.ts",
@@ -23,6 +23,7 @@
     "Firefox ESR"
   ],
   "devDependencies": {
+    "@eslint/js": "^9.17.0",
     "@inrupt/jest-jsdom-polyfills": "^1.6.0",
     "@types/jest": "^29.5.0",
     "@types/jsdom": "^21.1.0",
@@ -32,8 +33,10 @@
     "browserify": "^17.0.0",
     "cssnano": "^5.1.15",
     "del": "^2.2.2",
+    "eslint": "^9.17.0",
     "gulp": "^4.0.2",
     "gulp-css-base64": "^2.0.0",
+    "gulp-eslint-new": "^2.4.0",
     "gulp-header": "^2.0.9",
     "gulp-postcss": "^9.0.1",
     "gulp-rename": "^2.0.0",
@@ -41,7 +44,6 @@
     "gulp-sass": "^5.1.0",
     "gulp-sass-lint": "^1.4.0",
     "gulp-sourcemaps": "^3.0.0",
-    "gulp-tslint": "^8.1.4",
     "gulp-typescript": "^5.0.1",
     "gulp-uglify": "^3.0.2",
     "jest": "^29.5.0",
@@ -53,9 +55,9 @@
     "stream-combiner2": "^1.1.1",
     "ts-jest": "^29.0.5",
     "tsify": "^5.0.4",
-    "tslint": "^5.20.1",
     "typedoc": "^0.26.5",
     "typescript": "^5.0.2",
+    "typescript-eslint": "^8.18.1",
     "vinyl-buffer": "^1.0.1",
     "vinyl-source-stream": "^2.0.0",
     "watchify": "^4.0.0",

package/spec/helper/mockClass.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
 type Constructor<T = unknown> = { new (...params: any[]): T };
 type GenericMock = { [key: string]: jest.Mock };
 

package/spec/release/defineVersion.spec.ts

@@ -1,3 +1,4 @@
+// eslint-disable-next-line @typescript-eslint/no-require-imports
 const { defineReleaseVersion } = require('../../.github/scripts/defineVersion');
 
 describe('defineReleaseVersion', () => {

package/src/ts/components/container.ts

@@ -111,11 +111,11 @@ export class Container<Config extends ContainerConfig> extends Component<Config>
      */
     let component;
 
-    while (component = this.componentsToRemove.shift()) {
+    while ((component = this.componentsToRemove.shift()) !== undefined) {
       component.getDomElement().remove();
     }
 
-    while (component = this.componentsToAdd.shift()) {
+    while ((component = this.componentsToAdd.shift()) !== undefined) {
       this.innerContainerElement.append(component.getDomElement());
     }
   }

package/src/ts/components/listselector.ts

@@ -77,11 +77,12 @@ export abstract class ListSelector<Config extends ListSelectorConfig> extends Co
   }
 
   private getItemIndex(key: string): number {
-    for (let index in this.items) {
-      if (key === this.items[index].key) {
-        return parseInt(index);
+    for (let i = 0; i < this.items.length; i++) {
+      if (this.items[i].key === key) {
+        return i;
       }
     }
+
     return -1;
   }
 

package/src/ts/components/playbacktimelabel.ts

@@ -192,8 +192,7 @@ export class PlaybackTimeLabel extends Label<PlaybackTimeLabelConfig> {
         this.setText(`${currentTime} / ${totalTime}`);
         break;
       case PlaybackTimeLabelMode.RemainingTime:
-        let remainingTime = StringUtils.secondsToTime(durationSeconds - playbackSeconds, this.timeFormat);
-        this.setText(`${remainingTime}`);
+        this.setText(`${StringUtils.secondsToTime(durationSeconds - playbackSeconds, this.timeFormat)}`);
         break;
     }
   }

package/src/ts/components/seekbarcontroller.ts

@@ -70,8 +70,10 @@ export class SeekBarController {
 
   protected seekBarControls(type: SeekBarType) {
     if (type === SeekBarType.Live) {
+      // eslint-disable-next-line @typescript-eslint/unbound-method
       return this.arrowKeyControls(this.player.getTimeShift(), { min: this.player.getMaxTimeShift(), max: 0 }, this.player.timeShift);
     } else if (type === SeekBarType.Vod) {
+      // eslint-disable-next-line @typescript-eslint/unbound-method
       return this.arrowKeyControls(this.player.getCurrentTime(), { min: 0, max: this.player.getDuration() }, this.player.seek);
     } else if (type === SeekBarType.Volume && this.volumeController != null) {
       const volumeTransition = this.volumeController.startTransition();

package/src/ts/components/settingspanel.ts

@@ -367,6 +367,7 @@ export class SettingsPanel extends Container<SettingsPanelConfig> {
   private forceBrowserReflow(): void {
     // Force the browser to reflow the layout
     // https://gist.github.com/paulirish/5d52fb081b3570c81e3a
+    // eslint-disable-next-line @typescript-eslint/no-unused-expressions
     this.getDomElement().get(0).offsetLeft;
   }
 

package/src/ts/errorutils.ts

@@ -80,7 +80,7 @@ export namespace ErrorUtils {
 
     if (errorMessage) {
       // Use the error message text if there is one
-      return `${errorMessage}\n(${error.name})`; // default error message style
+      return `${errorMessage as string}\n(${error.name})`; // default error message style
     } else {
       // Fallback to error code/name if no message is defined
       return `${error.code} ${error.name}`;

package/src/ts/localization/i18n.ts

@@ -184,6 +184,7 @@ export class I18n {
 
     return matches
       .map((m: string) => ({ match: m, key: m.slice(1, -1) }))
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-call
       .reduce((str, { key, match }) => config.hasOwnProperty(key) ? str.replace(match, config[key]) : str, text);
   }
 

package/src/ts/spatialnavigation/navigationgroup.ts

@@ -122,6 +122,8 @@ export class NavigationGroup {
       }
       return;
     }
+
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     this.handleInput(direction, this.defaultNavigationHandler, this.onNavigation);
   }
 
@@ -131,6 +133,7 @@ export class NavigationGroup {
    * @param action The action of the event
    */
   public handleAction(action: Action): void {
+    // eslint-disable-next-line @typescript-eslint/unbound-method
     this.handleInput(action, this.defaultActionHandler, this.onAction);
   }
 

package/src/ts/uimanager.ts

@@ -887,6 +887,7 @@ export class PlayerWrapper {
     for (let method of methods) {
       wrapper[method] = function() {
         // console.log('called ' + member); // track method calls on the player
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-call
         return (<any>player)[method].apply(player, arguments);
       };
     }

package/tsconfig.json

@@ -8,6 +8,7 @@
     "declaration": true,
     "outDir": "dist/js/framework",
     "lib": ["es6", "dom", "scripthost"],
+    "skipLibCheck": true,
     // To be able to import Json Files.
     "resolveJsonModule": true,
     "esModuleInterop": true

package/tslint.json

@@ -1,39 +0,0 @@
-{
-  "rules": {
-    "class-name": true,
-    "comment-format": [true, "check-space"],
-    "indent": [true, "spaces"],
-    "no-duplicate-variable": true,
-    "no-eval": true,
-    "no-internal-module": true,
-    "no-trailing-whitespace": true,
-    "no-var-keyword": false,
-    "one-line": [true, "check-open-brace", "check-whitespace"],
-    "quotemark": [true, "single"],
-    "semicolon": [true, "always", "ignore-bound-class-methods"],
-    "triple-equals": [true, "allow-null-check"],
-    "typedef-whitespace": [true, {
-      "call-signature": "nospace",
-      "index-signature": "nospace",
-      "parameter": "nospace",
-      "property-declaration": "nospace",
-      "variable-declaration": "nospace"
-    }],
-    "variable-name": [true, "ban-keywords"],
-    "whitespace": [true,
-      "check-branch",
-      "check-decl",
-      "check-operator",
-      "check-separator",
-      "check-type"
-    ],
-    "trailing-comma": [true, {"multiline": {
-      "arrays": "always",
-      "exports": "always",
-      "functions": "always",
-      "imports": "always",
-      "objects": "always",
-      "typeLiterals": "always"
-    }, "singleline": "never"}]
-  }
-}