bitmovin-player-react-native 1.1.0 → 1.2.0

package/.prettierignore

@@ -9,3 +9,4 @@ integration_test/android/
 integration_test/ios/
 integration_test/ios/Pods/
 .github/*.md
+CLAUDE.md

package/AGENTS.md

@@ -0,0 +1,91 @@
+# Repository Guidelines
+
+## Project Structure & Module Organization
+
+- `src/`: TypeScript API surface and React components (library code).
+- `ios/`, `android/`: Native bridges (Swift/Kotlin) used by the Expo Module.
+- `plugin/`: Expo Config Plugin code used during prebuild.
+- `example/`: Runnable sample app (Expo) to develop and validate changes.
+- `integration_test/`: Expo app + Cavy-based integration tests.
+- `scripts/`: Repo tooling (lint/format hooks, helpers). `build/`: transpiled output.
+
+## Build, Test, and Development Commands
+
+- `yarn bootstrap` — install deps, prebuild example, set up pods.
+- `yarn build` (`build:module`, `build:plugin`) — build the library and plugin to `build/`.
+- `yarn example start | ios | android` — run Metro or launch the example on simulators/emulators.
+- `yarn integration-test test:ios | test:android | test` — run Cavy tests.
+- `yarn lint` (`lint:all`), `yarn typecheck` (`typecheck:all`), `yarn format:all` — quality gates.
+- `yarn docs` — generate TypeDoc documentation.
+
+## Coding Style & Naming Conventions
+
+- TypeScript: ESLint + Prettier (2 spaces, single quotes, trailing commas `es5`).
+- Names: types/interfaces PascalCase; variables/functions camelCase; React components PascalCase.
+- Files in `src/` use camelCase (e.g., `playerConfig.ts`).
+- iOS: SwiftLint via `yarn lint:ios`; format with `yarn format:ios`.
+- Android: ktlint via `yarn lint:android`; format with `yarn format:android`.
+
+## Testing Guidelines
+
+- Framework: Cavy; tests live under `integration_test/tests`.
+- Setup: `cp integration_test/.env.example integration_test/.env` and set `EXPO_PUBLIC_BITMOVIN_PLAYER_LICENSE_KEY`.
+- Run: `yarn integration-test test:ios` or `test:android` (simulator/emulator only).
+- Add per‑feature tests (e.g., `Playback.test.ts`) covering happy‑path and error events.
+
+## Commit & Pull Request Guidelines
+
+- Commits: concise, imperative; do not use prefixes such as `fix:`, `chore:`, etc.
+- PRs: follow `.github/PULL_REQUEST_TEMPLATE.md`; link issues; add screenshots for UI-facing changes.
+- Required before review: `yarn lint:all`, `yarn typecheck:all`, build the library, and run the example on at least one platform.
+- Changelog: add a `CHANGELOG.md` entry for user‑visible behavior changes.
+
+## Security & Configuration Tips
+
+- Never commit secrets. Keep license keys only in `integration_test/.env` (gitignored).
+
+## Docs Index
+
+- CONTRIBUTING.md — Development workflow, Development setup, TypeScript Code Style, Linting (pre-commit hooks), Kotlin, Swift, Testing, Scripts.
+- example/README.md — Getting started, Development Setup (.env and license keys), Running the application (iOS/Android/tvOS/Android TV), Bundler only, Architecture, Troubleshooting.
+- integration_test/README.md — Setup, Environment Configuration (.env), Running the tests, Architecture, Test Coverage, Platform Support.
+- README.md — “Sample Application” section links to `example/` README and official docs; use as entry point.
+
+## Developer Essentials
+
+- Environment
+  - Node + Yarn (use Yarn across workspaces); macOS: Xcode + CocoaPods; Android: Android Studio + JDK 17+ (Gradle 8.2 wrapper).
+  - Platforms per README: Expo 53+, React Native 0.79+, React 17+.
+- Tooling & Hooks
+  - Install hooks with `yarn setup-hooks`; verify with `yarn lint:all` and `yarn typecheck:all` before PRs.
+  - SwiftLint/ktlint required for native; use `yarn format:ios` / `yarn format:android` for auto-fixes.
+- Workflow
+  - Bootstrap from repo root: `yarn bootstrap`. Re-run prebuilds after env/native/config changes (`yarn example prebuild`, `yarn integration-test prebuild`).
+  - Public API: export via `src/index.ts`; keep native module/view names identical to TS wrappers; maintain event parity with TS types.
+  - Instance routing uses stable `nativeId` values; ensure native registries clean up on module destruction.
+- Secrets
+  - Never commit keys. Store license keys only in `.env` under `example/` and `integration_test/` as documented.
+- Validation
+  - Use the example app for manual checks and the integration tests on simulators/emulators for feature coverage.
+
+## Routing Public API to React Native
+
+- Source of truth: export public surface from `src/index.ts:1-29` (ensure new modules are re‑exported).
+- Use typed Expo wrappers in `src/modules/`:
+  - Define `declare class <Feature>Module extends NativeModule<Events> { ... }` and load with `requireNativeModule('<Feature>Module')` (example: `src/modules/PlayerModule.ts:1,251`).
+- Match native names exactly on both platforms:
+  - iOS: `Name("PlayerModule")` in `ios/PlayerModule.swift:7`; Android: `Name("PlayerModule")` in `android/src/main/java/com/bitmovin/player/reactnative/PlayerModule.kt:23`.
+- Bridge views via view managers:
+  - TS host component: `requireNativeViewManager('RNPlayerViewManager')` in `src/components/PlayerView/native.ts:33-35`.
+  - iOS manager: `ios/RNPlayerViewManager.swift:6`; Android manager: `android/src/main/java/com/bitmovin/player/reactnative/RNPlayerViewManager.kt:12`.
+- Events flow native → JS via Expo `Events(...)` lists; keep parity with TS props:
+  - Android events list: `android/.../RNPlayerViewManager.kt:50-112`; iOS: `ios/RNPlayerViewManager.swift:33-60`.
+  - TS event typings live in `src/components/PlayerView/nativeEvents.ts:72-160` (extend as needed).
+- Instance routing uses `nativeId` across modules; keep IDs stable and registry-backed on native:
+  - Example registry and async functions in `android/src/main/java/com/bitmovin/player/reactnative/OfflineModule.kt:18-24,41-49`.
+- Adding a new API (happy path):
+  - TS: add method on a `src/modules/<Feature>Module.ts` wrapper, export from `src/index.ts`.
+  - iOS/Android: add matching `AsyncFunction("methodName")` to Expo `ModuleDefinition`; emit events if needed.
+  - Views: add `Prop(...)`/`Events(...)` in native managers and extend `NativePlayerViewProps`.
+  - Tests: extend integration tests; validate on at least one platform.
+  - Naming: keep method/event names identical across TS, iOS, Android.

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## [1.2.0] - 2025-10-17
+
+### Changed
+
+- Update Bitmovin's native iOS SDK version to `3.97.2`
+- Update Bitmovin's native Android SDK version to `3.128.0+jason`
+- Update IMA SDK dependency on iOS to `3.26.1`
+- Update IMA SDK dependency on tvOS to `4.15.1`
+- Update IMA SDK dependency on Android to `3.37.0`
+
 ## [1.1.0] - 2025-09-03
 
 ### Changed

package/android/build.gradle

@@ -104,10 +104,10 @@ dependencies {
   implementation "androidx.concurrent:concurrent-futures-ktx:1.1.0"
 
   // Google IMA
-  implementation 'com.google.ads.interactivemedia.v3:interactivemedia:3.35.1'
+  implementation 'com.google.ads.interactivemedia.v3:interactivemedia:3.37.0'
 
   // Bitmovin
   implementation 'com.google.android.gms:play-services-ads-identifier:18.0.1'
-  implementation 'com.bitmovin.player:player:3.123.0+jason'
-  implementation 'com.bitmovin.player:player-media-session:3.123.0+jason'
+  implementation 'com.bitmovin.player:player:3.128.0+jason'
+  implementation 'com.bitmovin.player:player-media-session:3.128.0+jason'
 }

package/ios/RCTConvert+BitmovinPlayer.swift

@@ -196,7 +196,7 @@ extension RCTConvert {
             return nil
         }
         var request = HttpRequest(url: url, method: method)
-        request.headers = NSMutableDictionary(dictionary: headers)
+        request.headers = headers
 
         if let bodyBase64EncodedString = json["body"] as? String {
             request.body = Data(base64Encoded: bodyBase64EncodedString)

package/ios/RNBitmovinPlayer.podspec

@@ -28,9 +28,9 @@ Pod::Spec.new do |s|
   s.static_framework = true
 
   s.dependency 'ExpoModulesCore'
-  s.dependency "BitmovinPlayer", "3.94.1"
-  s.ios.dependency "GoogleAds-IMA-iOS-SDK", "3.23.0"
-  s.tvos.dependency "GoogleAds-IMA-tvOS-SDK", "4.13.0"
+  s.dependency "BitmovinPlayer", "3.97.2"
+  s.ios.dependency "GoogleAds-IMA-iOS-SDK", "3.26.1"
+  s.tvos.dependency "GoogleAds-IMA-tvOS-SDK", "4.15.1"
 
   if podfile_properties['BITMOVIN_GOOGLE_CAST_SDK_VERSION'].to_s != ''
     s.ios.dependency "google-cast-sdk", podfile_properties['BITMOVIN_GOOGLE_CAST_SDK_VERSION'].to_s

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bitmovin-player-react-native",
-  "version": "1.1.0",
+  "version": "1.2.0",
   "description": "Official React Native bindings for Bitmovin's mobile Player SDKs.",
   "main": "build/index.js",
   "types": "build/index.d.ts",
@@ -94,6 +94,6 @@
       "./scripts/format-android.sh",
       "./scripts/lint-android.sh"
     ],
-    "*.(ts|tsx|js|jsx|md|json|yml|yaml)": "prettier --write"
+    "*.(ts|tsx|js|jsx|md|json|yml|yaml)": "prettier --write --no-error-on-unmatched-pattern"
   }
 }

package/plugin/build/withAppGradleDependencies.js

@@ -19,6 +19,30 @@ const withAppGradleDependencies = (config, props) => {
         if (filteredDependencies.length === 0) {
             return config;
         }
+        const androidBlockStart = config.modResults.contents.search(/^android \{$/m);
+        if (androidBlockStart === -1) {
+            config_plugins_1.WarningAggregator.addWarningAndroid('withAppGradleDependencies', `Cannot configure app/build.gradle as no android block start was found`);
+            return config;
+        }
+        const fromAndroid = config.modResults.contents.substring(androidBlockStart);
+        const androidBlockEnd = fromAndroid.search(/^\}$/m);
+        if (androidBlockEnd === -1) {
+            config_plugins_1.WarningAggregator.addWarningAndroid('withAppGradleDependencies', `Cannot configure app/build.gradle as no android block end was found`);
+            return config;
+        }
+        const androidPosition = androidBlockStart + androidBlockEnd;
+        const compileOptions = [];
+        compileOptions.push(`${combinedProps.spacing}compileOptions {`);
+        compileOptions.push('\n');
+        compileOptions.push(`${combinedProps.spacing}setCoreLibraryDesugaringEnabled(true)`);
+        compileOptions.push('\n');
+        compileOptions.push(`${combinedProps.spacing}}`);
+        compileOptions.push('\n');
+        config.modResults.contents = [
+            config.modResults.contents.slice(0, androidPosition),
+            ...compileOptions,
+            config.modResults.contents.slice(androidPosition),
+        ].join('');
         const dependenciesBlockStart = config.modResults.contents.search(/^dependencies \{$/m);
         if (dependenciesBlockStart === -1) {
             config_plugins_1.WarningAggregator.addWarningAndroid('withAppGradleDependencies', `Cannot configure app/build.gradle as no dependency block start was found`);
@@ -33,6 +57,8 @@ const withAppGradleDependencies = (config, props) => {
         const position = dependenciesBlockStart + dependenciesBlockEnd;
         let insertedDependencies = [];
         insertedDependencies.push('\n');
+        insertedDependencies.push(`${combinedProps.spacing}coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.5'`);
+        insertedDependencies.push('\n');
         filteredDependencies.forEach((dependency) => {
             insertedDependencies.push(`${combinedProps.spacing}implementation '${dependency}'\n`);
         });

package/plugin/src/withAppGradleDependencies.ts

@@ -38,6 +38,39 @@ const withAppGradleDependencies: ConfigPlugin<PluginProps> = (
       return config;
     }
 
+    const androidBlockStart = config.modResults.contents.search(/^android \{$/m);
+    if (androidBlockStart === -1) {
+      WarningAggregator.addWarningAndroid(
+          'withAppGradleDependencies',
+          `Cannot configure app/build.gradle as no android block start was found`
+      );
+      return config;
+    }
+    const fromAndroid = config.modResults.contents.substring(
+      androidBlockStart
+    );
+    const androidBlockEnd = fromAndroid.search(/^\}$/m);
+    if (androidBlockEnd === -1) {
+      WarningAggregator.addWarningAndroid(
+          'withAppGradleDependencies',
+          `Cannot configure app/build.gradle as no android block end was found`
+      );
+      return config;
+    }
+    const androidPosition = androidBlockStart + androidBlockEnd;
+    const compileOptions = []
+      compileOptions.push(`${combinedProps.spacing}compileOptions {`)
+      compileOptions.push('\n');
+      compileOptions.push(`${combinedProps.spacing}setCoreLibraryDesugaringEnabled(true)`)
+      compileOptions.push('\n');
+      compileOptions.push(`${combinedProps.spacing}}`)
+      compileOptions.push('\n');
+      config.modResults.contents = [
+          config.modResults.contents.slice(0, androidPosition),
+          ... compileOptions,
+          config.modResults.contents.slice(androidPosition),
+      ].join('');
+
     const dependenciesBlockStart =
       config.modResults.contents.search(/^dependencies \{$/m);
     if (dependenciesBlockStart === -1) {
@@ -61,6 +94,8 @@ const withAppGradleDependencies: ConfigPlugin<PluginProps> = (
     const position = dependenciesBlockStart + dependenciesBlockEnd;
     let insertedDependencies: string[] = [];
     insertedDependencies.push('\n');
+    insertedDependencies.push(`${combinedProps.spacing}coreLibraryDesugaring 'com.android.tools:desugar_jdk_libs:2.1.5'`)
+    insertedDependencies.push('\n');
     filteredDependencies.forEach((dependency) => {
       insertedDependencies.push(
         `${combinedProps.spacing}implementation '${dependency}'\n`

package/scripts/setup-hooks.sh

@@ -1,18 +1,16 @@
 #!/bin/bash
 
+set -euo pipefail
+
 # Setup git pre-commit hooks for the project
 echo "Setting up pre-commit hooks..."
 
-# Check if .git directory exists
-if [ ! -d ".git" ]; then
-    echo "Error: Not a git repository. Please run this from the root of the project."
-    exit 1
-fi
+HOOK_DIR=$(git rev-parse --git-path hooks)
 
 # Check if hooks directory exists
-if [ ! -d ".git/hooks" ]; then
-    echo "Creating .git/hooks directory..."
-    mkdir -p .git/hooks
+if [ ! -d "$HOOK_DIR" ]; then
+    echo "Creating $HOOK_DIR directory..."
+    mkdir -p "$HOOK_DIR"
 fi
 
 # Get the directory where this script is located
@@ -26,7 +24,7 @@ if [ ! -f "$PRE_COMMIT_SOURCE" ]; then
 fi
 
 # Check if pre-commit hook already exists and compare content
-HOOK_PATH=".git/hooks/pre-commit"
+HOOK_PATH="$HOOK_DIR/pre-commit"
 NEEDS_UPDATE=true
 
 if [ -f "$HOOK_PATH" ]; then

package/android/src/main/AndroidManifestNew.xml

@@ -1,2 +0,0 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
-</manifest>