birdclaw 0.8.0 → 0.8.2

package/src/routes/api/profile-analysis.tsx

@@ -1,20 +1,18 @@
 import { createFileRoute } from "@tanstack/react-router";
 import { Effect } from "effect";
 import { maybeAutoUpdateBackupEffect } from "#/lib/backup";
-import { runEffectBackground } from "#/lib/effect-runtime";
 import {
 	parseBoundedInteger,
 	runRouteEffect,
 	sensitiveRequestErrorResponse,
 } from "#/lib/http-effect";
+import { createEffectNdjsonResponse } from "#/lib/ndjson-stream";
 import {
 	streamProfileAnalysisEffect,
 	type ProfileAnalysisOptions,
 	type ProfileAnalysisStreamEvent,
 } from "#/lib/profile-analysis";
 
-const encoder = new TextEncoder();
-
 function parseBoolean(value: string | null) {
 	return value === "true" || value === "1" || value === "yes";
 }
@@ -57,10 +55,6 @@ function parseOptions(url: URL): ProfileAnalysisOptions {
 	};
 }
 
-function encodeEvent(event: ProfileAnalysisStreamEvent) {
-	return encoder.encode(`${JSON.stringify(event)}\n`);
-}
-
 export const Route = createFileRoute("/api/profile-analysis")({
 	server: {
 		handlers: {
@@ -72,79 +66,30 @@ export const Route = createFileRoute("/api/profile-analysis")({
 
 						const url = new URL(request.url);
 						const options = parseOptions(url);
-						let abortAnalysis: (() => void) | undefined;
-
-						return new Response(
-							new ReadableStream({
-								cancel() {
-									abortAnalysis?.();
+						return createEffectNdjsonResponse<ProfileAnalysisStreamEvent>({
+							request,
+							initialEvents: [
+								{
+									type: "status",
+									label: "Starting profile analysis",
 								},
-								start(controller) {
-									const abortController = new AbortController();
-									let closed = false;
-									const close = () => {
-										closed = true;
-										abortController.abort();
-									};
-									const closeController = () => {
-										request.signal.removeEventListener("abort", onAbort);
-										if (!closed) {
-											closed = true;
-											controller.close();
-										}
-									};
-									const onAbort = () => close();
-									request.signal.addEventListener("abort", onAbort, {
-										once: true,
-									});
-									abortAnalysis = close;
-									const enqueue = (event: ProfileAnalysisStreamEvent) => {
-										if (closed) return;
-										try {
-											controller.enqueue(encodeEvent(event));
-										} catch {
-											close();
-										}
-									};
-									enqueue({
-										type: "status",
-										label: "Starting profile analysis",
-									});
-
-									runEffectBackground(
-										Effect.gen(function* () {
-											yield* maybeAutoUpdateBackupEffect();
-											return yield* streamProfileAnalysisEffect(
-												{
-													...options,
-													signal: abortController.signal,
-												},
-												{ onEvent: enqueue },
-											);
-										}),
-										{
-											onSuccess: closeController,
-											onFailure: (error) => {
-												enqueue({
-													type: "error",
-													error:
-														error instanceof Error
-															? error.message
-															: "Profile analysis failed",
-												});
-												closeController();
-											},
-										},
+							],
+							run: ({ signal, emit }) =>
+								Effect.gen(function* () {
+									yield* maybeAutoUpdateBackupEffect();
+									return yield* streamProfileAnalysisEffect(
+										{ ...options, signal },
+										{ onEvent: emit },
 									);
-								},
+								}),
+							errorEvent: (error) => ({
+								type: "error",
+								error:
+									error instanceof Error
+										? error.message
+										: "Profile analysis failed",
 							}),
-							{
-								headers: {
-									"cache-control": "no-store",
-									"content-type": "application/x-ndjson; charset=utf-8",
-								},
-							},
-						);
+						});
 					}),
 				),
 		},

package/src/routes/api/search-discussion.tsx

@@ -1,12 +1,12 @@
 import { createFileRoute } from "@tanstack/react-router";
 import { Effect } from "effect";
 import { maybeAutoUpdateBackupEffect } from "#/lib/backup";
-import { runEffectBackground } from "#/lib/effect-runtime";
 import {
 	parseBoundedInteger,
 	runRouteEffect,
 	sensitiveRequestErrorResponse,
 } from "#/lib/http-effect";
+import { createEffectNdjsonResponse } from "#/lib/ndjson-stream";
 import {
 	streamSearchDiscussionEffect,
 	type SearchDiscussionOptions,
@@ -15,7 +15,6 @@ import {
 } from "#/lib/search-discussion";
 import type { TweetSearchMode } from "#/lib/tweet-search-live";
 
-const encoder = new TextEncoder();
 const MAX_DISCUSSION_SEARCH_LIMIT = 20_000;
 const MAX_DISCUSSION_SEARCH_PAGES = 200;
 
@@ -73,10 +72,6 @@ function parseOptions(url: URL): SearchDiscussionOptions {
 	};
 }
 
-function encodeEvent(event: SearchDiscussionStreamEvent) {
-	return encoder.encode(`${JSON.stringify(event)}\n`);
-}
-
 export const Route = createFileRoute("/api/search-discussion")({
 	server: {
 		handlers: {
@@ -88,80 +83,29 @@ export const Route = createFileRoute("/api/search-discussion")({
 
 						const url = new URL(request.url);
 						const options = parseOptions(url);
-						let abortDiscussion: (() => void) | undefined;
-
-						return new Response(
-							new ReadableStream({
-								cancel() {
-									abortDiscussion?.();
-								},
-								start(controller) {
-									const abortController = new AbortController();
-									let closed = false;
-									const close = () => {
-										closed = true;
-										abortController.abort();
-									};
-									const closeController = () => {
-										request.signal.removeEventListener("abort", onAbort);
-										if (!closed) {
-											closed = true;
-											controller.close();
-										}
-									};
-									const onAbort = () => close();
-									request.signal.addEventListener("abort", onAbort, {
-										once: true,
-									});
-									abortDiscussion = close;
-									const enqueue = (event: SearchDiscussionStreamEvent) => {
-										if (closed) return;
-										try {
-											controller.enqueue(encodeEvent(event));
-										} catch {
-											close();
-										}
-									};
-
-									runEffectBackground(
-										maybeAutoUpdateBackupEffect().pipe(
-											Effect.flatMap(() => {
-												if (closed || abortController.signal.aborted) {
-													return Effect.succeed(undefined);
-												}
-												return streamSearchDiscussionEffect(
+						return createEffectNdjsonResponse<SearchDiscussionStreamEvent>({
+							request,
+							run: ({ signal, emit }) =>
+								maybeAutoUpdateBackupEffect().pipe(
+									Effect.flatMap(() =>
+										signal.aborted
+											? Effect.succeed(undefined)
+											: streamSearchDiscussionEffect(
 													{
 														...options,
-														signal: abortController.signal,
+														signal,
 														prefetchAvatars: true,
 													},
-													{ onEvent: enqueue },
-												);
-											}),
-										),
-										{
-											onSuccess: closeController,
-											onFailure: (error) => {
-												enqueue({
-													type: "error",
-													error:
-														error instanceof Error
-															? error.message
-															: "Discussion failed",
-												});
-												closeController();
-											},
-										},
-									);
-								},
+													{ onEvent: emit },
+												),
+									),
+								),
+							errorEvent: (error) => ({
+								type: "error",
+								error:
+									error instanceof Error ? error.message : "Discussion failed",
 							}),
-							{
-								headers: {
-									"cache-control": "no-store",
-									"content-type": "application/x-ndjson; charset=utf-8",
-								},
-							},
-						);
+						});
 					}),
 				),
 		},

package/src/routes/api/status.tsx

@@ -18,7 +18,9 @@ export const Route = createFileRoute("/api/status")({
 						if (denied) return denied;
 
 						yield* maybeAutoUpdateBackupEffect();
-						return jsonResponse(yield* getQueryEnvelopeEffect());
+						return jsonResponse(
+							yield* getQueryEnvelopeEffect({ includeArchives: false }),
+						);
 					}),
 				),
 		},

package/src/routes/dms.tsx

@@ -6,9 +6,11 @@ import { FeedEmpty, FeedError, FeedLoading } from "#/components/FeedState";
 import { SyncNowButton } from "#/components/SyncNowButton";
 import { useSelectedAccountId } from "#/components/account-selection";
 import {
+	fetchCachedQueryResponse,
 	fetchQueryEnvelope,
-	fetchQueryResponse,
+	invalidateCachedQueryResponses,
 	postAction,
+	readCachedQueryResponse,
 } from "#/lib/api-client";
 import type {
 	DmConversationItem,
@@ -16,6 +18,7 @@ import type {
 	QueryEnvelope,
 	ReplyFilter,
 } from "#/lib/types";
+import { useDebouncedValue } from "#/components/useDebouncedValue";
 import {
 	cx,
 	pageHeaderClass,
@@ -83,9 +86,10 @@ function DmsRoute() {
 	const [error, setError] = useState<string | null>(null);
 	const [replyError, setReplyError] = useState<string | null>(null);
 	const selectedAccountId = useSelectedAccountId(meta?.accounts);
+	const debouncedSearch = useDebouncedValue(search, 180);
 
-	async function loadStatus() {
-		setMeta(await fetchQueryEnvelope());
+	async function loadStatus(force = false) {
+		setMeta(await fetchQueryEnvelope(undefined, { force }));
 	}
 
 	useEffect(() => {
@@ -113,29 +117,41 @@ function DmsRoute() {
 		if (selectedConversationId) {
 			url.searchParams.set("conversationId", selectedConversationId);
 		}
-		if (search.trim()) {
-			url.searchParams.set("search", search.trim());
+		if (debouncedSearch.trim()) {
+			url.searchParams.set("search", debouncedSearch.trim());
 		}
 
+		const applyResponse = (
+			data: Awaited<ReturnType<typeof fetchCachedQueryResponse>>,
+		) => {
+			const conversations = data.items as DmConversationItem[];
+			const nextSelected =
+				data.selectedConversation?.conversation.id ?? conversations[0]?.id;
+			setLoadedConversationId(data.selectedConversation?.conversation.id);
+			setItems(conversations);
+			setSelectedConversationId((current) => {
+				if (!current) return nextSelected;
+				return conversations.some((conversation) => conversation.id === current)
+					? current
+					: nextSelected;
+			});
+			setMessages(data.selectedConversation?.messages ?? []);
+		};
 		setError(null);
+		const cached = readCachedQueryResponse(url);
+		if (cached) {
+			applyResponse(cached);
+			setLoading(false);
+			return () => {
+				active = false;
+				controller.abort();
+			};
+		}
 		setLoading(true);
-		fetchQueryResponse(url, { signal: controller.signal })
+		fetchCachedQueryResponse(url, { signal: controller.signal })
 			.then((data) => {
 				if (!active) return;
-				const conversations = data.items as DmConversationItem[];
-				const nextSelected =
-					data.selectedConversation?.conversation.id ?? conversations[0]?.id;
-				setLoadedConversationId(data.selectedConversation?.conversation.id);
-				setItems(conversations);
-				setSelectedConversationId((current) => {
-					if (!current) return nextSelected;
-					return conversations.some(
-						(conversation) => conversation.id === current,
-					)
-						? current
-						: nextSelected;
-				});
-				setMessages(data.selectedConversation?.messages ?? []);
+				applyResponse(data);
 			})
 			.catch((fetchError: unknown) => {
 				if (
@@ -170,7 +186,7 @@ function DmsRoute() {
 		inboxFilter,
 		refreshTick,
 		replyFilter,
-		search,
+		debouncedSearch,
 		selectedConversationId,
 		selectedAccountId,
 		sort,
@@ -247,6 +263,7 @@ function DmsRoute() {
 				text,
 			});
 
+			invalidateCachedQueryResponses();
 			setSelectedConversationId(conversationId);
 			setRefreshTick((value) => value + 1);
 		} catch (error) {
@@ -258,8 +275,9 @@ function DmsRoute() {
 	}
 
 	function refreshLocalView() {
+		invalidateCachedQueryResponses();
 		setRefreshTick((value) => value + 1);
-		void loadStatus();
+		void loadStatus(true);
 	}
 
 	return (

package/src/routes/links.tsx

@@ -18,7 +18,13 @@ import {
 	LinkSkeletonRows,
 } from "#/components/FeedState";
 import { ProfilePreview } from "#/components/ProfilePreview";
-import { formatCompactNumber, formatShortTimestamp } from "#/lib/present";
+import { SmartTimestamp } from "#/components/SmartTimestamp";
+import {
+	loadClientCache,
+	readClientCache,
+	writeClientCache,
+} from "#/lib/client-cache";
+import { formatCompactNumber } from "#/lib/present";
 import type {
 	LinkInsightItem,
 	LinkInsightKind,
@@ -55,6 +61,10 @@ const LINK_INSIGHTS_LIMIT = 30;
 const LINK_INSIGHTS_COMMENTS_LIMIT = 30;
 const PROFILE_HYDRATION_LIMIT = 30;
 const PROFILE_HYDRATION_DELAY_MS = 1200;
+const LINK_INSIGHTS_CACHE_PREFIX = "link-insights:";
+const LINK_INSIGHTS_CACHE_MAX_AGE_MS = 5 * 60_000;
+const LINK_PROFILE_HYDRATED_CACHE_PREFIX = "link-profile-hydrated:";
+const hydratingLinkProfileHandles = new Set<string>();
 
 const ranges: Array<{ value: LinkInsightRange; label: string }> = [
 	{ value: "today", label: "Today" },
@@ -86,6 +96,19 @@ function insightCacheKey(
 	return `${kind}:${range}:${sort}:${source}:${refreshTick}`;
 }
 
+function sharedInsightCacheKey(
+	kind: LinkInsightKind,
+	range: LinkInsightRange,
+	sort: LinkInsightSort,
+	source: LinkInsightSource,
+) {
+	return `${LINK_INSIGHTS_CACHE_PREFIX}${kind}:${range}:${sort}:${source}`;
+}
+
+function hydratedProfileCacheKey(handle: string) {
+	return `${LINK_PROFILE_HYDRATED_CACHE_PREFIX}${handle.toLowerCase()}`;
+}
+
 function linkInsightsUrl(
 	kind: LinkInsightKind,
 	range: LinkInsightRange,
@@ -393,7 +416,7 @@ function MentionCard({
 					rel="noreferrer"
 					target="_blank"
 				>
-					{formatShortTimestamp(mention.createdAt)}
+					<SmartTimestamp value={mention.createdAt} />
 				</a>
 			</div>
 			<p className="m-0 whitespace-pre-wrap text-[14px] leading-[1.45] text-[var(--ink)] [overflow-wrap:anywhere]">
@@ -633,7 +656,7 @@ function LinkInsightRow({
 						<span>/</span>
 						<SharerStrip item={item} />
 						<span>/</span>
-						<span>{formatShortTimestamp(item.lastSeenAt)}</span>
+						<SmartTimestamp value={item.lastSeenAt} />
 					</div>
 					<VideoPreview item={item} />
 				</div>
@@ -650,8 +673,16 @@ function LinksRoute() {
 	const [sort, setSort] = useState<LinkInsightSort>("rank");
 	const [search, setSearch] = useState("");
 	const [refreshTick, setRefreshTick] = useState(0);
-	const hydratedHandlesRef = useRef(new Set<string>());
-	const cacheRef = useRef(new Map<string, LinkInsightResponse>());
+	const initialCacheKey = insightCacheKey(kind, range, sort, source, 0);
+	const initialSharedData = readClientCache<LinkInsightResponse>(
+		sharedInsightCacheKey(kind, range, sort, source),
+		LINK_INSIGHTS_CACHE_MAX_AGE_MS,
+	);
+	const cacheRef = useRef(
+		new Map<string, LinkInsightResponse>(
+			initialSharedData ? [[initialCacheKey, initialSharedData]] : [],
+		),
+	);
 	const inFlightRef = useRef(new Set<string>());
 	const mountedRef = useRef(true);
 	const [errorByKey, setErrorByKey] = useState<Record<string, string>>({});
@@ -679,14 +710,35 @@ function LinksRoute() {
 			if (cacheRef.current.has(key) || inFlightRef.current.has(key)) {
 				return;
 			}
+			const sharedKey = sharedInsightCacheKey(fetchKind, range, sort, source);
+			if (refreshTick === 0) {
+				const cached = readClientCache<LinkInsightResponse>(
+					sharedKey,
+					LINK_INSIGHTS_CACHE_MAX_AGE_MS,
+				);
+				if (cached) {
+					cacheRef.current.set(key, cached);
+					bumpCacheVersion((value) => value + 1);
+					return;
+				}
+			}
 			inFlightRef.current.add(key);
 			setErrorByKey((current) => {
 				const rest = { ...current };
 				delete rest[key];
 				return rest;
 			});
-			fetch(linkInsightsUrl(fetchKind, range, sort, source, refreshTick))
-				.then((response) => response.json())
+			loadClientCache(
+				sharedKey,
+				() =>
+					fetch(
+						linkInsightsUrl(fetchKind, range, sort, source, refreshTick),
+					).then((response) => response.json() as Promise<LinkInsightResponse>),
+				{
+					force: refreshTick > 0,
+					maxAgeMs: LINK_INSIGHTS_CACHE_MAX_AGE_MS,
+				},
+			)
 				.then((response: LinkInsightResponse) => {
 					cacheRef.current.set(key, response);
 					if (mountedRef.current) {
@@ -731,7 +783,9 @@ function LinksRoute() {
 
 	useEffect(() => {
 		const handles = collectProfilesForHydration(data).filter(
-			(handle) => !hydratedHandlesRef.current.has(handle.toLowerCase()),
+			(handle) =>
+				!readClientCache<boolean>(hydratedProfileCacheKey(handle)) &&
+				!hydratingLinkProfileHandles.has(handle.toLowerCase()),
 		);
 		if (handles.length === 0) {
 			return;
@@ -741,19 +795,30 @@ function LinksRoute() {
 		const url = new URL("/api/profile-hydrate", window.location.origin);
 		url.searchParams.set("handles", handles.join(","));
 		for (const handle of handles) {
-			hydratedHandlesRef.current.add(handle.toLowerCase());
+			hydratingLinkProfileHandles.add(handle.toLowerCase());
 		}
+		const finishHydration = (succeeded: boolean) => {
+			for (const handle of handles) {
+				const normalized = handle.toLowerCase();
+				hydratingLinkProfileHandles.delete(normalized);
+				if (succeeded) {
+					writeClientCache(hydratedProfileCacheKey(normalized), true);
+				}
+			}
+		};
 
 		let idleId: number | null = null;
 		const runHydration = () => {
 			fetch(url, { signal: controller.signal })
 				.then((response) => response.json())
 				.then((response: { hydratedProfiles?: number }) => {
+					finishHydration(true);
 					if ((response.hydratedProfiles ?? 0) > 0) {
 						setRefreshTick((value) => value + 1);
 					}
 				})
 				.catch((error: unknown) => {
+					finishHydration(false);
 					if (error instanceof DOMException && error.name === "AbortError") {
 						return;
 					}
@@ -770,6 +835,7 @@ function LinksRoute() {
 
 		return () => {
 			controller.abort();
+			finishHydration(false);
 			window.clearTimeout(timer);
 			if (idleId !== null && "cancelIdleCallback" in window) {
 				window.cancelIdleCallback(idleId);