birdclaw 0.8.0 → 0.8.1

package/src/routes/api/profile-analysis.tsx

@@ -1,20 +1,18 @@
 import { createFileRoute } from "@tanstack/react-router";
 import { Effect } from "effect";
 import { maybeAutoUpdateBackupEffect } from "#/lib/backup";
-import { runEffectBackground } from "#/lib/effect-runtime";
 import {
 	parseBoundedInteger,
 	runRouteEffect,
 	sensitiveRequestErrorResponse,
 } from "#/lib/http-effect";
+import { createEffectNdjsonResponse } from "#/lib/ndjson-stream";
 import {
 	streamProfileAnalysisEffect,
 	type ProfileAnalysisOptions,
 	type ProfileAnalysisStreamEvent,
 } from "#/lib/profile-analysis";
 
-const encoder = new TextEncoder();
-
 function parseBoolean(value: string | null) {
 	return value === "true" || value === "1" || value === "yes";
 }
@@ -57,10 +55,6 @@ function parseOptions(url: URL): ProfileAnalysisOptions {
 	};
 }
 
-function encodeEvent(event: ProfileAnalysisStreamEvent) {
-	return encoder.encode(`${JSON.stringify(event)}\n`);
-}
-
 export const Route = createFileRoute("/api/profile-analysis")({
 	server: {
 		handlers: {
@@ -72,79 +66,30 @@ export const Route = createFileRoute("/api/profile-analysis")({
 
 						const url = new URL(request.url);
 						const options = parseOptions(url);
-						let abortAnalysis: (() => void) | undefined;
-
-						return new Response(
-							new ReadableStream({
-								cancel() {
-									abortAnalysis?.();
+						return createEffectNdjsonResponse<ProfileAnalysisStreamEvent>({
+							request,
+							initialEvents: [
+								{
+									type: "status",
+									label: "Starting profile analysis",
 								},
-								start(controller) {
-									const abortController = new AbortController();
-									let closed = false;
-									const close = () => {
-										closed = true;
-										abortController.abort();
-									};
-									const closeController = () => {
-										request.signal.removeEventListener("abort", onAbort);
-										if (!closed) {
-											closed = true;
-											controller.close();
-										}
-									};
-									const onAbort = () => close();
-									request.signal.addEventListener("abort", onAbort, {
-										once: true,
-									});
-									abortAnalysis = close;
-									const enqueue = (event: ProfileAnalysisStreamEvent) => {
-										if (closed) return;
-										try {
-											controller.enqueue(encodeEvent(event));
-										} catch {
-											close();
-										}
-									};
-									enqueue({
-										type: "status",
-										label: "Starting profile analysis",
-									});
-
-									runEffectBackground(
-										Effect.gen(function* () {
-											yield* maybeAutoUpdateBackupEffect();
-											return yield* streamProfileAnalysisEffect(
-												{
-													...options,
-													signal: abortController.signal,
-												},
-												{ onEvent: enqueue },
-											);
-										}),
-										{
-											onSuccess: closeController,
-											onFailure: (error) => {
-												enqueue({
-													type: "error",
-													error:
-														error instanceof Error
-															? error.message
-															: "Profile analysis failed",
-												});
-												closeController();
-											},
-										},
+							],
+							run: ({ signal, emit }) =>
+								Effect.gen(function* () {
+									yield* maybeAutoUpdateBackupEffect();
+									return yield* streamProfileAnalysisEffect(
+										{ ...options, signal },
+										{ onEvent: emit },
 									);
-								},
+								}),
+							errorEvent: (error) => ({
+								type: "error",
+								error:
+									error instanceof Error
+										? error.message
+										: "Profile analysis failed",
 							}),
-							{
-								headers: {
-									"cache-control": "no-store",
-									"content-type": "application/x-ndjson; charset=utf-8",
-								},
-							},
-						);
+						});
 					}),
 				),
 		},

package/src/routes/api/search-discussion.tsx

@@ -1,12 +1,12 @@
 import { createFileRoute } from "@tanstack/react-router";
 import { Effect } from "effect";
 import { maybeAutoUpdateBackupEffect } from "#/lib/backup";
-import { runEffectBackground } from "#/lib/effect-runtime";
 import {
 	parseBoundedInteger,
 	runRouteEffect,
 	sensitiveRequestErrorResponse,
 } from "#/lib/http-effect";
+import { createEffectNdjsonResponse } from "#/lib/ndjson-stream";
 import {
 	streamSearchDiscussionEffect,
 	type SearchDiscussionOptions,
@@ -15,7 +15,6 @@ import {
 } from "#/lib/search-discussion";
 import type { TweetSearchMode } from "#/lib/tweet-search-live";
 
-const encoder = new TextEncoder();
 const MAX_DISCUSSION_SEARCH_LIMIT = 20_000;
 const MAX_DISCUSSION_SEARCH_PAGES = 200;
 
@@ -73,10 +72,6 @@ function parseOptions(url: URL): SearchDiscussionOptions {
 	};
 }
 
-function encodeEvent(event: SearchDiscussionStreamEvent) {
-	return encoder.encode(`${JSON.stringify(event)}\n`);
-}
-
 export const Route = createFileRoute("/api/search-discussion")({
 	server: {
 		handlers: {
@@ -88,80 +83,29 @@ export const Route = createFileRoute("/api/search-discussion")({
 
 						const url = new URL(request.url);
 						const options = parseOptions(url);
-						let abortDiscussion: (() => void) | undefined;
-
-						return new Response(
-							new ReadableStream({
-								cancel() {
-									abortDiscussion?.();
-								},
-								start(controller) {
-									const abortController = new AbortController();
-									let closed = false;
-									const close = () => {
-										closed = true;
-										abortController.abort();
-									};
-									const closeController = () => {
-										request.signal.removeEventListener("abort", onAbort);
-										if (!closed) {
-											closed = true;
-											controller.close();
-										}
-									};
-									const onAbort = () => close();
-									request.signal.addEventListener("abort", onAbort, {
-										once: true,
-									});
-									abortDiscussion = close;
-									const enqueue = (event: SearchDiscussionStreamEvent) => {
-										if (closed) return;
-										try {
-											controller.enqueue(encodeEvent(event));
-										} catch {
-											close();
-										}
-									};
-
-									runEffectBackground(
-										maybeAutoUpdateBackupEffect().pipe(
-											Effect.flatMap(() => {
-												if (closed || abortController.signal.aborted) {
-													return Effect.succeed(undefined);
-												}
-												return streamSearchDiscussionEffect(
+						return createEffectNdjsonResponse<SearchDiscussionStreamEvent>({
+							request,
+							run: ({ signal, emit }) =>
+								maybeAutoUpdateBackupEffect().pipe(
+									Effect.flatMap(() =>
+										signal.aborted
+											? Effect.succeed(undefined)
+											: streamSearchDiscussionEffect(
 													{
 														...options,
-														signal: abortController.signal,
+														signal,
 														prefetchAvatars: true,
 													},
-													{ onEvent: enqueue },
-												);
-											}),
-										),
-										{
-											onSuccess: closeController,
-											onFailure: (error) => {
-												enqueue({
-													type: "error",
-													error:
-														error instanceof Error
-															? error.message
-															: "Discussion failed",
-												});
-												closeController();
-											},
-										},
-									);
-								},
+													{ onEvent: emit },
+												),
+									),
+								),
+							errorEvent: (error) => ({
+								type: "error",
+								error:
+									error instanceof Error ? error.message : "Discussion failed",
 							}),
-							{
-								headers: {
-									"cache-control": "no-store",
-									"content-type": "application/x-ndjson; charset=utf-8",
-								},
-							},
-						);
+						});
 					}),
 				),
 		},

package/src/routes/links.tsx

@@ -18,7 +18,8 @@ import {
 	LinkSkeletonRows,
 } from "#/components/FeedState";
 import { ProfilePreview } from "#/components/ProfilePreview";
-import { formatCompactNumber, formatShortTimestamp } from "#/lib/present";
+import { SmartTimestamp } from "#/components/SmartTimestamp";
+import { formatCompactNumber } from "#/lib/present";
 import type {
 	LinkInsightItem,
 	LinkInsightKind,
@@ -393,7 +394,7 @@ function MentionCard({
 					rel="noreferrer"
 					target="_blank"
 				>
-					{formatShortTimestamp(mention.createdAt)}
+					<SmartTimestamp value={mention.createdAt} />
 				</a>
 			</div>
 			<p className="m-0 whitespace-pre-wrap text-[14px] leading-[1.45] text-[var(--ink)] [overflow-wrap:anywhere]">
@@ -633,7 +634,7 @@ function LinkInsightRow({
 						<span>/</span>
 						<SharerStrip item={item} />
 						<span>/</span>
-						<span>{formatShortTimestamp(item.lastSeenAt)}</span>
+						<SmartTimestamp value={item.lastSeenAt} />
 					</div>
 					<VideoPreview item={item} />
 				</div>

package/src/routes/today.tsx

@@ -53,6 +53,8 @@ function digestUrl(
 	url.searchParams.set("includeDms", String(includeDms));
 	url.searchParams.set("maxTweets", "5000");
 	url.searchParams.set("maxLinks", "20");
+	// Cloudflare caps proxied requests; live timeline sync remains a separate job/UI action.
+	url.searchParams.set("liveSync", "false");
 	if (refresh) {
 		url.searchParams.set("refresh", "true");
 	}
@@ -77,6 +79,11 @@ async function digestRequestError(response: Response) {
 	} catch {
 		detail = "";
 	}
+	if (response.status === 524) {
+		return new Error(
+			"Digest startup timed out at Cloudflare (524). Retry to open a new stream.",
+		);
+	}
 	return new Error(
 		detail
 			? `Digest request failed (${status}): ${detail}`
@@ -84,6 +91,20 @@ async function digestRequestError(response: Response) {
 	);
 }
 
+function digestStreamError(cause: unknown, phase: string) {
+	const message = cause instanceof Error ? cause.message : String(cause);
+	if (
+		cause instanceof TypeError &&
+		/network error|failed to fetch|load failed/i.test(message)
+	) {
+		return `Digest connection was interrupted while ${phase.toLowerCase()}. Retry to continue.`;
+	}
+	if (cause instanceof SyntaxError) {
+		return `Digest stream returned invalid data while ${phase.toLowerCase()}. Retry to continue.`;
+	}
+	return message || "Digest failed";
+}
+
 function formatCounts(context: PeriodDigestContext | null) {
 	if (!context) return "Local Twitter memory, summarized as it streams.";
 	const counts = context.counts;
@@ -200,8 +221,11 @@ function useDigestStream(period: PeriodOption, includeDms: boolean) {
 			setError(null);
 			setStatus("Starting digest");
 			setLoading(true);
+			let latestStatus = "Starting digest";
+			let completed = false;
 
 			fetch(digestUrl(period, includeDms, refresh), {
+				cache: "no-store",
 				signal: controller.signal,
 			})
 				.then(async (response) => {
@@ -217,7 +241,14 @@ function useDigestStream(period: PeriodOption, includeDms: boolean) {
 					const pump = (): Promise<void> =>
 						reader.read().then(({ done, value }) => {
 							if (!isActiveRequest()) return;
-							if (done) return;
+							if (done) {
+								if (!completed) {
+									throw new Error(
+										`Digest connection closed while ${latestStatus.toLowerCase()}. Retry to continue.`,
+									);
+								}
+								return;
+							}
 							buffer += decoder.decode(value, { stream: true });
 							let newline = buffer.indexOf("\n");
 							while (newline >= 0) {
@@ -227,17 +258,18 @@ function useDigestStream(period: PeriodOption, includeDms: boolean) {
 									const event = JSON.parse(line) as PeriodDigestStreamEvent;
 									if (!isActiveRequest()) return;
 									if (event.type === "status") {
-										setStatus(
-											event.detail
-												? `${event.label} · ${event.detail}`
-												: event.label,
-										);
+										latestStatus = event.detail
+											? `${event.label} · ${event.detail}`
+											: event.label;
+										setStatus(latestStatus);
 									} else if (event.type === "start") {
 										setContext(event.context);
 									} else if (event.type === "delta") {
-										setStatus("Streaming AI summary");
+										latestStatus = "Streaming AI summary";
+										setStatus(latestStatus);
 										setMarkdown((current) => current + event.delta);
 									} else if (event.type === "done") {
+										completed = true;
 										setResult(event.result);
 										setContext(event.result.context);
 										setMarkdown(event.result.markdown);
@@ -245,6 +277,7 @@ function useDigestStream(period: PeriodOption, includeDms: boolean) {
 											event.result.cached ? "Loaded cached report" : "Ready",
 										);
 									} else if (event.type === "error") {
+										completed = true;
 										setError(event.error);
 										setStatus("Digest failed");
 									}
@@ -257,7 +290,7 @@ function useDigestStream(period: PeriodOption, includeDms: boolean) {
 				})
 				.catch((cause: unknown) => {
 					if (!isActiveRequest()) return;
-					setError(cause instanceof Error ? cause.message : "Digest failed");
+					setError(digestStreamError(cause, latestStatus));
 					setStatus("Digest failed");
 				})
 				.finally(() => {
@@ -421,7 +454,24 @@ function TodayRoute() {
 				</div>
 			</header>
 
-			{error ? <div className={errorCopyClass}>{error}</div> : null}
+			{error ? (
+				<div
+					className={cx(
+						errorCopyClass,
+						"flex items-center justify-between gap-3",
+					)}
+					role="alert"
+				>
+					<span>{error}</span>
+					<button
+						className="shrink-0 font-semibold underline underline-offset-2"
+						onClick={() => run(true)}
+						type="button"
+					>
+						Retry
+					</button>
+				</div>
+			) : null}
 
 			<div className="border-b border-[var(--line)] px-4 py-2 text-[13px] text-[var(--ink-soft)]">
 				<span className="inline-flex items-center gap-1">
@@ -436,7 +486,9 @@ function TodayRoute() {
 						? status
 						: result
 							? `${result.cached ? "Cached" : "Ready"} · ${result.context.window.label}`
-							: "Ready"}
+							: error
+								? "Digest failed"
+								: "Ready"}
 				</span>
 			</div>
 
@@ -447,7 +499,11 @@ function TodayRoute() {
 				/>
 			) : (
 				<div className="px-4 py-5 text-[14px] text-[var(--ink-soft)]">
-					{loading ? status : "Waiting for the first tokens..."}
+					{loading
+						? status
+						: error
+							? "No digest was generated. Retry to start a new run."
+							: "Waiting for the first tokens..."}
 				</div>
 			)}
 		</div>