bip-321 0.0.4 → 0.0.6

package/eslint.config.js

@@ -0,0 +1,94 @@
+import tseslint from "@typescript-eslint/eslint-plugin";
+import tsparser from "@typescript-eslint/parser";
+import importPlugin from "eslint-plugin-import";
+
+export default [
+  {
+    ignores: ["**/node_modules/**", "**/dist/**", "**/build/**", "**/*.min.js"],
+  },
+  {
+    files: ["**/*.ts", "**/*.tsx", "**/*.js", "**/*.jsx"],
+    languageOptions: {
+      parser: tsparser,
+      parserOptions: {
+        ecmaVersion: "latest",
+        sourceType: "module",
+        project: "./tsconfig.json",
+      },
+    },
+    plugins: {
+      "@typescript-eslint": tseslint,
+      import: importPlugin,
+    },
+    rules: {
+      "@typescript-eslint/no-explicit-any": "error",
+      "@typescript-eslint/no-non-null-assertion": "error",
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        { argsIgnorePattern: "^_", varsIgnorePattern: "^_" },
+      ],
+      "@typescript-eslint/no-floating-promises": "error",
+      "@typescript-eslint/no-misused-promises": "error",
+      "@typescript-eslint/await-thenable": "error",
+      "@typescript-eslint/no-unnecessary-condition": "warn",
+      "@typescript-eslint/prefer-nullish-coalescing": "error",
+      "@typescript-eslint/prefer-optional-chain": "error",
+      "@typescript-eslint/no-unsafe-assignment": "error",
+      "@typescript-eslint/no-unsafe-member-access": "error",
+      "@typescript-eslint/no-unsafe-call": "error",
+      "@typescript-eslint/no-unsafe-return": "error",
+      "@typescript-eslint/no-unsafe-argument": "error",
+      "@typescript-eslint/restrict-template-expressions": "error",
+      "@typescript-eslint/no-base-to-string": "error",
+      "@typescript-eslint/require-await": "error",
+      "@typescript-eslint/switch-exhaustiveness-check": "error",
+
+      "no-console": "warn",
+      "no-debugger": "error",
+      eqeqeq: ["error", "always"],
+      "no-var": "error",
+      "prefer-const": "error",
+      "prefer-arrow-callback": "error",
+      "no-throw-literal": "error",
+      "no-return-await": "error",
+      "require-await": "off",
+      "no-async-promise-executor": "error",
+      "no-promise-executor-return": "error",
+
+      "no-eval": "error",
+      "no-implied-eval": "error",
+      "no-new-func": "error",
+      "no-new-wrappers": "error",
+      "no-useless-concat": "error",
+      "prefer-template": "error",
+      "no-lonely-if": "error",
+      "no-else-return": "error",
+      "no-unneeded-ternary": "error",
+      "prefer-destructuring": [
+        "warn",
+        { array: false, object: true },
+        { enforceForRenamedProperties: false },
+      ],
+
+      "import/no-unresolved": "off",
+      "import/named": "error",
+      "import/no-duplicates": "error",
+      "import/no-cycle": "error",
+      "import/no-self-import": "error",
+
+      "no-await-in-loop": "warn",
+    },
+  },
+  {
+    files: ["example.ts", "example.js"],
+    rules: {
+      "no-console": "off",
+    },
+  },
+  {
+    files: ["*.test.ts", "*.test.js", "*.spec.ts", "*.spec.js"],
+    rules: {
+      "@typescript-eslint/no-non-null-assertion": "off",
+    },
+  },
+];

package/example.ts

@@ -47,7 +47,7 @@ const example4 = parseBIP321(
   "bitcoin:?lightning=lnbc15u1p3xnhl2pp5jptserfk3zk4qy42tlucycrfwxhydvlemu9pqr93tuzlv9cc7g3sdqsvfhkcap3xyhx7un8cqzpgxqzjcsp5f8c52y2stc300gl6s4xswtjpc37hrnnr3c9wvtgjfuvqmpm35evq9qyyssqy4lgd8tj637qcjp05rdpxxykjenthxftej7a2zzmwrmrl70fyj9hvj0rewhzj7jfyuwkwcg9g2jpwtk3wkjtwnkdks84hsnu8xps5vsq4gj5hs",
 );
 console.log(`Valid: ${example4.valid}`);
-console.log(`Address in path: ${example4.address || "none"}`);
+console.log(`Address in path: ${example4.address ?? "none"}`);
 console.log(`Payment type: ${example4.paymentMethods[0]?.type}`);
 console.log(`Network: ${example4.paymentMethods[0]?.network}`);
 console.log();
@@ -71,8 +71,8 @@ const example6 = parseBIP321(
 );
 const byNetwork = getPaymentMethodsByNetwork(example6);
 console.log(`Valid: ${example6.valid}`);
-console.log(`Mainnet methods: ${byNetwork.mainnet?.length || 0}`);
-console.log(`Testnet methods: ${byNetwork.testnet?.length || 0}`);
+console.log(`Mainnet methods: ${byNetwork.mainnet?.length ?? 0}`);
+console.log(`Testnet methods: ${byNetwork.testnet?.length ?? 0}`);
 console.log();
 
 // Example 7: Testnet lightning invoice

package/index.test.ts

@@ -30,6 +30,18 @@ const TEST_DATA = {
     signet:
       "lntbs10u1p5s6wgtsp5d8a763exauvdk6s5gwvl8zmuapmgjq05fdv6trasjd4slvgkvzzqpp56vxdyl24hmkpz0tvqq84xdpqqeql3x7kh8tey4uum2cu8jny6djqdq4g9exkgznw3hhyefqyvenyxqzjccqp2rzjqdwy5et9ygczjl2jqmr9e5xm28u3gksjfrf0pht04uwz2lt9d59cypqelcqqq8gqqqqqqqqpqqqqqzsqqc9qxpqysgq0x0pg2s65rnp2cr35td5tq0vwgmnrghkpzt93eypqvvfu5m40pcjl9k2x2m4kqgvz2ez8tzxqgw0nyeg2w60nfky579uakd4mhr3ncgp0xwars",
   },
+  ark: {
+    mainnet:
+      "ark1pwh9vsmezqqpjy9akejayl2vvcse6he97rn40g84xrlvrlnhayuuyefrp9nse2yspqqjl5wpy",
+    testnet:
+      "tark1pm6sr0fpzqqpnzzwxf209kju4qavs4gtumxk30yv2u5ncrvtp72z34axcvrydtdqpqq5838km",
+  },
+  silentPayment: {
+    mainnet:
+      "sp1qqvgwll3hawztz50nx5mcs70ytam4z068c2cw0z37zcg5yj23h65kcqamhqcxal0gerzly0jnkv7x0ar3sjhmh0n5yugyj3kd7ahzfsdw5590ajuk",
+    testnet:
+      "tsp1qq2svvt45f2rzmfr4vwhgvjfjgna92h09g9a9ttpvmz5x5wmscsepyqhkk6tjxzr6v0vj3q87gcrqjq73z6ljylgk4m6vphvkpg4afzwp4ve0nr78",
+  },
 } as const;
 
 describe("BIP-321 Parser", () => {
@@ -42,8 +54,8 @@ describe("BIP-321 Parser", () => {
       expect(result.address).toBe(TEST_DATA.addresses.mainnet.p2pkh);
       expect(result.network).toBe("mainnet");
       expect(result.paymentMethods.length).toBe(1);
-      expect(result.paymentMethods[0]!.type).toBe("onchain");
-      expect(result.paymentMethods[0]!.valid).toBe(true);
+      expect(result.paymentMethods[0]?.type).toBe("onchain");
+      expect(result.paymentMethods[0]?.valid).toBe(true);
     });
 
     test("parses bech32 mainnet address", () => {
@@ -52,7 +64,7 @@ describe("BIP-321 Parser", () => {
       );
       expect(result.valid).toBe(true);
       expect(result.network).toBe("mainnet");
-      expect(result.paymentMethods[0]!.valid).toBe(true);
+      expect(result.paymentMethods[0]?.valid).toBe(true);
     });
 
     test("parses testnet address", () => {
@@ -193,29 +205,113 @@ describe("BIP-321 Parser", () => {
   });
 
   describe("Alternative Payment Methods", () => {
-    test("parses BOLT12 offer", () => {
+    test("parses valid BOLT12 offer", () => {
+      const result = parseBIP321("bitcoin:?lno=lno1qqqq02k20d");
+      expect(result.valid).toBe(true);
+      expect(result.paymentMethods.length).toBe(1);
+      expect(result.paymentMethods[0]!.type).toBe("offer");
+      expect(result.paymentMethods[0]!.valid).toBe(true);
+    });
+
+    test("rejects invalid BOLT12 offer", () => {
       const result = parseBIP321("bitcoin:?lno=lno1bogusoffer");
+      expect(result.paymentMethods.length).toBe(1);
+      expect(result.paymentMethods[0]!.type).toBe("offer");
+      expect(result.paymentMethods[0]!.valid).toBe(false);
+      expect(result.errors.some((e) => e.includes("BOLT12 offer"))).toBe(true);
+    });
+
+    test("parses mainnet silent payment address", () => {
+      const result = parseBIP321(
+        `bitcoin:?sp=${TEST_DATA.silentPayment.mainnet}`,
+      );
       expect(result.valid).toBe(true);
       expect(result.paymentMethods.length).toBe(1);
-      expect(result.paymentMethods[0]!.type).toBe("lno");
+      expect(result.paymentMethods[0]!.type).toBe("silent-payment");
+      expect(result.paymentMethods[0]!.network).toBe("mainnet");
+      expect(result.paymentMethods[0]!.valid).toBe(true);
     });
 
-    test("parses silent payment address", () => {
-      const result = parseBIP321("bitcoin:?sp=sp1qsilentpayment");
+    test("parses testnet silent payment address", () => {
+      const result = parseBIP321(
+        `bitcoin:?sp=${TEST_DATA.silentPayment.testnet}`,
+      );
       expect(result.valid).toBe(true);
       expect(result.paymentMethods.length).toBe(1);
       expect(result.paymentMethods[0]!.type).toBe("silent-payment");
+      expect(result.paymentMethods[0]!.network).toBe("testnet");
+      expect(result.paymentMethods[0]!.valid).toBe(true);
+    });
+
+    test("rejects invalid silent payment address", () => {
+      const result = parseBIP321("bitcoin:?sp=sp1qinvalid");
+      expect(result.paymentMethods.length).toBe(1);
+      expect(result.paymentMethods[0]!.type).toBe("silent-payment");
+      expect(result.paymentMethods[0]!.valid).toBe(false);
+      expect(result.errors.some((e) => e.includes("silent payment"))).toBe(
+        true,
+      );
     });
 
     test("parses multiple payment methods", () => {
       const result = parseBIP321(
-        "bitcoin:?lno=lno1bogusoffer&sp=sp1qsilentpayment",
+        `bitcoin:?lno=lno1qqqq02k20d&sp=${TEST_DATA.silentPayment.mainnet}`,
       );
       expect(result.valid).toBe(true);
       expect(result.paymentMethods.length).toBe(2);
     });
   });
 
+  describe("Ark Addresses", () => {
+    test("parses mainnet Ark address", () => {
+      const result = parseBIP321(`bitcoin:?ark=${TEST_DATA.ark.mainnet}`);
+      expect(result.valid).toBe(true);
+      expect(result.paymentMethods.length).toBe(1);
+      expect(result.paymentMethods[0]!.type).toBe("ark");
+      expect(result.paymentMethods[0]!.network).toBe("mainnet");
+      expect(result.paymentMethods[0]!.valid).toBe(true);
+    });
+
+    test("parses testnet Ark address", () => {
+      const result = parseBIP321(`bitcoin:?ark=${TEST_DATA.ark.testnet}`);
+      expect(result.valid).toBe(true);
+      expect(result.paymentMethods.length).toBe(1);
+      expect(result.paymentMethods[0]!.type).toBe("ark");
+      expect(result.paymentMethods[0]!.network).toBe("testnet");
+      expect(result.paymentMethods[0]!.valid).toBe(true);
+    });
+
+    test("rejects invalid Ark address", () => {
+      const result = parseBIP321("bitcoin:?ark=invalid_ark_address");
+      expect(result.paymentMethods.length).toBe(1);
+      expect(result.paymentMethods[0]!.valid).toBe(false);
+      expect(result.errors.some((e) => e.includes("Ark address"))).toBe(true);
+    });
+
+    test("parses Ark with Bitcoin address", () => {
+      const result = parseBIP321(
+        `bitcoin:${TEST_DATA.addresses.mainnet.p2pkh}?ark=${TEST_DATA.ark.mainnet}`,
+      );
+      expect(result.valid).toBe(true);
+      expect(result.paymentMethods.length).toBe(2);
+      expect(result.paymentMethods[0]!.type).toBe("onchain");
+      expect(result.paymentMethods[1]!.type).toBe("ark");
+      expect(result.paymentMethods[0]!.network).toBe("mainnet");
+      expect(result.paymentMethods[1]!.network).toBe("mainnet");
+    });
+
+    test("validates Ark network matches expected network", () => {
+      const result = parseBIP321(
+        `bitcoin:?ark=${TEST_DATA.ark.mainnet}`,
+        "testnet",
+      );
+      expect(result.valid).toBe(false);
+      expect(result.errors.some((e) => e.includes("network mismatch"))).toBe(
+        true,
+      );
+    });
+  });
+
   describe("Network-specific Parameters", () => {
     test("parses bc parameter for mainnet", () => {
       const result = parseBIP321(
@@ -461,5 +557,45 @@ describe("BIP-321 Parser", () => {
       expect(result.paymentMethods.length).toBe(2);
       expect(result.paymentMethods.every((pm) => pm.valid)).toBe(true);
     });
+
+    test("accepts Ark testnet address when expecting regtest", () => {
+      const result = parseBIP321(
+        `bitcoin:?ark=${TEST_DATA.ark.testnet}`,
+        "regtest",
+      );
+      expect(result.valid).toBe(true);
+      expect(result.paymentMethods[0]!.type).toBe("ark");
+      expect(result.paymentMethods[0]!.valid).toBe(true);
+    });
+
+    test("accepts Ark testnet address when expecting signet", () => {
+      const result = parseBIP321(
+        `bitcoin:?ark=${TEST_DATA.ark.testnet}`,
+        "signet",
+      );
+      expect(result.valid).toBe(true);
+      expect(result.paymentMethods[0]!.type).toBe("ark");
+      expect(result.paymentMethods[0]!.valid).toBe(true);
+    });
+
+    test("accepts silent payment testnet address when expecting regtest", () => {
+      const result = parseBIP321(
+        `bitcoin:?sp=${TEST_DATA.silentPayment.testnet}`,
+        "regtest",
+      );
+      expect(result.valid).toBe(true);
+      expect(result.paymentMethods[0]!.type).toBe("silent-payment");
+      expect(result.paymentMethods[0]!.valid).toBe(true);
+    });
+
+    test("accepts silent payment testnet address when expecting signet", () => {
+      const result = parseBIP321(
+        `bitcoin:?sp=${TEST_DATA.silentPayment.testnet}`,
+        "signet",
+      );
+      expect(result.valid).toBe(true);
+      expect(result.paymentMethods[0]!.type).toBe("silent-payment");
+      expect(result.paymentMethods[0]!.valid).toBe(true);
+    });
   });
 });

package/index.ts

@@ -1,10 +1,14 @@
-import * as bitcoin from "bitcoinjs-lib";
-import { decode as decodeLightning } from "light-bolt11-decoder";
-import { sha256 } from "@noble/hashes/sha2.js";
-import { base58, bech32, bech32m } from "@scure/base";
+import {
+  validateBitcoinAddress,
+  validateLightningInvoice,
+  validateBolt12Offer,
+  validateSilentPaymentAddress,
+  validateArkAddress,
+  validatePopUri,
+} from "./validators";
 
 export interface PaymentMethod {
-  type: "onchain" | "lightning" | "lno" | "silent-payment" | "other";
+  type: "onchain" | "lightning" | "offer" | "silent-payment" | "ark";
   value: string;
   network?: "mainnet" | "testnet" | "regtest" | "signet";
   valid: boolean;
@@ -26,172 +30,6 @@ export interface BIP321ParseResult {
   errors: string[];
 }
 
-const FORBIDDEN_POP_SCHEMES = ["http", "https", "file", "javascript", "mailto"];
-
-function detectAddressNetwork(
-  address: string,
-): "mainnet" | "testnet" | "regtest" | "signet" | undefined {
-  try {
-    const lowerAddress = address.toLowerCase();
-
-    // Bech32/Bech32m addresses
-    if (lowerAddress.startsWith("bc1")) {
-      try {
-        // Try using bitcoinjs-lib first (works for non-taproot)
-        bitcoin.address.toOutputScript(address, bitcoin.networks.bitcoin);
-        return "mainnet";
-      } catch {
-        // Fallback to manual bech32/bech32m validation for taproot
-        try {
-          const decoded = lowerAddress.startsWith("bc1p")
-            ? bech32m.decode(address as `${string}1${string}`, 90)
-            : bech32.decode(address as `${string}1${string}`, 90);
-          if (decoded.prefix === "bc") {
-            return "mainnet";
-          }
-        } catch {
-          return undefined;
-        }
-      }
-    } else if (lowerAddress.startsWith("tb1")) {
-      try {
-        bitcoin.address.toOutputScript(address, bitcoin.networks.testnet);
-        return "testnet";
-      } catch {
-        try {
-          const decoded = lowerAddress.startsWith("tb1p")
-            ? bech32m.decode(address as `${string}1${string}`, 90)
-            : bech32.decode(address as `${string}1${string}`, 90);
-          if (decoded.prefix === "tb") {
-            return "testnet";
-          }
-        } catch {
-          return undefined;
-        }
-      }
-    } else if (lowerAddress.startsWith("bcrt1")) {
-      try {
-        bitcoin.address.toOutputScript(address, bitcoin.networks.regtest);
-        return "regtest";
-      } catch {
-        try {
-          const decoded = lowerAddress.startsWith("bcrt1p")
-            ? bech32m.decode(address as `${string}1${string}`, 90)
-            : bech32.decode(address as `${string}1${string}`, 90);
-          if (decoded.prefix === "bcrt") {
-            return "regtest";
-          }
-        } catch {
-          return undefined;
-        }
-      }
-    }
-
-    // Base58 addresses (P2PKH, P2SH) - manual validation with checksum
-    try {
-      const decoded = base58.decode(address);
-      if (decoded.length < 25) {
-        return undefined;
-      }
-
-      // Verify checksum
-      const payload = decoded.slice(0, -4);
-      const checksum = decoded.slice(-4);
-      const hash = sha256(sha256(payload));
-
-      for (let i = 0; i < 4; i++) {
-        if (checksum[i] !== hash[i]) {
-          return undefined;
-        }
-      }
-
-      const version = payload[0];
-
-      // Mainnet: P2PKH (0x00), P2SH (0x05)
-      if (version === 0x00 || version === 0x05) {
-        return "mainnet";
-      }
-      // Testnet: P2PKH (0x6f), P2SH (0xc4)
-      else if (version === 0x6f || version === 0xc4) {
-        return "testnet";
-      }
-    } catch (e) {
-      return undefined;
-    }
-  } catch {
-    return undefined;
-  }
-  return undefined;
-}
-
-function validateBitcoinAddress(address: string): {
-  valid: boolean;
-  network?: "mainnet" | "testnet" | "regtest" | "signet";
-  error?: string;
-} {
-  if (!address) {
-    return { valid: false, error: "Empty address" };
-  }
-
-  const network = detectAddressNetwork(address);
-  if (!network) {
-    return { valid: false, error: "Invalid bitcoin address" };
-  }
-
-  return { valid: true, network };
-}
-
-function validateLightningInvoice(invoice: string): {
-  valid: boolean;
-  network?: "mainnet" | "testnet" | "regtest" | "signet";
-  error?: string;
-} {
-  try {
-    const _decoded = decodeLightning(invoice);
-    let network: "mainnet" | "testnet" | "regtest" | "signet" | undefined;
-
-    const lowerInvoice = invoice.toLowerCase();
-    // Check order matters - lnbcrt before lnbc, lntbs before lntb
-    if (lowerInvoice.startsWith("lnbcrt")) {
-      network = "regtest";
-    } else if (lowerInvoice.startsWith("lnbc")) {
-      network = "mainnet";
-    } else if (lowerInvoice.startsWith("lntbs")) {
-      network = "signet";
-    } else if (
-      lowerInvoice.startsWith("lntb") ||
-      lowerInvoice.startsWith("lnbt")
-    ) {
-      network = "testnet";
-    }
-
-    return { valid: true, network };
-  } catch (e) {
-    return {
-      valid: false,
-      error: `Invalid lightning invoice: ${e instanceof Error ? e.message : String(e)}`,
-    };
-  }
-}
-
-function validatePopUri(popUri: string): { valid: boolean; error?: string } {
-  try {
-    const decoded = decodeURIComponent(popUri);
-    const schemeMatch = decoded.match(/^([a-zA-Z][a-zA-Z0-9+.-]*):?/);
-
-    if (schemeMatch && schemeMatch[1]) {
-      const scheme = schemeMatch[1].toLowerCase();
-      if (FORBIDDEN_POP_SCHEMES.includes(scheme)) {
-        return { valid: false, error: `Forbidden pop scheme: ${scheme}` };
-      }
-    }
-
-    return { valid: true };
-  } catch {
-    return { valid: false, error: "Invalid pop URI encoding" };
-  }
-}
-
 export function parseBIP321(
   uri: string,
   expectedNetwork?: "mainnet" | "testnet" | "regtest" | "signet",
@@ -268,7 +106,7 @@ export function parseBIP321(
       }
 
       const lowerKey = key.toLowerCase();
-      const count = (seenKeys.get(lowerKey) || 0) + 1;
+      const count = (seenKeys.get(lowerKey) ?? 0) + 1;
       seenKeys.set(lowerKey, count);
 
       if (lowerKey === "label") {
@@ -308,7 +146,7 @@ export function parseBIP321(
           // Keep pop value encoded as per spec
           const validation = validatePopUri(value);
           if (!validation.valid) {
-            result.errors.push(validation.error || "Invalid pop URI");
+            result.errors.push(validation.error ?? "Invalid pop URI");
             if (lowerKey === "req-pop") {
               result.valid = false;
             }
@@ -327,28 +165,47 @@ export function parseBIP321(
           error: validation.error,
         });
         if (!validation.valid) {
-          result.errors.push(validation.error || "Invalid lightning invoice");
+          result.errors.push(validation.error ?? "Invalid lightning invoice");
         }
       } else if (lowerKey === "lno") {
         const decodedValue = decodeURIComponent(value);
+        const validation = validateBolt12Offer(decodedValue);
         result.paymentMethods.push({
-          type: "lno",
+          type: "offer",
           value: decodedValue,
-          valid: true,
+          valid: validation.valid,
+          error: validation.error,
         });
+        if (!validation.valid) {
+          result.errors.push(validation.error ?? "Invalid BOLT12 offer");
+        }
       } else if (lowerKey === "sp") {
         const decodedValue = decodeURIComponent(value);
-        const isSilentPayment = decodedValue.toLowerCase().startsWith("sp1");
+        const validation = validateSilentPaymentAddress(decodedValue);
         result.paymentMethods.push({
           type: "silent-payment",
           value: decodedValue,
-          valid: isSilentPayment,
-          error: isSilentPayment
-            ? undefined
-            : "Invalid silent payment address format",
+          network: validation.network,
+          valid: validation.valid,
+          error: validation.error,
         });
-        if (!isSilentPayment) {
-          result.errors.push("Invalid silent payment address format");
+        if (!validation.valid) {
+          result.errors.push(
+            validation.error ?? "Invalid silent payment address",
+          );
+        }
+      } else if (lowerKey === "ark") {
+        const decodedValue = decodeURIComponent(value);
+        const validation = validateArkAddress(decodedValue);
+        result.paymentMethods.push({
+          type: "ark",
+          value: decodedValue,
+          network: validation.network,
+          valid: validation.valid,
+          error: validation.error,
+        });
+        if (!validation.valid) {
+          result.errors.push(validation.error ?? "Invalid Ark address");
         }
       } else if (
         lowerKey === "bc" ||
@@ -382,7 +239,7 @@ export function parseBIP321(
         if (!validation.valid || !networkMatches) {
           result.errors.push(
             !validation.valid
-              ? validation.error!
+              ? (validation.error ?? "Invalid address")
               : `Address network mismatch for ${lowerKey} parameter`,
           );
           result.valid = false;
@@ -392,9 +249,7 @@ export function parseBIP321(
         result.errors.push(`Unknown required parameter: ${key}`);
         result.valid = false;
       } else {
-        if (!result.optionalParams[lowerKey]) {
-          result.optionalParams[lowerKey] = [];
-        }
+        result.optionalParams[lowerKey] ??= [];
         result.optionalParams[lowerKey].push(decodeURIComponent(value));
       }
     }
@@ -408,12 +263,22 @@ export function parseBIP321(
   if (expectedNetwork) {
     for (const method of result.paymentMethods) {
       if (method.network && method.network !== expectedNetwork) {
-        result.errors.push(
-          `Payment method network mismatch: expected ${expectedNetwork}, got ${method.network}`,
-        );
-        result.valid = false;
-        method.valid = false;
-        method.error = `Network mismatch: expected ${expectedNetwork}`;
+        // For Ark and Silent Payments, testnet covers testnet/signet/regtest
+        const isTestnetCompatible =
+          (method.type === "ark" || method.type === "silent-payment") &&
+          method.network === "testnet" &&
+          (expectedNetwork === "testnet" ||
+            expectedNetwork === "signet" ||
+            expectedNetwork === "regtest");
+
+        if (!isTestnetCompatible) {
+          result.errors.push(
+            `Payment method network mismatch: expected ${expectedNetwork}, got ${method.network}`,
+          );
+          result.valid = false;
+          method.valid = false;
+          method.error = `Network mismatch: expected ${expectedNetwork}`;
+        }
       }
     }
   }
@@ -442,10 +307,17 @@ export function getPaymentMethodsByNetwork(
   };
 
   for (const method of result.paymentMethods) {
-    if (method.network && byNetwork[method.network]) {
-      byNetwork[method.network]!.push(method);
+    const { network } = method;
+    if (network && network in byNetwork) {
+      const networkArray = byNetwork[network];
+      if (networkArray) {
+        networkArray.push(method);
+      }
     } else {
-      byNetwork.unknown!.push(method);
+      const unknownArray = byNetwork.unknown;
+      if (unknownArray) {
+        unknownArray.push(method);
+      }
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bip-321",
-  "version": "0.0.4",
+  "version": "0.0.6",
   "description": "A TypeScript/JavaScript library for parsing BIP-321 Bitcoin URI scheme with support for multiple payment methods",
   "type": "module",
   "main": "./index.ts",
@@ -16,7 +16,7 @@
     "test": "bun test",
     "example": "bun example.ts",
     "check": "tsc --noEmit",
-    "lint": "oxlint"
+    "lint": "eslint ."
   },
   "keywords": [
     "bitcoin",
@@ -45,11 +45,15 @@
     "@noble/hashes": "^2.0.1",
     "@scure/base": "^2.0.0",
     "bitcoinjs-lib": "^7.0.0",
-    "light-bolt11-decoder": "^3.2.0"
+    "light-bolt11-decoder": "^3.2.0",
+    "light-bolt12-decoder": "^1.0.3"
   },
   "devDependencies": {
     "@types/bun": "latest",
-    "oxlint": "^1.26.0"
+    "@typescript-eslint/eslint-plugin": "^8.46.3",
+    "@typescript-eslint/parser": "^8.46.3",
+    "eslint": "^9.39.1",
+    "eslint-plugin-import": "^2.32.0"
   },
   "peerDependencies": {
     "typescript": "^5"