biotonomy 0.2.6 → 0.2.7

package/commands/loop.sh

@@ -63,11 +63,25 @@ bt_cmd_loop() {
 
   local feat_dir
   feat_dir="$(bt_feature_dir "$feature")"
+
+  # Auto-run plan-review if PLAN_REVIEW.md is missing or unapproved
   local plan_review="$feat_dir/PLAN_REVIEW.md"
   if [[ ! -f "$plan_review" ]] || ! grep -qiE "Verdict:.*(APPROVE_PLAN|APPROVED_PLAN)" "$plan_review"; then
-    bt_err "missing or unapproved $plan_review"
-    bt_err "run: bt plan-review $feature"
-    bt_die "loop hard-fails without approved PLAN_REVIEW verdict before implement/review"
+    bt_info "PLAN_REVIEW missing or unapproved; auto-running plan-review..."
+    # shellcheck source=/dev/null
+    source "$BT_ROOT/commands/plan-review.sh"
+    if ! bt_cmd_plan_review "$feature"; then
+      bt_err "auto plan-review failed for $feature"
+      bt_err "manually run: bt plan-review $feature"
+      bt_die "loop hard-fails without approved PLAN_REVIEW verdict before implement/review"
+    fi
+    # Re-check after auto-run
+    if [[ ! -f "$plan_review" ]] || ! grep -qiE "Verdict:.*(APPROVE_PLAN|APPROVED_PLAN)" "$plan_review"; then
+      bt_err "plan-review ran but did not produce an approved verdict"
+      bt_err "check $plan_review and re-run: bt plan-review $feature"
+      bt_die "loop hard-fails without approved PLAN_REVIEW verdict before implement/review"
+    fi
+    bt_info "plan-review auto-approved; continuing loop"
   fi
 
   bt_info "starting loop for: $feature (max iterations: $max_iter)"

package/lib/env.sh

@@ -6,6 +6,14 @@ bt__export_kv() {
   local val="$2"
 
   [[ "$key" =~ ^[A-Za-z_][A-Za-z0-9_]*$ ]] || return 0
+
+  # Respect process env: only set if not already present in environment.
+  # This ensures BT_GATE_TEST='echo hi' bt gates works even when .bt.env
+  # contains an empty BT_GATE_TEST= line.  (#38)
+  if [[ -n "${!key+x}" ]]; then
+    return 0
+  fi
+
   # Export without eval; keep value literal even if it contains spaces/symbols.
   export "$key=$val"
 }

package/lib/gates.sh

@@ -76,6 +76,33 @@ bt_get_gate_config() {
 
 # Runs gates and returns a JSON string fragment with results.
 # Writes logs to stderr. Returns 0 if all gates passed, 1 otherwise.
+bt__gate_script_exists() {
+  # Check if an npm/pnpm/yarn script actually exists in package.json.
+  # Returns 0 if the script exists or if we can't determine (non-npm project).
+  local cmd="$1"
+  local script_name=""
+
+  # Extract script name from common patterns
+  case "$cmd" in
+    "npm run "*)  script_name="${cmd#npm run }" ;;
+    "npm test")   script_name="test" ;;
+    "pnpm "*)     script_name="${cmd#pnpm }" ;;
+    "yarn "*)     script_name="${cmd#yarn }" ;;
+    *)            return 0 ;;  # Not an npm-style command, assume exists
+  esac
+  script_name="${script_name%% *}"  # Take first word only
+
+  local pkg="$BT_PROJECT_ROOT/package.json"
+  [[ -f "$pkg" ]] || return 0  # No package.json, can't check
+
+  # Check if script exists in package.json
+  if command -v node >/dev/null 2>&1; then
+    node -e "const p=require('$pkg'); process.exit(p.scripts && p.scripts['$script_name'] ? 0 : 1)" 2>/dev/null
+    return $?
+  fi
+  return 0  # Can't verify, assume exists
+}
+
 bt_run_gates() {
   local require_any=0
   if [[ "${1:-}" == "--require-any" ]]; then
@@ -93,14 +120,35 @@ bt_run_gates() {
 
   while IFS= read -r line; do
     [[ -n "$line" ]] || continue
-    any=1
     k="${line%%=*}"
     v="${line#*=}"
 
+    # Skip gates explicitly set to "skip" or "" (disabled)
+    if [[ "$v" == "skip" || -z "$v" ]]; then
+      bt_warn "gate disabled: $k"
+      local entry k_json v_json
+      k_json="$(bt__json_escape "$k")"
+      v_json="$(bt__json_escape "$v")"
+      printf -v entry '"%s": {"cmd": "%s", "status": -1, "skipped": true}' "$k_json" "$v_json"
+      if [[ -z "$results_json" ]]; then results_json="$entry"; else results_json="$results_json, $entry"; fi
+      continue
+    fi
+
+    # Skip gates whose scripts don't exist
+    if ! bt__gate_script_exists "$v"; then
+      bt_warn "gate skipped (script missing): $k ($v)"
+      local entry k_json v_json
+      k_json="$(bt__json_escape "$k")"
+      v_json="$(bt__json_escape "$v")"
+      printf -v entry '"%s": {"cmd": "%s", "status": -1, "skipped": true}' "$k_json" "$v_json"
+      if [[ -z "$results_json" ]]; then results_json="$entry"; else results_json="$results_json, $entry"; fi
+      continue
+    fi
+
+    any=1
+
     bt_info "gate: $k ($v)"
     local status=0
-    # Use bash -lc for interactivity if needed, but we typically want it non-interactive.
-    # The original used bash -lc "$v". We'll stick to that but capture status.
     if ! (cd "$BT_PROJECT_ROOT" && bash -lc "$v"); then
       bt_err "gate failed: $k"
       status=1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "biotonomy",
-  "version": "0.2.6",
+  "version": "0.2.7",
   "description": "Codex-native autonomous development loop CLI",
   "license": "MIT",
   "repository": {