bimba-cli 0.7.28 → 0.7.29

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bimba-cli",
-  "version": "0.7.28",
+  "version": "0.7.29",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/HeapVoid/bimba.git"

package/plugin.js

@@ -45,6 +45,16 @@ function compileErrorKey(filepath) {
   return physicalCompileKey(filepath) || `path:${normalizeCompilePath(filepath)}`;
 }
 
+function compileFileStamp(filepath) {
+  try {
+    const stat = fs.statSync(filepath);
+    if (!stat.isFile()) return null;
+    return `${stat.mtimeMs ?? stat.mtime?.getTime?.() ?? 0}_${stat.size ?? 0}`;
+  } catch(_) {
+    return null;
+  }
+}
+
 function compileErrorMessage(error) {
   return error?.message || String(error);
 }
@@ -102,66 +112,82 @@ export const imbaPlugin = {
     build.onLoad({ filter: /\.imba$/ }, async ({ path }) => {
 
       const f = dir.parse(path)
-      let contents = '';
-
-      // return the cached version if exists (include target in hash to avoid cross-platform cache hits)
-      const cached = dir.join(cache, Bun.hash(path + ':' + target) + '_' + fs.statSync(path).mtimeMs + '.js');
-      if (fs.existsSync(cached)) {
-        clearCompileError(path);
-        stats.bundled++;
-        stats.cached++;
-        return {
-          contents: await Bun.file(cached).text(),
-          loader: "js",
-        };
-      }
 
-      // clear previous cached version
-      const glob = new Glob(Bun.hash(path + ':' + target) + '_' + "*.js");
-      for await (const file of glob.scan(cache)) if (fs.existsSync(dir.join(cache, file))) unlink(dir.join(cache, file));
-
-      // if no cached version read and compile it with the imba compiler
-      const file = await Bun.file(path).text();
-      const platform = target === 'node' || target === 'bun' ? 'node' : 'browser';
-      let out
-      try {
-        out = compiler.compile(file, {
-          sourcePath: path,
-          platform: platform,
-          comments: false
-        })
-      } catch (error) {
-        out = { js: '', errors: [error] }
-      }
-      
-      // the file has been successfully compiled
-      if (!out.errors?.length) {
-        clearCompileError(path);
-        console.log(theme.action("compiling: ") + theme.folder(dir.join(f.dir,'/')) + theme.filename(f.base) + " - " + theme.success("compiled"));
-        stats.bundled++;
-        stats.compiled++;
-        contents = out.js;
-        await Bun.write(cached, contents);
-      }
-      // there were errors during compilation
-      else {
-        const shouldPrint = shouldPrintCompileError(path, out.errors);
-        if (shouldPrint) console.log(theme.action("compiling: ") + theme.folder(dir.join(f.dir,'/')) + theme.filename(f.base) + " - " + theme.failure(" fail "));
-        stats.failed++;
-        if (shouldPrint) {
-          stats.reported++;
-          for (let i = 0; i < out.errors.length; i++) {
-            if(out.errors[i]) printCompileError(out.errors[i]);
+      while (true) {
+        const stamp = compileFileStamp(path);
+        if (!stamp) {
+          clearCompileError(path);
+          return { contents: '', loader: "js" };
+        }
+
+        let contents = '';
+
+        // return the cached version if exists (include target in hash to avoid cross-platform cache hits)
+        const cached = dir.join(cache, Bun.hash(path + ':' + target) + '_' + stamp + '.js');
+        if (fs.existsSync(cached)) {
+          const cachedContents = await Bun.file(cached).text();
+          if (compileFileStamp(path) !== stamp) continue;
+          clearCompileError(path);
+          stats.bundled++;
+          stats.cached++;
+          return {
+            contents: cachedContents,
+            loader: "js",
+          };
+        }
+
+        // clear previous cached version
+        const glob = new Glob(Bun.hash(path + ':' + target) + '_' + "*.js");
+        for await (const file of glob.scan(cache)) if (fs.existsSync(dir.join(cache, file))) unlink(dir.join(cache, file));
+
+        // if no cached version read and compile it with the imba compiler
+        const file = await Bun.file(path).text();
+        if (compileFileStamp(path) !== stamp) continue;
+
+        const platform = target === 'node' || target === 'bun' ? 'node' : 'browser';
+        let out
+        try {
+          out = compiler.compile(file, {
+            sourcePath: path,
+            platform: platform,
+            comments: false
+          })
+        } catch (error) {
+          out = { js: '', errors: [error] }
+        }
+
+        // Never report or cache a result from an older source snapshot.
+        if (compileFileStamp(path) !== stamp) continue;
+
+        // the file has been successfully compiled
+        if (!out.errors?.length) {
+          clearCompileError(path);
+          console.log(theme.action("compiling: ") + theme.folder(dir.join(f.dir,'/')) + theme.filename(f.base) + " - " + theme.success("compiled"));
+          stats.bundled++;
+          stats.compiled++;
+          contents = out.js;
+          await Bun.write(cached, contents);
+        }
+        // there were errors during compilation
+        else {
+          const shouldPrint = shouldPrintCompileError(path, out.errors);
+          if (shouldPrint) console.log(theme.action("compiling: ") + theme.folder(dir.join(f.dir,'/')) + theme.filename(f.base) + " - " + theme.failure(" fail "));
+          stats.failed++;
+          if (shouldPrint) {
+            stats.reported++;
+            for (let i = 0; i < out.errors.length; i++) {
+              if(out.errors[i]) printCompileError(out.errors[i]);
+            }
           }
+          stats.errors++;
         }
-        stats.errors++;
+
+        // and return the compiled source code as "js"
+        return {
+          contents,
+          loader: "js",
+        };
       }
-      
-      // and return the compiled source code as "js"
-      return {
-        contents,
-        loader: "js",
-      };
     });
   }
 };

package/serve.js

@@ -409,6 +409,17 @@ function isMissingFileError(error) {
 	return error?.code === 'ENOENT' || String(error?.message || error).includes('ENOENT: no such file or directory')
 }
 
+function fileStamp(abs) {
+	try {
+		const stat = statSync(abs)
+		if (!stat.isFile()) return null
+		return `${stat.mtimeMs ?? stat.mtime?.getTime?.() ?? 0}:${stat.size ?? 0}`
+	} catch (error) {
+		if (isMissingFileError(error)) return null
+		throw error
+	}
+}
+
 function missingCompileResult(filepath) {
 	dropFileState(filepath)
 	return { js: '', errors: [], slots: null, changeType: 'missing', missing: true }
@@ -416,49 +427,59 @@ function missingCompileResult(filepath) {
 
 async function compileFile(filepath) {
 	const abs = path.resolve(filepath)
-	if (!existsSync(abs)) return missingCompileResult(abs)
 
-	const file = Bun.file(abs)
-	let stat
-	try {
-		stat = await file.stat()
-	} catch (error) {
-		if (isMissingFileError(error)) return missingCompileResult(abs)
-		throw error
-	}
-	const stamp = `${stat.mtimeMs ?? stat.mtime?.getTime?.() ?? 0}:${stat.size ?? 0}`
+	while (true) {
+		const stamp = fileStamp(abs)
+		if (!stamp) return missingCompileResult(abs)
 
-	const cached = _compileCache.get(abs)
-	if (cached && cached.stamp === stamp) return _normalizeResult(cached.result, { changeType: 'cached' })
+		const cached = _compileCache.get(abs)
+		if (cached && cached.stamp === stamp) {
+			if (fileStamp(abs) !== stamp) continue
+			return _normalizeResult(cached.result, { changeType: 'cached' })
+		}
 
-	let code
-	try {
-		code = await file.text()
-	} catch (error) {
-		if (isMissingFileError(error)) return missingCompileResult(abs)
-		throw error
-	}
-	const result = compiler.compile(code, {
-		sourcePath: filepath,
-		platform: 'browser',
-		sourcemap: 'inline',
-	})
+		const file = Bun.file(abs)
+		let code
+		try {
+			code = await file.text()
+		} catch (error) {
+			if (isMissingFileError(error)) return missingCompileResult(abs)
+			throw error
+		}
 
-	const errors = result.errors || []
-	if (!errors.length && result.js) {
-		const { js, slotCount } = stabilizeSymbols(result.js, abs)
-		result.js = rewriteBareImports(js)
-		const prev = _prevSlots.get(abs)
-		result.slots = (prev === undefined || prev === slotCount) ? 'stable' : 'shifted'
-		_prevSlots.set(abs, slotCount)
-	}
+		// A save can land while an older request is compiling. Never publish,
+		// cache, or report a result unless it still matches the current file.
+		if (fileStamp(abs) !== stamp) continue
 
-	// Bake errors as an own property so caching/spreading preserves them.
-	const baked = { js: result.js, errors, slots: result.slots }
-	const changeType = _prevJs.get(abs) === baked.js ? 'none' : 'full'
-	_prevJs.set(abs, baked.js)
-	_compileCache.set(abs, { stamp, result: baked })
-	return _normalizeResult(baked, { changeType })
+		let result
+		try {
+			result = compiler.compile(code, {
+				sourcePath: filepath,
+				platform: 'browser',
+				sourcemap: 'inline',
+			})
+		} catch (error) {
+			result = { js: '', errors: [error], slots: null }
+		}
+
+		if (fileStamp(abs) !== stamp) continue
+
+		const errors = result.errors || []
+		if (!errors.length && result.js) {
+			const { js, slotCount } = stabilizeSymbols(result.js, abs)
+			result.js = rewriteBareImports(js)
+			const prev = _prevSlots.get(abs)
+			result.slots = (prev === undefined || prev === slotCount) ? 'stable' : 'shifted'
+			_prevSlots.set(abs, slotCount)
+		}
+
+		// Bake errors as an own property so caching/spreading preserves them.
+		const baked = { js: result.js, errors, slots: result.slots }
+		const changeType = _prevJs.get(abs) === baked.js ? 'none' : 'full'
+		_prevJs.set(abs, baked.js)
+		_compileCache.set(abs, { stamp, result: baked })
+		return _normalizeResult(baked, { changeType })
+	}
 }
 
 // ─── HTML helpers ─────────────────────────────────────────────────────────────