bimba-cli 0.5.8 → 0.5.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bimba-cli",
-  "version": "0.5.8",
+  "version": "0.5.10",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/HeapVoid/bimba.git"

package/serve.js

@@ -70,10 +70,25 @@ const hmrClient = `
 
 	function _applyUpdate(file, slots) {
 		_queue = _queue.then(() => _doUpdate(file, slots)).catch(err => {
-			console.error('[bimba HMR]', err);
+			// Safety net: any uncaught failure during HMR → full reload.
+			// Better to lose state than to leave a broken page.
+			console.error('[bimba HMR] reload due to error:', err);
+			location.reload();
 		});
 	}
 
+	// Walk a subtree and call disconnectedCallback on each custom element.
+	// Used before destroying inner DOM on the shifted path so imba/web-component
+	// teardown logic (event listeners, observers, etc.) runs cleanly.
+	function _disconnectDescendants(root) {
+		const all = root.querySelectorAll('*');
+		for (const el of all) {
+			if (el.tagName.includes('-')) {
+				try { el.disconnectedCallback && el.disconnectedCallback(); } catch(_) {}
+			}
+		}
+	}
+
 	async function _doUpdate(file, slots) {
 		clearError();
 
@@ -115,11 +130,23 @@ const hmrClient = `
 		//   that imba's runtime uses for lifecycle), clear innerHTML,
 		//   restore state, re-render. Loses inner DOM state for instances
 		//   of the patched tags, but preserves their instance fields.
+		// Snapshot child counts of the patched tags BEFORE commit. On the
+		// stable path, child count must not grow — if it does, it means slot
+		// stabilization failed for this edit and imba's renderer appended
+		// fresh children alongside the old ones. That's the duplication bug
+		// we cannot recover from in-place → trigger a reload.
+		const childSnap = new Map();
+		for (const tag of collected) {
+			const list = document.querySelectorAll(tag);
+			for (const el of list) childSnap.set(el, el.children.length);
+		}
+
 		if (slots === 'shifted') {
 			for (const tag of collected) {
 				document.querySelectorAll(tag).forEach(el => {
 					const state = {};
 					for (const k of Object.keys(el)) state[k] = el[k];
+					_disconnectDescendants(el);
 					for (const sym of Object.getOwnPropertySymbols(el)) {
 						if (Symbol.keyFor(sym) !== undefined) continue;
 						try { delete el[sym]; } catch(_) {}
@@ -127,12 +154,30 @@ const hmrClient = `
 					el.innerHTML = '';
 					Object.assign(el, state);
 					try { el.render && el.render(); } catch(_) {}
+					// Re-fire lifecycle for the top tag itself: imba compiles
+					// "def mount" to a mount() instance method, and standard
+					// connectedCallback may also matter for descendants created
+					// by render(). The element is still attached to its parent,
+					// so we just call them directly.
+					try { el.connectedCallback && el.connectedCallback(); } catch(_) {}
+					try { el.mount && el.mount(); } catch(_) {}
 				});
 			}
 		}
 
 		if (typeof imba !== 'undefined') imba.commit();
 
+		// Stable-path duplication check.
+		if (slots !== 'shifted') {
+			for (const [el, before] of childSnap) {
+				if (el.children.length > before) {
+					console.warn('[bimba HMR] slot stabilization failed, reloading');
+					location.reload();
+					return;
+				}
+			}
+		}
+
 		// Smart body dedupe: remove only elements that were ADDED during this
 		// HMR cycle and whose tag already existed in body before. This catches
 		// accidental re-mounts from top-level imba.mount() re-runs, but