bigpowers 2.87.3 → 2.87.4

package/.pi/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bigpowers",
-  "version": "2.87.3",
+  "version": "2.87.4",
   "description": "81 skills — 73 agent skills synthesizing 17 years of software engineering discipline into a prescriptive methodology for solo developers",
   "keywords": [
     "pi-package"

package/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [2.87.4](https://github.com/danielvm-git/bigpowers/compare/v2.87.3...v2.87.4) (2026-08-07)
+
+
+### Bug Fixes
+
+* **install:** uninstall menu now removes symlinks for all 18 tools and local installs ([#110](https://github.com/danielvm-git/bigpowers/issues/110)) ([5e8ae1c](https://github.com/danielvm-git/bigpowers/commit/5e8ae1ccd6a127502edde2b0dfb93a28609e82a3))
+
 ## [2.87.3](https://github.com/danielvm-git/bigpowers/compare/v2.87.2...v2.87.3) (2026-08-07)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bigpowers",
-  "version": "2.87.3",
+  "version": "2.87.4",
   "description": "73 agent skills synthesizing 17 years of software engineering discipline into a prescriptive methodology for solo developers",
   "main": "index.js",
   "scripts": {

package/scripts/lib/install-helpers.js

@@ -404,23 +404,23 @@ function installLocal(tool, repoRoot) {
 
 function uninstallTool(toolId, repoRoot) {
   const homeDir = require('os').homedir();
+  // installLocal() resolves its own targets from process.cwd() at call time
+  // (bin/setup.js never passes a mode/cwd into uninstallTool), so the
+  // interactive Uninstall menu — which offers no global/local choice — must
+  // clean whichever scope was actually installed into. Previously this
+  // function only ever touched homeDir: a local install (`bigpowers install`
+  // → Local) was reported as "removed" but every local symlink survived.
+  const cwd = process.cwd();
 
   switch (toolId) {
     case 'claude': {
-      const skillsDir = path.join(homeDir, '.claude', 'skills');
-      if (fs.existsSync(skillsDir)) {
-        for (const entry of fs.readdirSync(skillsDir, { withFileTypes: true })) {
-          if (!entry.isSymbolicLink()) continue;
-          const target = fs.readlinkSync(path.join(skillsDir, entry.name));
-          if (target.startsWith(repoRoot)) {
-            removeSymlink(path.join(skillsDir, entry.name));
-          }
-        }
-      }
+      removeRepoRootedSkillLinks(path.join(homeDir, '.claude', 'skills'), repoRoot);
       const hooksDir = path.join(homeDir, '.claude', 'hooks');
       removeSymlink(path.join(hooksDir, 'block-dangerous-git.sh'));
       removeSymlink(path.join(hooksDir, 'rtk-rewrite.sh'));
       removeSymlink(path.join(hooksDir, 'lib'));
+      // installLocal('claude') only links skills/ (no hooks) into cwd/.claude/skills
+      removeRepoRootedSkillLinks(path.join(cwd, '.claude', 'skills'), repoRoot);
       break;
     }
     case 'gemini':
@@ -434,18 +434,12 @@ function uninstallTool(toolId, repoRoot) {
       ]) {
         removeSymlink(path.join(homeDir, '.gemini', 'hooks', hookFile));
       }
+      // installLocal('gemini') links repoRoot/.gemini/extensions/bigpowers into cwd
+      removeSymlink(path.join(cwd, '.gemini', 'extensions', 'bigpowers'));
       break;
     case 'pi': {
-      const skillsDir = path.join(homeDir, '.pi', 'agent', 'skills');
-      if (fs.existsSync(skillsDir)) {
-        for (const entry of fs.readdirSync(skillsDir, { withFileTypes: true })) {
-          if (!entry.isSymbolicLink()) continue;
-          const target = fs.readlinkSync(path.join(skillsDir, entry.name));
-          if (target.startsWith(repoRoot)) {
-            removeSymlink(path.join(skillsDir, entry.name));
-          }
-        }
-      }
+      removeRepoRootedSkillLinks(path.join(homeDir, '.pi', 'agent', 'skills'), repoRoot);
+      removeRepoRootedSkillLinks(path.join(cwd, '.pi', 'agent', 'skills'), repoRoot);
       break;
     }
     case 'hermes': {
@@ -460,6 +454,17 @@ function uninstallTool(toolId, repoRoot) {
         }
       }
       removeSymlink(path.join(homeDir, '.hermes', 'hooks', 'session-log'));
+      // installLocal('hermes') renders skills into cwd/.hermes/skills (no hook locally)
+      const localSkillsDir = path.join(cwd, '.hermes', 'skills');
+      if (fs.existsSync(localSkillsDir)) {
+        for (const entry of fs.readdirSync(localSkillsDir, { withFileTypes: true })) {
+          if (!entry.isSymbolicLink()) continue;
+          const target = fs.readlinkSync(path.join(localSkillsDir, entry.name));
+          if (target.startsWith(repoRoot) || target.includes('.hermes/skills')) {
+            removeSymlink(path.join(localSkillsDir, entry.name));
+          }
+        }
+      }
       break;
     }
     case 'zcode': {
@@ -474,6 +479,8 @@ function uninstallTool(toolId, repoRoot) {
         }
       }
       removeSymlink(path.join(homeDir, '.zcode', 'AGENTS.md'));
+      removeManagedSkillLinks(path.join(cwd, '.zcode', 'skills'), repoRoot);
+      removeSymlink(path.join(cwd, '.zcode', 'AGENTS.md'));
       break;
     }
     case 'mimo': {
@@ -488,6 +495,8 @@ function uninstallTool(toolId, repoRoot) {
         }
       }
       removeSymlink(path.join(homeDir, '.mimocode', 'AGENTS.md'));
+      removeManagedSkillLinks(path.join(cwd, '.mimocode', 'skills'), repoRoot);
+      removeSymlink(path.join(cwd, '.mimocode', 'AGENTS.md'));
       break;
     }
     case 'antigravity':
@@ -502,10 +511,20 @@ function uninstallTool(toolId, repoRoot) {
           }
         }
       }
+      // installLocal('antigravity') renders into cwd/.agents/skills and — only
+      // if absent — symlinks cwd/AGENTS.md. Skip the local skills dir entirely
+      // when cwd === repoRoot: that's this repo's own tracked .agents/skills
+      // source tree (the installer's rendered-skill INPUT), not an install
+      // target, and must never be touched by uninstall.
+      if (cwd !== repoRoot) {
+        removeManagedSkillLinks(path.join(cwd, '.agents', 'skills'), repoRoot);
+      }
+      removeSymlink(path.join(cwd, 'AGENTS.md'));
       break;
     }
     case 'cursor':
       removeSymlink(path.join(homeDir, '.cursor', 'rules'));
+      removeSymlink(path.join(cwd, '.cursor', 'rules'));
       break;
     case 'codex':
       {
@@ -518,7 +537,60 @@ function uninstallTool(toolId, repoRoot) {
         }
       }
       removeSymlink(path.join(homeDir, '.codex', 'hooks', 'pre-tool-git-guard.sh'));
+      removeSymlink(path.join(homeDir, '.codex', 'AGENTS.md'));
+      // installLocal('codex') only symlinks cwd/.codex/AGENTS.md (no skills/hooks locally)
+      removeSymlink(path.join(cwd, '.codex', 'AGENTS.md'));
       break; // story: e65s02
+    case 'qwen':
+      removeManagedSkillLinks(path.join(homeDir, '.qwen', 'skills'), repoRoot);
+      removeSymlink(path.join(homeDir, '.qwen', 'QWEN.md'));
+      removeSymlink(path.join(homeDir, '.qwen', 'hooks', 'pre-tool-git-guard.sh'));
+      break; // story: e68s02
+    case 'codebuddy':
+      removeManagedSkillLinks(path.join(homeDir, '.codebuddy', 'skills'), repoRoot);
+      removeSymlink(path.join(homeDir, '.codebuddy', 'AGENTS.md'));
+      removeSymlink(path.join(homeDir, '.codebuddy', 'hooks', 'pre-tool-git-guard.sh'));
+      break; // story: e72s02
+    case 'cline':
+      removeManagedSkillLinks(path.join(homeDir, '.cline', 'skills'), repoRoot);
+      break; // story: e66s02
+    case 'kilo':
+    case 'kilocode': {
+      const rulesDir = path.join(homeDir, '.kilocode', 'rules');
+      if (fs.existsSync(rulesDir)) {
+        for (const f of fs.readdirSync(rulesDir)) {
+          if (!f.endsWith('.md')) continue;
+          removeSymlink(path.join(rulesDir, f));
+        }
+      }
+      removeManagedFile(path.join(homeDir, '.kilocode', 'AGENTS.md'));
+      break; // story: e67s02
+    }
+    case 'trae':
+      removeManagedSkillLinks(path.join(homeDir, '.trae', 'skills'), repoRoot);
+      removeSymlink(path.join(homeDir, '.trae', 'AGENTS.md'));
+      removeSymlink(path.join(homeDir, '.trae', 'hooks', 'pre-tool-git-guard.sh'));
+      break; // story: e70s02
+    case 'windsurf': {
+      const rulesDir = path.join(homeDir, '.codeium', 'windsurf', 'rules');
+      if (fs.existsSync(rulesDir)) {
+        for (const f of fs.readdirSync(rulesDir)) {
+          if (!f.endsWith('.md')) continue;
+          removeSymlink(path.join(rulesDir, f));
+        }
+      }
+      removeManagedFile(path.join(homeDir, '.codeium', 'windsurf', 'AGENTS.md'));
+      removeSymlink(path.join(homeDir, '.codeium', 'windsurf', 'hooks', 'pre-tool-git-guard.sh'));
+      break; // story: e73s02
+    }
+    case 'opencode':
+      removeManagedSkillLinks(path.join(homeDir, '.config', 'opencode', 'skills'), repoRoot);
+      removeSymlink(path.join(homeDir, '.config', 'opencode', 'AGENTS.md'));
+      break; // story: e62s02
+    case 'copilot':
+      removeManagedSkillLinks(path.join(homeDir, '.copilot', 'skills'), repoRoot);
+      removeManagedFile(path.join(homeDir, '.copilot', 'AGENTS.md'));
+      break; // story: e71s02
   }
 }
 
@@ -533,6 +605,61 @@ function removeSymlink(p) {
   return false;
 }
 
+// Strict variant of removeManagedSkillLinks: only removes symlinks whose
+// target starts with THIS repoRoot exactly (no 'bigpowers' substring match).
+// Used for claude/pi, where a looser match could delete symlinks pointing at
+// an unrelated bigpowers checkout elsewhere on disk (e.g. a second clone).
+function removeRepoRootedSkillLinks(skillsDir, repoRoot) {
+  if (!fs.existsSync(skillsDir)) return;
+  for (const entry of fs.readdirSync(skillsDir, { withFileTypes: true })) {
+    if (!entry.isSymbolicLink()) continue;
+    const linkPath = path.join(skillsDir, entry.name);
+    let target;
+    try {
+      target = fs.readlinkSync(linkPath);
+    } catch {
+      continue;
+    }
+    if (target.startsWith(repoRoot)) {
+      removeSymlink(linkPath);
+    }
+  }
+}
+
+// Remove bigpowers-managed skill symlinks from a tool's skills dir. Only touches
+// symlinks that resolve back into the repo (installGlobal creates them via
+// linkRenderedSkills → linkDir), leaving any user-authored entries alone.
+function removeManagedSkillLinks(skillsDir, repoRoot) {
+  if (!fs.existsSync(skillsDir)) return;
+  for (const entry of fs.readdirSync(skillsDir, { withFileTypes: true })) {
+    if (!entry.isSymbolicLink()) continue;
+    const linkPath = path.join(skillsDir, entry.name);
+    let target;
+    try {
+      target = fs.readlinkSync(linkPath);
+    } catch {
+      continue;
+    }
+    if (target.startsWith(repoRoot) || target.includes('bigpowers')) {
+      removeSymlink(linkPath);
+    }
+  }
+}
+
+// Remove a file the installer placed as a plain copy (kilo/windsurf/copilot use
+// fs.copyFileSync for AGENTS.md, so removeSymlink would skip it). Also handles
+// the symlink case so it's safe on either install shape.
+function removeManagedFile(p) {
+  try {
+    const stat = fs.lstatSync(p);
+    if (stat.isSymbolicLink() || stat.isFile()) {
+      fs.unlinkSync(p);
+      return true;
+    }
+  } catch {}
+  return false;
+}
+
 function detectExistingInstall() {
   const homeDir = require('os').homedir();
   const marker = path.join(homeDir, '.claude', 'skills', 'survey-context');

package/scripts/test-install-helpers.js

@@ -87,6 +87,116 @@ try {
   uninstallTool('cursor', ROOT);
   assert.ok(!fs.existsSync(rulesDst), 'uninstallTool(cursor) must remove rules symlink');
 
+  // Regression: every tool the uninstall menu offers must have a real uninstall
+  // path. Before this, qwen/codebuddy/cline/kilo/trae/windsurf/opencode/copilot
+  // had install cases but no uninstall case — uninstall reported success while
+  // leaving every symlink in place.
+  installGlobal({ id: 'qwen', name: 'Qwen Code' }, ROOT);
+  const qwenSkills = path.join(tmpHome, '.qwen', 'skills');
+  const qwenSample = fs.existsSync(qwenSkills)
+    && fs.readdirSync(qwenSkills).find((n) => {
+      try { return fs.lstatSync(path.join(qwenSkills, n)).isSymbolicLink(); } catch { return false; }
+    });
+  assert.ok(qwenSample, 'qwen install must create at least one skill symlink');
+  uninstallTool('qwen', ROOT);
+  assert.ok(
+    !fs.existsSync(path.join(qwenSkills, qwenSample)),
+    'uninstallTool(qwen) must remove repo-rooted skill symlinks'
+  );
+
+  // copilot writes AGENTS.md as a plain copy (not a symlink); uninstall must
+  // still remove it via removeManagedFile.
+  installGlobal({ id: 'copilot', name: 'Copilot' }, ROOT);
+  const copilotAgents = path.join(tmpHome, '.copilot', 'AGENTS.md');
+  const copilotHadAgents = fs.existsSync(copilotAgents);
+  uninstallTool('copilot', ROOT);
+  if (copilotHadAgents) {
+    assert.ok(!fs.existsSync(copilotAgents), 'uninstallTool(copilot) must remove copied AGENTS.md');
+  }
+  const copilotSkills = path.join(tmpHome, '.copilot', 'skills');
+  if (fs.existsSync(copilotSkills)) {
+    const leftover = fs.readdirSync(copilotSkills).find((n) => {
+      try { return fs.lstatSync(path.join(copilotSkills, n)).isSymbolicLink(); } catch { return false; }
+    });
+    assert.ok(!leftover, 'uninstallTool(copilot) must remove skill symlinks');
+  }
+
+  // Regression: uninstallTool() only ever touched homeDir. The interactive
+  // Uninstall menu (bin/setup.js handleUninstall) never asks global-vs-local
+  // and calls uninstallTool(toolId, ROOT) unconditionally — so a *local*
+  // install (`bigpowers install` → Local) was reported "removed" while every
+  // local symlink survived, for every tool. Verify local install/uninstall
+  // round-trips for tools spanning each install shape: skill-symlink dir
+  // (pi, claude), single linked dir (cursor, gemini), and a linked file
+  // (codex AGENTS.md).
+  const { installLocal } = require('../scripts/lib/install-helpers.js');
+  const savedCwd = process.cwd();
+  const tmpCwd = mkdtempSync(path.join(os.tmpdir(), 'bp-install-helpers-local-'));
+  try {
+    process.chdir(tmpCwd);
+
+    installLocal({ id: 'pi', name: 'pi' }, ROOT);
+    const localPiSkills = path.join(tmpCwd, '.pi', 'agent', 'skills');
+    const localPiSample = fs.readdirSync(localPiSkills).find((n) => {
+      try { return fs.lstatSync(path.join(localPiSkills, n)).isSymbolicLink(); } catch { return false; }
+    });
+    assert.ok(localPiSample, 'local pi install must create at least one skill symlink');
+    uninstallTool('pi', ROOT);
+    assert.ok(
+      !fs.existsSync(path.join(localPiSkills, localPiSample)),
+      'uninstallTool(pi) must also remove LOCAL (cwd) skill symlinks, not just global'
+    );
+
+    installLocal({ id: 'claude', name: 'Claude Code' }, ROOT);
+    const localClaudeSkills = path.join(tmpCwd, '.claude', 'skills');
+    const localClaudeSample = fs.readdirSync(localClaudeSkills).find((n) => {
+      try { return fs.lstatSync(path.join(localClaudeSkills, n)).isSymbolicLink(); } catch { return false; }
+    });
+    assert.ok(localClaudeSample, 'local claude install must create at least one skill symlink');
+    uninstallTool('claude', ROOT);
+    assert.ok(
+      !fs.existsSync(path.join(localClaudeSkills, localClaudeSample)),
+      'uninstallTool(claude) must also remove LOCAL (cwd) skill symlinks, not just global'
+    );
+
+    installLocal({ id: 'cursor', name: 'Cursor' }, ROOT);
+    const localCursorRules = path.join(tmpCwd, '.cursor', 'rules');
+    assert.ok(fs.lstatSync(localCursorRules).isSymbolicLink(), 'local cursor install must symlink .cursor/rules');
+    uninstallTool('cursor', ROOT);
+    assert.ok(!fs.existsSync(localCursorRules), 'uninstallTool(cursor) must remove LOCAL .cursor/rules symlink');
+
+    installLocal({ id: 'gemini', name: 'Gemini' }, ROOT);
+    const localGeminiExt = path.join(tmpCwd, '.gemini', 'extensions', 'bigpowers');
+    assert.ok(fs.lstatSync(localGeminiExt).isSymbolicLink(), 'local gemini install must symlink extensions/bigpowers');
+    uninstallTool('gemini', ROOT);
+    assert.ok(!fs.existsSync(localGeminiExt), 'uninstallTool(gemini) must remove LOCAL extensions/bigpowers symlink');
+
+    installLocal({ id: 'codex', name: 'Codex' }, ROOT);
+    const localCodexAgents = path.join(tmpCwd, '.codex', 'AGENTS.md');
+    assert.ok(fs.lstatSync(localCodexAgents).isSymbolicLink(), 'local codex install must symlink AGENTS.md');
+    uninstallTool('codex', ROOT);
+    assert.ok(!fs.existsSync(localCodexAgents), 'uninstallTool(codex) must remove LOCAL AGENTS.md symlink');
+  } finally {
+    process.chdir(savedCwd);
+    rmSync(tmpCwd, { recursive: true, force: true });
+  }
+
+  // Guard against future drift: assert the menu's supported set matches the
+  // uninstall switch. Any id in SUPPORTED_IDS with no uninstall case regresses
+  // this bug (silent no-op reported as success).
+  const helpersSrc = fs.readFileSync(path.join(ROOT, 'scripts', 'lib', 'install-helpers.js'), 'utf8');
+  const uninstallBody = helpersSrc.slice(helpersSrc.indexOf('function uninstallTool'));
+  const setupText = fs.readFileSync(path.join(ROOT, 'bin/setup.js'), 'utf8');
+  const supportedLine = setupText.match(/const SUPPORTED_IDS = new Set\(\[([^\]]*)\]\)/);
+  assert.ok(supportedLine, 'SUPPORTED_IDS must be declarable from bin/setup.js');
+  const supportedIds = supportedLine[1].match(/'([^']+)'/g).map((s) => s.replace(/'/g, ''));
+  for (const id of supportedIds) {
+    assert.ok(
+      new RegExp(`case '${id}':`).test(uninstallBody),
+      `uninstallTool must handle '${id}' (listed in SUPPORTED_IDS) — else uninstall silently no-ops`
+    );
+  }
+
   const installPaths = [
     path.join(ROOT, 'scripts', 'install.sh'),
     ...fs.readdirSync(path.join(ROOT, 'scripts', 'lib'))