bigpowers 2.84.0 → 2.84.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (72) hide show
  1. package/.agents/skills/audit-code/SKILL.md +4 -7
  2. package/.agents/skills/grill-me/SKILL.md +12 -0
  3. package/.agents/skills/grill-with-docs/SKILL.md +12 -0
  4. package/.agents/skills/request-review/SKILL.md +1 -0
  5. package/.agents/skills/wire-ci/SKILL.md +164 -181
  6. package/.codebuddy/skills/audit-code/SKILL.md +4 -7
  7. package/.codebuddy/skills/grill-me/SKILL.md +12 -0
  8. package/.codebuddy/skills/grill-with-docs/SKILL.md +12 -0
  9. package/.codebuddy/skills/request-review/SKILL.md +1 -0
  10. package/.codebuddy/skills/wire-ci/SKILL.md +164 -181
  11. package/.codex/skills/audit-code/SKILL.md +4 -7
  12. package/.codex/skills/grill-me/SKILL.md +12 -0
  13. package/.codex/skills/grill-with-docs/SKILL.md +12 -0
  14. package/.codex/skills/request-review/SKILL.md +1 -0
  15. package/.codex/skills/wire-ci/SKILL.md +164 -181
  16. package/.hermes/skills/audit-code/SKILL.md +4 -7
  17. package/.hermes/skills/grill-me/SKILL.md +12 -0
  18. package/.hermes/skills/grill-with-docs/SKILL.md +12 -0
  19. package/.hermes/skills/request-review/SKILL.md +1 -0
  20. package/.hermes/skills/wire-ci/SKILL.md +164 -181
  21. package/.kilocode/rules/audit-code.md +4 -7
  22. package/.kilocode/rules/grill-me.md +12 -0
  23. package/.kilocode/rules/grill-with-docs.md +12 -0
  24. package/.kilocode/rules/request-review.md +1 -0
  25. package/.kilocode/rules/wire-ci.md +164 -181
  26. package/.mimocode/skills/audit-code/SKILL.md +4 -7
  27. package/.mimocode/skills/grill-me/SKILL.md +12 -0
  28. package/.mimocode/skills/grill-with-docs/SKILL.md +12 -0
  29. package/.mimocode/skills/request-review/SKILL.md +1 -0
  30. package/.mimocode/skills/wire-ci/SKILL.md +164 -181
  31. package/.pi/package.json +1 -1
  32. package/.pi/prompts/audit-code.md +4 -7
  33. package/.pi/prompts/grill-me.md +12 -0
  34. package/.pi/prompts/grill-with-docs.md +12 -0
  35. package/.pi/prompts/request-review.md +1 -0
  36. package/.pi/prompts/wire-ci.md +164 -181
  37. package/.pi/skills/audit-code/SKILL.md +4 -7
  38. package/.pi/skills/grill-me/SKILL.md +12 -0
  39. package/.pi/skills/grill-with-docs/SKILL.md +12 -0
  40. package/.pi/skills/request-review/SKILL.md +1 -0
  41. package/.pi/skills/wire-ci/SKILL.md +164 -181
  42. package/.trae/skills/audit-code/SKILL.md +4 -7
  43. package/.trae/skills/grill-me/SKILL.md +12 -0
  44. package/.trae/skills/grill-with-docs/SKILL.md +12 -0
  45. package/.trae/skills/request-review/SKILL.md +1 -0
  46. package/.trae/skills/wire-ci/SKILL.md +164 -181
  47. package/.windsurf/rules/audit-code.md +4 -7
  48. package/.windsurf/rules/grill-me.md +12 -0
  49. package/.windsurf/rules/grill-with-docs.md +12 -0
  50. package/.windsurf/rules/request-review.md +1 -0
  51. package/.windsurf/rules/wire-ci.md +164 -181
  52. package/.zcode/skills/audit-code/SKILL.md +4 -7
  53. package/.zcode/skills/grill-me/SKILL.md +12 -0
  54. package/.zcode/skills/grill-with-docs/SKILL.md +12 -0
  55. package/.zcode/skills/request-review/SKILL.md +1 -0
  56. package/.zcode/skills/wire-ci/SKILL.md +164 -181
  57. package/CHANGELOG.md +7 -0
  58. package/README.md +14 -1
  59. package/SKILL-INDEX.md +84 -76
  60. package/package.json +1 -1
  61. package/scripts/generate-skill-index.sh +20 -4
  62. package/scripts/golden-g04-selftest.sh +19 -0
  63. package/scripts/lib/__pycache__/link_utils.cpython-312.pyc +0 -0
  64. package/scripts/lib/__pycache__/srp_engine_links.cpython-312.pyc +0 -0
  65. package/skills/audit-code/SKILL.md +4 -7
  66. package/skills/grill-me/SKILL.md +12 -0
  67. package/skills/grill-with-docs/SKILL.md +12 -0
  68. package/skills/request-review/SKILL.md +1 -0
  69. package/skills/visual-dashboard/scripts/frame-template.html +1 -39
  70. package/skills/wire-ci/REFERENCE.md +137 -152
  71. package/skills/wire-ci/SKILL.md +28 -30
  72. package/skills-lock.json +5 -5
@@ -10,12 +10,12 @@ description: "CI pipeline setup with pre-built templates and local validation. G
10
10
  >
11
11
  > **HARD GATE** — CI that is untestable locally will break every cycle. Always run `--validate` after generating workflows and `--dry-run` before pushing.
12
12
 
13
- Generate, validate, and test CI workflows. Detects your project type, produces platform-appropriate GitHub Actions configurations, and provides local verification to catch auth, permissions, and syntax issues before they reach CI.
13
+ Generate, validate, and test CI workflows. Detects your project type, copies org templates from `danielvm-git/.github/workflow-templates/`, and provides local verification to catch auth, permissions, and syntax issues before they reach CI.
14
14
 
15
15
  ## What this sets up
16
16
 
17
- 1. **CI workflow** — `.github/workflows/ci.yaml` with test, lint, typecheck, build steps
18
- 2. **Release workflow** — `.github/workflows/release.yaml` with semantic-release (if applicable)
17
+ 1. **Test Build Release workflow** — `.github/workflows/test-build-release.yml` with lint → test → build → release (single pipeline, `needs:` chain)
18
+ 2. **Deploy workflow** — `.github/workflows/deploy.yml` triggered via `workflow_run` (BigBase/Pages stacks only; CLI/library repos omit this)
19
19
  3. **`--validate` mode** — checks YAML syntax, workflow permissions, required secrets, and common pitfalls
20
20
  4. **`--dry-run` mode** — runs workflows locally via `act` or `gh workflow run` to prove correctness before push
21
21
  5. **Failure pattern documentation** — common CI failure categories and their fixes
@@ -24,45 +24,41 @@ Generate, validate, and test CI workflows. Detects your project type, produces p
24
24
 
25
25
  ### 1. Detect project type
26
26
 
27
- Read the project root for manifest files to determine which template to use:
27
+ Read the project root for manifest files to determine which template pair to copy:
28
28
 
29
- | Manifest | Type | Template |
30
- |----------|------|----------|
31
- | `Cargo.toml` | Rust | Rust CI: test, clippy, fmt, build |
32
- | `package.json` | Node | Node CI: test, lint, typecheck, build |
33
- | `setup.py` / `pyproject.toml` | Python | Python CI: pytest, ruff/mypy/flake8, build |
34
- | `go.mod` | Go | Go CI: test, vet, staticcheck, build |
35
- | `CMakeLists.txt` | C/C++ | C/C++ CI: cmake build, ctest |
36
- | Multiple detected | Polyglot | Combined workflows or error if ambiguous |
29
+ | Manifest | Type | Template pair (from `.github` repo) |
30
+ |----------|------|-------------------------------------|
31
+ | `Cargo.toml` | Rust | `test-build-release-monorepo.yml` + `deploy-monorepo.yml` (or monorepo subset) |
32
+ | `package.json` | Node | `test-build-release-node.yml` + `deploy-node.yml` |
33
+ | `setup.py` / `pyproject.toml` | Python | `test-build-release-python.yml` + `deploy-python.yml` |
34
+ | `go.mod` | Go | `test-build-release-go.yml` + `deploy-go.yml` |
35
+ | Static site (no server) | Static | `test-build-release-static.yml` + `deploy-static.yml` |
36
+ | `Package.swift` | Swift | `test-build-release-swift.yml` only (no deploy yet) |
37
+ | Multiple detected | Polyglot | `test-build-release-monorepo.yml` + `deploy-monorepo.yml` |
37
38
 
38
- If no manifest is found, prompt the user to specify the type or pass `--type <rust|node|python|go|cpp>`.
39
+ **CLI/library repos** (no hosted target): copy only `test-build-release-<stack>.yml` → `test-build-release.yml`. The `release` job is terminal; skip `deploy.yml`. See `docs/how-to/migrate-ci-cd/migration-plan.md` § CLI and library repos.
39
40
 
40
- ### 2. Generate CI workflow
41
+ If no manifest is found, prompt the user to specify the type or pass `--type <rust|node|python|go|static|swift>`.
41
42
 
42
- Create `.github/workflows/ci.yaml` with standard steps derived from the project type and its manifest:
43
+ ### 2. Copy test-build-release template
43
44
 
44
- **Rust template (`Cargo.toml`):**
45
- See [REFERENCE.md](../../../skills/wire-ci/REFERENCE.md)
46
-
47
- **Node template (`package.json`):**
48
- See [REFERENCE.md](../../../skills/wire-ci/REFERENCE.md)
45
+ Copy the matching template from `~/Developer/.github/workflow-templates/` to `.github/workflows/test-build-release.yml`. **Do not rename the workflow `name:` field** — deploy listens for `"Test Build Release"`.
49
46
 
50
- **Python template (`setup.py` / `pyproject.toml`):**
51
- See [REFERENCE.md](../../../skills/wire-ci/REFERENCE.md)
47
+ Edit placeholders: `APP_TYPE`, `SITE_URL`, language versions.
52
48
 
53
- **Go template (`go.mod`):**
54
- See [REFERENCE.md](../../../skills/wire-ci/REFERENCE.md)
49
+ See [REFERENCE.md](../../../skills/wire-ci/REFERENCE.md) for stack-specific job shapes.
55
50
 
56
- **C/C++ template (`CMakeLists.txt`):**
57
- See [REFERENCE.md](../../../skills/wire-ci/REFERENCE.md)
51
+ ### 3. Copy deploy template (hosted stacks only)
58
52
 
59
- ### 3. Generate release workflow (if semantic-release detected)
53
+ If the project deploys to BigBase or GitHub Pages:
60
54
 
61
- If the project has semantic-release configured (in `package.json`, `.releaserc`, or `release.config.js`), also generate `.github/workflows/release.yaml`:
55
+ ```bash
56
+ cp ~/Developer/.github/workflow-templates/deploy-${STACK}.yml .github/workflows/deploy.yml
57
+ ```
62
58
 
63
- See [REFERENCE.md](../../../skills/wire-ci/REFERENCE.md)
59
+ Configure `BIGBASE_SITE_ID`, `BIGBASE_DEPLOY_TOKEN`, and matching `SITE_URL`. Deploy runs via `workflow_run` after TBR succeeds on `main` with `cancel-in-progress: false`.
64
60
 
65
- > **NPM_TOKEN is required** for publishing to npm. Without it, semantic-release will fail at the publish step. See `--validate` to check this.
61
+ Skip this step for CLI/library repos.
66
62
 
67
63
  ### 4. Validate workflows (`--validate`)
68
64
 
@@ -97,6 +93,8 @@ Add the following to the project's documentation or CLAUDE.md after setup:
97
93
  | `cargo clippy` errors | New lints in Rust nightly | `cargo clippy --fix` or allow specific lints |
98
94
  | `act` not found | Docker not running or act not installed | `brew install act` / `docker ps` to verify Docker |
99
95
  | Hardcoded Node version stale | `.nvmrc` exists but workflow uses hardcoded version | Use `node-version-file: .nvmrc` instead |
96
+ | Deploy never runs | TBR workflow renamed | Keep `name: Test Build Release` in test-build-release.yml |
97
+ | Release rebuilds binary | Artifact not downloaded | `release` job must `download-artifact` from `build` |
100
98
 
101
99
  ## Verify
102
100
 
@@ -120,26 +118,24 @@ Add the following to the project's documentation or CLAUDE.md after setup:
120
118
 
121
119
  ## Examples
122
120
 
123
- ### Create CI for a Rust project
121
+ ### Create CI for a Go project (TBR + optional deploy)
124
122
 
125
123
  ```bash
126
- # Detect from Cargo.toml, generate workflows
127
- wire-ci
124
+ # Copy org templates
125
+ cp ~/Developer/.github/workflow-templates/test-build-release-go.yml .github/workflows/test-build-release.yml
126
+ cp ~/Developer/.github/workflow-templates/deploy-go.yml .github/workflows/deploy.yml
128
127
 
129
- # Validate generated workflows
130
128
  wire-ci --validate
131
-
132
- # Run locally with act
133
129
  wire-ci --dry-run
134
130
  ```
135
131
 
136
- ### Create CI for a Node project with semantic-release
132
+ ### Create CI for a CLI tool (TBR only, no deploy)
137
133
 
138
134
  ```bash
139
- wire-ci
135
+ cp ~/Developer/.github/workflow-templates/test-build-release-go.yml .github/workflows/test-build-release.yml
136
+ # Edit release job to download build artifact — see big-release dogfood
137
+
140
138
  wire-ci --validate
141
- # Expect warning: "npm publish step found but no NPM_TOKEN in secrets"
142
- # Fix: add NPM_TOKEN to repo secrets
143
139
  ```
144
140
 
145
141
  ### Validate existing workflows (no generation)
@@ -148,7 +144,6 @@ wire-ci --validate
148
144
  wire-ci --validate --check-only
149
145
  ```
150
146
 
151
-
152
147
  ---
153
148
 
154
149
  ## Options
@@ -160,8 +155,7 @@ wire-ci --validate --check-only
160
155
  | `--check-only` | Only validate, do not generate new files |
161
156
  | `--type <type>` | Force project type (skip auto-detection) |
162
157
  | `--force` | Overwrite existing workflow files |
163
- | `--no-release` | Skip release workflow generation even if semantic-release detected |
164
-
158
+ | `--no-deploy` | Skip deploy.yml even for hosted stacks |
165
159
 
166
160
  ---
167
161
 
@@ -174,202 +168,191 @@ When `wire-ci` is used as part of `build-epic`:
174
168
 
175
169
  ---
176
170
 
177
- ## Reference block 1
171
+ ## Reference block 1 — test-build-release.yml (Go, excerpt)
178
172
 
179
173
  ```yaml
180
- name: CI
181
- on: [push, pull_request]
182
- jobs:
183
- test:
184
- runs-on: ubuntu-latest
185
- steps:
186
- - uses: actions/checkout@v4
187
- - uses: actions-rust/toolchain@v1
188
- with:
189
- toolchain: stable
190
- components: clippy, rustfmt
191
- - run: cargo fmt --all -- --check
192
- - run: cargo clippy -- -D warnings
193
- - run: cargo test
194
- - run: cargo build --release
195
- ```
174
+ name: Test Build Release
175
+ on:
176
+ push:
177
+ branches: [main]
178
+ pull_request:
179
+ branches: [main]
196
180
 
197
- ---
181
+ permissions:
182
+ contents: read
198
183
 
199
- ## Reference block 2
184
+ concurrency:
185
+ group: pipeline-${{ github.workflow }}-${{ github.ref }}
186
+ cancel-in-progress: true
200
187
 
201
- ```yaml
202
- name: CI
203
- on: [push, pull_request]
204
188
  jobs:
205
- test:
206
- runs-on: ubuntu-latest
189
+ lint:
190
+ runs-on: ubuntu-22.04
191
+ timeout-minutes: 10
207
192
  steps:
208
- - uses: actions/checkout@v4
209
- - uses: actions/setup-node@v4
193
+ - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
194
+ - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6.5.0
210
195
  with:
211
- node-version: 20
212
- cache: npm
213
- - run: npm ci
214
- - run: npm test
215
- - run: npm run lint 2>/dev/null || true
216
- - run: npm run typecheck 2>/dev/null || true
217
- - run: npm run build 2>/dev/null || true
218
- ```
219
-
220
- ---
221
-
222
- ## Reference block 3
196
+ go-version: '1.22'
197
+ cache: true
198
+ - uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 # v6.5.2
199
+ with:
200
+ version: v1.64.8
223
201
 
224
- ```yaml
225
- name: CI
226
- on: [push, pull_request]
227
- jobs:
228
202
  test:
229
- runs-on: ubuntu-latest
203
+ needs: [lint]
204
+ runs-on: ubuntu-22.04
230
205
  steps:
231
- - uses: actions/checkout@v4
232
- - uses: actions/setup-python@v5
206
+ - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
207
+ - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6.5.0
233
208
  with:
234
- python-version: "3.12"
235
- cache: pip
236
- - run: pip install -e ".[dev]" || pip install -e .
237
- - run: pip install pytest ruff mypy
238
- - run: ruff check .
239
- - run: mypy . 2>/dev/null || true
240
- - run: pytest
241
- ```
242
-
243
- ---
244
-
245
- ## Reference block 4
209
+ go-version: '1.22'
210
+ cache: true
211
+ - run: go vet ./...
212
+ - run: go test ./... -count=1
246
213
 
247
- ```yaml
248
- name: CI
249
- on: [push, pull_request]
250
- jobs:
251
- test:
252
- runs-on: ubuntu-latest
214
+ build:
215
+ needs: [test]
216
+ runs-on: ubuntu-22.04
253
217
  steps:
254
- - uses: actions/checkout@v4
255
- - uses: actions/setup-go@v5
218
+ - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
219
+ - uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6.5.0
256
220
  with:
257
- go-version: stable
221
+ go-version: '1.22'
258
222
  cache: true
259
- - run: go vet ./...
260
- - run: go test ./...
261
223
  - run: go build ./...
224
+ - run: jq -n --arg sha "${{ github.sha }}" '{sha: $sha}' > deploy-meta.json
225
+ - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
226
+ with:
227
+ name: deploy-meta
228
+ path: deploy-meta.json
229
+
230
+ release:
231
+ if: github.ref == 'refs/heads/main' && github.event_name == 'push'
232
+ needs: [build]
233
+ permissions:
234
+ contents: write
235
+ steps:
236
+ - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
237
+ with:
238
+ fetch-depth: 0
239
+ - run: npx semantic-release
240
+ env:
241
+ GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
262
242
  ```
263
243
 
264
244
  ---
265
245
 
266
- ## Reference block 5
246
+ ## Reference block 2 — deploy.yml (BigBase, excerpt)
267
247
 
268
248
  ```yaml
269
- name: CI
270
- on: [push, pull_request]
249
+ name: Deploy
250
+ on:
251
+ workflow_run:
252
+ workflows: ["Test Build Release"]
253
+ types: [completed]
254
+
255
+ permissions:
256
+ contents: read
257
+ actions: read
258
+
259
+ concurrency:
260
+ group: deploy-production
261
+ cancel-in-progress: false
262
+
263
+ env:
264
+ SITE_URL: "https://CHANGE-ME.bigbase.click"
265
+
271
266
  jobs:
272
- test:
273
- runs-on: ubuntu-latest
267
+ deploy:
268
+ if: >
269
+ github.event.workflow_run.conclusion == 'success' &&
270
+ github.event.workflow_run.head_branch == 'main'
271
+ runs-on: ubuntu-22.04
272
+ environment: production
274
273
  steps:
275
- - uses: actions/checkout@v4
276
- - run: cmake -B build
277
- - run: cmake --build build
278
- - run: ctest --test-dir build
274
+ - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
275
+ with:
276
+ name: deploy-meta
277
+ github-token: ${{ secrets.GITHUB_TOKEN }}
278
+ run-id: ${{ github.event.workflow_run.id }}
279
+ path: deploy-meta
280
+ - uses: danielvm-git/.github/actions/bigbase-deploy@9c56ac10c629f3baa110ddb19136579e3c90d690 # v1
281
+ with:
282
+ site_id: ${{ secrets.BIGBASE_SITE_ID }}
283
+ app_type: go
284
+ site_url: ${{ env.SITE_URL }}
285
+ deploy_token: ${{ secrets.BIGBASE_DEPLOY_TOKEN }}
286
+ ref: ${{ steps.meta.outputs.ref }}
287
+ skip_health_check: true
288
+ - name: Health check
289
+ run: |
290
+ curl -sf "${{ env.SITE_URL }}" || exit 1
279
291
  ```
280
292
 
281
293
  ---
282
294
 
283
- ## Reference block 6
295
+ ## Reference block 3 — CLI dogfood (big-release pattern)
284
296
 
285
297
  ```yaml
286
- name: Release
287
- on:
288
- push:
289
- branches: [main]
290
- jobs:
291
- release:
292
- runs-on: ubuntu-latest
293
- permissions:
294
- contents: write
295
- issues: write
296
- pull-requests: write
297
- id-token: write
298
+ build:
299
+ needs: [test]
298
300
  steps:
299
- - uses: actions/checkout@v4
301
+ - run: make build
302
+ - uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
300
303
  with:
301
- fetch-depth: 0
302
- - uses: actions/setup-node@v4
304
+ name: big-release-${{ github.sha }}
305
+ path: bin/big-release
306
+
307
+ release:
308
+ needs: [build]
309
+ if: github.ref == 'refs/heads/main' && github.event_name == 'push'
310
+ steps:
311
+ - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
303
312
  with:
304
- node-version: 20
305
- cache: npm
306
- - run: npm ci
307
- - run: npm run build 2>/dev/null || true
308
- - run: npx semantic-release
309
- env:
310
- GITHUB_TOKEN: \${{ secrets.GITHUB_TOKEN }}
311
- NPM_TOKEN: \${{ secrets.NPM_TOKEN }}
313
+ name: big-release-${{ github.sha }}
314
+ path: bin
315
+ - run: make release # cross-compile assets only; host binary from artifact
316
+ - run: big-release release --verbose
312
317
  ```
313
318
 
319
+ No `deploy.yml` — CLI publishes via the release job.
320
+
314
321
  ---
315
322
 
316
- ## Reference block 7
323
+ ## Reference block 4 — validate script
317
324
 
318
325
  ```bash
319
- # Validate YAML syntax
320
- for f in .github/workflows/*.yaml; do
326
+ for f in .github/workflows/*.yml .github/workflows/*.yaml; do
327
+ [ -f "$f" ] || continue
321
328
  python3 -c "import yaml; yaml.safe_load(open('$f'))" || echo "FAIL: $f has YAML syntax errors"
322
329
  done
323
330
 
324
- # Check permissions block presence
325
- for f in .github/workflows/*.yaml; do
331
+ for f in .github/workflows/test-build-release.yml; do
326
332
  if grep -q "permissions:" "$f"; then
327
333
  echo "OK: $f has permissions block"
328
334
  else
329
- echo "WARNING: $f missing permissions block — add one for security"
330
- fi
331
- done
332
-
333
- # Check for npm publish without NPM_TOKEN
334
- for f in .github/workflows/*.yaml; do
335
- if grep -q "npm publish\|npx semantic-release" "$f"; then
336
- if ! grep -q "NPM_TOKEN" "$f"; then
337
- echo "WARNING: $f has npm publish/semantic-release but no NPM_TOKEN secret"
338
- fi
335
+ echo "WARNING: $f missing permissions block"
339
336
  fi
340
337
  done
341
338
 
342
- # Check for hardcoded Node versions
343
- for f in .github/workflows/*.yaml; do
344
- if grep -q "node-version: [0-9]" "$f" && grep -qv "node-version-file\|\.nvmrc" "$f"; then
345
- echo "NOTE: $f has hardcoded Node version — consider using .nvmrc instead"
339
+ if grep -q 'workflows: \["Test Build Release"\]' .github/workflows/deploy.yml 2>/dev/null; then
340
+ if ! grep -q 'name: Test Build Release' .github/workflows/test-build-release.yml; then
341
+ echo "WARNING: deploy.yml listens for Test Build Release but TBR name may differ"
346
342
  fi
347
- done
348
-
349
- # Check for common secrets reference errors
350
- for f in .github/workflows/*.yaml; do
351
- # Secrets referencing something that doesn't exist in the workflow
352
- grep -oP 'secrets\.\w+' "$f" | sort -u | while read -r secret; do
353
- echo "REF: $f references $secret"
354
- done
355
- done
343
+ fi
356
344
  ```
357
345
 
358
346
  ---
359
347
 
360
- ## Reference block 8
348
+ ## Reference block 5 — dry-run
361
349
 
362
350
  ```bash
363
- # Option A: Use act (recommended)
364
351
  if command -v act &>/dev/null; then
365
- act push --dry-run
366
- echo "OK: act dry-run completed"
352
+ act push --dry-run -W .github/workflows/test-build-release.yml
367
353
  elif command -v gh &>/dev/null; then
368
- # Option B: Use gh workflow run (remote test, no local docker)
369
- gh workflow run ci.yaml --ref "$(git branch --show-current)"
370
- echo "OK: CI workflow dispatched. Check status: gh run list"
354
+ gh workflow run test-build-release.yml --ref "$(git branch --show-current)"
371
355
  else
372
- echo "NOTE: Install act (https://github.com/nektos/act) for full local dry-run"
373
- echo " Install gh CLI for remote dry-run"
356
+ echo "Install act or gh for dry-run"
374
357
  fi
375
358
  ```
@@ -95,6 +95,10 @@ bash scripts/lib/parallel-review-worktrees.sh audit-code
95
95
  - [ ] Dependency Inversion: dependencies injected, not imported globally where avoidable
96
96
  - [ ] **Chapter 17 Heuristics**: Code is free of smells documented in `audit-code/HEURISTICS.md` (G, N, C, T)
97
97
 
98
+ ### Refactoring Smells (Fowler)
99
+
100
+ Explicitly name any detected smells: Mysterious Name, Duplicated Code, Feature Envy, Data Clumps, Primitive Obsession, Message Chains, Middle Man.
101
+
98
102
  ### Code Style (CONVENTIONS.md)
99
103
 
100
104
  - [ ] Functions: 4–20 lines; split if longer
@@ -106,13 +110,6 @@ bash scripts/lib/parallel-review-worktrees.sh audit-code
106
110
  - [ ] Conditionals: expressed as positives (G29)
107
111
  - [ ] Comments explain WHY, not WHAT
108
112
 
109
- ### Agent Readability (Akita's Lens)
110
-
111
- - [ ] Functions are small enough to fit in a standard context window (4–20 lines)
112
- - [ ] Names are unique and specific enough to be `grep`-able (grep returns < 5 hits)
113
- - [ ] Types are explicit (no `any`, no inferred return types for public APIs)
114
- - [ ] Code avoids deep nesting (max 2 levels) and uses early returns
115
-
116
113
  ### Red Flags
117
114
 
118
115
  Before reporting, name any rationalization you caught yourself making for skipping a checklist item. Silence is not acceptable — if you skipped an item, state the reason explicitly.
@@ -18,6 +18,14 @@ Interview relentlessly about every aspect of this plan until reaching shared und
18
18
 
19
19
  If a question can be answered by exploring the codebase, explore it instead.
20
20
 
21
+ ### Facts vs. Decisions Boundary
22
+
23
+ Distinguish between **facts** and **decisions**:
24
+ - **Facts** — things discoverable by exploring the codebase, reading docs, or checking APIs. Do not ask the user to confirm facts; find them yourself.
25
+ - **Decisions** — choices that require user input (trade-offs, preferences, priorities). Always present options and ask the user to choose.
26
+
27
+ Never "grill yourself" — if the answer is in the code, go find it. Only ask questions where the user's judgment is needed.
28
+
21
29
  ## Docs mode
22
30
 
23
31
  Ground every challenge in real documentation — no assumption about a library's behavior goes unchecked. See [REFERENCE.md](REFERENCE.md) for the full process.
@@ -29,6 +37,10 @@ Short form:
29
37
  4. Report confirmed ✓, corrected ✗ (with the real behavior), and uncertain → `spike-prototype`.
30
38
  5. Update the plan for each confirmed discrepancy.
31
39
 
40
+ ## Confirmation Gate
41
+
42
+ > **HARD GATE** — Do NOT enact the plan or generate specifications until the user explicitly confirms shared understanding. Wait for explicit approval (e.g., "looks good", "confirmed", "proceed") before transitioning to any implementation, spec-writing, or task-slicing step.
43
+
32
44
  ---
33
45
 
34
46
  # Docs Mode — Full Process
@@ -23,6 +23,18 @@ description: "Doc-grounded variant of grill-me — stress-tests plan assumptions
23
23
  - If docs contradict the plan, plan loses until updated.
24
24
  - Prefer official docs over blog posts.
25
25
 
26
+ ## Facts vs. Decisions Boundary
27
+
28
+ Distinguish between **facts** and **decisions**:
29
+ - **Facts** — things discoverable by reading docs, checking APIs, or exploring the codebase. Do not ask the user to confirm facts; find them yourself.
30
+ - **Decisions** — choices that require user input (trade-offs, preferences, priorities). Always present options and ask the user to choose.
31
+
32
+ Never "grill yourself" — if the answer is in the docs, go fetch it. Only ask questions where the user's judgment is needed.
33
+
34
+ ## Confirmation Gate
35
+
36
+ > **HARD GATE** — Do NOT enact the plan or generate specifications until the user explicitly confirms shared understanding. Wait for explicit approval (e.g., "looks good", "confirmed", "proceed") before transitioning to any implementation, spec-writing, or task-slicing step.
37
+
26
38
  ## Verify
27
39
 
28
40
  → verify: `grep -c 'https\?://' skills/grill-with-docs/SKILL.md | awk '{if($1>=2) print "OK"; else print "NEEDS DOCS"}'`
@@ -86,6 +86,7 @@ Review for:
86
86
  4. Design — are there simpler or more robust approaches?
87
87
  5. Edge cases — what inputs or states could cause failures?
88
88
  6. Security — any injection, auth, or data exposure risks?
89
+ 7. Refactoring smells — explicitly name any detected Fowler smells: Mysterious Name, Duplicated Code, Feature Envy, Data Clumps, Primitive Obsession, Message Chains, Middle Man
89
90
 
90
91
  For each finding, categorize as: must-fix / should-fix / consider.
91
92
  Run the verify command and report the result.