bigpowers 2.1.3 → 2.3.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.pi/package.json +16 -0
- package/.pi/prompts/assess-impact.md +76 -0
- package/.pi/prompts/audit-code.md +156 -0
- package/.pi/prompts/build-epic.md +44 -0
- package/.pi/prompts/change-request.md +105 -0
- package/.pi/prompts/commit-message.md +135 -0
- package/.pi/prompts/compose-workflow.md +40 -0
- package/.pi/prompts/craft-skill.md +150 -0
- package/.pi/prompts/deepen-architecture.md +235 -0
- package/.pi/prompts/define-language.md +79 -0
- package/.pi/prompts/define-success.md +62 -0
- package/.pi/prompts/delegate-task.md +76 -0
- package/.pi/prompts/design-interface.md +96 -0
- package/.pi/prompts/develop-tdd.md +375 -0
- package/.pi/prompts/diagnose-root.md +23 -0
- package/.pi/prompts/dispatch-agents.md +83 -0
- package/.pi/prompts/edit-document.md +22 -0
- package/.pi/prompts/elaborate-spec.md +81 -0
- package/.pi/prompts/enforce-first.md +77 -0
- package/.pi/prompts/evolve-skill.md +38 -0
- package/.pi/prompts/execute-plan.md +54 -0
- package/.pi/prompts/fix-bug.md +36 -0
- package/.pi/prompts/grill-me.md +95 -0
- package/.pi/prompts/grill-with-docs.md +37 -0
- package/.pi/prompts/guard-git.md +212 -0
- package/.pi/prompts/hook-commits.md +93 -0
- package/.pi/prompts/inspect-quality.md +105 -0
- package/.pi/prompts/investigate-bug.md +117 -0
- package/.pi/prompts/kickoff-branch.md +99 -0
- package/.pi/prompts/map-codebase.md +70 -0
- package/.pi/prompts/migrate-spec.md +482 -0
- package/.pi/prompts/model-domain.md +227 -0
- package/.pi/prompts/orchestrate-project.md +161 -0
- package/.pi/prompts/organize-workspace.md +159 -0
- package/.pi/prompts/plan-refactor.md +77 -0
- package/.pi/prompts/plan-release.md +145 -0
- package/.pi/prompts/plan-work.md +161 -0
- package/.pi/prompts/release-branch.md +158 -0
- package/.pi/prompts/request-review.md +70 -0
- package/.pi/prompts/research-first.md +62 -0
- package/.pi/prompts/reset-baseline.md +20 -0
- package/.pi/prompts/respond-review.md +70 -0
- package/.pi/prompts/run-evals.md +56 -0
- package/.pi/prompts/run-planning.md +26 -0
- package/.pi/prompts/scope-work.md +23 -0
- package/.pi/prompts/search-skills.md +21 -0
- package/.pi/prompts/seed-conventions.md +132 -0
- package/.pi/prompts/session-state.md +146 -0
- package/.pi/prompts/setup-environment.md +23 -0
- package/.pi/prompts/simulate-agents.md +25 -0
- package/.pi/prompts/slice-tasks.md +23 -0
- package/.pi/prompts/spike-prototype.md +94 -0
- package/.pi/prompts/stocktake-skills.md +40 -0
- package/.pi/prompts/survey-context.md +129 -0
- package/.pi/prompts/terse-mode.md +37 -0
- package/.pi/prompts/trace-requirement.md +68 -0
- package/.pi/prompts/using-bigpowers.md +105 -0
- package/.pi/prompts/validate-fix.md +98 -0
- package/.pi/prompts/verify-work.md +125 -0
- package/.pi/prompts/visual-dashboard.md +51 -0
- package/.pi/prompts/wire-observability.md +92 -0
- package/.pi/prompts/write-document.md +244 -0
- package/.pi/skills/assess-impact/SKILL.md +77 -0
- package/.pi/skills/audit-code/SKILL.md +157 -0
- package/.pi/skills/build-epic/SKILL.md +45 -0
- package/.pi/skills/change-request/SKILL.md +106 -0
- package/.pi/skills/commit-message/SKILL.md +136 -0
- package/.pi/skills/compose-workflow/SKILL.md +41 -0
- package/.pi/skills/craft-skill/SKILL.md +151 -0
- package/.pi/skills/deepen-architecture/SKILL.md +236 -0
- package/.pi/skills/define-language/SKILL.md +80 -0
- package/.pi/skills/define-success/SKILL.md +63 -0
- package/.pi/skills/delegate-task/SKILL.md +77 -0
- package/.pi/skills/design-interface/SKILL.md +97 -0
- package/.pi/skills/develop-tdd/SKILL.md +376 -0
- package/.pi/skills/diagnose-root/SKILL.md +24 -0
- package/.pi/skills/dispatch-agents/SKILL.md +84 -0
- package/.pi/skills/edit-document/SKILL.md +23 -0
- package/.pi/skills/elaborate-spec/SKILL.md +82 -0
- package/.pi/skills/enforce-first/SKILL.md +78 -0
- package/.pi/skills/evolve-skill/SKILL.md +39 -0
- package/.pi/skills/execute-plan/SKILL.md +55 -0
- package/.pi/skills/fix-bug/SKILL.md +37 -0
- package/.pi/skills/grill-me/SKILL.md +96 -0
- package/.pi/skills/grill-with-docs/SKILL.md +38 -0
- package/.pi/skills/guard-git/SKILL.md +213 -0
- package/.pi/skills/hook-commits/SKILL.md +94 -0
- package/.pi/skills/inspect-quality/SKILL.md +106 -0
- package/.pi/skills/investigate-bug/SKILL.md +118 -0
- package/.pi/skills/kickoff-branch/SKILL.md +100 -0
- package/.pi/skills/map-codebase/SKILL.md +71 -0
- package/.pi/skills/migrate-spec/SKILL.md +483 -0
- package/.pi/skills/model-domain/SKILL.md +228 -0
- package/.pi/skills/orchestrate-project/SKILL.md +162 -0
- package/.pi/skills/organize-workspace/SKILL.md +160 -0
- package/.pi/skills/plan-refactor/SKILL.md +78 -0
- package/.pi/skills/plan-release/SKILL.md +146 -0
- package/.pi/skills/plan-work/SKILL.md +162 -0
- package/.pi/skills/release-branch/SKILL.md +159 -0
- package/.pi/skills/request-review/SKILL.md +71 -0
- package/.pi/skills/research-first/SKILL.md +63 -0
- package/.pi/skills/reset-baseline/SKILL.md +21 -0
- package/.pi/skills/respond-review/SKILL.md +71 -0
- package/.pi/skills/run-evals/SKILL.md +57 -0
- package/.pi/skills/run-planning/SKILL.md +27 -0
- package/.pi/skills/scope-work/SKILL.md +24 -0
- package/.pi/skills/search-skills/SKILL.md +22 -0
- package/.pi/skills/seed-conventions/SKILL.md +133 -0
- package/.pi/skills/session-state/SKILL.md +147 -0
- package/.pi/skills/setup-environment/SKILL.md +24 -0
- package/.pi/skills/simulate-agents/SKILL.md +26 -0
- package/.pi/skills/slice-tasks/SKILL.md +24 -0
- package/.pi/skills/spike-prototype/SKILL.md +95 -0
- package/.pi/skills/stocktake-skills/SKILL.md +41 -0
- package/.pi/skills/survey-context/SKILL.md +130 -0
- package/.pi/skills/terse-mode/SKILL.md +38 -0
- package/.pi/skills/trace-requirement/SKILL.md +69 -0
- package/.pi/skills/using-bigpowers/SKILL.md +106 -0
- package/.pi/skills/validate-fix/SKILL.md +99 -0
- package/.pi/skills/verify-work/SKILL.md +126 -0
- package/.pi/skills/visual-dashboard/SKILL.md +52 -0
- package/.pi/skills/wire-observability/SKILL.md +93 -0
- package/.pi/skills/write-document/SKILL.md +245 -0
- package/CHANGELOG.md +14 -0
- package/CLAUDE.md +1 -1
- package/CONVENTIONS.md +16 -10
- package/README.md +30 -4
- package/build-epic/SKILL.md +1 -1
- package/deepen-architecture/SKILL.md +2 -0
- package/define-language/SKILL.md +2 -0
- package/develop-tdd/REFERENCE.md +61 -0
- package/develop-tdd/SKILL.md +19 -119
- package/diagnose-root/SKILL.md +2 -0
- package/edit-document/SKILL.md +2 -0
- package/fix-bug/SKILL.md +3 -1
- package/grill-me/SKILL.md +3 -1
- package/grill-with-docs/SKILL.md +3 -1
- package/investigate-bug/SKILL.md +5 -11
- package/map-codebase/SKILL.md +3 -1
- package/migrate-spec/REFERENCE-GSD.md +4 -4
- package/migrate-spec/REFERENCE.md +33 -6
- package/migrate-spec/SKILL.md +1 -14
- package/model-domain/SKILL.md +2 -0
- package/orchestrate-project/REFERENCE.md +1 -1
- package/package.json +3 -2
- package/plan-release/SKILL.md +1 -1
- package/plan-work/REFERENCE.md +104 -0
- package/plan-work/SKILL.md +17 -151
- package/release-branch/REFERENCE.md +55 -0
- package/release-branch/SKILL.md +19 -117
- package/request-review/SKILL.md +1 -1
- package/run-planning/SKILL.md +3 -2
- package/scope-work/SKILL.md +3 -1
- package/scripts/audit-compliance.sh +15 -3
- package/scripts/check-skill-size.sh +79 -0
- package/scripts/generate-reference-tables.sh +64 -0
- package/scripts/project-survey.sh +2 -2
- package/scripts/sync-skills.sh +51 -3
- package/scripts/validate-doctrine.sh +143 -0
- package/seed-conventions/REFERENCE.md +63 -0
- package/seed-conventions/SKILL.md +23 -177
- package/slice-tasks/SKILL.md +3 -1
- package/survey-context/SKILL.md +3 -1
- package/write-document/SKILL.md +4 -2
|
@@ -0,0 +1,150 @@
|
|
|
1
|
+
---
|
|
2
|
+
description: Create new bigpowers skills with proper structure, progressive disclosure, and bundled resources. Use when user wants to create, write, or build a new skill for the bigpowers lifecycle.
|
|
3
|
+
---
|
|
4
|
+
|
|
5
|
+
|
|
6
|
+
# Craft Skill
|
|
7
|
+
|
|
8
|
+
> **HARD GATE** — Do NOT name a skill without a two-word verb-noun pair. Do NOT merge a new skill without running `sync-skills.sh` — the generated `.cursor/rules/` and `.gemini/` artifacts must match the source SKILL.md.
|
|
9
|
+
|
|
10
|
+
## Process
|
|
11
|
+
|
|
12
|
+
1. **Gather requirements** — ask user about:
|
|
13
|
+
- What task/domain does the skill cover?
|
|
14
|
+
- What specific use cases should it handle?
|
|
15
|
+
- Does it need executable scripts or just instructions?
|
|
16
|
+
- Any reference materials to include?
|
|
17
|
+
- What specs/ output does it produce (if any)?
|
|
18
|
+
|
|
19
|
+
2. **Verify Principles** — Ensure the skill aligns with [PRINCIPLES.md](../docs/PRINCIPLES.md):
|
|
20
|
+
- Is it atomic (verb-noun)?
|
|
21
|
+
- Is it "deep" (simple interface, complex internal logic)?
|
|
22
|
+
- Does it include Hard Gates?
|
|
23
|
+
- Is it verifiable with a `.feature` file?
|
|
24
|
+
|
|
25
|
+
3. **Draft the skill** — create:
|
|
26
|
+
- SKILL.md with concise instructions (see [REFERENCE.md](REFERENCE.md) for template)
|
|
27
|
+
- Additional reference files if content exceeds 100 lines
|
|
28
|
+
- Utility scripts if deterministic operations needed
|
|
29
|
+
|
|
30
|
+
**Auto-skill from library README:** When user provides a library README or API docs URL, extract: triggers, HARD GATEs, verify commands, specs/ output — draft SKILL.md without inventing APIs not in the source.
|
|
31
|
+
|
|
32
|
+
4. Add `model:` frontmatter (`haiku` | `sonnet` | `opus`) per [model-profiles.md](../docs/references/model-profiles.md).
|
|
33
|
+
|
|
34
|
+
> **STREAM CONTINUITY** — When writing file content, output in continuous chunks of ~200 lines. Do not pause. Continue immediately until complete. If you need time, emit a placeholder comment rather than going silent.
|
|
35
|
+
|
|
36
|
+
5. **Review with user** — present draft and ask:
|
|
37
|
+
- Does this cover your use cases?
|
|
38
|
+
- Anything missing or unclear?
|
|
39
|
+
- Should any section be more/less detailed?
|
|
40
|
+
|
|
41
|
+
## Naming Rules
|
|
42
|
+
|
|
43
|
+
Every skill name must be a **two-word verb-noun pair**. See [REFERENCE.md](REFERENCE.md) for full rules, examples, and documented exceptions.
|
|
44
|
+
|
|
45
|
+
## specs/ Output
|
|
46
|
+
|
|
47
|
+
If the skill produces written output, it goes in `specs/` at the project root. Document the output file path in the skill body and in CONVENTIONS.md's output files table.
|
|
48
|
+
|
|
49
|
+
## Review Checklist
|
|
50
|
+
|
|
51
|
+
After drafting, verify:
|
|
52
|
+
|
|
53
|
+
- [ ] Name is a two-word verb-noun pair (or follows grill-me exception)
|
|
54
|
+
- [ ] Description includes triggers ("Use when...")
|
|
55
|
+
- [ ] SKILL.md under 100 lines
|
|
56
|
+
- [ ] No time-sensitive info
|
|
57
|
+
- [ ] Consistent terminology with CONVENTIONS.md
|
|
58
|
+
- [ ] specs/ output documented if applicable
|
|
59
|
+
- [ ] `sync-skills.sh` run to propagate to Cursor/Gemini
|
|
60
|
+
|
|
61
|
+
---
|
|
62
|
+
|
|
63
|
+
# Craft Skill — Reference
|
|
64
|
+
|
|
65
|
+
## Naming Rules (full)
|
|
66
|
+
|
|
67
|
+
Every skill name must be a **two-word verb-noun pair**:
|
|
68
|
+
- First word: a verb (survey, model, define, develop, audit…)
|
|
69
|
+
- Second word: a noun from PMBOK 6 / Agile vocabulary (context, domain, language, tdd, code…)
|
|
70
|
+
- Pronounceable in any language, searchable, no noise words, no encodings
|
|
71
|
+
- Exception precedent: `grill-me` — kept for recognizability
|
|
72
|
+
|
|
73
|
+
Good: `survey-context`, `audit-code`, `validate-fix`
|
|
74
|
+
Bad: `context-surveyor`, `code-auditing-skill`, `fix-validator`
|
|
75
|
+
|
|
76
|
+
Any new naming exception requires an entry in CONVENTIONS.md before the skill is published.
|
|
77
|
+
|
|
78
|
+
## Skill Structure
|
|
79
|
+
|
|
80
|
+
```
|
|
81
|
+
skill-name/
|
|
82
|
+
├── SKILL.md # Main instructions (required)
|
|
83
|
+
├── REFERENCE.md # Detailed docs (if needed)
|
|
84
|
+
├── EXAMPLES.md # Usage examples (if needed)
|
|
85
|
+
└── scripts/ # Utility scripts (if needed)
|
|
86
|
+
└── helper.sh
|
|
87
|
+
```
|
|
88
|
+
|
|
89
|
+
## SKILL.md Template
|
|
90
|
+
|
|
91
|
+
```md
|
|
92
|
+
---
|
|
93
|
+
name: skill-name
|
|
94
|
+
description: Brief description of capability. Use when [specific triggers].
|
|
95
|
+
---
|
|
96
|
+
|
|
97
|
+
# Skill Name
|
|
98
|
+
|
|
99
|
+
## Quick start
|
|
100
|
+
|
|
101
|
+
[Minimal working example]
|
|
102
|
+
|
|
103
|
+
## Workflows
|
|
104
|
+
|
|
105
|
+
[Step-by-step processes with checklists for complex tasks]
|
|
106
|
+
|
|
107
|
+
## Advanced features
|
|
108
|
+
|
|
109
|
+
[Link to separate files: See [REFERENCE.md](REFERENCE.md)]
|
|
110
|
+
```
|
|
111
|
+
|
|
112
|
+
## Description Requirements
|
|
113
|
+
|
|
114
|
+
The description is **the only thing your agent sees** when deciding which skill to load.
|
|
115
|
+
|
|
116
|
+
**Format**:
|
|
117
|
+
- Max 1024 chars
|
|
118
|
+
- Write in third person
|
|
119
|
+
- First sentence: what it does
|
|
120
|
+
- Second sentence: "Use when [specific triggers]"
|
|
121
|
+
|
|
122
|
+
**Good example**:
|
|
123
|
+
```
|
|
124
|
+
Investigate a bug by exploring the codebase to find root cause, then write a TDD-based fix plan to specs/bugs/BUG-*.md. Use when user reports a bug, wants to investigate a problem, or mentions "triage".
|
|
125
|
+
```
|
|
126
|
+
|
|
127
|
+
## When to Add Scripts
|
|
128
|
+
|
|
129
|
+
Add utility scripts when:
|
|
130
|
+
- Operation is deterministic (validation, formatting)
|
|
131
|
+
- Same code would be generated repeatedly
|
|
132
|
+
- Errors need explicit handling
|
|
133
|
+
|
|
134
|
+
## When to Split Files
|
|
135
|
+
|
|
136
|
+
Split into separate files when:
|
|
137
|
+
- SKILL.md exceeds 100 lines
|
|
138
|
+
- Content has distinct domains
|
|
139
|
+
- Advanced features are rarely needed
|
|
140
|
+
|
|
141
|
+
## sync-skills.sh Propagation
|
|
142
|
+
|
|
143
|
+
After adding a new skill directory with SKILL.md, run `scripts/sync-skills.sh` from the bigpowers repo root. This automatically generates:
|
|
144
|
+
- `.cursor/rules/<name>.mdc` — for Cursor
|
|
145
|
+
- `.gemini/extensions/bigpowers/skills/<name>/SKILL.md` — Agent Skill
|
|
146
|
+
- `.gemini/extensions/bigpowers/commands/<name>.toml` — Slash Command
|
|
147
|
+
- `.gemini/extensions/bigpowers/commands/prompts/<name>.md` — Command Prompt
|
|
148
|
+
- Updated `gemini-extension.json`
|
|
149
|
+
|
|
150
|
+
verify: `bash scripts/sync-skills.sh 2>&1 | grep "skills synced"`
|
|
@@ -0,0 +1,235 @@
|
|
|
1
|
+
---
|
|
2
|
+
description: Find deepening opportunities in a codebase, informed by the domain language in specs/tech-architecture/tech-stack.md and the decisions in specs/adr/. Use when the user wants to improve architecture, find refactoring opportunities, consolidate tightly-coupled modules, or make a codebase more testable and AI-navigable.
|
|
3
|
+
---
|
|
4
|
+
|
|
5
|
+
|
|
6
|
+
# Deepen Architecture
|
|
7
|
+
|
|
8
|
+
Surface architectural friction and propose **deepening opportunities** — refactors that turn shallow modules into deep ones. The aim is testability and AI-navigability.
|
|
9
|
+
|
|
10
|
+
**Distinct from `define-language` and `model-domain`:** Use this skill to find module-level refactoring opportunities in the codebase. Use `define-language` to produce a canonical glossary of terms. Use `model-domain` to stress-test a plan through a domain-model interview.
|
|
11
|
+
|
|
12
|
+
> **HARD GATE** — Deep modules must solve a forcing function, not just be "nice abstractions." If you cannot articulate why the abstraction exists, it is premature.
|
|
13
|
+
|
|
14
|
+
## Glossary
|
|
15
|
+
|
|
16
|
+
Use these terms exactly in every suggestion. Consistent language is the point — don't drift into "component," "service," "API," or "boundary." Full definitions in [LANGUAGE.md](LANGUAGE.md).
|
|
17
|
+
|
|
18
|
+
- **Module** — anything with an interface and an implementation (function, class, package, slice).
|
|
19
|
+
- **Interface** — everything a caller must know to use the module: types, invariants, error modes, ordering, config. Not just the type signature.
|
|
20
|
+
- **Implementation** — the code inside.
|
|
21
|
+
- **Depth** — leverage at the interface: a lot of behaviour behind a small interface. **Deep** = high leverage. **Shallow** = interface nearly as complex as the implementation.
|
|
22
|
+
- **Seam** — where an interface lives; a place behaviour can be altered without editing in place. (Use this, not "boundary.")
|
|
23
|
+
- **Adapter** — a concrete thing satisfying an interface at a seam.
|
|
24
|
+
- **Leverage** — what callers get from depth.
|
|
25
|
+
- **Locality** — what maintainers get from depth: change, bugs, knowledge concentrated in one place.
|
|
26
|
+
|
|
27
|
+
Key principles (see [LANGUAGE.md](LANGUAGE.md) for the full list):
|
|
28
|
+
|
|
29
|
+
- **Deletion test**: imagine deleting the module. If complexity vanishes, it was a pass-through. If complexity reappears across N callers, it was earning its keep.
|
|
30
|
+
- **The interface is the test surface.**
|
|
31
|
+
- **One adapter = hypothetical seam. Two adapters = real seam.**
|
|
32
|
+
|
|
33
|
+
This skill is _informed_ by the project's domain model — `specs/tech-architecture/tech-stack.md` and any `specs/adr/`. The domain language gives names to good seams; ADRs record decisions the skill should not re-litigate. See [CONTEXT-FORMAT.md](../model-domain/CONTEXT-FORMAT.md) and [ADR-FORMAT.md](../model-domain/ADR-FORMAT.md).
|
|
34
|
+
|
|
35
|
+
## Process
|
|
36
|
+
|
|
37
|
+
### 1. Explore
|
|
38
|
+
|
|
39
|
+
Read existing documentation first:
|
|
40
|
+
|
|
41
|
+
- `specs/tech-architecture/tech-stack.md` (or `specs/tech-architecture/tech-stack.md` + each `specs/tech-architecture/tech-stack.md` in a multi-context repo)
|
|
42
|
+
- Relevant ADRs in `specs/adr/`
|
|
43
|
+
|
|
44
|
+
If any of these files don't exist, proceed silently — don't flag their absence or suggest creating them upfront.
|
|
45
|
+
|
|
46
|
+
Then use the Agent tool with `subagent_type=Explore` to walk the codebase. Don't follow rigid heuristics — explore organically and note where you experience friction:
|
|
47
|
+
|
|
48
|
+
- Where does understanding one concept require bouncing between many small modules?
|
|
49
|
+
- Where are modules **shallow** — interface nearly as complex as the implementation?
|
|
50
|
+
- Where have pure functions been extracted just for testability, but the real bugs hide in how they're called?
|
|
51
|
+
- Where do tightly-coupled modules leak across their seams?
|
|
52
|
+
- Which parts of the codebase are untested, or hard to test through their current interface?
|
|
53
|
+
|
|
54
|
+
Apply the **deletion test** to anything you suspect is shallow.
|
|
55
|
+
|
|
56
|
+
### 2. Module Depth score
|
|
57
|
+
|
|
58
|
+
For each candidate module, assign a **Module Depth score** (1–5, Ousterhout):
|
|
59
|
+
|
|
60
|
+
| Score | Meaning |
|
|
61
|
+
|-------|---------|
|
|
62
|
+
| 1 | Shallow — interface complexity ≈ implementation |
|
|
63
|
+
| 3 | Balanced |
|
|
64
|
+
| 5 | Deep — small interface, substantial hidden behavior |
|
|
65
|
+
|
|
66
|
+
Include the score in each candidate row. Prioritize score ≤ 2 for deepening.
|
|
67
|
+
|
|
68
|
+
### 3. Present candidates
|
|
69
|
+
|
|
70
|
+
Present a numbered list of deepening opportunities. For each candidate:
|
|
71
|
+
|
|
72
|
+
- **Files** — which files/modules are involved
|
|
73
|
+
- **Problem** — why the current architecture is causing friction
|
|
74
|
+
- **Solution** — plain English description of what would change
|
|
75
|
+
- **Benefits** — explained in terms of locality and leverage, and how tests would improve
|
|
76
|
+
|
|
77
|
+
**Use `specs/tech-architecture/tech-stack.md` vocabulary for the domain, and [LANGUAGE.md](LANGUAGE.md) vocabulary for the architecture.**
|
|
78
|
+
|
|
79
|
+
**ADR conflicts**: if a candidate contradicts an existing ADR, only surface it when the friction is real enough to warrant revisiting the ADR. Mark it clearly. Don't list every theoretical refactor an ADR forbids.
|
|
80
|
+
|
|
81
|
+
Do NOT propose interfaces yet. Ask the user: "Which of these would you like to explore?"
|
|
82
|
+
|
|
83
|
+
### 4. Grilling loop
|
|
84
|
+
|
|
85
|
+
Once the user picks a candidate, drop into a grilling conversation. Walk the design tree with them — constraints, dependencies, the shape of the deepened module, what sits behind the seam, what tests survive.
|
|
86
|
+
|
|
87
|
+
Side effects happen inline as decisions crystallize:
|
|
88
|
+
|
|
89
|
+
- **Naming a deepened module after a concept not in `specs/tech-architecture/tech-stack.md`?** Add the term to `specs/tech-architecture/tech-stack.md` — same discipline as `model-domain` (see [CONTEXT-FORMAT.md](../model-domain/CONTEXT-FORMAT.md)). Create the file lazily if it doesn't exist.
|
|
90
|
+
- **Sharpening a fuzzy term during the conversation?** Update `specs/tech-architecture/tech-stack.md` right there.
|
|
91
|
+
- **User rejects the candidate with a load-bearing reason?** Offer an ADR, framed as: _"Want me to record this as an ADR so future architecture reviews don't re-suggest it?"_ Only offer when the reason would actually be needed by a future explorer. See [ADR-FORMAT.md](../model-domain/ADR-FORMAT.md).
|
|
92
|
+
- **Want to explore alternative interfaces for the deepened module?** See [INTERFACE-DESIGN.md](INTERFACE-DESIGN.md).
|
|
93
|
+
|
|
94
|
+
---
|
|
95
|
+
|
|
96
|
+
# Deepening
|
|
97
|
+
|
|
98
|
+
How to deepen a cluster of shallow modules safely, given its dependencies. Assumes the vocabulary in [LANGUAGE.md](LANGUAGE.md) — **module**, **interface**, **seam**, **adapter**.
|
|
99
|
+
|
|
100
|
+
## Dependency categories
|
|
101
|
+
|
|
102
|
+
When assessing a candidate for deepening, classify its dependencies. The category determines how the deepened module is tested across its seam.
|
|
103
|
+
|
|
104
|
+
### 1. In-process
|
|
105
|
+
|
|
106
|
+
Pure computation, in-memory state, no I/O. Always deepenable — merge the modules and test through the new interface directly. No adapter needed.
|
|
107
|
+
|
|
108
|
+
### 2. Local-substitutable
|
|
109
|
+
|
|
110
|
+
Dependencies that have local test stand-ins (PGLite for Postgres, in-memory filesystem). Deepenable if the stand-in exists. The deepened module is tested with the stand-in running in the test suite. The seam is internal; no port at the module's external interface.
|
|
111
|
+
|
|
112
|
+
### 3. Remote but owned (Ports & Adapters)
|
|
113
|
+
|
|
114
|
+
Your own services across a network boundary (microservices, internal APIs). Define a **port** (interface) at the seam. The deep module owns the logic; the transport is injected as an **adapter**. Tests use an in-memory adapter. Production uses an HTTP/gRPC/queue adapter.
|
|
115
|
+
|
|
116
|
+
Recommendation shape: *"Define a port at the seam, implement an HTTP adapter for production and an in-memory adapter for testing, so the logic sits in one deep module even though it's deployed across a network."*
|
|
117
|
+
|
|
118
|
+
### 4. True external (Mock)
|
|
119
|
+
|
|
120
|
+
Third-party services (Stripe, Twilio, etc.) you don't control. The deepened module takes the external dependency as an injected port; tests provide a mock adapter.
|
|
121
|
+
|
|
122
|
+
## Seam discipline
|
|
123
|
+
|
|
124
|
+
- **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a port unless at least two adapters are justified (typically production + test). A single-adapter seam is just indirection.
|
|
125
|
+
- **Internal seams vs external seams.** A deep module can have internal seams (private to its implementation, used by its own tests) as well as the external seam at its interface. Don't expose internal seams through the interface just because tests use them.
|
|
126
|
+
|
|
127
|
+
## Testing strategy: replace, don't layer
|
|
128
|
+
|
|
129
|
+
- Old unit tests on shallow modules become waste once tests at the deepened module's interface exist — delete them.
|
|
130
|
+
- Write new tests at the deepened module's interface. The **interface is the test surface**.
|
|
131
|
+
- Tests assert on observable outcomes through the interface, not internal state.
|
|
132
|
+
- Tests should survive internal refactors — they describe behaviour, not implementation. If a test has to change when the implementation changes, it's testing past the interface.
|
|
133
|
+
|
|
134
|
+
---
|
|
135
|
+
|
|
136
|
+
# Interface Design
|
|
137
|
+
|
|
138
|
+
When the user wants to explore alternative interfaces for a chosen deepening candidate, use this parallel sub-agent pattern. Based on "Design It Twice" (Ousterhout) — your first idea is unlikely to be the best.
|
|
139
|
+
|
|
140
|
+
Uses the vocabulary in [LANGUAGE.md](LANGUAGE.md) — **module**, **interface**, **seam**, **adapter**, **leverage**.
|
|
141
|
+
|
|
142
|
+
## Process
|
|
143
|
+
|
|
144
|
+
### 1. Frame the problem space
|
|
145
|
+
|
|
146
|
+
Before spawning sub-agents, write a user-facing explanation of the problem space for the chosen candidate:
|
|
147
|
+
|
|
148
|
+
- The constraints any new interface would need to satisfy
|
|
149
|
+
- The dependencies it would rely on, and which category they fall into (see [DEEPENING.md](DEEPENING.md))
|
|
150
|
+
- A rough illustrative code sketch to ground the constraints — not a proposal, just a way to make the constraints concrete
|
|
151
|
+
|
|
152
|
+
Show this to the user, then immediately proceed to Step 2. The user reads and thinks while the sub-agents work in parallel.
|
|
153
|
+
|
|
154
|
+
### 2. Spawn sub-agents
|
|
155
|
+
|
|
156
|
+
Spawn 3+ sub-agents in parallel using the Agent tool. Each must produce a **radically different** interface for the deepened module.
|
|
157
|
+
|
|
158
|
+
Prompt each sub-agent with a separate technical brief (file paths, coupling details, dependency category from [DEEPENING.md](DEEPENING.md), what sits behind the seam). The brief is independent of the user-facing problem-space explanation in Step 1. Give each agent a different design constraint:
|
|
159
|
+
|
|
160
|
+
- Agent 1: "Minimize the interface — aim for 1–3 entry points max. Maximise leverage per entry point."
|
|
161
|
+
- Agent 2: "Maximise flexibility — support many use cases and extension."
|
|
162
|
+
- Agent 3: "Optimise for the most common caller — make the default case trivial."
|
|
163
|
+
- Agent 4 (if applicable): "Design around ports & adapters for cross-seam dependencies."
|
|
164
|
+
|
|
165
|
+
Include both [LANGUAGE.md](LANGUAGE.md) vocabulary and CONTEXT.md vocabulary in the brief so each sub-agent names things consistently with the architecture language and the project's domain language.
|
|
166
|
+
|
|
167
|
+
Each sub-agent outputs:
|
|
168
|
+
|
|
169
|
+
1. Interface (types, methods, params — plus invariants, ordering, error modes)
|
|
170
|
+
2. Usage example showing how callers use it
|
|
171
|
+
3. What the implementation hides behind the seam
|
|
172
|
+
4. Dependency strategy and adapters (see [DEEPENING.md](DEEPENING.md))
|
|
173
|
+
5. Trade-offs — where leverage is high, where it's thin
|
|
174
|
+
|
|
175
|
+
### 3. Present and compare
|
|
176
|
+
|
|
177
|
+
Present designs sequentially so the user can absorb each one, then compare them in prose. Contrast by **depth** (leverage at the interface), **locality** (where change concentrates), and **seam placement**.
|
|
178
|
+
|
|
179
|
+
After comparing, give your own recommendation: which design you think is strongest and why. If elements from different designs would combine well, propose a hybrid. Be opinionated — the user wants a strong read, not a menu.
|
|
180
|
+
|
|
181
|
+
---
|
|
182
|
+
|
|
183
|
+
# Language
|
|
184
|
+
|
|
185
|
+
Shared vocabulary for every suggestion this skill makes. Use these terms exactly — don't substitute "component," "service," "API," or "boundary." Consistent language is the whole point.
|
|
186
|
+
|
|
187
|
+
## Terms
|
|
188
|
+
|
|
189
|
+
**Module**
|
|
190
|
+
Anything with an interface and an implementation. Deliberately scale-agnostic — applies equally to a function, class, package, or tier-spanning slice.
|
|
191
|
+
_Avoid_: unit, component, service.
|
|
192
|
+
|
|
193
|
+
**Interface**
|
|
194
|
+
Everything a caller must know to use the module correctly. Includes the type signature, but also invariants, ordering constraints, error modes, required configuration, and performance characteristics.
|
|
195
|
+
_Avoid_: API, signature (too narrow — those refer only to the type-level surface).
|
|
196
|
+
|
|
197
|
+
**Implementation**
|
|
198
|
+
What's inside a module — its body of code. Distinct from **Adapter**: a thing can be a small adapter with a large implementation (a Postgres repo) or a large adapter with a small implementation (an in-memory fake). Reach for "adapter" when the seam is the topic; "implementation" otherwise.
|
|
199
|
+
|
|
200
|
+
**Depth**
|
|
201
|
+
Leverage at the interface — the amount of behaviour a caller (or test) can exercise per unit of interface they have to learn. A module is **deep** when a large amount of behaviour sits behind a small interface. A module is **shallow** when the interface is nearly as complex as the implementation.
|
|
202
|
+
|
|
203
|
+
**Seam** _(from Michael Feathers)_
|
|
204
|
+
A place where you can alter behaviour without editing in that place. The *location* at which a module's interface lives. Choosing where to put the seam is its own design decision, distinct from what goes behind it.
|
|
205
|
+
_Avoid_: boundary (overloaded with DDD's bounded context).
|
|
206
|
+
|
|
207
|
+
**Adapter**
|
|
208
|
+
A concrete thing that satisfies an interface at a seam. Describes *role* (what slot it fills), not substance (what's inside).
|
|
209
|
+
|
|
210
|
+
**Leverage**
|
|
211
|
+
What callers get from depth. More capability per unit of interface they have to learn. One implementation pays back across N call sites and M tests.
|
|
212
|
+
|
|
213
|
+
**Locality**
|
|
214
|
+
What maintainers get from depth. Change, bugs, knowledge, and verification concentrate at one place rather than spreading across callers. Fix once, fixed everywhere.
|
|
215
|
+
|
|
216
|
+
## Principles
|
|
217
|
+
|
|
218
|
+
- **Depth is a property of the interface, not the implementation.** A deep module can be internally composed of small, mockable, swappable parts — they just aren't part of the interface. A module can have **internal seams** (private to its implementation, used by its own tests) as well as the **external seam** at its interface.
|
|
219
|
+
- **The deletion test.** Imagine deleting the module. If complexity vanishes, the module wasn't hiding anything (it was a pass-through). If complexity reappears across N callers, the module was earning its keep.
|
|
220
|
+
- **The interface is the test surface.** Callers and tests cross the same seam. If you want to test *past* the interface, the module is probably the wrong shape.
|
|
221
|
+
- **One adapter means a hypothetical seam. Two adapters means a real one.** Don't introduce a seam unless something actually varies across it.
|
|
222
|
+
|
|
223
|
+
## Relationships
|
|
224
|
+
|
|
225
|
+
- A **Module** has exactly one **Interface** (the surface it presents to callers and tests).
|
|
226
|
+
- **Depth** is a property of a **Module**, measured against its **Interface**.
|
|
227
|
+
- A **Seam** is where a **Module**'s **Interface** lives.
|
|
228
|
+
- An **Adapter** sits at a **Seam** and satisfies the **Interface**.
|
|
229
|
+
- **Depth** produces **Leverage** for callers and **Locality** for maintainers.
|
|
230
|
+
|
|
231
|
+
## Rejected framings
|
|
232
|
+
|
|
233
|
+
- **Depth as ratio of implementation-lines to interface-lines** (Ousterhout): rewards padding the implementation. We use depth-as-leverage instead.
|
|
234
|
+
- **"Interface" as the TypeScript `interface` keyword or a class's public methods**: too narrow — interface here includes every fact a caller must know.
|
|
235
|
+
- **"Boundary"**: overloaded with DDD's bounded context. Say **seam** or **interface**.
|
|
@@ -0,0 +1,79 @@
|
|
|
1
|
+
---
|
|
2
|
+
description: Extract a DDD-style ubiquitous language glossary from the current conversation, flagging ambiguities and proposing canonical terms. Saves to specs/UBIQUITOUS_LANGUAGE.md. Use when user wants to define domain terms, build a glossary, harden terminology, create a ubiquitous language, or mentions "domain model" or "DDD".
|
|
3
|
+
---
|
|
4
|
+
|
|
5
|
+
|
|
6
|
+
# Define Language
|
|
7
|
+
|
|
8
|
+
Extract and formalize domain terminology from the current conversation into a consistent glossary, saved to `specs/UBIQUITOUS_LANGUAGE.md`.
|
|
9
|
+
|
|
10
|
+
**Distinct from `model-domain` and `deepen-architecture`:** Use this skill to produce a canonical glossary of terms (words and definitions). Use `model-domain` to stress-test a plan through an interview that resolves domain model decisions. Use `deepen-architecture` to find module-level refactoring opportunities in the codebase.
|
|
11
|
+
|
|
12
|
+
> **HARD GATE** — Ubiquitous language is NOT optional. Every term in the domain that could be misunderstood must be glossed. Ambiguity = rework.
|
|
13
|
+
|
|
14
|
+
## Process
|
|
15
|
+
|
|
16
|
+
1. **Scan the conversation** for domain-relevant nouns, verbs, and concepts
|
|
17
|
+
2. **Identify problems**:
|
|
18
|
+
- Same word used for different concepts (ambiguity)
|
|
19
|
+
- Different words used for the same concept (synonyms)
|
|
20
|
+
- Vague or overloaded terms
|
|
21
|
+
3. **Propose a canonical glossary** with opinionated term choices
|
|
22
|
+
4. **Write to `specs/UBIQUITOUS_LANGUAGE.md`** in the working directory using the format below
|
|
23
|
+
5. **Output a summary** inline in the conversation
|
|
24
|
+
|
|
25
|
+
## Output Format
|
|
26
|
+
|
|
27
|
+
Write a `specs/UBIQUITOUS_LANGUAGE.md` file with this structure:
|
|
28
|
+
|
|
29
|
+
```md
|
|
30
|
+
# Ubiquitous Language
|
|
31
|
+
|
|
32
|
+
## Order lifecycle
|
|
33
|
+
|
|
34
|
+
| Term | Definition | Aliases to avoid |
|
|
35
|
+
| ----------- | ------------------------------------------------------- | --------------------- |
|
|
36
|
+
| **Order** | A customer's request to purchase one or more items | Purchase, transaction |
|
|
37
|
+
| **Invoice** | A request for payment sent to a customer after delivery | Bill, payment request |
|
|
38
|
+
|
|
39
|
+
## People
|
|
40
|
+
|
|
41
|
+
| Term | Definition | Aliases to avoid |
|
|
42
|
+
| ------------ | ------------------------------------------- | ---------------------- |
|
|
43
|
+
| **Customer** | A person or organization that places orders | Client, buyer, account |
|
|
44
|
+
| **User** | An authentication identity in the system | Login, account |
|
|
45
|
+
|
|
46
|
+
## Relationships
|
|
47
|
+
|
|
48
|
+
- An **Invoice** belongs to exactly one **Customer**
|
|
49
|
+
- An **Order** produces one or more **Invoices**
|
|
50
|
+
|
|
51
|
+
## Example dialogue
|
|
52
|
+
|
|
53
|
+
> **Dev:** "When a **Customer** places an **Order**, do we create the **Invoice** immediately?"
|
|
54
|
+
> **Domain expert:** "No — an **Invoice** is only generated once a **Fulfillment** is confirmed."
|
|
55
|
+
|
|
56
|
+
## Flagged ambiguities
|
|
57
|
+
|
|
58
|
+
- "account" was used to mean both **Customer** and **User** — these are distinct concepts.
|
|
59
|
+
```
|
|
60
|
+
|
|
61
|
+
## Rules
|
|
62
|
+
|
|
63
|
+
- **Be opinionated.** When multiple words exist for the same concept, pick the best one and list the others as aliases to avoid.
|
|
64
|
+
- **Flag conflicts explicitly.** If a term is used ambiguously, call it out in "Flagged ambiguities" with a clear recommendation.
|
|
65
|
+
- **Only include terms relevant for domain experts.** Skip names of modules or classes unless they have domain meaning.
|
|
66
|
+
- **Keep definitions tight.** One sentence max. Define what it IS, not what it does.
|
|
67
|
+
- **Show relationships.** Use bold term names and express cardinality where obvious.
|
|
68
|
+
- **Group terms into multiple tables** when natural clusters emerge. One table is fine if terms are cohesive.
|
|
69
|
+
- **Write an example dialogue.** 3–5 exchanges between a dev and domain expert showing terms used precisely.
|
|
70
|
+
|
|
71
|
+
## Re-running
|
|
72
|
+
|
|
73
|
+
When invoked again in the same conversation:
|
|
74
|
+
|
|
75
|
+
1. Read the existing `specs/UBIQUITOUS_LANGUAGE.md`
|
|
76
|
+
2. Incorporate any new terms from subsequent discussion
|
|
77
|
+
3. Update definitions if understanding has evolved
|
|
78
|
+
4. Re-flag any new ambiguities
|
|
79
|
+
5. Rewrite the example dialogue to incorporate new terms
|
|
@@ -0,0 +1,62 @@
|
|
|
1
|
+
---
|
|
2
|
+
description: Convert an imperative task statement into explicit "step → verify: <cmd>" pairs before implementation begins. Use before plan-work when success criteria are unclear, when a task lacks verifiable checkpoints, or when user says "how will we know this is done?".
|
|
3
|
+
---
|
|
4
|
+
|
|
5
|
+
|
|
6
|
+
# Define Success
|
|
7
|
+
|
|
8
|
+
Transform "do X" into "step → verify: <cmd>" pairs. This is the pre-flight check before `plan-work` or `develop-tdd` — it makes success observable and removes ambiguity about when you're done.
|
|
9
|
+
|
|
10
|
+
> **HARD GATE** — Success criteria must be testable and user-observable. "Code should be fast" is not testable. "Pageload latency < 2s" is testable.
|
|
11
|
+
|
|
12
|
+
## Why this matters
|
|
13
|
+
|
|
14
|
+
"Implement user authentication" is not a plan. It has no checkpoints, no evidence requirement, and no way to know if you're done. The Karpathy principle: every step must be independently verifiable with a runnable command. If you can't verify it, you can't prove it works.
|
|
15
|
+
|
|
16
|
+
## Process
|
|
17
|
+
|
|
18
|
+
### 1. Read the task statement
|
|
19
|
+
|
|
20
|
+
Take the task as stated (from conversation, or from `specs/epics/ (see slice-tasks)`, or from `specs/product/SCOPE_LATEST.yaml`).
|
|
21
|
+
|
|
22
|
+
### 2. Break into observable outcomes
|
|
23
|
+
|
|
24
|
+
For each thing the task requires, identify:
|
|
25
|
+
- The smallest unit of observable behavior that proves something works
|
|
26
|
+
- The command that proves it
|
|
27
|
+
|
|
28
|
+
Work at the level of behaviors (what the system does) not implementation steps (how you'll write the code).
|
|
29
|
+
|
|
30
|
+
### 3. Write the pairs
|
|
31
|
+
|
|
32
|
+
Format each pair as:
|
|
33
|
+
```
|
|
34
|
+
N. [What must be true] → verify: <runnable command>
|
|
35
|
+
```
|
|
36
|
+
|
|
37
|
+
Examples:
|
|
38
|
+
|
|
39
|
+
```
|
|
40
|
+
Task: "Add user registration to the API"
|
|
41
|
+
|
|
42
|
+
1. POST /users accepts {email, name} and returns {id, email, name} → verify: curl -s -X POST http://localhost:3000/users -H 'Content-Type: application/json' -d '{"email":"test@test.com","name":"Test"}' | jq .id
|
|
43
|
+
2. Duplicate email is rejected with 409 → verify: npm test -- user-registration.test.ts
|
|
44
|
+
3. Missing email is rejected with 400 and descriptive error → verify: npm test -- user-validation.test.ts
|
|
45
|
+
4. Password is hashed (never stored in plaintext) → verify: npm test -- user-security.test.ts
|
|
46
|
+
5. All existing tests still pass → verify: npm test
|
|
47
|
+
```
|
|
48
|
+
|
|
49
|
+
### 4. Challenge completeness
|
|
50
|
+
|
|
51
|
+
Ask yourself:
|
|
52
|
+
- Is there any behavior the task requires that isn't covered by a verify step?
|
|
53
|
+
- Is every verify step runnable right now without additional setup?
|
|
54
|
+
- Does the final step verify the whole thing end-to-end?
|
|
55
|
+
|
|
56
|
+
Add any missing pairs.
|
|
57
|
+
|
|
58
|
+
### 5. Output
|
|
59
|
+
|
|
60
|
+
Present the pairs to the user and ask: "Does this capture everything the task requires? Anything missing?"
|
|
61
|
+
|
|
62
|
+
Once confirmed, these pairs become the skeleton for `plan-work`'s steps. Pass them along when calling `plan-work`.
|
|
@@ -0,0 +1,76 @@
|
|
|
1
|
+
---
|
|
2
|
+
description: Delegate one complex task to a single subagent, review its work in two stages before merging back. Sequential — one agent at a time, with oversight. Use when a task is complex and requires careful review before the result is accepted. Distinct from dispatch-agents (no parallelism here; reviewer sees full diff before proceeding).
|
|
3
|
+
---
|
|
4
|
+
|
|
5
|
+
|
|
6
|
+
# Delegate Task
|
|
7
|
+
> **HARD GATE** — **HARD GATE** — Delegated work must have clear success criteria and verification commands. The delegate must be able to verify completion independently.
|
|
8
|
+
|
|
9
|
+
|
|
10
|
+
Delegate a single complex task to a subagent with a two-stage review gate before accepting the result. Use when oversight of a single task matters more than speed.
|
|
11
|
+
|
|
12
|
+
**Distinct from `dispatch-agents`:** This skill runs one subagent sequentially with a mandatory review. `dispatch-agents` runs multiple subagents in parallel without inter-task review gates.
|
|
13
|
+
|
|
14
|
+
## Process
|
|
15
|
+
|
|
16
|
+
### 1. Define the task
|
|
17
|
+
|
|
18
|
+
Before spawning the agent, read `specs/state.yaml` if it exists. Then write a minimal self-contained brief using this template (brief size directly controls token cost and hallucination risk — do not pad):
|
|
19
|
+
|
|
20
|
+
```
|
|
21
|
+
Goal: [one sentence — specific, measurable outcome]
|
|
22
|
+
In scope: [explicit file or module list]
|
|
23
|
+
Out of bounds: [what NOT to do]
|
|
24
|
+
Constraints: [relevant CONVENTIONS.md rules, existing patterns, test requirements]
|
|
25
|
+
Verify: [runnable command]
|
|
26
|
+
Prior decisions: [relevant entries from specs/state.yaml — omit section if none apply]
|
|
27
|
+
```
|
|
28
|
+
|
|
29
|
+
Do not include full file contents, full conversation history, or decisions unrelated to this task.
|
|
30
|
+
|
|
31
|
+
### 2. Spawn the subagent (iterative retrieval, max 3 cycles)
|
|
32
|
+
|
|
33
|
+
Use the Agent tool with a **fresh context** per spawn. Pass prior decisions only via `specs/state.yaml`.
|
|
34
|
+
|
|
35
|
+
**Cycle:** dispatch → evaluate output vs goal → refine brief → re-spawn if needed (max 3 cycles).
|
|
36
|
+
|
|
37
|
+
Include in each brief:
|
|
38
|
+
- All context the agent needs (it starts cold — no shared state)
|
|
39
|
+
- Reference to CONVENTIONS.md constraints
|
|
40
|
+
- The verify command it must run before reporting done
|
|
41
|
+
|
|
42
|
+
### 3. Stage 1 review — output inspection
|
|
43
|
+
|
|
44
|
+
When the subagent returns, review its report before looking at the diff:
|
|
45
|
+
- Did it run the verify command? Did it pass?
|
|
46
|
+
- Does it explain what it changed and why?
|
|
47
|
+
- Are there any concerns raised by the agent?
|
|
48
|
+
|
|
49
|
+
If the report raises red flags, ask the subagent for clarification or re-run with adjusted instructions.
|
|
50
|
+
|
|
51
|
+
### 4. Stage 2 review — diff inspection
|
|
52
|
+
|
|
53
|
+
Inspect the actual diff:
|
|
54
|
+
```bash
|
|
55
|
+
git diff main...HEAD
|
|
56
|
+
```
|
|
57
|
+
|
|
58
|
+
Check:
|
|
59
|
+
- [ ] Changes are scoped to what was asked — nothing extra
|
|
60
|
+
- [ ] No `any`, no `@ts-ignore`, no disabled lint rules
|
|
61
|
+
- [ ] Tests added for new behavior
|
|
62
|
+
- [ ] CONVENTIONS.md compliance (naming, structure, no gh issue creation)
|
|
63
|
+
- [ ] Boy Scout Rule: touched areas are cleaner than before
|
|
64
|
+
|
|
65
|
+
### 5. Decision
|
|
66
|
+
|
|
67
|
+
- **Accept**: merge the result into the main working branch
|
|
68
|
+
- **Revise**: send back to the subagent with specific feedback
|
|
69
|
+
- **Reject**: discard and re-approach differently
|
|
70
|
+
|
|
71
|
+
**After accepting**, append to `specs/state.yaml` under `## Active Decisions`:
|
|
72
|
+
```
|
|
73
|
+
**[task short name]**: [what approach the agent chose and why — one sentence]
|
|
74
|
+
```
|
|
75
|
+
|
|
76
|
+
Report the decision and rationale to the user.
|