bgrun 3.12.0 → 3.12.2

package/src/index.ts

@@ -12,7 +12,7 @@ import type { CommandOptions } from "./types";
 import { error, announce } from "./logger";
 // startServer is dynamically imported only when --_serve is used
 // to avoid loading melina (which has side-effects) on every bgrun command
-import { getHomeDir, getShellCommand, findChildPid, isProcessRunning, terminateProcess, getProcessPorts, killProcessOnPort, waitForPortFree, isPortFree } from "./platform";
+import { getHomeDir, getShellCommand, findChildPid, isProcessRunning, terminateProcess, getProcessPorts, killProcessOnPort, waitForPortFree, isPortFree, findPidByPort } from "./platform";
 import { insertProcess, removeProcessByName, getProcess, retryDatabaseOperation, getDbInfo } from "./db";
 import dedent from "dedent";
 import chalk from "chalk";
@@ -26,6 +26,48 @@ if (!Bun.argv.includes("--_serve")) {
   }
 }
 
+/**
+ * Redirect console.log/warn/error to log files when running detached.
+ * The parent spawner passes file paths via BGR_STDOUT/BGR_STDERR env vars.
+ * Appends timestamped lines so `bgrun <name> --logs` shows real output.
+ */
+function redirectConsoleToFiles() {
+  const stdoutPath = Bun.env.BGR_STDOUT;
+  const stderrPath = Bun.env.BGR_STDERR;
+  if (!stdoutPath && !stderrPath) return; // Not detached, keep normal console
+
+  const { appendFileSync } = require('fs');
+
+  // Strip ANSI escape codes for clean log files
+  const stripAnsi = (s: string) => s.replace(/\x1b\[[0-9;]*m/g, '');
+
+  const timestamp = () => new Date().toISOString().replace('T', ' ').substring(0, 19);
+
+  if (stdoutPath) {
+    const origLog = console.log;
+    const origWarn = console.warn;
+    console.log = (...args: any[]) => {
+      const line = `[${timestamp()}] ${stripAnsi(args.map(String).join(' '))}\n`;
+      try { appendFileSync(stdoutPath, line); } catch { }
+      origLog.apply(console, args); // Also keep original (goes to /dev/null when detached, but useful if attached)
+    };
+    console.warn = (...args: any[]) => {
+      const line = `[${timestamp()}] WARN: ${stripAnsi(args.map(String).join(' '))}\n`;
+      try { appendFileSync(stdoutPath, line); } catch { }
+      origWarn.apply(console, args);
+    };
+  }
+
+  if (stderrPath) {
+    const origError = console.error;
+    console.error = (...args: any[]) => {
+      const line = `[${timestamp()}] ERROR: ${stripAnsi(args.map(String).join(' '))}\n`;
+      try { appendFileSync(stderrPath, line); } catch { }
+      origError.apply(console, args);
+    };
+  }
+}
+
 async function showHelp() {
   const usage = dedent`
     ${chalk.bold('bgrun — Bun Background Runner')}
@@ -120,6 +162,9 @@ async function run() {
   // Port is NOT passed explicitly — Melina auto-detects from BUN_PORT env
   // or defaults to 3000 with fallback to next available port.
   if (values['_serve']) {
+    // Redirect console output to log files when running detached
+    // The spawner passes paths via BGR_STDOUT/BGR_STDERR env vars
+    redirectConsoleToFiles();
     const { startServer } = await import("./server");
     await startServer();
     return;
@@ -127,6 +172,8 @@ async function run() {
 
   // Internal: actually run the guard loop (spawned by --guard)
   if (values['_guard-loop']) {
+    // Redirect console output to log files when running detached
+    redirectConsoleToFiles();
     const { startGuardLoop } = await import("./guard");
     const intervalStr = positionals[0];
     const intervalMs = intervalStr ? parseInt(intervalStr) * 1000 : undefined;
@@ -193,10 +240,13 @@ async function run() {
     await Bun.write(stderrPath, '');
 
     // Pass BUN_PORT env var only if user explicitly requested a port
-    const spawnEnv = { ...Bun.env };
+    const spawnEnv: Record<string, string> = { ...Bun.env } as any;
     if (requestedPort) {
       spawnEnv.BUN_PORT = requestedPort;
     }
+    // Pass log paths so the detached process can redirect its own console output
+    spawnEnv.BGR_STDOUT = stdoutPath;
+    spawnEnv.BGR_STDERR = stderrPath;
 
     // Resolve the target port: --port flag > BUN_PORT env > default 3000
     const targetPort = parseInt(requestedPort || Bun.env.BUN_PORT || '3000');
@@ -216,16 +266,18 @@ async function run() {
     const newProcess = Bun.spawn(getShellCommand(spawnCommand), {
       env: spawnEnv,
       cwd: bgrDir,
-      stdout: Bun.file(stdoutPath),
-      stderr: Bun.file(stderrPath),
-    });
+      stdout: "ignore",
+      stderr: "ignore",
+      detached: true, // Windows: new process group outside parent's Job Object — survives terminal close
+    } as any);
 
     newProcess.unref();
 
-    // Resolve the actual child PID by traversing the process tree
-    // (cmd.exe → bun.exe), then detect which port it bound
+    // With detached: cmd.exe wrapper exits immediately, so findChildPid won't work.
+    // Instead, wait for the server to bind a port and find the PID from there.
     await sleep(2000); // Give the server time to start and bind a port
-    const actualPid = await findChildPid(newProcess.pid);
+    const resolvedPort = parseInt(requestedPort || Bun.env.BUN_PORT || '3000');
+    const actualPid = await findPidByPort(resolvedPort, 10000) ?? await findChildPid(newProcess.pid);
 
     // Detect the port the server actually bound to
     let actualPort: number | null = null;
@@ -310,15 +362,27 @@ async function run() {
     await Bun.write(stderrPath, '');
 
     const newProcess = Bun.spawn(getShellCommand(spawnCommand), {
-      env: { ...Bun.env },
+      env: { ...Bun.env, BGR_STDOUT: stdoutPath, BGR_STDERR: stderrPath },
       cwd: bgrDir,
-      stdout: Bun.file(stdoutPath),
-      stderr: Bun.file(stderrPath),
-    });
+      stdout: "ignore",
+      stderr: "ignore",
+      detached: true, // Windows: new process group outside parent's Job Object — survives terminal close
+    } as any);
 
     newProcess.unref();
     await sleep(1000);
-    const actualPid = await findChildPid(newProcess.pid);
+    // With detached: cmd.exe exits immediately. Search for the guard by command line.
+    let actualPid = await findChildPid(newProcess.pid);
+    if (!(await isProcessRunning(actualPid))) {
+      // cmd.exe already died — search for the bun process running --_guard-loop
+      const { psExec: ps } = await import('./platform');
+      const result = ps(
+        `Get-CimInstance Win32_Process -Filter "Name='bun.exe'" | Where-Object { $_.CommandLine -match '_guard-loop' } | Sort-Object -Property CreationDate -Descending | Select-Object -First 1 -ExpandProperty ProcessId`,
+        3000
+      );
+      const foundPid = parseInt(result.trim());
+      if (!isNaN(foundPid) && foundPid > 0) actualPid = foundPid;
+    }
 
     await retryDatabaseOperation(() =>
       insertProcess({
@@ -510,6 +574,15 @@ async function run() {
     return;
   }
 
+  // Explicit "list" command
+  if (name === 'list') {
+    await showAll({
+      json: values.json as boolean | undefined,
+      filter: values.filter as string | undefined
+    });
+    return;
+  }
+
   // List or Run or Details
   if (name) {
     if (!values.command && !values.directory) {
@@ -541,5 +614,10 @@ async function run() {
 }
 
 run().catch(err => {
-  error(err);
+  // BgrunError was already printed by error() — just exit
+  // For unexpected errors, print and exit
+  if (err.name !== 'BgrunError') {
+    console.error(err);
+  }
+  process.exit(1);
 });