bfx-api-node-ws1 1.0.0 → 1.0.4

package/.eslintrc

@@ -0,0 +1,3 @@
+{
+  "extends": "standard"
+}

package/.eslintrc.json

@@ -0,0 +1,26 @@
+{
+  "parser": "babel-eslint",
+  "extends": [
+    "standard"
+  ],
+  "rules": {
+    "jsx-quotes": ["error", "prefer-single"],
+    "semi": [1, "never"],
+    "max-len": 0,
+    "import/no-named-as-default": 0,
+    "import/no-named-as-default-member": 0
+  },
+  "settings": {
+    "import/resolver": {
+      "node": {
+        "moduleDirectory": [
+          "node_modules",
+          "lib"
+        ]
+      }
+    }
+  },
+  "env": {
+    "jest": true
+  }
+}

package/.github/ISSUE_TEMPLATE

@@ -0,0 +1,13 @@
+#### Issue type
+- [ ] bug
+- [ ] missing functionality
+- [ ] performance
+- [ ] feature request
+
+#### Brief description
+
+#### Steps to reproduce
+-
+
+##### Additional Notes:
+-

package/.github/PULL_REQUEST_TEMPLATE

@@ -0,0 +1,17 @@
+### Description:
+...
+
+### Breaking changes:
+- [ ]
+
+### New features:
+- [ ]
+
+### Fixes:
+- [ ]
+
+### PR status:
+- [ ] Version bumped
+- [ ] Change-log updated
+- [ ] Tests added or updated
+- [ ] Documentation updated

package/.travis.yml

@@ -3,3 +3,10 @@ sudo: false
 language: node_js
 node_js:
   - "stable"
+
+install:
+  - npm install
+
+script:
+  - npm run lint
+  - npm run unit

package/CHANGELOG

@@ -0,0 +1,14 @@
+# 1.0.3
+- fix: use relative paths to allow generic mocha execution
+- feature: add isOpen() method
+
+# 1.0.2
+- docs: create/update
+
+# 1.0.1
+- manifest: bump deps
+- meta: add github issue/pr templates
+- meta: standardize travis config
+
+# 1.0.0
+- Initial version

package/README.md

@@ -1,7 +1,47 @@
-# Bitfinex WSv1 Reference Implementation
+# Bitfinex WSv1 Reference Implementation for Node.JS
 
 [![Build Status](https://travis-ci.org/bitfinexcom/bfx-api-node-ws1.svg?branch=master)](https://travis-ci.org/bitfinexcom/bfx-api-node-ws1)
 
 This repo contains the reference implementation for version 1 of the websocket Bitfinex API. It is deprecated in favour of version 2, and should no longer be used.
 
 For the version 2 API library, see [bitfinex-api-node](https://github.com/bitfinexcom/bitfinex-api-node)
+
+### Features
+
+* Emits API data as events from the class instance
+* Provides methods for channel management & listening to incoming data
+
+### Installation
+
+```bash
+npm i --save bfx-api-node-ws1
+```
+
+### Quickstart & Example
+
+```js
+const WSv1 = require('bfx-api-node-ws1')
+const ws = new WSv1()
+
+ws.open()
+
+ws.on('open', () => {
+  ws.subscribeTrades('BTCUSD')
+})
+
+ws.on('trades', (pair, trade) => {
+  console.log(JSON.stringify({ pair, trade }, null, 2))
+})
+```
+
+### Docs
+
+For JSDoc-generated API documentation, [see `docs/ws1.md`](/docs/ws1.md)
+
+### Contributing
+
+1. Fork it
+2. Create your feature branch (`git checkout -b my-new-feature`)
+3. Commit your changes (`git commit -am 'Add some feature'`)
+4. Push to the branch (`git push origin my-new-feature`)
+5. Create a new Pull Request

package/docs/ws1_docs.md

@@ -0,0 +1,114 @@
+<a name="WSv1"></a>
+
+## WSv1
+Communicates with v1 of the Bitfinex WebSocket API
+
+**Kind**: global class  
+
+* [WSv1](#WSv1)
+    * [new WSv1()](#new_WSv1_new)
+    * [.open()](#WSv1+open)
+    * [.close()](#WSv1+close)
+    * [.send(msg)](#WSv1+send)
+    * [.subscribeOrderBook(pair, precision, length)](#WSv1+subscribeOrderBook)
+    * [.subscribeTrades(pair)](#WSv1+subscribeTrades)
+    * [.subscribeTicker(pair)](#WSv1+subscribeTicker)
+    * [.unsubscribe(chanId)](#WSv1+unsubscribe)
+    * [.auth()](#WSv1+auth)
+
+<a name="new_WSv1_new"></a>
+
+### new WSv1()
+
+| Param | Type | Description |
+| --- | --- | --- |
+| opts.apiKey | <code>sting</code> |  |
+| opts.apiSecret | <code>string</code> |  |
+| opts.url | <code>string</code> | ws connection url |
+
+<a name="WSv1+open"></a>
+
+### wSv1.open()
+Opens a new websocket conection to the configured URL
+
+**Kind**: instance method of [<code>WSv1</code>](#WSv1)  
+<a name="WSv1+close"></a>
+
+### wSv1.close()
+Close the websocket connection
+
+**Kind**: instance method of [<code>WSv1</code>](#WSv1)  
+<a name="WSv1+send"></a>
+
+### wSv1.send(msg)
+Send a packet via the ws connection; automatically converted to a JSON
+string.
+
+**Kind**: instance method of [<code>WSv1</code>](#WSv1)  
+
+| Param | Type |
+| --- | --- |
+| msg | <code>\*</code> | 
+
+<a name="WSv1+subscribeOrderBook"></a>
+
+### wSv1.subscribeOrderBook(pair, precision, length)
+Subscribe to order book updates. Snapshot will be sent as multiple updates.
+Event will be emited as `PAIRNAME_book`.
+
+**Kind**: instance method of [<code>WSv1</code>](#WSv1)  
+**See**: http://docs.bitfinex.com/#order-books  
+
+| Param | Type | Default | Description |
+| --- | --- | --- | --- |
+| pair | <code>string</code> | <code>&quot;BTCUSD&quot;</code> |  |
+| precision | <code>string</code> |  | price aggregation level (P0 (def), P1, P2, P3) |
+| length | <code>string</code> |  | number of price points. 25 (default) or 100. |
+
+<a name="WSv1+subscribeTrades"></a>
+
+### wSv1.subscribeTrades(pair)
+Subscribe to trades. Snapshot will be sent as multiple updates.
+Event will be emited as `PAIRNAME_trades`.
+
+**Kind**: instance method of [<code>WSv1</code>](#WSv1)  
+**See**: http://docs.bitfinex.com/#trades75  
+
+| Param | Type | Default |
+| --- | --- | --- |
+| pair | <code>string</code> | <code>&quot;BTCUSD&quot;</code> | 
+
+<a name="WSv1+subscribeTicker"></a>
+
+### wSv1.subscribeTicker(pair)
+Subscribe to ticker updates. The ticker is a high level overview of the
+state of the market. It shows you the current best bid and ask, as well as
+the last trade price.
+
+Event will be emited as `PAIRNAME_ticker`.
+
+**Kind**: instance method of [<code>WSv1</code>](#WSv1)  
+**See**: http://docs.bitfinex.com/#ticker76  
+
+| Param | Type | Default | Description |
+| --- | --- | --- | --- |
+| pair | <code>string</code> | <code>&quot;BTCUSD&quot;</code> | pair |
+
+<a name="WSv1+unsubscribe"></a>
+
+### wSv1.unsubscribe(chanId)
+Unsubscribe from a channel.
+
+**Kind**: instance method of [<code>WSv1</code>](#WSv1)  
+
+| Param | Type | Description |
+| --- | --- | --- |
+| chanId | <code>number</code> | ID of the channel received on `subscribed` event |
+
+<a name="WSv1+auth"></a>
+
+### wSv1.auth()
+Authenticate the user. Will receive executed traded updates.
+
+**Kind**: instance method of [<code>WSv1</code>](#WSv1)  
+**See**: http://docs.bitfinex.com/#wallet-updates  

package/lib/ws.js

@@ -11,11 +11,11 @@ const WS_URL = 'wss://api.bitfinex.com/ws/'
 /**
  * Communicates with v1 of the Bitfinex WebSocket API
  */
-module.exports = class WSv1 extends EventEmitter {
+class WSv1 extends EventEmitter {
   /**
    * @param {sting} opts.apiKey
    * @param {string} opts.apiSecret
-   * @param {string} opts.url - ws connection url
+   * @param {string?} opts.url - ws connection url
    */
   constructor (opts = { apiKey: '', apiSecret: '', url: WS_URL }) {
     super()
@@ -26,15 +26,31 @@ module.exports = class WSv1 extends EventEmitter {
     this._channelMap = {} // map channel IDs to events
   }
 
+  /**
+   * Returns status of websocket
+   *
+   * @return {boolean} open
+   */
+  isOpen () {
+    return this._ws.isOpen()
+  }
+
+  /**
+   * Opens a new websocket conection to the configured URL
+   */
   open () {
     this._ws = new WebSocket(this._url)
-
     this._ws.on('message', this._onWSMessage.bind(this))
     this._ws.on('open', this._onWSOpen.bind(this))
     this._ws.on('error', this._onWSError.bind(this))
     this._ws.on('close', this._onWSClose.bind(this))
   }
 
+  /**
+   * @param {string} msgJSON
+   * @param {number} flags
+   * @private
+   */
   _onWSMessage (msgJSON, flags) {
     let msg
 
@@ -72,6 +88,10 @@ module.exports = class WSv1 extends EventEmitter {
     this.emit(msg.event, msg)
   }
 
+  /**
+   * @param {Array|Array[]} msg
+   * @private
+   */
   _handleChannel (msg) {
     // First element of Array is the channelId, the rest is the info.
     const channelId = msg.shift() // Pop the first element
@@ -98,6 +118,10 @@ module.exports = class WSv1 extends EventEmitter {
     }
   }
 
+  /**
+   * @param {Array} msg
+   * @private
+   */
   _processUserEvent (msg) {
     const event = msg[0]
     const data = msg[1]
@@ -113,6 +137,11 @@ module.exports = class WSv1 extends EventEmitter {
     }
   }
 
+  /**
+   * @param {Array} msg
+   * @param {Object} event
+   * @private
+   */
   _processTickerEvent (msg, event) {
     if (msg.length > 9) { // Update
       // All values are numbers
@@ -134,6 +163,11 @@ module.exports = class WSv1 extends EventEmitter {
     }
   }
 
+  /**
+   * @param {Array[]} msg
+   * @param {Object} event
+   * @private
+   */
   _processTradeEvent (msg, event) {
     if (isSnapshot(msg)) {
       const snapshot = msg[0].map(el => ({
@@ -169,8 +203,12 @@ module.exports = class WSv1 extends EventEmitter {
     this.emit('trade', event.pair, update)
   }
 
+  /**
+   * @param {Array[]} msg
+   * @param {Object} event
+   * @private
+   */
   _processBookEvent (msg, event) {
-    // TODO: Maybe break this up into snapshot/normal handlers? Also trade event
     if (!isSnapshot(msg[0]) && msg.length > 2) {
       let update
 
@@ -217,23 +255,41 @@ module.exports = class WSv1 extends EventEmitter {
     }
   }
 
+  /**
+   * Close the websocket connection
+   */
   close () {
     this._ws.close()
   }
 
+  /**
+   * @private
+   */
   _onWSOpen () {
     this._channelMap = {}
     this.emit('open')
   }
 
+  /**
+   * @private
+   */
   _onWSError (error) {
     this.emit('error', error)
   }
 
+  /**
+   * @private
+   */
   _onWSClose () {
     this.emit('close')
   }
 
+  /**
+   * Send a packet via the ws connection; automatically converted to a JSON
+   * string.
+   *
+   * @param {*} msg
+   */
   send (msg) {
     debug('Sending %j', msg)
     this._ws.send(JSON.stringify(msg))
@@ -243,7 +299,7 @@ module.exports = class WSv1 extends EventEmitter {
    * Subscribe to order book updates. Snapshot will be sent as multiple updates.
    * Event will be emited as `PAIRNAME_book`.
    *
-   * @param {string} pair - BTCUSD, LTCUSD or LTCBTC. Default BTCUSD
+   * @param {string} pair
    * @param {string} precision - price aggregation level (P0 (def), P1, P2, P3)
    * @param {string} length - number of price points. 25 (default) or 100.
    * @see http://docs.bitfinex.com/#order-books
@@ -262,7 +318,7 @@ module.exports = class WSv1 extends EventEmitter {
    * Subscribe to trades. Snapshot will be sent as multiple updates.
    * Event will be emited as `PAIRNAME_trades`.
    *
-   * @param {string} pair - BTCUSD, LTCUSD or LTCBTC. Default BTCUSD
+   * @param {string} pair
    * @see http://docs.bitfinex.com/#trades75
    */
   subscribeTrades (pair = 'BTCUSD') {
@@ -280,7 +336,7 @@ module.exports = class WSv1 extends EventEmitter {
    *
    * Event will be emited as `PAIRNAME_ticker`.
    *
-   * @param {string} - pair BTCUSD, LTCUSD or LTCBTC. Default BTCUSD
+   * @param {string} - pair
    * @see http://docs.bitfinex.com/#ticker76
    */
   subscribeTicker (pair = 'BTCUSD') {
@@ -319,3 +375,5 @@ module.exports = class WSv1 extends EventEmitter {
     })
   }
 }
+
+module.exports = WSv1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bfx-api-node-ws1",
-  "version": "1.0.0",
+  "version": "1.0.4",
   "description": "Legacy WSv1 transport for the Bitfinex Node API",
   "engines": {
     "node": ">=7"
@@ -9,7 +9,9 @@
   "scripts": {
     "lint": "standard",
     "test": "npm run lint && npm run unit",
-    "unit": "NODE_ENV=test mocha -b --recursive"
+    "unit": "NODE_ENV=test mocha -b --recursive",
+    "docs": "npm run ws1_docs",
+    "ws1_docs": "node_modules/jsdoc-to-markdown/bin/cli.js lib/ws.js > docs/ws1_docs.md"
   },
   "repository": {
     "type": "git",
@@ -20,27 +22,31 @@
     "bitcoin",
     "BTC"
   ],
+  "author": "Bitfinex",
   "contributors": [
     "Josh Rossi <josh@bitfinex.com> (https://www.bitfinex.com)",
     "Cris Mihalache <cris.m@bitfinex.com> (https://www.bitfinex.com)",
     "Robert Kowalski <robert@bitfinex.com> (https://www.bitfinex.com)",
     "Simone Poggi <simone@bitfinex.com> (https://www.bitfinex.com)",
-    "Paolo Ardoino <paolo@bitfinex.com> (https://www.bitfinex.com)"
+    "Paolo Ardoino <paolo@bitfinex.com> (https://www.bitfinex.com)",
+    "Jacob Plaster <jacob.plaster@bitfinex.com> (https://www.bitfinex.com)"
   ],
   "license": "MIT",
   "bugs": {
     "url": "https://github.com/bitfinexcom/bfx-api-node-ws1/issues"
   },
   "devDependencies": {
-    "chai": "^3.4.1",
-    "mocha": "^3.4.2",
-    "standard": "^10.0.2"
+    "babel-eslint": "^10.0.3",
+    "chai": "^4.2.0",
+    "jsdoc-to-markdown": "^5.0.1",
+    "mocha": "^6.2.0",
+    "standard": "^14.1.0"
   },
   "dependencies": {
-    "bluebird": "^3.5.1",
-    "debug": "^2.2.0",
-    "lodash": "^4.17.4",
-    "ws": "^3.0.0",
-    "bfx-api-node-util": "bitfinexcom/bfx-api-node-util"
+    "bfx-api-node-util": "^1.0.10",
+    "bluebird": "3.5.5",
+    "debug": "4.1.1",
+    "lodash": "^4.17.15",
+    "ws": "3.0.0"
   }
 }

package/test/lib/ws-1-handle-channel.js

@@ -16,11 +16,11 @@ describe('ws1 channel msg handling', () => {
     }
 
     bfxWs.once('orderbook', (symbol, data) => {
-      assert.deepEqual(data, { price: 2477.1, orderId: 2919111002, amount: 0.0125 })
+      assert.deepStrictEqual(data, { price: 2477.1, orderId: 2919111002, amount: 0.0125 })
       done()
     })
 
-    bfxWs._handleChannel([ 32755, 2919111002, 2477.1, 0.0125 ])
+    bfxWs._handleChannel([32755, 2919111002, 2477.1, 0.0125])
   })
 
   it('ws1 transforms & normalizes well - P1 update', (done) => {
@@ -29,11 +29,11 @@ describe('ws1 channel msg handling', () => {
     }
 
     bfxWs.once('orderbook', (symbol, data) => {
-      assert.deepEqual(data, { price: 2494, count: 2, amount: 5.9895 })
+      assert.deepStrictEqual(data, { price: 2494, count: 2, amount: 5.9895 })
       done()
     })
 
-    bfxWs._handleChannel([ 182, 2494, 2, 5.9895 ])
+    bfxWs._handleChannel([182, 2494, 2, 5.9895])
   })
 
   it('ws1 transforms & normalizes well - P1 snap', (done) => {
@@ -42,14 +42,14 @@ describe('ws1 channel msg handling', () => {
     }
 
     bfxWs.once('orderbook', (symbol, data) => {
-      assert.deepEqual(data[1], { price: 2494, count: 3, amount: 0.14606853 })
+      assert.deepStrictEqual(data[1], { price: 2494, count: 3, amount: 0.14606853 })
       done()
     })
 
-    const snap = [ 39, [
-      [ 2495, 2, 0.8744 ],
-      [ 2494, 3, 0.14606853 ],
-      [ 2492, 1, 0.4 ]
+    const snap = [39, [
+      [2495, 2, 0.8744],
+      [2494, 3, 0.14606853],
+      [2492, 1, 0.4]
     ]]
 
     bfxWs._handleChannel(snap)
@@ -61,17 +61,17 @@ describe('ws1 channel msg handling', () => {
     }
 
     bfxWs.once('orderbook', (symbol, data) => {
-      assert.deepEqual(
+      assert.deepStrictEqual(
         data[1],
         { price: 2494.5, orderId: 2919279471, amount: 0.07288 }
       )
       done()
     })
 
-    const snap = [ 34513, [
-      [ 2919278474, 2494.5, 0.07901704 ],
-      [ 2919279471, 2494.5, 0.07288 ],
-      [ 2919280093, 2494.5, 0.03644 ]
+    const snap = [34513, [
+      [2919278474, 2494.5, 0.07901704],
+      [2919279471, 2494.5, 0.07288],
+      [2919280093, 2494.5, 0.03644]
     ]]
 
     bfxWs._handleChannel(snap)

package/test/lib/ws-1-parsing.js

@@ -8,16 +8,35 @@ const WebSocket = require('ws')
 const WSv1 = require('../../lib/ws')
 
 describe('websocket1 parsing non json', () => {
+  let ws = null
+  let wss = null
+
+  afterEach(async () => {
+    try { // may fail due to being modified by a test, it's not a problem
+      if (ws && ws.isOpen()) {
+        await new Promise(resolve => ws.close(resolve))
+      }
+    } catch (e) {}
+
+    ws = null
+
+    if (wss) {
+      await new Promise(resolve => wss.close(resolve))
+    }
+
+    wss = null
+  })
+
   it('should not crash the client', (done) => {
-    const bws = new WSv1({
+    ws = new WSv1({
       apiKey: 'dummy',
       apiSecret: 'dummy',
       url: `ws://localhost:${PORT}`
     })
 
-    bws.open()
+    ws.open()
 
-    const wss = new WebSocket.Server({
+    wss = new WebSocket.Server({
       perMessageDeflate: false,
       port: PORT
     })
@@ -25,16 +44,13 @@ describe('websocket1 parsing non json', () => {
     wss.on('connection', function connection (ws) {
       ws.on('message', function incoming (msg) {
         msg = JSON.parse(msg)
-        assert.equal(msg.len, '25')
-        wss.close()
+        assert.strictEqual(msg.len, '25')
         done()
       })
 
       ws.send("HTTP Code 408 - I'm a Tea Pot")
     })
 
-    bws.on('open', () => {
-      bws.subscribeOrderBook('BTCUSD', 'R0')
-    })
+    ws.on('open', () => ws.subscribeOrderBook('BTCUSD', 'R0'))
   })
 })

package/test/lib/ws-1-test.js

@@ -1,112 +1,121 @@
 /* eslint-env mocha */
 'use strict'
 
-const PORT = 1337
-
 const assert = require('assert')
-
 const WebSocket = require('ws')
-const WSv1 = require('../../lib/ws')
+const _isObject = require('lodash/isObject')
 
+const WSv1 = require('../../lib/ws')
 const orderbookR0 = require('../fixtures/response-ws-1-orderbook-R0.json')
 
-const getWSInstance = () => {
-  return new WSv1({
-    apiKey: 'dummy',
-    apiSecret: 'dummy',
-    url: `ws://localhost:${PORT}`
+const PORT = 1334
+const getWSInstance = (args) => (
+  new WSv1({
+    url: `ws://localhost:${PORT}`,
+    ...args
   })
-}
+)
 
 describe('WebSocket v1 integration', () => {
+  let ws = null
+  let wss = null
+
+  afterEach(async () => {
+    try { // may fail due to being modified by a test, it's not a problem
+      if (ws && ws.isOpen()) {
+        ws.close()
+      }
+    } catch (e) {}
+
+    ws = null
+
+    if (wss) {
+      await new Promise(resolve => wss.close(resolve))
+    }
+
+    wss = null
+  })
+
   it('plays ping pong', (done) => {
-    const wss = new WebSocket.Server({
+    wss = new WebSocket.Server({
       perMessageDeflate: false,
       port: PORT
     })
 
-    const bws = getWSInstance()
-    bws.open()
-
-    wss.on('connection', function connection (ws) {
-      ws.on('message', function incoming (msg) {
+    ws = getWSInstance()
+    wss.on('connection', (ws) => {
+      ws.on('message', (msg) => {
         ws.send('{"event":"pong"}')
       })
     })
 
-    bws.on('open', () => {
-      bws.send({ event: 'ping' })
-    })
-
-    bws.on('pong', () => {
-      bws.close()
-      wss.close(done)
-    })
+    ws.on('open', () => ws.send({ event: 'ping' }))
+    ws.on('pong', () => done())
+    ws.open()
   })
 
   it('should receive info message', (done) => {
-    const wss = new WebSocket.Server({
+    wss = new WebSocket.Server({
       perMessageDeflate: false,
       port: PORT
     })
 
-    const bws = getWSInstance()
-    bws.open()
+    ws = getWSInstance()
 
-    wss.on('connection', function connection (ws) {
-      ws.send('{"event": "info", "version": 1.1 }')
+    wss.on('connection', (ws) => {
+      ws.send(JSON.stringify({
+        event: 'info',
+        version: 1.1,
+        platform: {
+          status: 1
+        }
+      }))
     })
 
-    bws.on('info', (data) => {
-      assert.deepEqual(
-        data,
-        {
-          event: 'info',
-          version: 1.1
-        }
-      )
-      bws.close()
-      wss.close(done)
+    ws.on('info', (data) => {
+      assert(_isObject(data.platform))
+      assert.strictEqual(data.event, 'info')
+      assert.strictEqual(data.version, 1.1)
+      assert.strictEqual(data.platform.status, 1)
+      done()
     })
+
+    ws.open()
   })
 
   it('should emit an error when authorization fails', (done) => {
-    const wss = new WebSocket.Server({
+    wss = new WebSocket.Server({
       perMessageDeflate: false,
       port: PORT
     })
 
-    const bws = getWSInstance()
-    bws.open()
+    ws = getWSInstance()
 
-    wss.on('connection', function connection (ws) {
-      ws.on('message', function incoming (msg) {
+    wss.on('connection', (ws) => {
+      ws.on('message', (msg) => {
         ws.send('{"event":"auth","status":"FAILED","chanId":0,"code":10100,"msg":"apikey: invalid"}')
       })
     })
 
-    bws.on('error', (err) => {
-      assert.equal(err.event, 'auth')
-      bws.close()
-      wss.close(done)
+    ws.on('error', (err) => {
+      assert.strictEqual(err.event, 'auth')
+      done()
     })
 
-    bws.on('open', () => {
-      bws.auth()
-    })
+    ws.on('open', ws.auth.bind(ws))
+    ws.open()
   })
 
-  it('should unsubscribe by channelId', function (done) {
-    const wss = new WebSocket.Server({
+  it('should unsubscribe by channelId', (done) => {
+    wss = new WebSocket.Server({
       perMessageDeflate: false,
       port: PORT
     })
 
-    const bws = getWSInstance()
-    bws.open()
+    ws = getWSInstance()
 
-    wss.on('connection', function connection (ws) {
-      ws.on('message', function incoming (msg) {
+    wss.on('connection', (ws) => {
+      ws.on('message', (msg) => {
         msg = JSON.parse(msg)
         if (msg.event === 'unsubscribe') {
           ws.send('{"event":"unsubscribed","status":"OK","chanId":4}')
@@ -117,159 +126,157 @@ describe('WebSocket v1 integration', () => {
       })
     })
 
-    bws.once('subscribed', (data) => {
+    ws.once('subscribed', (data) => {
       const channelId = data.chanId
 
-      bws.once('unsubscribed', (data) => {
-        assert.equal(data.status, 'OK')
-        assert.equal(data.chanId, channelId)
-        bws.close()
-        wss.close(done)
+      ws.once('unsubscribed', (data) => {
+        assert.strictEqual(data.status, 'OK')
+        assert.strictEqual(data.chanId, channelId)
+        done()
       })
-      bws.unsubscribe(channelId)
-    })
-    bws.on('open', () => {
-      bws.subscribeTicker('BTCUSD')
+
+      ws.unsubscribe(channelId)
     })
+
+    ws.on('open', () => ws.subscribeTicker('BTCUSD'))
+    ws.open()
   })
 
   it('should receive a subscribed success messages', (done) => {
-    const wss = new WebSocket.Server({
+    wss = new WebSocket.Server({
       perMessageDeflate: false,
       port: PORT
     })
 
-    const bws = getWSInstance()
-    bws.open()
-
-    wss.on('connection', function connection (ws) {
-      ws.on('message', function incoming (msg) {
+    ws = getWSInstance()
+    wss.on('connection', (ws) => {
+      ws.on('message', (msg) => {
         ws.send('{"event":"subscribed","channel":"trades","chanId":4,"pair":"BTCUSD"}')
       })
     })
 
-    bws.on('subscribed', (data) => {
-      assert.equal(data.channel, 'trades')
-      assert.equal(data.pair, 'BTCUSD')
-      bws.close()
-      wss.close(done)
-    })
-    bws.on('open', () => {
-      bws.subscribeTrades('BTCUSD')
+    ws.on('subscribed', (data) => {
+      assert.strictEqual(data.channel, 'trades')
+      assert.strictEqual(data.pair, 'BTCUSD')
+      done()
     })
+
+    ws.on('open', () => ws.subscribeTrades('BTCUSD'))
+    ws.open()
   })
 
   it('#orderBook data should have the defined fields', (done) => {
-    const wss = new WebSocket.Server({
+    wss = new WebSocket.Server({
       perMessageDeflate: false,
       port: PORT
     })
 
-    wss.on('connection', function connection (ws) {
-      ws.on('message', function incoming (msg) {
-        ws.send('{"event":"subscribed","channel":"book","chanId":13242,"prec":"R0","freq":"F0","len":"25","pair":"BTCUSD"}')
+    wss.on('connection', (ws) => {
+      ws.on('message', (msg) => {
+        ws.send(JSON.stringify({
+          event: 'subscribed',
+          channel: 'book',
+          chanId: 13242,
+          prec: 'R0',
+          freq: 'F0',
+          len: '25',
+          pair: 'BTCUSD'
+        }))
+
         ws.send(JSON.stringify(orderbookR0))
       })
     })
 
-    const bws = getWSInstance()
-    bws.open()
-
-    bws.once('orderbook', (pair, data) => {
-      assert.equal(pair, 'BTCUSD')
-      assert.equal(typeof data[0].price, 'number')
-      assert.equal(typeof data[0].orderId, 'number')
-      assert.equal(typeof data[0].amount, 'number')
-      assert.equal(data.length, 50)
-      bws.close()
-      wss.close(done)
+    ws = getWSInstance({ transform: true })
+    ws.once('orderbook', (pair, data) => {
+      assert.strictEqual(pair, 'BTCUSD')
+      assert.strictEqual(typeof data[0].price, 'number')
+      assert.strictEqual(typeof data[0].orderId, 'number')
+      assert.strictEqual(typeof data[0].amount, 'number')
+      assert.strictEqual(data.length, 50)
+      done()
     })
-    bws.on('open', () => {
-      bws.subscribeOrderBook('BTCUSD')
-    })
-  })
+
+    ws.on('open', () => ws.subscribeOrderBook('BTCUSD'))
+    ws.open()
+  }).timeout(10 * 1000)
 
   it('#ticker data should have the defined fields', (done) => {
-    const wss = new WebSocket.Server({
+    wss = new WebSocket.Server({
       perMessageDeflate: false,
       port: PORT
     })
 
-    wss.on('connection', function connection (ws) {
+    wss.on('connection', (ws) => {
       ws.send('{"event":"info","version":1.1}')
-      ws.on('message', function incoming (msg) {
+      ws.on('message', (msg) => {
         ws.send('{"event":"subscribed","channel":"ticker","chanId":4,"pair":"BTCUSD"}')
         ws.send('[4,2169.6,1.93,2169.8,0.0349,100.9,0.0488,2169.6,25479.40978657,2196,2000.1]')
       })
     })
 
-    const bws = getWSInstance()
-    bws.open()
-
-    bws.once('ticker', (pair, data) => {
-      assert.equal(pair, 'BTCUSD')
-      assert.equal(typeof data.bid, 'number')
-      assert.equal(typeof data.bidSize, 'number')
-      assert.equal(typeof data.ask, 'number')
-      assert.equal(typeof data.askSize, 'number')
-      assert.equal(typeof data.dailyChange, 'number')
-      assert.equal(typeof data.dailyChangePerc, 'number')
-      assert.equal(typeof data.lastPrice, 'number')
-      assert.equal(typeof data.volume, 'number')
-      assert.equal(typeof data.high, 'number')
-      assert.equal(typeof data.low, 'number')
-      bws.close()
-      wss.close(done)
-    })
-    bws.on('open', () => {
-      bws.subscribeTicker('BTCUSD')
+    ws = getWSInstance()
+
+    ws.once('ticker', (pair, data) => {
+      assert.strictEqual(pair, 'BTCUSD')
+      assert.strictEqual(typeof data.bid, 'number')
+      assert.strictEqual(typeof data.bidSize, 'number')
+      assert.strictEqual(typeof data.ask, 'number')
+      assert.strictEqual(typeof data.askSize, 'number')
+      assert.strictEqual(typeof data.dailyChange, 'number')
+      assert.strictEqual(typeof data.dailyChangePerc, 'number')
+      assert.strictEqual(typeof data.lastPrice, 'number')
+      assert.strictEqual(typeof data.volume, 'number')
+      assert.strictEqual(typeof data.high, 'number')
+      assert.strictEqual(typeof data.low, 'number')
+      done()
     })
+
+    ws.on('open', () => ws.subscribeTicker('BTCUSD'))
+    ws.open()
   })
 
   it('#trade data should have the defined fields', (done) => {
-    const wss = new WebSocket.Server({
+    wss = new WebSocket.Server({
       perMessageDeflate: false,
       port: PORT
     })
 
-    wss.on('connection', function connection (ws) {
+    wss.on('connection', (ws) => {
       ws.send('{"event":"info","version":1.1}')
-      ws.on('message', function incoming (msg) {
+      ws.on('message', (msg) => {
         ws.send('{"event":"subscribed","channel":"trades","chanId":33,"pair":"BTCUSD"}')
-        ws.send(`
-[33,[[32970704,1495442718,2169.1,0.03647196],[32970701,1495442718,2169.1,0.01058338],
-[32970697,1495442717,2169,-0.0000791],[32970696,1495442717,2169,-0.01054738],
-[32970692,1495442716,2169,-0.01063712],[32970683,1495442715,2169,-0.00191556],
-[32970682,1495442715,2169,-0.02003456],[32970681,1495442715,2169,-0.02002811],
-[32970680,1495442715,2169,-0.01079782],[32970679,1495442715,2169,-0.02002726],
-[32970678,1495442715,2169,-0.01079782],[32970662,1495442714,2169,-3.68585828],
-[32970654,1495442712,2169,-0.01413205],[32970646,1495442711,2169,-0.01066102],
-[32970643,1495442710,2169,-0.02002146],[32970640,1495442709,2169,-0.01727607],
-[32970631,1495442708,2169,-0.00984518],[32970629,1495442708,2169,-1.07188465],
-[32970618,1495442706,2169,-0.0995877],[32970613,1495442706,2169,-0.015553],
-[32970595,1495442702,2169,-0.00864857],[32970593,1495442702,2169,-0.01999732],
-[32970592,1495442702,2169,-0.01067048],[32970591,1495442702,2169.1,0.92541262],
-[32970590,1495442702,2169.1,0.9787866],[32970589,1495442702,2169,-0.01067048],
-[32970573,1495442702,2169,-0.01067048],[32970572,1495442702,2169,-0.0172659],
-[32970569,1495442701,2169,-0.02000913],[32970567,1495442701,2169,-0.01413205]]]
-          `)
+        ws.send([
+          '[33,[[32970704,1495442718,2169.1,0.03647196],[32970701,1495442718,2169.1,0.01058338],',
+          '[32970697,1495442717,2169,-0.0000791],[32970696,1495442717,2169,-0.01054738],',
+          '[32970692,1495442716,2169,-0.01063712],[32970683,1495442715,2169,-0.00191556],',
+          '[32970682,1495442715,2169,-0.02003456],[32970681,1495442715,2169,-0.02002811],',
+          '[32970680,1495442715,2169,-0.01079782],[32970679,1495442715,2169,-0.02002726],',
+          '[32970678,1495442715,2169,-0.01079782],[32970662,1495442714,2169,-3.68585828],',
+          '[32970654,1495442712,2169,-0.01413205],[32970646,1495442711,2169,-0.01066102],',
+          '[32970643,1495442710,2169,-0.02002146],[32970640,1495442709,2169,-0.01727607],',
+          '[32970631,1495442708,2169,-0.00984518],[32970629,1495442708,2169,-1.07188465],',
+          '[32970618,1495442706,2169,-0.0995877],[32970613,1495442706,2169,-0.015553],',
+          '[32970595,1495442702,2169,-0.00864857],[32970593,1495442702,2169,-0.01999732],',
+          '[32970592,1495442702,2169,-0.01067048],[32970591,1495442702,2169.1,0.92541262],',
+          '[32970590,1495442702,2169.1,0.9787866],[32970589,1495442702,2169,-0.01067048],',
+          '[32970573,1495442702,2169,-0.01067048],[32970572,1495442702,2169,-0.0172659],',
+          '[32970569,1495442701,2169,-0.02000913],[32970567,1495442701,2169,-0.01413205]]]'
+        ].join(''))
       })
     })
 
-    const bws = getWSInstance()
-    bws.open()
-
-    bws.once('trade', (pair, data) => {
-      assert.equal(pair, 'BTCUSD')
-      assert.equal(typeof data[0].seq, 'number')
-      assert.equal(typeof data[0].timestamp, 'number')
-      assert.equal(typeof data[0].price, 'number')
-      assert.equal(typeof data[0].amount, 'number')
-      bws.close()
-      wss.close(done)
-    })
-    bws.on('open', () => {
-      bws.subscribeTrades('BTCUSD')
+    ws = getWSInstance()
+
+    ws.once('trade', (pair, data) => {
+      assert.strictEqual(pair, 'BTCUSD')
+      assert.strictEqual(typeof data[0].timestamp, 'number')
+      assert.strictEqual(typeof data[0].price, 'number')
+      assert.strictEqual(typeof data[0].amount, 'number')
+      done()
     })
+
+    ws.on('open', () => ws.subscribeTrades('BTCUSD'))
+    ws.open()
   })
-})
+}).timeout(10 * 1000)