bfg-common 1.6.29 → 1.6.30

package/components/common/vm/actions/common/select/storage/new/lib/config/table.ts

@@ -9,7 +9,9 @@ import type { UI_I_StatusData } from '~/components/common/vm/actions/common/sele
 import { datastoreLocalizationByState } from '~/components/common/lib/config/states'
 import { getStatus } from '~/components/common/vm/actions/common/select/storage/new/lib/utils/utils'
 
-export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable => ({
+export const tableDataFunc = (
+  localization: UI_I_Localization
+): UI_I_DataTable => ({
   id: 'select-storage',
   header: [
     {
@@ -29,7 +31,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.inventorySummary.state,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '160px',
       show: true,
       filter: true,
@@ -40,7 +42,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.common.capacity,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '150px',
       show: true,
       filter: true,
@@ -51,7 +53,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.common.provisioned,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '150px',
       show: true,
       filter: true,
@@ -62,7 +64,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.common.free,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '150px',
       show: true,
       filter: true,
@@ -73,7 +75,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.common.used,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '150px',
       show: true,
       filter: true,
@@ -84,7 +86,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.common.type,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '120px',
       show: true,
       filter: true,
@@ -95,7 +97,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.common.thinProvisioning,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '160px',
       show: true,
       filter: true,
@@ -106,7 +108,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.common.access,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '120px',
       show: true,
       filter: true,
@@ -117,7 +119,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.common.hardwareAcceleration,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '200px',
       show: true,
       filter: true,
@@ -128,7 +130,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.common.driverType,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '150px',
       show: true,
       filter: true,
@@ -139,7 +141,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.common.device,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '150px',
       show: true,
       filter: true,
@@ -150,7 +152,7 @@ export const tableDataFunc = (localization: UI_I_Localization): UI_I_DataTable =
       text: localization.common.storageIoControl,
       isSortable: false,
       sort: 'asc',
-      sortColumn: false,
+      sortColumn: true,
       width: '180px',
       show: true,
       filter: true,

package/components/common/vm/actions/confirm/Confirm.vue

@@ -4,7 +4,6 @@
     :sub-title="props.subTitle"
     :description="props.description"
     :modal-texts="props.modalTexts"
-    :loading="props.isLoading"
     @hide-modal="emits('hide')"
     @confirm="emits('confirm')"
   >
@@ -23,11 +22,9 @@ const props = withDefaults(
     subTitle: string
     description: string
     modalTexts?: UI_I_ModalTexts
-    isLoading?: boolean
   }>(),
   {
     modalTexts: undefined,
-    isLoading: false
   }
 )
 

package/components/common/vm/actions/rename/New.vue

@@ -12,13 +12,13 @@
   >
     <template #content>
       <ui-alert
-          v-if="props.errors.length"
-          :messages="props.errors.length && !isEmptyName ? props.errors : []"
-          test-id="vm-rename-error-alert"
-          type="error"
-          class="mb-2 mx-8"
-          size="md"
-          hide-close-button
+        v-if="props.errors.length"
+        :messages="props.errors.length && !isEmptyName ? props.errors : []"
+        test-id="vm-rename-error-alert"
+        type="error"
+        class="mb-2 mt-2 mx-8"
+        size="md"
+        hide-close-button
       />
       <div class="content">
         <form @submit.prevent="onRename">

package/components/common/vm/snapshots/DetailView.vue

@@ -7,13 +7,13 @@
     >
       <tbody>
         <tr>
-          <td class="left" data-id="vm-snapshot-name-label">{{ localization.common.name }}</td>
+          <td class="left">{{ localization.common.name }}</td>
           <td class="left snapshot-name-label" data-id="vm-snapshot-name">
             {{ detailData.name }}
           </td>
         </tr>
         <tr>
-          <td class="left" data-id="vm-snapshot-description-label">{{ localization.common.description }}</td>
+          <td class="left">{{ localization.common.description }}</td>
           <td
             class="left snapshot-name-label"
             data-id="vm-snapshot-description"
@@ -22,17 +22,17 @@
           </td>
         </tr>
         <tr>
-          <td class="left" data-id="vm-snapshot-timestamp-label">{{ localization.snapshots.timestamp }}</td>
+          <td class="left">{{ localization.snapshots.timestamp }}</td>
           <td class="left snapshot-name-label" data-id="vm-snapshot-timestamp">
             {{ detailData.timestamp }}
           </td>
         </tr>
         <tr>
-          <td class="left" data-id="vm-snapshot-size-label">{{ localization.common.size }}</td>
+          <td class="left">{{ localization.common.size }}</td>
           <td class="left snapshot-name-label">{{ detailData.size }}</td>
         </tr>
         <tr>
-          <td class="left" data-id="vm-snapshot-of-memory-label">
+          <td class="left">
             {{ localization.common.snapshotTheVirtualMachinesMemory }}
           </td>
           <td class="left snapshot-name-label" data-id="vm-snapshot-of-memory">
@@ -40,7 +40,7 @@
           </td>
         </tr>
         <tr>
-          <td class="left" data-id="vm-snapshot-file-system-label">
+          <td class="left">
             {{ localization.common.quiesceGuestFileSystem }}
           </td>
           <td

package/components/common/wizards/common/steps/name/New.vue

@@ -17,9 +17,11 @@
     <div class="name-field">
       <div class="flex-1 flex-align-center">
         <ui-skeleton-item v-if="isLoading" width="112px" height="20px" />
-        <label v-else :for="`${props.testIds.name}-name`" class="name-label">{{
-          localization.common.name
-        }}</label>
+        <label v-else :for="`${props.testIds.name}-name`" class="name-label"
+          >{{ localization.common.name }} ({{
+            localization.common.optional
+          }})</label
+        >
 
         <common-tooltip-help
           v-if="!isLoading"
@@ -55,7 +57,7 @@
             <ui-input
               v-model="name"
               id="vm-name-tooltip"
-              :placeholder="`${localization.common.name} (${localization.common.optional})`"
+              :placeholder="`${localization.common.name}`"
               type="text"
               maxlength="54"
               :error="props.nameErrorText"

package/components/common/wizards/datastore/add/New.vue

@@ -256,10 +256,4 @@ const onCreateDatastore = (): void => emits('submit')
     padding: 10px 12px;
   }
 }
-:deep(.ui-wizard-content-right-container) {
-  padding: 0 30px;
-}
-:deep(.ui-wizard-subtitle-container) + *, :deep(.ui-wizard-subtitle-container) {
-  padding-left: 2px;
-}
 </style>

package/components/common/wizards/datastore/add/steps/nameAndDevice/NameAndDeviceNew.vue

@@ -179,7 +179,7 @@ const onSelectHost = (event: string): void => {
   display: flex;
   flex-direction: column;
   row-gap: 16px;
-  margin: 16px 0;
+  margin: 16px 0 16px 2px;
 
   &__alert {
     align-items: flex-start;

package/components/common/wizards/datastore/add/steps/nameAndDevice/advancedOptions/New.vue

@@ -3,7 +3,7 @@
     <ui-button
       variant="text"
       test-id="advanced-options-button"
-      class="advanced-options-btn"
+      class="advanced-options-btn btn btn-link"
       @click="isShowAdvancedOptions = !isShowAdvancedOptions"
     >
       <template #icon>

package/components/common/wizards/network/add/Add.vue

@@ -618,20 +618,9 @@ const finalValidationFunc = async (
     const stepId = wizard.getStepIdByFieldName(fieldName)
 
     if (stepId !== -1) {
-      let message = ''
-
-      if (validationFields[fieldName]) {
-        message = `${validationFields[
-          fieldName
-        ][0].toUpperCase()}${validationFields[fieldName].substring(1)}`
-
-        message =
-          message.charAt(message.length - 1) !== '.' ? message + '.' : message
-      }
-
       stepHasError = wizard.setValidation(stepId, fieldName, {
-        fieldMessage: message,
-        alertMessage: message,
+        fieldMessage: validationFields[fieldName],
+        alertMessage: validationFields[fieldName],
       })
     }
   }

package/components/common/wizards/network/add/AddNew.vue

@@ -44,21 +44,22 @@
         >
           <template #subTitle>
             <div ref="selectTargetDeviceBlock">
-              <div class="alert-block flex flex-col">
+              <div class="subtitle-block flex flex-col">
                 <template
                   v-for="(message, field, key) in selectedStep.fields"
                   :key="key"
                 >
                   <ui-alert
-                    v-if="!!message.alert"
                     :messages="[message.alert]"
                     test-id="select-target-device-alert"
+                    :class="{
+                      'mb-4':
+                        props.alertMessages[selectedStep.id].length - 1 === key,
+                    }"
                     size="md"
                     @hide="emits('hide-alert', selectedStep.id, field)"
                   />
                 </template>
-              </div>
-              <div class="subtitle-block flex flex-col">
                 <ui-wizard-subtitle :sub-title="selectedStep.subTitle" />
                 <ui-line margin="12px 0 0" />
               </div>
@@ -88,21 +89,22 @@
         >
           <template #subTitle>
             <div ref="createStandardSwitchBlock">
-              <div class="alert-block flex flex-col">
+              <div class="subtitle-block flex flex-col">
                 <template
                   v-for="(message, field, key) in selectedStep.fields"
                   :key="key"
                 >
                   <ui-alert
-                    v-if="!!message.alert"
                     :messages="[message.alert]"
                     test-id="create-standard-switch-alert"
+                    :class="{
+                      'mb-4':
+                        props.alertMessages[selectedStep.id].length - 1 === key,
+                    }"
                     size="md"
                     @hide="emits('hide-alert', selectedStep.id, field)"
                   />
                 </template>
-              </div>
-              <div class="subtitle-block flex flex-col">
                 <ui-wizard-subtitle :sub-title="selectedStep.subTitle" />
                 <ui-line margin="12px 0 0" />
               </div>
@@ -144,21 +146,22 @@
         >
           <template #subTitle>
             <div ref="portPropertiesBlock">
-              <div class="alert-block flex flex-col">
+              <div class="subtitle-block flex flex-col">
                 <template
                   v-for="(message, field, key) in selectedStep.fields"
                   :key="key"
                 >
                   <ui-alert
-                    v-if="!!message.alert"
                     :messages="[message.alert]"
                     test-id="port-properties-alert"
+                    :class="{
+                      'mb-4':
+                        props.alertMessages[selectedStep.id].length - 1 === key,
+                    }"
                     size="md"
                     @hide="emits('hide-alert', selectedStep.id, field)"
                   />
                 </template>
-              </div>
-              <div class="subtitle-block flex flex-col">
                 <ui-wizard-subtitle :sub-title="selectedStep.subTitle" />
                 <ui-line margin="12px 0 0" />
               </div>
@@ -187,21 +190,22 @@
         >
           <template #subTitle>
             <div ref="ipFourSettingsBlock">
-              <div class="alert-block flex flex-col">
+              <div class="subtitle-block flex flex-col">
                 <template
                   v-for="(message, field, key) in selectedStep.fields"
                   :key="key"
                 >
                   <ui-alert
-                    v-if="!!message.alert"
                     :messages="[message.alert]"
                     test-id="ip-four-settings-alert"
+                    :class="{
+                      'mb-4':
+                        props.alertMessages[selectedStep.id].length - 1 === key,
+                    }"
                     size="md"
                     @hide="emits('hide-alert', selectedStep.id, field)"
                   />
                 </template>
-              </div>
-              <div class="subtitle-block flex flex-col">
                 <ui-wizard-subtitle :sub-title="selectedStep.subTitle" />
                 <ui-line margin="12px 0 0" />
               </div>
@@ -229,21 +233,22 @@
         >
           <template #subTitle>
             <div ref="connectionSettingsBlock">
-              <div class="alert-block flex flex-col">
+              <div class="subtitle-block flex flex-col">
                 <template
                   v-for="(message, field, key) in selectedStep.fields"
                   :key="key"
                 >
                   <ui-alert
-                    v-if="!!message.alert"
                     :messages="[message.alert]"
                     test-id="connection-settings-alert"
+                    :class="{
+                      'mb-4':
+                        props.alertMessages[selectedStep.id].length - 1 === key,
+                    }"
                     size="md"
                     @hide="emits('hide-alert', selectedStep.id, field)"
                   />
                 </template>
-              </div>
-              <div class="subtitle-block flex flex-col">
                 <ui-wizard-subtitle :sub-title="selectedStep.subTitle" />
                 <ui-line margin="12px 0 0" />
               </div>
@@ -458,7 +463,6 @@ const onChangeSteps = async (value: UI_I_WizardStep[]): Promise<void> => {
   }
   :deep(.ui-wizard-content-with-subtitle) {
     padding-right: 0;
-    scrollbar-gutter: unset;
   }
 }
 
@@ -473,7 +477,7 @@ const onChangeSteps = async (value: UI_I_WizardStep[]): Promise<void> => {
 :deep(.ui-alert-item) {
   margin-bottom: 12px;
 
-  &:last-of-type {
+  &.mb-4 {
     margin-bottom: 16px;
   }
 }

package/components/common/wizards/network/add/lib/config/initialData.ts

@@ -37,7 +37,7 @@ export const portPropertiesInitial = (
   localization: UI_I_Localization
 ): UI_I_PortProperties => ({
   networkLabel: '',
-  vlanId: `${localization.common.none2} (0)`,
+  vlanId: `${localization.common.none} (0)`,
   mtu: {
     option: '0',
     size: 1500,
@@ -62,15 +62,15 @@ export const connectionSettingsInitial = (
   localization: UI_I_Localization
 ): UI_I_ConnectionSettings => ({
   networkLabel: 'VM Network',
-  vlanId: `${localization.common.none2} (0)`,
+  vlanId: `${localization.common.none} (0)`,
 })
 
 export const vlanIdSelectDataFunc = (
   localization: UI_I_Localization
 ): UI_I_VlanIdData[] => [
   {
-    text: `${localization.common.none2} (0)`,
-    value: `${localization.common.none2} (0)`,
+    text: `${localization.common.none} (0)`,
+    value: `${localization.common.none} (0)`,
   },
   {
     text: `${localization.common.all} (4095)`,

package/components/common/wizards/network/add/lib/utils/utils.ts

@@ -5,5 +5,5 @@ export const getVlanId = (
   localization: UI_I_Localization
 ): string =>
   (vlanId === `${localization.common.all} (4095)` && '4095') ||
-  (vlanId === `${localization.common.none2} (0)` && '0') ||
+  (vlanId === `${localization.common.none} (0)` && '0') ||
   vlanId

package/components/common/wizards/network/add/steps/ipFourSettings/IpFourSettingsNew.vue

@@ -281,8 +281,14 @@ const fields = computed({
   }
 }
 :deep(.ui-checkbox-label) {
-  &.md {
-    height: unset;
+  text-overflow: ellipsis;
+  white-space: nowrap;
+  overflow: hidden;
+
+  .ui-checkbox-label-text {
+    text-overflow: ellipsis;
+    white-space: nowrap;
+    overflow: hidden;
   }
 }
 .tooltip-text {

package/components/common/wizards/network/add/steps/portProperties/PortPropertiesNew.vue

@@ -299,8 +299,14 @@ const portPropertiesEnabledServices = computed<
   padding: 0 8px 0 12px;
 }
 :deep(.ui-checkbox-label) {
-  &.md {
-    height: unset;
+  text-overflow: ellipsis;
+  white-space: nowrap;
+  overflow: hidden;
+
+  .ui-checkbox-label-text {
+    text-overflow: ellipsis;
+    white-space: nowrap;
+    overflow: hidden;
   }
 }
 </style>

package/components/common/wizards/network/add/steps/selectTargetDevice/SelectTargetDeviceNew.vue

@@ -103,7 +103,7 @@
               <template #row="{ item }">
                 <div v-if="item.iconName" class="browse-btn">
                   <ui-button
-                    test-id="browse-network"
+                    test-id="button-1"
                     type="primary"
                     variant="text"
                     size="lg"
@@ -154,7 +154,7 @@
               <template #row="{ item }">
                 <div v-if="item.iconName" class="browse-btn">
                   <ui-button
-                    test-id="browse-standard-switch"
+                    test-id="button-1"
                     type="primary"
                     variant="text"
                     size="lg"
@@ -203,7 +203,7 @@
               <template #row="{ item }">
                 <div v-if="item.iconName" class="browse-btn">
                   <ui-button
-                    test-id="browse-switch"
+                    test-id="button-1"
                     type="primary"
                     variant="text"
                     size="lg"
@@ -357,17 +357,10 @@ watch(
     :deep(.ui-btn) {
       justify-content: flex-start;
       height: 32px;
-      overflow: hidden;
-      text-overflow: ellipsis;
-      white-space: nowrap;
-      width: 100%;
 
       span {
         text-align: left;
         color: var(--select-text);
-        overflow: hidden;
-        text-overflow: ellipsis;
-        white-space: nowrap;
       }
 
       &:hover {

package/components/common/wizards/network/add/steps/selectTargetDevice/modals/new/SelectNetwork.vue

@@ -46,7 +46,7 @@ import type {
   UI_I_DataTable,
   UI_I_DataTableHeader,
   UI_I_DataTableBody,
-  UI_I_TableTexts,
+  UI_I_TableTexts
 } from '~/node_modules/bfg-uikit/components/ui/dataTable/lib/models/interfaces'
 import type { UI_I_Localization } from '~/lib/models/interfaces'
 import type {
@@ -147,10 +147,6 @@ const onSelectNetwork = (): void => {
 <style scoped lang="scss">
 :deep(.table-container) {
   padding: 8px 32px !important;
-
-  .column-manager-button span {
-    font-weight: 500;
-  }
 }
 
 .row-container {

package/components/common/wizards/network/add/validations/common.ts

@@ -21,7 +21,7 @@ export const checkVlanId = (
   vlanId: string,
   localization: UI_I_Localization
 ): boolean =>
-  vlanId !== `${localization.common.none2} (0)` &&
+  vlanId !== `${localization.common.none} (0)` &&
   vlanId !== `${localization.common.all} (4095)` &&
   (isIntegerNumberInRange(vlanId, 0, 4095) || vlanId.trim() === '')
 

package/components/common/wizards/vm/migrate/steps/computeResource/tableView/new/New.vue

@@ -2,7 +2,7 @@
   <div class="device-table-container">
     <ui-data-table
       :data="data"
-      :options="tableConfig.options"
+      :options="options"
       :loading="props.isLoading"
       :total-pages="props.totalPages"
       :total-items="props.totalItems"
@@ -79,10 +79,13 @@ import type {
   UI_I_TableTexts,
 } from '~/node_modules/bfg-uikit/components/ui/dataTable/models/interfaces'
 import type { UI_I_DataTableSkeleton } from '~/node_modules/bfg-uikit/components/ui/dataTable/models/interfaces'
-import type { UI_T_SelectComputeResourceTabType } from '~/components/common/wizards/vm/migrate/steps/selectStorage/lib/models/types'
+import type { UI_T_SelectComputeResourceTabType } from '~/components/common/wizards/vm/migrate/select/storage/lib/models/types'
 import type { UI_T_ComputeResourceTableItem } from '~/components/common/wizards/vm/migrate/steps/computeResource/lib/models/types'
-import * as hostTable from '~/components/common/wizards/vm/migrate/steps/computeResource/tableView/new/lib/config/hostTable'
-import * as clusterTable from '~/components/common/wizards/vm/migrate/steps/computeResource/tableView/new/lib/config/clusterTable'
+import {
+  options,
+  getHeaderDataFunc,
+  getBodyDataFunc,
+} from '~/components/common/wizards/vm/migrate/steps/computeResource/tableView/new/lib/config/hostTable'
 
 const selectedDataLocal = defineModel<number | null>({ required: true })
 const props = defineProps<{
@@ -117,33 +120,15 @@ const tableSkeleton = ref<UI_I_DataTableSkeleton>({
   withoutPagination: true,
 })
 
-const tableTitleMap = {
-  host: localization.value.common.hosts,
-  cluster: localization.value.common.clusters,
-} as const
-const tableConfigMap = {
-  host: hostTable,
-  cluster: clusterTable,
-} as const
-
-const tableConfig = computed(
-  () => tableConfigMap[props.type as keyof typeof tableConfigMap]
-)
-
 const data = computed<UI_I_DataTable>(() => ({
-  id: `compute-resource-${props.type}-table`,
-  title: tableDataTitle.value,
+  id: 'compute-resource-host-table',
+  title: `${localization.value.common.hosts} (${props.totalItems})`,
   header: deviceHeadItems.value,
   body: deviceBodyItems.value,
 }))
-const tableDataTitle = computed<string>(
-  () =>
-    `${tableTitleMap[props.type as keyof typeof tableConfigMap]} (${
-      props.totalItems
-    })`
-)
+
 const deviceHeadItems = computed<UI_I_DataTableHeader[]>(() =>
-  tableConfig.value.getHeaderDataFunc(localization.value)
+  getHeaderDataFunc(localization.value)
 )
 
 const deviceBodyItems = ref<UI_I_DataTableBody[]>([])
@@ -155,16 +140,13 @@ watch(
       return
     }
 
-    deviceBodyItems.value = tableConfig.value.getBodyDataFunc(
-      newValue,
-      localization.value
-    )
+    deviceBodyItems.value = getBodyDataFunc(newValue, localization.value)
   },
   { deep: true, immediate: true }
 )
 
 const onSelectRow = (value: UI_I_DataTableBody[]): void => {
-  selectedDataLocal.value = value?.[0].row as number
+  selectedDataLocal.value = value?.[0].row
 }
 </script>