betterddb 0.7.0 → 0.8.1

package/babel.config.cjs

@@ -0,0 +1,6 @@
+module.exports = {
+  presets: [
+    ['@babel/preset-env', { targets: { node: 'current' } }],
+    '@babel/preset-typescript',
+  ],
+}; 

package/{jest.config.js → jest.config.cjs}

@@ -1,16 +1,17 @@
+/** @type {import('jest').Config} */
 const config = {
   testEnvironment: "node",
   roots: ["<rootDir>/test/"],
   testMatch: ["**/*.test.ts"],
   transform: {
-    "^.+\\.(ts|tsx|js|jsx)$": "ts-jest",
+    "^.+\\.(ts|tsx|js|jsx)$": "babel-jest"
   },
   moduleNameMapper: {
     "^@/(.*)$": "<rootDir>/src/$1",
     "^~/(.*)$": "<rootDir>/src/$1",
+    "^(\\.{1,2}/.*)\\.js$": "$1"
   },
-  extensionsToTreatAsEsm: [".ts", ".tsx"],
-  moduleFileExtensions: ["ts", "tsx", "js", "jsx", "json", "node"],
+  moduleFileExtensions: ["ts", "tsx", "js", "jsx", "json", "node"]
 };
 
-export default config;
+module.exports = config; 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "betterddb",
-  "version": "0.7.0",
+  "version": "0.8.1",
   "description": "A definition-based DynamoDB wrapper library that provides a schema-driven and fully typesafe DAL.",
   "type": "module",
   "main": "./dist/index.js",
@@ -43,11 +43,15 @@
     "zod": "^3.24.2"
   },
   "devDependencies": {
+    "@babel/core": "^7.28.0",
+    "@babel/preset-env": "^7.28.0",
+    "@babel/preset-typescript": "^7.27.1",
     "@eslint/js": "^9.11.1",
     "@types/jest": "^29.5.14",
     "@types/node": "^22.13.5",
     "@typescript-eslint/eslint-plugin": "^8.24.1",
     "@typescript-eslint/parser": "^8.24.1",
+    "babel-jest": "^30.0.4",
     "del-cli": "^6.0.0",
     "eslint": "^8.57.1",
     "eslint-config-prettier": "^9.1.0",

package/src/betterddb.ts

@@ -20,6 +20,7 @@ export type PrimaryKeyValue = string | number;
 export type KeyDefinition<T> =
   | keyof T
   | {
+      // eslint-disable-next-line no-unused-vars
       build: (rawKey: Partial<T>) => string;
     };
 

package/src/builders/batch-get-builder.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-vars */
 import { type BetterDDB } from "../betterddb.js";
 import { BatchGetCommand } from "@aws-sdk/lib-dynamodb";
 import { type BatchGetItemInput } from "@aws-sdk/client-dynamodb";

package/src/builders/create-builder.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-vars */
 import {
   type AttributeValue,
   type Put,

package/src/builders/delete-builder.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-vars */
 import { type BetterDDB } from "../betterddb.js";
 import {
   type TransactWriteItem,

package/src/builders/get-builder.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-vars */
 import { type BetterDDB } from "../betterddb.js";
 import { TransactGetCommand, GetCommand } from "@aws-sdk/lib-dynamodb";
 import {

package/src/builders/query-builder.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-vars */
 import {
   type NativeAttributeValue,
   QueryCommand,

package/src/builders/scan-builder.ts

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-vars */
 import {
   ScanCommand,
   type ScanCommandInput,

package/src/builders/update-builder.ts

@@ -1,14 +1,17 @@
+/* eslint-disable no-unused-vars */
 import {
   type NativeAttributeValue,
   TransactWriteCommand,
   UpdateCommand,
+  type UpdateCommandInput,
 } from "@aws-sdk/lib-dynamodb";
 import { type BetterDDB } from "../betterddb.js";
 import {
   type TransactWriteItem,
   type Update,
-  type UpdateItemInput,
+  type ReturnValue,
 } from "@aws-sdk/client-dynamodb";
+
 interface UpdateActions<T> {
   set?: Partial<T>;
   remove?: (keyof T)[];
@@ -39,7 +42,9 @@ export class UpdateBuilder<T> {
       (acc, [key, value]) => {
         if (
           value === undefined ||
-          (typeof value === "string" && value.trim() === "")
+          (typeof value === "string" &&
+            value.trim() === "" &&
+            this.parent.getSchema().shape[key]?.isOptional?.())
         ) {
           acc.toRemove.push(key as keyof T);
         } else {
@@ -125,34 +130,44 @@ export class UpdateBuilder<T> {
   /**
    * Builds the update expression and associated maps.
    */
-  private buildExpression(): {
+  private buildExpression(newItemForIndexes?: T): {
     updateExpression: string;
     attributeNames: Record<string, string>;
     attributeValues?: Record<string, NativeAttributeValue>;
   } {
     const ExpressionAttributeNames: Record<string, string> = {};
-    let ExpressionAttributeValues:
-      | Record<string, NativeAttributeValue>
-      | undefined = {};
+    const ExpressionAttributeValues: Record<string, NativeAttributeValue> = {};
     const clauses: string[] = [];
 
-    // Build SET clause.
+    // 1) SET – from actions.set
+    const setParts: string[] = [];
     if (this.actions.set) {
-      const setParts: string[] = [];
       for (const [attr, value] of Object.entries(this.actions.set)) {
         const nameKey = `#n_${attr}`;
         const valueKey = `:v_${attr}`;
         ExpressionAttributeNames[nameKey] = attr;
-        ExpressionAttributeValues[valueKey] = value;
+        ExpressionAttributeValues[valueKey] = value!;
         setParts.push(`${nameKey} = ${valueKey}`);
       }
-      if (setParts.length > 0) {
-        clauses.push(`SET ${setParts.join(", ")}`);
+    }
+
+    // 2) also SET – from index‐rebuild if requested
+    if (newItemForIndexes) {
+      const indexAttrs = this.parent.buildIndexes(newItemForIndexes);
+      for (const [attr, value] of Object.entries(indexAttrs)) {
+        const nameKey = `#n_idx_${attr}`;
+        const valueKey = `:v_idx_${attr}`;
+        ExpressionAttributeNames[nameKey] = attr;
+        ExpressionAttributeValues[valueKey] = value;
+        setParts.push(`${nameKey} = ${valueKey}`);
       }
     }
+    if (setParts.length > 0) {
+      clauses.push(`SET ${setParts.join(", ")}`);
+    }
 
-    // Build REMOVE clause.
-    if (this.actions.remove && this.actions.remove.length > 0) {
+    // 3) REMOVE
+    if (this.actions.remove?.length) {
       const removeParts = this.actions.remove.map((attr) => {
         const nameKey = `#n_${String(attr)}`;
         ExpressionAttributeNames[nameKey] = String(attr);
@@ -161,66 +176,70 @@ export class UpdateBuilder<T> {
       clauses.push(`REMOVE ${removeParts.join(", ")}`);
     }
 
-    // Build ADD clause.
+    // 4) ADD
     if (this.actions.add) {
       const addParts: string[] = [];
       for (const [attr, value] of Object.entries(this.actions.add)) {
         const nameKey = `#n_${attr}`;
         const valueKey = `:v_${attr}`;
         ExpressionAttributeNames[nameKey] = attr;
-        ExpressionAttributeValues[valueKey] = value;
+        ExpressionAttributeValues[valueKey] = value as NativeAttributeValue;
         addParts.push(`${nameKey} ${valueKey}`);
       }
-      if (addParts.length > 0) {
+      if (addParts.length) {
         clauses.push(`ADD ${addParts.join(", ")}`);
       }
     }
 
-    // Build DELETE clause.
+    // 5) DELETE
     if (this.actions.delete) {
       const deleteParts: string[] = [];
       for (const [attr, value] of Object.entries(this.actions.delete)) {
         const nameKey = `#n_${attr}`;
         const valueKey = `:v_${attr}`;
         ExpressionAttributeNames[nameKey] = attr;
-        ExpressionAttributeValues[valueKey] = value;
+        ExpressionAttributeValues[valueKey] = value as NativeAttributeValue;
         deleteParts.push(`${nameKey} ${valueKey}`);
       }
-      if (deleteParts.length > 0) {
+      if (deleteParts.length) {
         clauses.push(`DELETE ${deleteParts.join(", ")}`);
       }
     }
 
-    // Merge any provided condition attribute names and values
+    // 6) merge in condition‐names/values
     if (this.condition) {
       Object.assign(ExpressionAttributeNames, this.condition.attributeNames);
       Object.assign(ExpressionAttributeValues, this.condition.attributeValues);
     }
 
-    if (Object.keys(ExpressionAttributeValues).length === 0) {
-      ExpressionAttributeValues = undefined;
-    }
+    // 7) normalize empty values
+    const hasValues = Object.keys(ExpressionAttributeValues).length > 0;
+    const finalValues = hasValues ? ExpressionAttributeValues : undefined;
 
-    // If no clauses were generated, throw an error
     if (clauses.length === 0) {
       throw new Error(
-        "No attributes to update - all values were empty or undefined",
+        "No attributes to update – all values were empty or undefined",
       );
     }
 
     return {
       updateExpression: clauses.join(" "),
       attributeNames: ExpressionAttributeNames,
-      attributeValues: ExpressionAttributeValues,
+      attributeValues: finalValues,
     };
   }
 
   /**
    * Returns a transaction update item that can be included in a transactWrite call.
    */
-  public toTransactUpdate(): TransactWriteItem {
+  public async toTransactUpdate(
+    newItemForIndexes?: T,
+  ): Promise<TransactWriteItem> {
+    if (!newItemForIndexes) {
+      newItemForIndexes = await this.createExpectedNewItem();
+    }
     const { updateExpression, attributeNames, attributeValues } =
-      this.buildExpression();
+      this.buildExpression(newItemForIndexes);
     const updateItem: Update = {
       TableName: this.parent.getTableName(),
       Key: this.parent.buildKey(this.key),
@@ -234,47 +253,55 @@ export class UpdateBuilder<T> {
     return { Update: updateItem };
   }
 
-  private async rebuildIndexes() {
+  private async createExpectedNewItem() {
     const existingItem = await this.parent.get(this.key).execute();
     if (existingItem === null) {
       throw new Error("Item not found");
     }
-    const indexAttributes = this.parent.buildIndexes(existingItem);
-    if (Object.keys(indexAttributes).length > 0) {
-      const updateExpression = `SET ${Object.entries(indexAttributes)
-        .map(([attr]) => `#n_${attr} = :v_${attr}`)
-        .join(", ")}`;
-      const attributeNames = Object.fromEntries(
-        Object.entries(indexAttributes).map(([attr]) => [`#n_${attr}`, attr]),
-      );
-      const attributeValues = Object.fromEntries(
-        Object.entries(indexAttributes).map(([attr, value]) => [
-          `:v_${attr}`,
-          value,
-        ]),
-      );
-
-      const params: UpdateItemInput = {
-        TableName: this.parent.getTableName(),
-        Key: this.parent.buildKey(this.key),
-        UpdateExpression: updateExpression,
-        ExpressionAttributeNames: attributeNames,
-        ExpressionAttributeValues: attributeValues,
-        ReturnValues: "ALL_NEW",
-      };
-
-      const result = await this.parent
-        .getClient()
-        .send(new UpdateCommand(params));
-      return result.Attributes;
+    const expectedNewItem: Record<string, any> = {
+      ...existingItem,
+      ...this.actions.set,
+    };
+    if (this.actions.remove) {
+      this.actions.remove.forEach((attr) => {
+        delete expectedNewItem[String(attr)];
+      });
+    }
+    if (this.actions.add) {
+      Object.entries(this.actions.add).forEach(([attr, value]) => {
+        const currentValue = expectedNewItem[attr] ?? 0;
+        if (typeof value === "number") {
+          expectedNewItem[attr] = currentValue + value;
+        } else if (value instanceof Set) {
+          const currentSet =
+            expectedNewItem[attr] instanceof Set
+              ? expectedNewItem[attr]
+              : new Set();
+          expectedNewItem[attr] = new Set([...currentSet, ...value]);
+        }
+      });
+    }
+    if (this.actions.delete) {
+      Object.entries(this.actions.delete).forEach(([attr, value]) => {
+        if (value instanceof Set) {
+          const currentSet = expectedNewItem[attr];
+          if (currentSet instanceof Set) {
+            value.forEach((v) => {
+              currentSet.delete(v);
+            });
+          }
+        }
+      });
     }
-    return existingItem;
+    return this.parent.getSchema().parse(expectedNewItem) as T;
   }
 
   /**
    * Commits the update immediately by calling the parent's update method.
    */
   public async execute(): Promise<T> {
+    const expectedNewItem = await this.createExpectedNewItem();
+
     if (this.parent.getTimestamps()) {
       const now = new Date().toISOString();
       if (!this.actions.set) {
@@ -285,7 +312,7 @@ export class UpdateBuilder<T> {
     if (this.extraTransactItems.length > 0) {
       // For transactions, we must throw if there's nothing to update
       // since we can't safely skip updates in a transaction
-      const myTransactItem = this.toTransactUpdate();
+      const myTransactItem = await this.toTransactUpdate(expectedNewItem);
       const allItems = [...this.extraTransactItems, myTransactItem];
       await this.parent.getClient().send(
         new TransactWriteCommand({
@@ -297,22 +324,24 @@ export class UpdateBuilder<T> {
       if (result === null) {
         throw new Error("Item not found after transaction update");
       }
-      const rebuiltItem = await this.rebuildIndexes();
-      return this.parent.getSchema().parse(rebuiltItem) as T;
+
+      return result;
     }
 
     // For normal updates, handle empty updates gracefully
     try {
       const { updateExpression, attributeNames, attributeValues } =
-        this.buildExpression();
-      const params: UpdateItemInput = {
+        this.buildExpression(expectedNewItem);
+
+      let params: UpdateCommandInput = {
         TableName: this.parent.getTableName(),
         Key: this.parent.buildKey(this.key),
         UpdateExpression: updateExpression,
         ExpressionAttributeNames: attributeNames,
         ExpressionAttributeValues: attributeValues,
-        ReturnValues: "ALL_NEW",
+        ReturnValues: "ALL_NEW" as ReturnValue,
       };
+
       if (this.condition?.expression) {
         params.ConditionExpression = this.condition.expression;
       }
@@ -322,9 +351,7 @@ export class UpdateBuilder<T> {
       if (!result.Attributes) {
         throw new Error("No attributes returned after update");
       }
-
-      const rebuiltItem = await this.rebuildIndexes();
-      return this.parent.getSchema().parse(rebuiltItem) as T;
+      return this.parent.getSchema().parse(result.Attributes) as T;
     } catch (error) {
       // If there's nothing to update, just return the existing item
       if (

package/test/update.test.ts

@@ -55,6 +55,7 @@ const UserSchema = z.object({
   id: z.string(),
   name: z.string(),
   email: z.string().email(),
+  nickname: z.string().optional(),
   points: z.number().optional(),
   tags: z.set(z.string()).optional(),
 });
@@ -229,7 +230,7 @@ describe("BetterDDB - Update Operation", () => {
     await userDdb.create(newUser).execute();
 
     // Create a second update builder for the transaction
-    const secondUpdate = userDdb
+    const secondUpdate = await userDdb
       .update({ id: "user-456", email: "alice@example.com" })
       .set({ name: "Alice Updated" })
       .toTransactUpdate();
@@ -318,7 +319,7 @@ describe("BetterDDB - Update Operation", () => {
     // First set initial values
     await userDdb
       .update({ id: "user-123", email: "john@example.com" })
-      .set({ name: "John Doe", points: 10 })
+      .set({ name: "John Doe", points: 10, nickname: "John" })
       .execute();
 
     // Update with a mix of values - some to set, some to remove
@@ -327,13 +328,15 @@ describe("BetterDDB - Update Operation", () => {
       .set({
         name: "", // Should trigger remove
         points: undefined, // Should trigger remove
+        nickname: "", // Should trigger remove
         email: "john@example.com", // Should remain (required field)
       })
       .execute();
 
     // Fields should be removed, not null or undefined
-    expect(updatedUser.name).toBeUndefined(); // Removed due to empty string
+    expect(updatedUser.name).toBe(""); // Removed due to empty string
     expect(updatedUser.points).toBeUndefined(); // Removed due to undefined
+    expect(updatedUser.nickname).toBeUndefined(); // Removed due to empty string
     expect(updatedUser.email).toBe("john@example.com"); // Required field remains
 
     // Now let's verify we can still set values normally

package/tsconfig.json

@@ -16,8 +16,8 @@
     "sourceMap": true,
     "composite": true,
     "declarationMap": true,
-    "rootDir": "./src"
+    "rootDir": "."
   },
-  "include": ["src/**/*"],
+  "include": ["src/**/*", "test/**/*"],
   "exclude": ["node_modules", "dist"]
 }