betterddb 0.5.3 → 0.5.4

package/lib/builders/batch-get-builder.js

@@ -16,9 +16,21 @@ class BatchGetBuilder {
      * Returns an array of parsed items of type T.
      */
     async execute() {
+        if (this.keys.length === 0) {
+            return [];
+        }
+        const seen = new Set();
+        const deduplicatedKeys = this.keys.filter((key) => {
+            const keyString = JSON.stringify(key);
+            if (seen.has(keyString)) {
+                return false;
+            }
+            seen.add(keyString);
+            return true;
+        });
         const tableName = this.parent.getTableName();
         // Build an array of keys using the parent's key builder.
-        const keysArray = this.keys.map(key => this.parent.buildKey(key));
+        const keysArray = deduplicatedKeys.map(key => this.parent.buildKey(key));
         // Construct the BatchGet parameters.
         const params = {
             RequestItems: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "betterddb",
-  "version": "0.5.3",
+  "version": "0.5.4",
   "description": "A definition-based DynamoDB wrapper library that provides a schema-driven and fully typesafe DAL.",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",

package/src/builders/batch-get-builder.ts

@@ -14,9 +14,22 @@ export class BatchGetBuilder<T> {
    * Returns an array of parsed items of type T.
    */
   public async execute(): Promise<T[]> {
+    if (this.keys.length === 0) {
+      return [];
+    }
+
+    const seen = new Set();
+    const deduplicatedKeys = this.keys.filter((key) => {
+      const keyString = JSON.stringify(key);
+      if (seen.has(keyString)) {
+        return false;
+      }
+      seen.add(keyString);
+      return true;
+    });
     const tableName = this.parent.getTableName();
     // Build an array of keys using the parent's key builder.
-    const keysArray = this.keys.map(key => this.parent.buildKey(key));
+    const keysArray = deduplicatedKeys.map(key => this.parent.buildKey(key));
 
     // Construct the BatchGet parameters.
     const params: BatchGetItemInput = {

package/test/batch-get.test.ts

@@ -78,4 +78,20 @@ describe('BetterDDB - Get Operation', () => {
     expect(users.some(user => user.id === 'user-123')).toBe(true);
     expect(users.some(user => user.id === 'user-124')).toBe(true);
   });
+
+  it('should retrieve an item using GetBuilder that does not exist', async () => {
+    const users = await userDdb.batchGet([{ id: 'user-123', email: 'jane@example.com' }]).execute();
+    expect(users.length).toEqual(0);
+  });
+
+  it('should return an empty array if no keys are provided', async () => {
+    const users = await userDdb.batchGet([]).execute();
+    expect(users.length).toEqual(0);
+  });
+
+  it('should deduplicate keys', async () => {
+    const users = await userDdb.batchGet([{ id: 'user-123', email: 'john@example.com' }, { id: 'user-123', email: 'john@example.com' }]).execute();
+    expect(users.length).toEqual(1);
+    expect(users[0].id).toEqual('user-123');
+  });
 });