better-review 0.5.0 → 0.5.2

package/README.md

@@ -60,7 +60,7 @@ seulement pour les PR qui me concernent. Recherche GitHub limitée à 1000 résu
 | `WEB_PORT`         | `5173`                         | Port Vite en développement                                                              |
 | `GITHUB_TOKEN`     | `gh auth token`                | Token GitHub                                                                            |
 | `BR_CONFIG_DIR`    | `~/.config/better-review`      | `config.json` (repos / orgs suivis, `staleDays`) — éditable à la main, rechargé à chaud |
-| `BR_DATA_DIR`      | `~/.local/share/better-review` | `state.db` (SQLite : visites, hunks vus, threads lus, cache des diffs)                  |
+| `BR_DATA_DIR`      | `~/.local/share/better-review` | `state.db` (SQLite : visites, hunks vus, commentaires lus, cache des diffs)             |
 | `BR_SESSION_TOKEN` | `BR_DATA_DIR/session-token`    | Jeton de session imposé (scripts, tests)                                                |
 
 ## Raccourcis (vue PR)
@@ -71,13 +71,30 @@ vu suivant), comme le bouton « Vu » d'un fichier · `h` hunk vu · `r` répond
 `?` aide.
 
 Commenter : clic sur un numéro de ligne (« + » au survol), côté ancien code pour une ligne supprimée ou côté
-nouveau code pour une ligne ajoutée, `Maj+clic` pour une plage ; bouton « Commenter » dans l'en-tête d'un fichier
-pour le fichier entier. Chaque commentaire part seul ou dans la review en attente.
+nouveau code pour une ligne ajoutée, `Maj+clic` pour une plage (dans un même hunk) ; bouton « Commenter » dans
+l'en-tête d'un fichier pour le fichier entier. Chaque commentaire part seul ou dans la review en attente. GitHub ne
+place un commentaire que sur une ligne du diff de la PR : dans une plage « depuis ma dernière visite / review » ou un
+commit, seules les lignes du nouveau code que ce diff montre aussi sont commentables.
 
 Réactions emoji (celles de GitHub) sous chaque commentaire, review et la description : clic sur une réaction pour
-ajouter / retirer la mienne, « ☺ » pour en choisir une autre. Les conversations résolues sont repliées (« Afficher N
-messages ») et s'ouvrent quand on y navigue. La CI de l'en-tête met les échecs en avant (détail au clic) et est sondée
-toutes les 15 s tant que des checks tournent.
+ajouter / retirer la mienne, « ☺ » pour en choisir une autre ; au survol, qui a réagi (noms chargés à ce moment-là).
+Les conversations résolues sont repliées (« Afficher N messages ») et s'ouvrent quand on y navigue. La CI de l'en-tête
+met les échecs en avant (détail au clic) et est sondée toutes les 15 s tant que des checks tournent.
+
+Commentaires non lus (liseré orange) : leur bouton « Vu » se remplit pendant le temps de lecture estimé, tant que le
+commentaire est à l'écran ; plein, il passe en « ✓ Vu » et le commentaire est lu (clic : lu tout de suite). Un thread se
+lit dans l'ordre et pas quand il est replié ; répondre le lit jusqu'à la réponse. Ce qui précède ma première visite de la
+PR, ou mon dernier commentaire / ma dernière review, compte comme lu. À l'accueil, « non lue » = jamais visitée, nouveaux
+commits, ou dernier mot d'un autre (thread ou conversation) pas encore lu.
+
+Liens GitHub dans les commentaires, reviews et la description : ils s'ouvrent dans better-review quand c'est possible —
+fichier ou lignes de la PR (`/files#diff-…`, `/blob/<head ou branche>/…#L10-L20`, surlignées en jaune), conversation
+(`#discussion_r…`), commit de la PR, autre PR. Une plage qui ne montre pas la cible passe à « Tous les changements ». Le
+reste (issues, fichiers hors PR, sites externes) s'ouvre dans un nouvel onglet ; Ctrl / Cmd+clic garde le lien GitHub.
+
+Plage : une PR s'ouvre toujours sur « Tous les changements ». « Depuis ma dernière visite / review » se choisit dans
+le sélecteur ; ces deltas sont désactivés quand la branche a été rebasée depuis (l'ancien head n'est plus dans la PR et
+le diff montrerait aussi les changements de la branche cible).
 
 ## Naviguer dans les fichiers
 

package/dist/cli.js

@@ -242,8 +242,8 @@ var recordBodyBufferedBeforeDisconnect = (incoming) => {
   const incomingWithRecovery = incoming;
   incomingWithRecovery[bodyBufferedLengthBeforeDisconnectKey] ??= incoming.readableLength;
 };
-var readBodyBufferedBeforeDisconnect = (incoming, chunks) => {
-  if (incoming.readableDidRead && !chunks || !isRecoverableDisconnectedIncoming(incoming)) return;
+var readBodyBufferedBeforeDisconnect = (incoming, chunks2) => {
+  if (incoming.readableDidRead && !chunks2 || !isRecoverableDisconnectedIncoming(incoming)) return;
   const incomingWithRecovery = incoming;
   if (incomingWithRecovery[bodyBufferedBeforeDisconnectKey] !== void 0) return incomingWithRecovery[bodyBufferedBeforeDisconnectKey];
   let result;
@@ -251,7 +251,7 @@ var readBodyBufferedBeforeDisconnect = (incoming, chunks) => {
   if (errored && errored.code !== "ECONNRESET") result = errored;
   else if (incomingWithRecovery[bodyBufferedLengthBeforeDisconnectKey] !== void 0 && incoming.readableLength !== incomingWithRecovery[bodyBufferedLengthBeforeDisconnectKey]) result = newBodyUnusableError();
   else {
-    const bodyChunks = chunks ?? [];
+    const bodyChunks = chunks2 ?? [];
     const chunk = incoming.read();
     if (chunk !== null) bodyChunks.push(toBufferChunk(chunk, incoming.readableEncoding));
     const buffer = bodyChunks.length === 1 ? bodyChunks[0] : Buffer.concat(bodyChunks);
@@ -427,7 +427,7 @@ var readBodyDirect = (request) => {
     return Promise.resolve(buffered);
   }
   const promise2 = new Promise((resolve, reject) => {
-    const chunks = [];
+    const chunks2 = [];
     let settled = false;
     const finish = (callback) => {
       if (settled) return;
@@ -439,7 +439,7 @@ var readBodyDirect = (request) => {
       const streamError = incoming.errored ?? error62;
       if (!isRecoverableDisconnectedIncoming(incoming) || streamError && streamError.code !== "ECONNRESET") return false;
       finish(() => {
-        const recovered = readBodyBufferedBeforeDisconnect(incoming, chunks);
+        const recovered = readBodyBufferedBeforeDisconnect(incoming, chunks2);
         if (recovered instanceof Error) reject(recovered);
         else if (recovered === void 0) reject(error62 ?? normalizeAbortError(request, incoming));
         else {
@@ -450,11 +450,11 @@ var readBodyDirect = (request) => {
       return true;
     };
     const onData = (chunk) => {
-      chunks.push(toBufferChunk(chunk, incoming.readableEncoding));
+      chunks2.push(toBufferChunk(chunk, incoming.readableEncoding));
     };
     const onEnd = () => {
       finish(() => {
-        const buffer = chunks.length === 1 ? chunks[0] : Buffer.concat(chunks);
+        const buffer = chunks2.length === 1 ? chunks2[0] : Buffer.concat(chunks2);
         request[bodyBufferKey] = buffer;
         resolve(buffer);
       });
@@ -25806,6 +25806,28 @@ var REACTION_FIELDS = (
   }
 `
 );
+var REACTORS_QUERY = (
+  /* GraphQL */
+  `
+  query Reactors($id: ID!, $first: Int!) {
+    node(id: $id) {
+      ... on Reactable {
+        reactionGroups {
+          content
+          reactors(first: $first) {
+            totalCount
+            nodes {
+              ... on Actor {
+                login
+              }
+            }
+          }
+        }
+      }
+    }
+  }
+`
+);
 var REVIEW_COMMENT_FIELDS = (
   /* GraphQL */
   `
@@ -26214,6 +26236,7 @@ var CHECKS_QUERY = (
         ${CHECKS_FIELDS}
         reviewThreads(first: 100) {
           nodes {
+            id
             isResolved
           }
         }
@@ -26234,12 +26257,14 @@ var DETAILS_QUERY = (
         ${CHECKS_FIELDS}
         viewerLatestReview {
           state
+          submittedAt
           commit {
             oid
           }
         }
         comments(last: 1) {
           nodes {
+            id
             author {
               login
             }
@@ -26248,9 +26273,11 @@ var DETAILS_QUERY = (
         }
         reviewThreads(first: 100) {
           nodes {
+            id
             isResolved
             comments(last: 1) {
               nodes {
+                id
                 author {
                   login
                 }
@@ -26314,6 +26341,14 @@ var INBOX_FINGERPRINT_QUERY = (
 `
 );
 
+// ../server/src/readState.ts
+function readBaseline(firstVisitAt, myActivity) {
+  if (firstVisitAt === null) return Number.POSITIVE_INFINITY;
+  let at = firstVisitAt;
+  for (const date5 of myActivity) if (date5) at = Math.max(at, Date.parse(date5));
+  return at;
+}
+
 // ../server/src/inbox.ts
 var MERGED_WINDOW_MS = 24 * 36e5;
 function scopeTerms(config2) {
@@ -26322,9 +26357,9 @@ function scopeTerms(config2) {
 var SCOPE_CHUNK = 20;
 function scopeChunks(config2) {
   const terms = scopeTerms(config2);
-  const chunks = [];
-  for (let i = 0; i < terms.length; i += SCOPE_CHUNK) chunks.push(terms.slice(i, i + SCOPE_CHUNK).join(" "));
-  return chunks;
+  const chunks2 = [];
+  for (let i = 0; i < terms.length; i += SCOPE_CHUNK) chunks2.push(terms.slice(i, i + SCOPE_CHUNK).join(" "));
+  return chunks2;
 }
 function searchQueries(scope, mergedSince) {
   const open2 = `is:pr is:open archived:false ${scope}`;
@@ -26344,27 +26379,35 @@ function isApproved(decision, states) {
   if (decision !== null) return decision === "APPROVED";
   return states.includes("APPROVED") && !states.includes("CHANGES_REQUESTED");
 }
-function toInboxPr(node2, me, visit2) {
+function toInboxPr(node2, me, reads) {
   const [owner = "", repo = ""] = node2.repository.nameWithOwner.split("/");
+  const key = prKey(owner, repo, node2.number);
+  const visit2 = reads.lastVisits.get(key);
+  const myReview = node2.viewerLatestReview;
+  const lastComment = node2.comments?.nodes[0];
+  const lastInThreads = (node2.reviewThreads?.nodes ?? []).flatMap((t2) => {
+    const last = t2.comments?.nodes[0];
+    return last ? [{ threadId: t2.id, last }] : [];
+  });
+  const isMine = (c) => c.author?.login === me;
+  const baseline = readBaseline(reads.firstVisits.get(key) ?? null, [
+    myReview?.submittedAt ?? null,
+    ...lastInThreads.filter(({ last }) => isMine(last)).map(({ last }) => last.createdAt),
+    ...lastComment && isMine(lastComment) ? [lastComment.createdAt] : []
+  ]);
+  const unreadBy = (c, read) => !isMine(c) && Date.parse(c.createdAt) > baseline && !read;
+  const unreadComment = lastInThreads.some(({ threadId, last }) => unreadBy(last, reads.threads.get(threadId) === last.id)) || lastComment !== void 0 && unreadBy(lastComment, reads.entries.has(lastComment.id));
   let threads;
-  let lastOtherActivity = 0;
   if (node2.reviewThreads) {
     threads = { total: node2.reviewThreads.nodes.length, open: 0, awaitingMyReply: 0 };
     for (const thread of node2.reviewThreads.nodes) {
       const last = thread.comments?.nodes[0];
-      const lastIsOther = last?.author?.login !== me;
       if (!thread.isResolved) {
         threads.open++;
-        if (last && lastIsOther) threads.awaitingMyReply++;
+        if (last && !isMine(last)) threads.awaitingMyReply++;
       }
-      if (last && lastIsOther) lastOtherActivity = Math.max(lastOtherActivity, Date.parse(last.createdAt));
     }
   }
-  const lastComment = node2.comments?.nodes[0];
-  if (lastComment && lastComment.author?.login !== me) {
-    lastOtherActivity = Math.max(lastOtherActivity, Date.parse(lastComment.createdAt));
-  }
-  const myReview = node2.viewerLatestReview;
   return {
     id: node2.id,
     owner,
@@ -26400,7 +26443,7 @@ function toInboxPr(node2, me, visit2) {
       }
     } : {},
     lastVisitAt: visit2?.visitedAt ?? null,
-    unread: !visit2 || visit2.headOid !== node2.headRefOid || lastOtherActivity > visit2.visitedAt
+    unread: !visit2 || visit2.headOid !== node2.headRefOid || unreadComment
   };
 }
 function stageOf(pr) {
@@ -26417,12 +26460,11 @@ function stageOf(pr) {
   const reviewed = pr.reviewDecision === "CHANGES_REQUESTED" || pr.reviewCount > 0 || pr.reviews.length > 0 || (pr.threads?.total ?? 0) > 0;
   return reviewed ? "review" : "waiting";
 }
-function buildBoard(sources, me, visits, staleBefore) {
+function buildBoard(sources, me, reads, staleBefore) {
   const nodes = /* @__PURE__ */ new Map();
   for (const node2 of [...sources.open, ...sources.merged]) nodes.set(node2.id, node2);
   const prs = [...nodes.values()].map((node2) => {
-    const [owner = "", repo = ""] = node2.repository.nameWithOwner.split("/");
-    const pr = toInboxPr(node2, me, visits.get(prKey(owner, repo, node2.number)));
+    const pr = toInboxPr(node2, me, reads);
     const stage = stageOf(pr);
     const mine = pr.author?.login === me;
     const tags = mine ? ["mine"] : [];
@@ -26535,18 +26577,29 @@ async function loadSources(gh, config2, now) {
     sources: { open: nodesOf(openIds), merged: nodesOf(mergedIds), requested, involved }
   };
 }
-async function loadInbox(gh, config2, viewerFallback, lastVisits) {
+async function loadInbox(gh, config2, viewerFallback, store) {
   const now = Date.now();
   const { viewer: viewer2, truncated, sources } = await loadSources(gh, config2, now);
   const me = viewer2 ?? await viewerFallback();
-  const keys = [...sources.open, ...sources.merged].map((n) => {
-    const [owner = "", repo = ""] = n.repository.nameWithOwner.split("/");
-    return prKey(owner, repo, n.number);
-  });
+  const all = [...sources.open, ...sources.merged];
+  const keys = [
+    ...new Set(
+      all.map((n) => {
+        const [owner = "", repo = ""] = n.repository.nameWithOwner.split("/");
+        return prKey(owner, repo, n.number);
+      })
+    )
+  ];
+  const reads = {
+    lastVisits: store.lastVisits(keys),
+    firstVisits: store.firstVisits(keys),
+    threads: store.threadReads(all.flatMap((n) => n.reviewThreads?.nodes.map((t2) => t2.id) ?? [])),
+    entries: store.entryReads(all.flatMap((n) => n.comments?.nodes.map((c) => c.id) ?? []))
+  };
   return {
     viewer: me,
     configured: config2.repos.length + config2.orgs.length > 0,
-    prs: buildBoard(sources, me.login, lastVisits([...new Set(keys)]), now - config2.staleDays * 864e5),
+    prs: buildBoard(sources, me.login, reads, now - config2.staleDays * 864e5),
     truncated,
     fetchedAt: now
   };
@@ -26597,11 +26650,19 @@ async function loadPr(gh, store, ref) {
     )
   ]);
   const reads = store.threadReads(threadNodes.map((t2) => t2.id));
+  const entryIds = [...pr.comments.nodes.map((c) => c.id), ...pr.reviews.nodes.map((r) => r.id)];
+  const entriesRead = store.entryReads(entryIds);
   const visits = store.visits(key);
-  const lastVisitAt = visits[0]?.visitedAt ?? 0;
   const seenCommits = store.seenCommits(key);
   const pending = pr.reviews.nodes.find((r) => r.state === "PENDING" && r.author?.login === me) ?? null;
-  const threads = threadNodes.map((t2) => toThread(t2, me, reads.get(t2.id)));
+  const mine = (author) => author?.login === me;
+  const baseline = readBaseline(store.firstVisits([key]).get(key) ?? null, [
+    ...threadNodes.flatMap((t2) => t2.comments.nodes.filter((c) => mine(c.author)).map((c) => c.createdAt)),
+    ...pr.comments.nodes.filter((c) => mine(c.author)).map((c) => c.createdAt),
+    ...pr.reviews.nodes.filter((r) => r.state !== "PENDING" && mine(r.author)).map((r) => r.submittedAt)
+  ]);
+  const entryUnread = (id, author, createdAt) => !mine(author) && Date.parse(createdAt) > baseline && !entriesRead.has(id);
+  const threads = threadNodes.map((t2) => toThread(t2, me, { lastReadId: reads.get(t2.id), baseline }));
   const pendingComments = threads.reduce((n, t2) => n + t2.comments.filter((c) => c.pending).length, 0);
   const reviewers = /* @__PURE__ */ new Map();
   for (const r of pr.latestOpinionatedReviews.nodes) {
@@ -26624,7 +26685,7 @@ async function loadPr(gh, store, ref) {
       reactions: toReactions(c.reactionGroups),
       createdAt: c.createdAt,
       author: c.author,
-      unread: c.author?.login !== me && Date.parse(c.createdAt) > lastVisitAt
+      unread: entryUnread(c.id, c.author, c.createdAt)
     })),
     ...pr.reviews.nodes.filter((r) => r.state !== "PENDING" && (r.body.trim() !== "" || r.state !== "COMMENTED")).map((r) => ({
       kind: "review",
@@ -26636,7 +26697,7 @@ async function loadPr(gh, store, ref) {
       reactions: toReactions(r.reactionGroups),
       createdAt: r.submittedAt ?? r.createdAt,
       author: r.author,
-      unread: r.author?.login !== me && Date.parse(r.submittedAt ?? r.createdAt) > lastVisitAt
+      unread: entryUnread(r.id, r.author, r.submittedAt ?? r.createdAt)
     }))
   ].sort((a, b) => a.createdAt.localeCompare(b.createdAt));
   return {
@@ -26702,6 +26763,19 @@ async function loadPr(gh, store, ref) {
 function toReactions(groups) {
   return (groups ?? []).filter((g) => g.reactors.totalCount > 0).map((g) => ({ content: g.content, count: g.reactors.totalCount, mine: g.viewerHasReacted }));
 }
+var REACTORS_SHOWN = 20;
+async function loadReactors(gh, subjectId) {
+  const data = await gh.graphql(REACTORS_QUERY, {
+    id: subjectId,
+    first: REACTORS_SHOWN
+  });
+  return (data.node?.reactionGroups ?? []).filter((g) => g.reactors.totalCount > 0).map((g) => ({
+    content: g.content,
+    // Deleted accounts come back null.
+    logins: g.reactors.nodes.flatMap((n) => n?.login ? [n.login] : []),
+    total: g.reactors.totalCount
+  }));
+}
 function toComment(c) {
   return {
     id: c.id,
@@ -26712,16 +26786,19 @@ function toComment(c) {
     reactions: toReactions(c.reactionGroups),
     createdAt: c.createdAt,
     author: c.author,
+    unread: false,
     pending: c.state === "PENDING",
     originalCommitOid: c.originalCommit?.oid ?? null,
     canUpdate: c.viewerCanUpdate,
     canDelete: c.viewerCanDelete
   };
 }
-function toThread(t2, me, lastReadId) {
-  const comments = t2.comments.nodes.map(toComment);
-  const readIdx = lastReadId ? comments.findIndex((c) => c.id === lastReadId) : -1;
-  const unread = comments.slice(readIdx + 1).filter((c) => c.author?.login !== me).length;
+function toThread(t2, me, read) {
+  const readIdx = read.lastReadId ? t2.comments.nodes.findIndex((c) => c.id === read.lastReadId) : -1;
+  const comments = t2.comments.nodes.map((node2, i) => ({
+    ...toComment(node2),
+    unread: i > readIdx && node2.author?.login !== me && node2.state !== "PENDING" && Date.parse(node2.createdAt) > read.baseline
+  }));
   return {
     id: t2.id,
     path: t2.path,
@@ -26739,8 +26816,7 @@ function toThread(t2, me, lastReadId) {
     canReply: t2.viewerCanReply,
     diffHunk: t2.comments.nodes[0]?.diffHunk ?? "",
     comments,
-    unread,
-    lastReadCommentId: readIdx === -1 ? null : lastReadId ?? null,
+    unread: comments.filter((c) => c.unread).length,
     pending: comments.length > 0 && comments.every((c) => c.pending)
   };
 }
@@ -26901,12 +26977,21 @@ async function addThread(gh, prId, pendingReviewId, thread, mode) {
       ${THREAD_FIELDS}`,
       { input: { pullRequestReviewId: reviewId, ...threadInput(thread) } }
     );
+    if (!data.addPullRequestReviewThread.thread) {
+      throw new GitHubError(
+        `GitHub n\u2019a pas pu placer le commentaire sur ${thread.path} : position hors du diff de la PR.`,
+        422
+      );
+    }
     node2 = data.addPullRequestReviewThread.thread;
   } catch (error62) {
     if (!pendingReviewId) await discardReview(gh, reviewId).catch(() => void 0);
     throw error62;
   }
-  const created = toThread(node2, "", node2.comments.nodes.at(-1)?.id);
+  const created = toThread(node2, "", {
+    lastReadId: node2.comments.nodes.at(-1)?.id,
+    baseline: Number.POSITIVE_INFINITY
+  });
   if (mode === "review") return { thread: created, pendingReviewId: reviewId };
   await submitReview(gh, prId, reviewId, "COMMENT", "");
   return {
@@ -28492,14 +28577,7 @@ var configRouter = router({
   remove: procedure.input(trackedEntrySchema).mutation(({ ctx, input: input2 }) => ctx.config.remove(input2))
 });
 var inboxRouter = router({
-  get: procedure.query(
-    ({ ctx }) => loadInbox(
-      ctx.gh,
-      ctx.config.get(),
-      () => viewer(ctx),
-      (keys) => ctx.store.lastVisits(keys)
-    )
-  ),
+  get: procedure.query(({ ctx }) => loadInbox(ctx.gh, ctx.config.get(), () => viewer(ctx), ctx.store)),
   onChange: procedure.subscription(async function* ({ ctx, signal }) {
     yield* pollChanges(
       INBOX_POLL_MS,
@@ -28543,6 +28621,9 @@ var prRouter = router({
   markThreadsRead: procedure.input(external_exports.array(external_exports.object({ threadId: external_exports.string(), lastCommentId: external_exports.string() }))).mutation(({ ctx, input: input2 }) => {
     ctx.store.markThreadsRead(input2);
   }),
+  markEntriesRead: procedure.input(external_exports.array(external_exports.string()).min(1)).mutation(({ ctx, input: input2 }) => {
+    ctx.store.markEntriesRead(input2);
+  }),
   reply: procedure.input(
     external_exports.object({
       threadId: external_exports.string(),
@@ -28554,6 +28635,7 @@ var prRouter = router({
   ),
   setResolved: procedure.input(external_exports.object({ threadId: external_exports.string(), resolved: external_exports.boolean() })).mutation(({ ctx, input: input2 }) => setThreadResolved(ctx.gh, input2.threadId, input2.resolved)),
   react: procedure.input(external_exports.object({ subjectId: external_exports.string(), content: reactionContentSchema, on: external_exports.boolean() })).mutation(({ ctx, input: input2 }) => setReaction(ctx.gh, input2.subjectId, input2.content, input2.on)),
+  reactors: procedure.input(external_exports.object({ subjectId: external_exports.string() })).query(({ ctx, input: input2 }) => loadReactors(ctx.gh, input2.subjectId)),
   addThread: procedure.input(
     external_exports.object({
       prId: external_exports.string(),
@@ -28763,8 +28845,24 @@ var MIGRATIONS = [
      thread_id TEXT PRIMARY KEY,
      last_comment_id TEXT NOT NULL,
      read_at INTEGER NOT NULL
-   );`
+   );`,
+  // Read state of conversation entries (PR comments, reviews); first visit as the « already read » line.
+  `CREATE TABLE entry_read (
+     subject_id TEXT PRIMARY KEY,
+     read_at INTEGER NOT NULL
+   );
+   CREATE TABLE pr_first_visit (
+     pr_key TEXT PRIMARY KEY,
+     visited_at INTEGER NOT NULL
+   );
+   INSERT INTO pr_first_visit (pr_key, visited_at) SELECT pr_key, MIN(visited_at) FROM pr_visit GROUP BY pr_key;`
 ];
+var IN_CHUNK = 500;
+function chunks(items) {
+  const out = [];
+  for (let i = 0; i < items.length; i += IN_CHUNK) out.push(items.slice(i, i + IN_CHUNK));
+  return out;
+}
 var Store = class {
   db;
   constructor(dir) {
@@ -28803,8 +28901,10 @@ var Store = class {
   }
   recordVisit(prKey2, headOid, commitOids) {
     this.db.exec("BEGIN");
+    const now = Date.now();
     try {
-      this.db.prepare("INSERT OR REPLACE INTO pr_visit (pr_key, head_oid, visited_at) VALUES (?, ?, ?)").run(prKey2, headOid, Date.now());
+      this.db.prepare("INSERT OR REPLACE INTO pr_visit (pr_key, head_oid, visited_at) VALUES (?, ?, ?)").run(prKey2, headOid, now);
+      this.db.prepare("INSERT OR IGNORE INTO pr_first_visit (pr_key, visited_at) VALUES (?, ?)").run(prKey2, now);
       const insert = this.db.prepare("INSERT OR IGNORE INTO commit_seen (pr_key, oid) VALUES (?, ?)");
       for (const oid of commitOids) insert.run(prKey2, oid);
       this.db.exec("COMMIT");
@@ -28837,13 +28937,26 @@ ${r.hash}`);
       throw error62;
     }
   }
+  /** First visit per PR in better-review: what was there before counts as read. */
+  firstVisits(prKeys) {
+    const result = /* @__PURE__ */ new Map();
+    for (const keys of chunks(prKeys)) {
+      const rows = this.db.prepare(
+        `SELECT pr_key, visited_at FROM pr_first_visit WHERE pr_key IN (${keys.map(() => "?").join(",")})`
+      ).all(...keys);
+      for (const row of rows) result.set(row.pr_key, row.visited_at);
+    }
+    return result;
+  }
+  /** Last comment read per thread. */
   threadReads(threadIds) {
     const result = /* @__PURE__ */ new Map();
-    if (threadIds.length === 0) return result;
-    const rows = this.db.prepare(
-      `SELECT thread_id, last_comment_id FROM thread_read WHERE thread_id IN (${threadIds.map(() => "?").join(",")})`
-    ).all(...threadIds);
-    for (const row of rows) result.set(row.thread_id, row.last_comment_id);
+    for (const ids of chunks(threadIds)) {
+      const rows = this.db.prepare(
+        `SELECT thread_id, last_comment_id FROM thread_read WHERE thread_id IN (${ids.map(() => "?").join(",")})`
+      ).all(...ids);
+      for (const row of rows) result.set(row.thread_id, row.last_comment_id);
+    }
     return result;
   }
   markThreadsRead(items) {
@@ -28853,6 +28966,20 @@ ${r.hash}`);
     const now = Date.now();
     for (const item of items) stmt.run(item.threadId, item.lastCommentId, now);
   }
+  /** Conversation entries (PR comments, reviews) read among `ids`. */
+  entryReads(ids) {
+    const result = /* @__PURE__ */ new Set();
+    for (const chunk of chunks(ids)) {
+      const rows = this.db.prepare(`SELECT subject_id FROM entry_read WHERE subject_id IN (${chunk.map(() => "?").join(",")})`).all(...chunk);
+      for (const row of rows) result.add(row.subject_id);
+    }
+    return result;
+  }
+  markEntriesRead(ids) {
+    const stmt = this.db.prepare("INSERT OR IGNORE INTO entry_read (subject_id, read_at) VALUES (?, ?)");
+    const now = Date.now();
+    for (const id of ids) stmt.run(id, now);
+  }
 };
 
 // ../server/src/env.ts