better-auth-firestore 1.2.3 → 1.2.5

package/dist/firebase-adapter.js

@@ -215,6 +215,39 @@ function normalizeWriteData(model, data) {
         return data;
     return normalizeSessionWriteData(data);
 }
+/**
+ * Build a Firestore-safe write payload from a normalized data object.
+ *
+ * - Maps app field names to their Firestore-side names via `mapper`.
+ * - Skips `undefined` values. The Firestore Admin SDK rejects writes that
+ *   contain `undefined` unless the client was initialized with
+ *   `ignoreUndefinedProperties: true`, and better-auth routinely emits
+ *   optional-undefined fields (e.g. `image` on email/password sign-up).
+ *   Stripping here lets the adapter work with any user-supplied Firestore
+ *   instance, not just ones we initialize.
+ * - Routes a string `id` field out as `idOverride` so create callers can
+ *   set it on the document reference instead of writing it into the body.
+ *   For updates the caller can simply ignore `idOverride` — you cannot
+ *   change a Firestore document ID by writing to a field.
+ *
+ * `null` is preserved deliberately: Firestore accepts null and callers may
+ * use it to explicitly clear a field.
+ */
+function buildFirestoreWriteData(data, mapper) {
+    const docData = {};
+    let idOverride;
+    for (const [k, v] of Object.entries(data)) {
+        if (v === undefined)
+            continue;
+        if (k === "id") {
+            if (typeof v === "string" && v)
+                idOverride = v;
+            continue;
+        }
+        docData[mapper.toDb(k)] = v;
+    }
+    return { docData, idOverride };
+}
 export const firestoreAdapter = (config = {}) => {
     const db = resolveDb(config);
     const { namingStrategy = "default", collections: collectionsOverride = {}, debugLogs = false, } = (config && config.collection
@@ -237,16 +270,9 @@ export const firestoreAdapter = (config = {}) => {
                     const txAdapter = {
                         create: async ({ model, data }) => {
                             const col = getCollectionRef(db, model, collections);
-                            let ref = col.doc();
                             const normalizedData = normalizeWriteData(model, data);
-                            const docData = {};
-                            for (const [k, v] of Object.entries(normalizedData)) {
-                                if (k === "id" && v) {
-                                    ref = col.doc(v);
-                                    continue;
-                                }
-                                docData[mapper.toDb(k)] = v;
-                            }
+                            const { docData, idOverride } = buildFirestoreWriteData(normalizedData, mapper);
+                            const ref = idOverride ? col.doc(idOverride) : col.doc();
                             transaction.set(ref, docData);
                             return { ...normalizedData, id: ref.id };
                         },
@@ -263,10 +289,7 @@ export const firestoreAdapter = (config = {}) => {
                             if (!doc)
                                 return null;
                             const normalizedUpdate = normalizeWriteData(model, update);
-                            const updateData = {};
-                            for (const [k, v] of Object.entries(normalizedUpdate)) {
-                                updateData[mapper.toDb(k)] = v;
-                            }
+                            const { docData: updateData } = buildFirestoreWriteData(normalizedUpdate, mapper);
                             transaction.update(doc.ref, updateData);
                             const existing = doc.data();
                             const result = { id: doc.id };
@@ -307,16 +330,9 @@ export const firestoreAdapter = (config = {}) => {
             return {
                 create: async ({ model, data }) => {
                     const col = getCollectionRef(db, model, collections);
-                    let ref = col.doc();
                     const normalizedData = normalizeWriteData(model, data);
-                    const docData = {};
-                    for (const [k, v] of Object.entries(normalizedData)) {
-                        if (k === "id" && v) {
-                            ref = col.doc(v);
-                            continue;
-                        }
-                        docData[mapper.toDb(k)] = v;
-                    }
+                    const { docData, idOverride } = buildFirestoreWriteData(normalizedData, mapper);
+                    const ref = idOverride ? col.doc(idOverride) : col.doc();
                     if (debugLogs) {
                         console.log(`[Firestore Adapter] CREATE ${model}:`, {
                             input: data,
@@ -378,10 +394,7 @@ export const firestoreAdapter = (config = {}) => {
                             }
                             return null;
                         }
-                        const updateData = {};
-                        for (const [k, v] of Object.entries(normalizedUpdate)) {
-                            updateData[mapper.toDb(k)] = v;
-                        }
+                        const { docData: updateData } = buildFirestoreWriteData(normalizedUpdate, mapper);
                         if (debugLogs) {
                             console.log(`[Firestore Adapter] UPDATE ${model} - updateData:`, updateData);
                         }
@@ -421,10 +434,7 @@ export const firestoreAdapter = (config = {}) => {
                         }
                         return null;
                     }
-                    const updateData = {};
-                    for (const [k, v] of Object.entries(normalizedUpdate)) {
-                        updateData[mapper.toDb(k)] = v;
-                    }
+                    const { docData: updateData } = buildFirestoreWriteData(normalizedUpdate, mapper);
                     if (debugLogs) {
                         console.log(`[Firestore Adapter] UPDATE ${model} - updateData:`, updateData);
                     }
@@ -448,10 +458,7 @@ export const firestoreAdapter = (config = {}) => {
                     let count = 0;
                     const seenDocIds = new Set();
                     const normalizedUpdate = normalizeWriteData(model, update);
-                    const updateData = {};
-                    for (const [k, v] of Object.entries(normalizedUpdate)) {
-                        updateData[mapper.toDb(k)] = v;
-                    }
+                    const { docData: updateData } = buildFirestoreWriteData(normalizedUpdate, mapper);
                     for (const whereClause of getChunkedWhereClauses(where)) {
                         const q = applyWhereClause(col, whereClause, mapper);
                         const snap = await q.get();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "better-auth-firestore",
-  "version": "1.2.3",
+  "version": "1.2.5",
   "private": false,
   "description": "Firestore adapter for Better Auth (Firebase Admin SDK)",
   "author": "Slava Yultyyev <yultyyev@gmail.com>",