bestax-migrate 2.3.3 → 2.3.5

package/dist/sources/_shared/polymorphic.d.ts

@@ -48,8 +48,6 @@ export declare function declaresAs(target: string): boolean;
 /** The rows the type test holds to the library. */
 export declare const HREF_TABLE: Record<string, string>;
 export declare const AS_ANY_TARGETS: readonly string[];
-/** The rows the type test holds to the library. */
-export declare const TARGET_LINK_ATTR_TABLE: Record<string, readonly string[]>;
 /**
  * The intrinsic elements React types an `href` onto.
  *

package/dist/sources/_shared/polymorphic.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"polymorphic.d.ts","sourceRoot":"","sources":["../../../src/sources/_shared/polymorphic.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;GA0BG;AAEH,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,EAML,KAAK,gBAAgB,EACtB,MAAM,gBAAgB,CAAC;AA0BxB,eAAO,MAAM,SAAS,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAAkB,CAAC;AAmK3E;;;;;;;;;;;;;GAaG;AACH,eAAO,MAAM,WAAW,GACtB,UAAU,MAAM,GAAG,SAAS,EAC5B,eAAa,KACZ,MAmBF,CAAC;AAMF,oDAAoD;AACpD,wBAAgB,UAAU,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAElD;AAQD,mDAAmD;AACnD,eAAO,MAAM,UAAU,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAW,CAAC;AAC1D,eAAO,MAAM,cAAc,EAAE,SAAS,MAAM,EAAuB,CAAC;AAuEpE,mDAAmD;AACnD,eAAO,MAAM,sBAAsB,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAClD,CAAC;AAEpB;;;;;;;GAOG;AACH,eAAO,MAAM,aAAa,EAAE,SAAS,MAAM,EAAkC,CAAC;AAE9E;;;;;;;;;;GAUG;AACH,eAAO,MAAM,eAAe,EAAE,SAAS,MAAM,EAwH5C,CAAC;AAEF;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAEnD;AASD,sFAAsF;AACtF,wBAAgB,oBAAoB,CAAC,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,GAAG,OAAO,CAG3E;AAED,0DAA0D;AAC1D,eAAO,MAAM,UAAU,EAAE,SAAS,MAAM,EAAoC,CAAC;AAE7E,6CAA6C;AAC7C,eAAO,MAAM,eAAe,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAC1C,CAAC;AAuLrB;;;GAGG;AACH,wBAAgB,uBAAuB,CACrC,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,MAAM,EAAE,MAAM;AACd;;;;;;;;;GASG;AACH,gBAAgB,UAAQ,GACvB,IAAI,CAsEN"}
+{"version":3,"file":"polymorphic.d.ts","sourceRoot":"","sources":["../../../src/sources/_shared/polymorphic.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;GA0BG;AAEH,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,EAML,KAAK,gBAAgB,EACtB,MAAM,gBAAgB,CAAC;AA0BxB,eAAO,MAAM,SAAS,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAAkB,CAAC;AAkK3E;;;;;;;;;;;;;GAaG;AACH,eAAO,MAAM,WAAW,GACtB,UAAU,MAAM,GAAG,SAAS,EAC5B,eAAa,KACZ,MAmBF,CAAC;AAMF,oDAAoD;AACpD,wBAAgB,UAAU,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAElD;AAQD,mDAAmD;AACnD,eAAO,MAAM,UAAU,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAW,CAAC;AAC1D,eAAO,MAAM,cAAc,EAAE,SAAS,MAAM,EAAuB,CAAC;AAkEpE;;;;;;;GAOG;AACH,eAAO,MAAM,aAAa,EAAE,SAAS,MAAM,EAAkC,CAAC;AAE9E;;;;;;;;;;GAUG;AACH,eAAO,MAAM,eAAe,EAAE,SAAS,MAAM,EAwH5C,CAAC;AAEF;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAEnD;AASD,sFAAsF;AACtF,wBAAgB,oBAAoB,CAAC,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,GAAG,OAAO,CAG3E;AAED,0DAA0D;AAC1D,eAAO,MAAM,UAAU,EAAE,SAAS,MAAM,EAAoC,CAAC;AAE7E,6CAA6C;AAC7C,eAAO,MAAM,eAAe,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAC1C,CAAC;AAqLrB;;;GAGG;AACH,wBAAgB,uBAAuB,CACrC,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,MAAM,EAAE,MAAM;AACd;;;;;;;;;GASG;AACH,gBAAgB,UAAQ,GACvB,IAAI,CAsEN"}

package/dist/sources/_shared/polymorphic.js

@@ -78,8 +78,7 @@ const AS_ANY = new Set(['Button', 'Menu.Item', 'Navbar.Item', 'Navbar.Link']);
  * typechecking cannot answer the question on its own. `Level.Item` declares
  * `href` on its props at every `as`, so `<Level.Item href="/x">` compiles --
  * but it renders a <div> and forwards `href` only when the tag is an `<a>`
- * (`bulma-ui/src/layout/Level.tsx:227`), so the attribute is dropped at
- * runtime. A table built from the types alone calls that supported; it is the
+ * (`LevelItem`'s anchor branch), so the attribute is dropped at runtime. A table built from the types alone calls that supported; it is the
  * same dead attribute this pass exists to remove.
  */
 const HREF_OK = {
@@ -252,7 +251,7 @@ export const AS_ANY_TARGETS = [...AS_ANY].sort();
  *
  * They are excluded because the components disagree about what they forward,
  * so no shared set is right. `Menu.Item` strips `href` unless the tag is an
- * `<a>` or a custom component (`bulma-ui/src/components/Menu.tsx:212-222`),
+ * `<a>` or a custom component (`MenuItem`'s `isLinkLike` guard),
  * while `Button` routes everything but `'button'` through its anchor path and
  * would forward it. Keeping `href` beside `as="area"` therefore typechecks on
  * both and does nothing on one of them, which is the silently-dead attribute
@@ -271,6 +270,20 @@ const ANCHOR = 'a';
  * `<Navbar.Link as="span" target="_blank">`, which does not compile either --
  * and the check has to run whether or not an `href` was there to start with,
  * since that shape is just as invalid without one.
+ *
+ * bulma-ui answers the same question from the other side, in
+ * `bulma-ui/src/helpers/anchorAttrs.ts`: which attributes an `<a>` adds over any
+ * element, subtracted from React's types rather than listed. The two are NOT
+ * interchangeable and neither derives from the other -- that set is per
+ * ATTRIBUTE, this table is per attribute per ELEMENT, because a codemod meets
+ * tags a component never renders.
+ *
+ * They also do not always AGREE, which is worth stating rather than asserting
+ * away: this package strips `target` from `<Menu.Item as="span">` where the
+ * component forwards it, because the codemod removes what the element cannot use
+ * while `Menu.Item` withholds `href` alone. A change to either still wants a look
+ * at the other, and #682 put bulma-ui's copy in one place so there is a single
+ * thing to look at.
  */
 const LINK_ATTR_ELEMENTS = {
     target: ['a', 'area', 'base', 'form'],
@@ -291,26 +304,6 @@ const LINK_ATTR_ELEMENTS = {
 // `rel` is deliberately absent: React declares it on `HTMLAttributes`, so it
 // is valid on every intrinsic and there is nothing to remove. The same point
 // `bulma-ui/src/__typetests__/polymorphic.tsx` makes about it.
-/**
- * The link attributes a target accepts, where its props do not follow `as`.
- *
- * Most components here either follow `as` (the element decides, above) or
- * extend `AnchorHTMLAttributes` outright (`Pagination.*`, `Panel.Block`, so
- * everything is fine). `Level.Item` is the exception that enumerates: it
- * declares `href`, `target` and `rel` and nothing else, so `download`,
- * `hrefLang`, `ping` and `referrerPolicy` are type errors there even at
- * `as="a"`.
- *
- * A target absent from `HREF_OK` needs no row: a component that takes no
- * `href` at any `as` takes none of its siblings either -- verified for
- * `Card.FooterItem`, `Tabs.Item` and `Delete`, which is why this is derived
- * from that table rather than being a second list to keep.
- */
-const TARGET_LINK_ATTRS = {
-    'Level.Item': ['target'],
-};
-/** The rows the type test holds to the library. */
-export const TARGET_LINK_ATTR_TABLE = TARGET_LINK_ATTRS;
 /**
  * The intrinsic elements React types an `href` onto.
  *
@@ -565,22 +558,21 @@ function dropInertHref(ctx, path, element, target, literal, elementKnown) {
  */
 function dropInertLinkAttrs(ctx, path, element, target, rendered) {
     const carriesLinks = HREF_OK[target] !== undefined;
-    const declared = TARGET_LINK_ATTRS[target];
     for (const name of LINK_ATTRS) {
-        // Both have to allow it. A target that enumerates its props can be
-        // narrower than the element, and the element can be narrower than the
-        // target: `Level.Item` declares `target` but forwards it only when the
-        // tag is an `<a>`, so `<Level.Item as="p" target="_blank">` was keeping
-        // the same inert attribute this pass removes everywhere else.
-        // Which check rejects it decides both the outcome and what the TODO says.
-        // Keying the message off "the target has a row" instead told a
-        // `<Level.Item as="p" target>` reader that `Level.Item` does not declare
-        // `target` -- it does; the <p> is what refuses it.
+        // Two ways to refuse it, and which one decides the TODO's wording. The
+        // component refuses outright if it is no link at any `as`. Otherwise the
+        // ELEMENT decides — `Level.Item` declares `target` and forwards it only for
+        // an `<a>`, so `<Level.Item as="p" target="_blank">` would keep the same
+        // inert attribute this pass removes everywhere else, and the message has to
+        // say the `<p>` refused it rather than that the component did.
+        //
+        // There used to be a third way: a per-target table for a component that
+        // enumerated a SUBSET of the link attributes and was therefore narrower
+        // than its own element. Nothing is, since #672, so the table went with the
+        // branch that read it.
         let rejectedBy = null;
         if (!carriesLinks)
             rejectedBy = 'component';
-        else if (declared && !declared.includes(name))
-            rejectedBy = 'component';
         // A dynamic `as` leaves the element unknown, and guessing either way is
         // worse than leaving it for the author.
         else if (rendered !== undefined && !elementTakesLinkAttr(name, rendered))
@@ -594,9 +586,7 @@ function dropInertLinkAttrs(ctx, path, element, target, rendered) {
         removeAttr(element, attr);
         const because = rejectedBy === 'element'
             ? `\`${name}\` needs an element that takes it, and \`${target}\` renders a <${rendered}> here`
-            : !carriesLinks
-                ? `bestax \`${target}\` is not a link at any \`as\`, so it takes no \`${name}\` either`
-                : `bestax \`${target}\` declares its own props rather than taking the element's, and \`${name}\` is not among them`;
+            : `bestax \`${target}\` is not a link at any \`as\`, so it takes no \`${name}\` either`;
         addTodo(ctx, path, `prop:${name}`, `${because} -- ${was ? `it read \`${was}\`; ` : ''}${remedyFor(target, rendered)}`);
         ctx.dirty = true;
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bestax-migrate",
-  "version": "2.3.3",
+  "version": "2.3.5",
   "description": "Codemods for migrating existing React apps from other Bulma libraries to @allxsmith/bestax-bulma",
   "type": "module",
   "bin": {
@@ -38,7 +38,7 @@
     "chalk": "^6.0.0",
     "commander": "^15.0.0",
     "jscodeshift": "^17.3.0",
-    "@allxsmith/bestax-bulma": "^5.15.2"
+    "@allxsmith/bestax-bulma": "^5.15.4"
   },
   "devDependencies": {
     "@jest/globals": "^30.0.0",