bestax-migrate 2.3.2 → 2.3.4

package/dist/sources/_shared/polymorphic.d.ts

@@ -28,13 +28,26 @@
 import type { ASTPath } from 'jscodeshift';
 import { type TransformContext } from './jsx-utils.js';
 export declare const AS_UNIONS: Record<string, readonly string[]>;
+/**
+ * What to do with a link the element refuses. `carry` is true for an attribute
+ * that has to land ON the anchor to do anything (`target`, `download`, …) and
+ * false where the anchor itself IS the remedy (a bare `href`).
+ *
+ * Four answers, because "put an <a> inside" is wrong in three different ways:
+ * an anchor inside interactive content is invalid, an anchor inside a void
+ * element is impossible, and an anchor around a context-bound element puts it
+ * somewhere its parent may not be.
+ *
+ * Exported because `specials-utils.ts` reaches the same question from the plain
+ * markup side, and `bestax-migrate/CLAUDE.md` puts a rule two transforms need in
+ * `_shared/` rather than in one of them.
+ */
+export declare const nestOrClick: (rendered: string | undefined, carry?: boolean) => string;
 /** The targets whose `as` this pass may believe. */
 export declare function declaresAs(target: string): boolean;
 /** The rows the type test holds to the library. */
 export declare const HREF_TABLE: Record<string, string>;
 export declare const AS_ANY_TARGETS: readonly string[];
-/** The rows the type test holds to the library. */
-export declare const TARGET_LINK_ATTR_TABLE: Record<string, readonly string[]>;
 /**
  * The intrinsic elements React types an `href` onto.
  *

package/dist/sources/_shared/polymorphic.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"polymorphic.d.ts","sourceRoot":"","sources":["../../../src/sources/_shared/polymorphic.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;GA0BG;AAEH,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,EAML,KAAK,gBAAgB,EACtB,MAAM,gBAAgB,CAAC;AA0BxB,eAAO,MAAM,SAAS,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAAkB,CAAC;AAsF3E,oDAAoD;AACpD,wBAAgB,UAAU,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAElD;AAQD,mDAAmD;AACnD,eAAO,MAAM,UAAU,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAW,CAAC;AAC1D,eAAO,MAAM,cAAc,EAAE,SAAS,MAAM,EAAuB,CAAC;AAuEpE,mDAAmD;AACnD,eAAO,MAAM,sBAAsB,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAClD,CAAC;AAEpB;;;;;;;GAOG;AACH,eAAO,MAAM,aAAa,EAAE,SAAS,MAAM,EAAkC,CAAC;AAE9E;;;;;;;;;;GAUG;AACH,eAAO,MAAM,eAAe,EAAE,SAAS,MAAM,EAwH5C,CAAC;AAEF;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAEnD;AASD,sFAAsF;AACtF,wBAAgB,oBAAoB,CAAC,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,GAAG,OAAO,CAG3E;AAED,0DAA0D;AAC1D,eAAO,MAAM,UAAU,EAAE,SAAS,MAAM,EAAoC,CAAC;AAE7E,6CAA6C;AAC7C,eAAO,MAAM,eAAe,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAC1C,CAAC;AAuLrB;;;GAGG;AACH,wBAAgB,uBAAuB,CACrC,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,MAAM,EAAE,MAAM;AACd;;;;;;;;;GASG;AACH,gBAAgB,UAAQ,GACvB,IAAI,CAsEN"}
+{"version":3,"file":"polymorphic.d.ts","sourceRoot":"","sources":["../../../src/sources/_shared/polymorphic.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;GA0BG;AAEH,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,EAML,KAAK,gBAAgB,EACtB,MAAM,gBAAgB,CAAC;AA0BxB,eAAO,MAAM,SAAS,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAAkB,CAAC;AAkK3E;;;;;;;;;;;;;GAaG;AACH,eAAO,MAAM,WAAW,GACtB,UAAU,MAAM,GAAG,SAAS,EAC5B,eAAa,KACZ,MAmBF,CAAC;AAMF,oDAAoD;AACpD,wBAAgB,UAAU,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAElD;AAQD,mDAAmD;AACnD,eAAO,MAAM,UAAU,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAW,CAAC;AAC1D,eAAO,MAAM,cAAc,EAAE,SAAS,MAAM,EAAuB,CAAC;AAoDpE;;;;;;;GAOG;AACH,eAAO,MAAM,aAAa,EAAE,SAAS,MAAM,EAAkC,CAAC;AAE9E;;;;;;;;;;GAUG;AACH,eAAO,MAAM,eAAe,EAAE,SAAS,MAAM,EAwH5C,CAAC;AAEF;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAEnD;AASD,sFAAsF;AACtF,wBAAgB,oBAAoB,CAAC,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,GAAG,OAAO,CAG3E;AAED,0DAA0D;AAC1D,eAAO,MAAM,UAAU,EAAE,SAAS,MAAM,EAAoC,CAAC;AAE7E,6CAA6C;AAC7C,eAAO,MAAM,eAAe,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAC1C,CAAC;AAqLrB;;;GAGG;AACH,wBAAgB,uBAAuB,CACrC,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,MAAM,EAAE,MAAM;AACd;;;;;;;;;GASG;AACH,gBAAgB,UAAQ,GACvB,IAAI,CAsEN"}

package/dist/sources/_shared/polymorphic.js

@@ -78,12 +78,12 @@ const AS_ANY = new Set(['Button', 'Menu.Item', 'Navbar.Item', 'Navbar.Link']);
  * typechecking cannot answer the question on its own. `Level.Item` declares
  * `href` on its props at every `as`, so `<Level.Item href="/x">` compiles --
  * but it renders a <div> and forwards `href` only when the tag is an `<a>`
- * (`bulma-ui/src/layout/Level.tsx:227`), so the attribute is dropped at
- * runtime. A table built from the types alone calls that supported; it is the
+ * (`LevelItem`'s anchor branch), so the attribute is dropped at runtime. A table built from the types alone calls that supported; it is the
  * same dead attribute this pass exists to remove.
  */
 const HREF_OK = {
     Button: 'button',
+    'Dropdown.Item': 'a',
     'Level.Item': 'div',
     'Menu.Item': 'a',
     'Navbar.Item': 'a',
@@ -106,7 +106,6 @@ const NO_HREF_HINT = {
     // mapping said the right thing here before the entry moved into this table.
     Delete: 'bestax `Delete` renders a <button> with no children and has no anchor form; wrap it in an <a>, or navigate in `onClick`',
     'Card.Header.Icon': 'bestax `Card.Header.Icon` renders a <button>, so an <a> inside it would nest interactive elements; navigate in `onClick`, or wrap the whole icon in an <a>',
-    'Dropdown.Item': 'bestax `Dropdown.Item` declares no `href` and already renders an <a> by default, so an <a> inside would nest anchors; navigate in `onClick`',
 };
 /**
  * Where to put a link on a target, for the attributes beside `href`. The same
@@ -117,12 +116,122 @@ const NO_HREF_HINT = {
 const LINK_REMEDY = {
     Delete: 'wrap it in an <a>, or navigate in `onClick`',
     'Navbar.Dropdown': 'put it on the `<Navbar.Link>` inside',
-    // Both already render interactive elements -- a <button> and an <a> -- so
-    // "put an <a> inside" would nest one inside the other, which is invalid.
+    // Already renders an interactive element, so "put an <a> inside" would nest
+    // one inside the other, which is invalid.
     'Card.Header.Icon': 'navigate in `onClick`, or wrap the whole icon in an <a>',
-    'Dropdown.Item': 'navigate in `onClick`',
 };
-const remedyFor = (target) => LINK_REMEDY[target] ?? 'put it on an <a> inside, or change the element';
+/**
+ * Elements that may not CONTAIN an `<a>`, so "put an <a> inside" names markup
+ * the author cannot write.
+ *
+ * This is not the same question as "may an `<a>` contain it". Interactive
+ * content -- `button`, `input`, `details`, `iframe`, … -- may not be an `<a>`
+ * DESCENDANT, which rules out wrapping; only a subset also refuses an `<a>`
+ * child, which is what rules out nesting. `<details>` is the case that shows
+ * they differ: an `<a>` may not wrap one, and
+ * `<details><summary>…</summary><a href>…</a></details>` is ordinary valid
+ * markup. Conflating the two directions suppressed advice that was correct.
+ *
+ * So this set is only the second direction, read off each element's content
+ * model: `a` (transparent, but no `a` descendant), `button` (no interactive
+ * descendant), `select`/`textarea` (options and text only), `embed`/`input`
+ * (void), `iframe` (content model "nothing" — markup between the tags is not a
+ * usable child).
+ *
+ * `label` is deliberately NOT here, though it is interactive: its content model
+ * is phrasing content excluding labelable controls and nested labels, and an
+ * `<a>` is neither. It refuses to be WRAPPED, not to hold a link.
+ *
+ * `LINK_REMEDY` states the same thing per TARGET, for components that render
+ * such an element whatever `as` says; this states it per RENDERED ELEMENT, for
+ * the ones where the author's `as` chose it. `Dropdown.Item` needs both
+ * readings: it is a link by default and a `<button>` on request.
+ */
+const NO_ANCHOR_CHILD = new Set([
+    'a',
+    'button',
+    'embed',
+    'iframe',
+    'input',
+    'select',
+    'textarea',
+]);
+/**
+ * Elements an `<a>` may not WRAP, because they are interactive content and an
+ * `<a>` may have no interactive descendant. The complement of the set above
+ * rather than the same list: `details` and `label` refuse to be wrapped and
+ * accept an `<a>` child perfectly well, which is the whole reason the two
+ * questions need two sets.
+ *
+ * `audio` and `video` are deliberately absent -- interactive only with
+ * `controls`, which the tag alone does not say, so wrapping one is valid as far
+ * as this can tell.
+ */
+const NO_ANCHOR_WRAPPER = new Set([...NO_ANCHOR_CHILD, 'details', 'label']);
+/**
+ * Void elements an `<a>` may actually WRAP. `<a><img></a>` is the canonical
+ * form, and it is the advice `Delete` already gives through `LINK_REMEDY` for
+ * the same reason. The plain-markup path reaches these: bloomer's `tag` is
+ * whatever literal the source wrote, so `<Help tag="img">` is one rewrite away.
+ *
+ * Deliberately short. Void-ness is necessary and not sufficient, and the two
+ * ways of getting that wrong are both invalid trees: `input` and `embed` are
+ * interactive (above), and the set below belongs somewhere an `<a>` cannot be.
+ */
+const WRAPPABLE_VOID = new Set(['br', 'hr', 'img', 'wbr']);
+/**
+ * Void elements whose parent is fixed by the spec, so no `<a>` can sit between
+ * them and it: `base`, `link` and `meta` belong to `<head>`, `col` to
+ * `<colgroup>`, `source` and `track` to a media element, `param` to `<object>`,
+ * `area` to `<map>`.
+ *
+ * Nothing can be nested in them and nothing can wrap them, so the only honest
+ * remedy is to stop using the element for this.
+ */
+const CONTEXT_BOUND = new Set([
+    'area',
+    'base',
+    'col',
+    'link',
+    'meta',
+    'param',
+    'source',
+    'track',
+]);
+/**
+ * What to do with a link the element refuses. `carry` is true for an attribute
+ * that has to land ON the anchor to do anything (`target`, `download`, …) and
+ * false where the anchor itself IS the remedy (a bare `href`).
+ *
+ * Four answers, because "put an <a> inside" is wrong in three different ways:
+ * an anchor inside interactive content is invalid, an anchor inside a void
+ * element is impossible, and an anchor around a context-bound element puts it
+ * somewhere its parent may not be.
+ *
+ * Exported because `specials-utils.ts` reaches the same question from the plain
+ * markup side, and `bestax-migrate/CLAUDE.md` puts a rule two transforms need in
+ * `_shared/` rather than in one of them.
+ */
+export const nestOrClick = (rendered, carry = false) => {
+    if (rendered !== undefined && NO_ANCHOR_CHILD.has(rendered)) {
+        return 'navigate in `onClick`';
+    }
+    if (rendered !== undefined && CONTEXT_BOUND.has(rendered)) {
+        return carry
+            ? 'move it to an element that can take it'
+            : 'use an element that can be a link';
+    }
+    if (rendered !== undefined &&
+        WRAPPABLE_VOID.has(rendered) &&
+        !NO_ANCHOR_WRAPPER.has(rendered)) {
+        return carry
+            ? 'put it on an <a> wrapping this element'
+            : 'wrap it in an <a>';
+    }
+    return carry ? 'put it on an <a> inside' : 'put an <a> inside';
+};
+const remedyFor = (target, rendered) => LINK_REMEDY[target] ??
+    `${nestOrClick(rendered, true)}, or change the element`;
 /** The targets whose `as` this pass may believe. */
 export function declaresAs(target) {
     return target in AS_UNIONS || AS_ANY.has(target);
@@ -142,7 +251,7 @@ export const AS_ANY_TARGETS = [...AS_ANY].sort();
  *
  * They are excluded because the components disagree about what they forward,
  * so no shared set is right. `Menu.Item` strips `href` unless the tag is an
- * `<a>` or a custom component (`bulma-ui/src/components/Menu.tsx:212-222`),
+ * `<a>` or a custom component (`MenuItem`'s `isLinkLike` guard),
  * while `Button` routes everything but `'button'` through its anchor path and
  * would forward it. Keeping `href` beside `as="area"` therefore typechecks on
  * both and does nothing on one of them, which is the silently-dead attribute
@@ -181,26 +290,6 @@ const LINK_ATTR_ELEMENTS = {
 // `rel` is deliberately absent: React declares it on `HTMLAttributes`, so it
 // is valid on every intrinsic and there is nothing to remove. The same point
 // `bulma-ui/src/__typetests__/polymorphic.tsx` makes about it.
-/**
- * The link attributes a target accepts, where its props do not follow `as`.
- *
- * Most components here either follow `as` (the element decides, above) or
- * extend `AnchorHTMLAttributes` outright (`Pagination.*`, `Panel.Block`, so
- * everything is fine). `Level.Item` is the exception that enumerates: it
- * declares `href`, `target` and `rel` and nothing else, so `download`,
- * `hrefLang`, `ping` and `referrerPolicy` are type errors there even at
- * `as="a"`.
- *
- * A target absent from `HREF_OK` needs no row: a component that takes no
- * `href` at any `as` takes none of its siblings either -- verified for
- * `Dropdown.Item`, `Card.FooterItem`, `Tabs.Item` and `Delete`, which is why
- * this is derived from that table rather than being a second list to keep.
- */
-const TARGET_LINK_ATTRS = {
-    'Level.Item': ['target'],
-};
-/** The rows the type test holds to the library. */
-export const TARGET_LINK_ATTR_TABLE = TARGET_LINK_ATTRS;
 /**
  * The intrinsic elements React types an `href` onto.
  *
@@ -431,7 +520,7 @@ function dropInertHref(ctx, path, element, target, literal, elementKnown) {
     if (rendered === undefined) {
         if (defaultEl === ANCHOR)
             return;
-        drop(`bestax \`${target}\` renders a <${defaultEl}> unless \`as\` says otherwise, and only its <a> form carries an \`href\` -- set \`as="a"\` to make this a link, or navigate in \`onClick\``);
+        drop(`bestax \`${target}\` renders a <${defaultEl}> unless \`as\` says otherwise, and only its <a> form carries an \`href\` -- set \`as="a"\` to make this a link, or ${nestOrClick(defaultEl)}`);
         return;
     }
     if (rendered === ANCHOR)
@@ -441,8 +530,8 @@ function dropInertHref(ctx, path, element, target, literal, elementKnown) {
     // anchor; on `Button` it gives a <button> that will not compile, and on
     // `Level.Item` a <div> that compiles and quietly is not a link.
     const remedy = defaultEl === ANCHOR
-        ? 'drop the `as` to make this a link, or put an <a> inside'
-        : `set \`as="a"\` to make this a link -- dropping the \`as\` gives you a <${defaultEl}> -- or put an <a> inside`;
+        ? `drop the \`as\` to make this a link, or ${nestOrClick(rendered)}`
+        : `set \`as="a"\` to make this a link -- dropping the \`as\` gives you a <${defaultEl}> -- or ${nestOrClick(rendered)}`;
     drop(`\`href\` on \`as="${rendered}"\`: bestax gives an element the attributes of the tag \`as\` names, and a <${rendered}> takes no \`href\` (it navigated nowhere in the source either) -- ${remedy}`);
 }
 /**
@@ -455,22 +544,21 @@ function dropInertHref(ctx, path, element, target, literal, elementKnown) {
  */
 function dropInertLinkAttrs(ctx, path, element, target, rendered) {
     const carriesLinks = HREF_OK[target] !== undefined;
-    const declared = TARGET_LINK_ATTRS[target];
     for (const name of LINK_ATTRS) {
-        // Both have to allow it. A target that enumerates its props can be
-        // narrower than the element, and the element can be narrower than the
-        // target: `Level.Item` declares `target` but forwards it only when the
-        // tag is an `<a>`, so `<Level.Item as="p" target="_blank">` was keeping
-        // the same inert attribute this pass removes everywhere else.
-        // Which check rejects it decides both the outcome and what the TODO says.
-        // Keying the message off "the target has a row" instead told a
-        // `<Level.Item as="p" target>` reader that `Level.Item` does not declare
-        // `target` -- it does; the <p> is what refuses it.
+        // Two ways to refuse it, and which one decides the TODO's wording. The
+        // component refuses outright if it is no link at any `as`. Otherwise the
+        // ELEMENT decides — `Level.Item` declares `target` and forwards it only for
+        // an `<a>`, so `<Level.Item as="p" target="_blank">` would keep the same
+        // inert attribute this pass removes everywhere else, and the message has to
+        // say the `<p>` refused it rather than that the component did.
+        //
+        // There used to be a third way: a per-target table for a component that
+        // enumerated a SUBSET of the link attributes and was therefore narrower
+        // than its own element. Nothing is, since #672, so the table went with the
+        // branch that read it.
         let rejectedBy = null;
         if (!carriesLinks)
             rejectedBy = 'component';
-        else if (declared && !declared.includes(name))
-            rejectedBy = 'component';
         // A dynamic `as` leaves the element unknown, and guessing either way is
         // worse than leaving it for the author.
         else if (rendered !== undefined && !elementTakesLinkAttr(name, rendered))
@@ -484,10 +572,8 @@ function dropInertLinkAttrs(ctx, path, element, target, rendered) {
         removeAttr(element, attr);
         const because = rejectedBy === 'element'
             ? `\`${name}\` needs an element that takes it, and \`${target}\` renders a <${rendered}> here`
-            : !carriesLinks
-                ? `bestax \`${target}\` is not a link at any \`as\`, so it takes no \`${name}\` either`
-                : `bestax \`${target}\` declares its own props rather than taking the element's, and \`${name}\` is not among them`;
-        addTodo(ctx, path, `prop:${name}`, `${because} -- ${was ? `it read \`${was}\`; ` : ''}${remedyFor(target)}`);
+            : `bestax \`${target}\` is not a link at any \`as\`, so it takes no \`${name}\` either`;
+        addTodo(ctx, path, `prop:${name}`, `${because} -- ${was ? `it read \`${was}\`; ` : ''}${remedyFor(target, rendered)}`);
         ctx.dirty = true;
     }
 }
@@ -563,8 +649,8 @@ spreadCanCarryAs = false) {
     // The element as it will render: the `as` if the target takes it, otherwise
     // the component's own. Unknown for a dynamic `as`, and unknown for a target
     // outside `HREF_OK` that was given no `as` -- the default element is only
-    // recorded for the nine that can carry a link. So this rule reaches an
-    // explicit accepted `as` on any target, plus those nine bare; elsewhere it
+    // recorded for the targets in that table. So this rule reaches an explicit
+    // accepted `as` on any target, plus those targets bare; elsewhere it
     // declines rather than guesses.
     const rendered = read.shadowed
         ? undefined

package/dist/sources/_shared/specials-utils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"specials-utils.d.ts","sourceRoot":"","sources":["../../../src/sources/_shared/specials-utils.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAEH,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AAOjD,OAAO,EAUL,KAAK,gBAAgB,EACtB,MAAM,gBAAgB,CAAC;AAIxB,MAAM,WAAW,aAAa;IAC5B,2DAA2D;IAC3D,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,oEAAoE;IACpE,QAAQ,CAAC,EAAE,OAAO,CAAC;IACnB,yEAAyE;IACzE,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;CACzB;AAED,MAAM,MAAM,cAAc,GAAG,CAC3B,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,KACT,aAAa,CAAC;AAEnB,4EAA4E;AAC5E,wBAAgB,WAAW,CACzB,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,IAAI,EAAE,MAAM,EACZ,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,EAC/B,QAAQ,EAAE,MAAM,GACf,aAAa,CAuBf;AAED;;;;;;;GAOG;AACH,wBAAgB,sBAAsB,CACpC,cAAc,EAAE,MAAM,CAAC,MAAM,EAAE,UAAU,CAAC,EAC1C,qBAAqB,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,IAAI,CAAC,IAGlD,KAAK,gBAAgB,EACrB,MAAM,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,GAAG,EAAE,EACZ,OAAO,MAAM,KACZ,GAAG,EAAE,CAuBT;AAED;;;;GAIG;AACH,wBAAgB,cAAc,CAC5B,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,IAAI,EAAE,MAAM,GAAG,SAAS,EACxB,KAAK,EAAE,MAAM,GACZ,MAAM,GAAG,SAAS,CAiBpB;AAED,iEAAiE;AACjE,MAAM,WAAW,iBAAiB;IAChC,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,0FAA0F;IAC1F,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB;;;;OAIG;IACH,SAAS,EAAE,MAAM,EAAE,CAAC;CACrB;AAED;;;GAGG;AACH,wBAAgB,gBAAgB,CAAC,SAAS,EAAE,MAAM,GAAG,iBAAiB,GAAG,IAAI,CAqE5E;AAED;;;;GAIG;AACH,wBAAgB,cAAc,CAC5B,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,MAAM,EAAE,iBAAiB,GACxB,IAAI,CA0BN;AAED;;;;GAIG;AACH,wBAAgB,aAAa,CAC3B,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,IAAI,EAAE,MAAM,EACZ,IAAI,EAAE,MAAM,EACZ,KAAK,EAAE,MAAM,GACZ,MAAM,CAeR;AAED;;;;;;;GAOG;AACH,wBAAgB,mBAAmB,CACjC,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,MAAM,EAAE,MAAM,GAAG,SAAS,EAC1B,OAAO,EAAE,MAAM,EAAE,EACjB,IAAI,SAAO,GACV,IAAI,CAaN;AAED;;;;;;;GAOG;AACH,wBAAgB,wBAAwB,CACtC,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,GAAG,EAAE,MAAM,EACX,KAAK,EAAE,MAAM,GACZ,IAAI,CA2CN;AAED,8EAA8E;AAC9E,MAAM,MAAM,SAAS,GAAG,CACtB,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,KAAK,EAAE,GAAG,EAAE,EACZ,KAAK,EAAE,MAAM,KACV,GAAG,EAAE,CAAC;AAEX;;;;;GAKG;AACH,wBAAgB,qBAAqB,CAAC,KAAK,EAAE,SAAS;4BAG7C,gBAAgB,QACf,OAAO,CAAC,GAAG,CAAC,WACT,GAAG,OACP,MAAM,aACA,MAAM,GAAG,SAAS,SACtB,MAAM,KACZ,aAAa;6BA2CT,gBAAgB,QACf,OAAO,CAAC,GAAG,CAAC,WACT,GAAG,SACL,MAAM,YACH,MAAM,GAAG,MAAM,EAAE,KAC1B,aAAa,GAAG,IAAI;EA8CxB"}
+{"version":3,"file":"specials-utils.d.ts","sourceRoot":"","sources":["../../../src/sources/_shared/specials-utils.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAEH,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,gBAAgB,CAAC;AAQjD,OAAO,EAUL,KAAK,gBAAgB,EACtB,MAAM,gBAAgB,CAAC;AAIxB,MAAM,WAAW,aAAa;IAC5B,2DAA2D;IAC3D,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,oEAAoE;IACpE,QAAQ,CAAC,EAAE,OAAO,CAAC;IACnB,yEAAyE;IACzE,YAAY,CAAC,EAAE,MAAM,EAAE,CAAC;CACzB;AAED,MAAM,MAAM,cAAc,GAAG,CAC3B,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,KACT,aAAa,CAAC;AAEnB,4EAA4E;AAC5E,wBAAgB,WAAW,CACzB,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,IAAI,EAAE,MAAM,EACZ,OAAO,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAC,EAC/B,QAAQ,EAAE,MAAM,GACf,aAAa,CAuBf;AAED;;;;;;;GAOG;AACH,wBAAgB,sBAAsB,CACpC,cAAc,EAAE,MAAM,CAAC,MAAM,EAAE,UAAU,CAAC,EAC1C,qBAAqB,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,GAAG,IAAI,CAAC,IAGlD,KAAK,gBAAgB,EACrB,MAAM,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,GAAG,EAAE,EACZ,OAAO,MAAM,KACZ,GAAG,EAAE,CAuBT;AAED;;;;GAIG;AACH,wBAAgB,cAAc,CAC5B,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,IAAI,EAAE,MAAM,GAAG,SAAS,EACxB,KAAK,EAAE,MAAM,GACZ,MAAM,GAAG,SAAS,CAiBpB;AAED,iEAAiE;AACjE,MAAM,WAAW,iBAAiB;IAChC,IAAI,EAAE,MAAM,CAAC;IACb,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,0FAA0F;IAC1F,QAAQ,EAAE,MAAM,EAAE,CAAC;IACnB;;;;OAIG;IACH,SAAS,EAAE,MAAM,EAAE,CAAC;CACrB;AAED;;;GAGG;AACH,wBAAgB,gBAAgB,CAAC,SAAS,EAAE,MAAM,GAAG,iBAAiB,GAAG,IAAI,CAqE5E;AAED;;;;GAIG;AACH,wBAAgB,cAAc,CAC5B,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,MAAM,EAAE,iBAAiB,GACxB,IAAI,CA0BN;AAED;;;;GAIG;AACH,wBAAgB,aAAa,CAC3B,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,IAAI,EAAE,MAAM,EACZ,IAAI,EAAE,MAAM,EACZ,KAAK,EAAE,MAAM,GACZ,MAAM,CAeR;AAED;;;;;;;GAOG;AACH,wBAAgB,mBAAmB,CACjC,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,MAAM,EAAE,MAAM,GAAG,SAAS,EAC1B,OAAO,EAAE,MAAM,EAAE,EACjB,IAAI,SAAO,GACV,IAAI,CAaN;AAED;;;;;;;GAOG;AACH,wBAAgB,wBAAwB,CACtC,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,GAAG,EAAE,MAAM,EACX,KAAK,EAAE,MAAM,GACZ,IAAI,CA2CN;AAED,8EAA8E;AAC9E,MAAM,MAAM,SAAS,GAAG,CACtB,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,KAAK,EAAE,GAAG,EAAE,EACZ,KAAK,EAAE,MAAM,KACV,GAAG,EAAE,CAAC;AAEX;;;;;GAKG;AACH,wBAAgB,qBAAqB,CAAC,KAAK,EAAE,SAAS;4BAG7C,gBAAgB,QACf,OAAO,CAAC,GAAG,CAAC,WACT,GAAG,OACP,MAAM,aACA,MAAM,GAAG,SAAS,SACtB,MAAM,KACZ,aAAa;6BA2CT,gBAAgB,QACf,OAAO,CAAC,GAAG,CAAC,WACT,GAAG,SACL,MAAM,YACH,MAAM,GAAG,MAAM,EAAE,KAC1B,aAAa,GAAG,IAAI;EA8CxB"}

package/dist/sources/_shared/specials-utils.js

@@ -8,7 +8,7 @@
  * the modifier vocabulary is the one thing here that differs per source.
  */
 import { addAttrOnce } from './props.js';
-import { LINK_ATTRS, elementTakesLinkAttr, tagRejectsHref, } from './polymorphic.js';
+import { LINK_ATTRS, elementTakesLinkAttr, nestOrClick, tagRejectsHref, } from './polymorphic.js';
 import { addAttr, addTodo, attrSource, attributesOf, findAttr, literalValueOf, makeAttr, plainElement, removeAttr, } from './jsx-utils.js';
 /** Pick a target based on a literal align-style prop, removing the prop. */
 export function alignTarget(ctx, path, element, prop, targets, fallback) {
@@ -234,7 +234,7 @@ export function dropLinkAttrsForPlainTag(ctx, path, element, tag, where) {
     if (href) {
         const was = attrSource(ctx.j, href);
         removeAttr(element, href);
-        addTodo(ctx, path, 'prop:href', `${where} became a plain <${tag}>, which takes no \`href\` — make it an <a>, or put one inside${was ? ` — it read \`${was}\`` : ''}`);
+        addTodo(ctx, path, 'prop:href', `${where} became a plain <${tag}>, which takes no \`href\` — make it an <a>, or ${nestOrClick(tag)}${was ? ` — it read \`${was}\`` : ''}`);
         ctx.dirty = true;
     }
     // Its siblings are judged against the same tag, each on its own, so a
@@ -247,7 +247,7 @@ export function dropLinkAttrsForPlainTag(ctx, path, element, tag, where) {
             continue;
         const was = attrSource(ctx.j, attr);
         removeAttr(element, attr);
-        addTodo(ctx, path, `prop:${name}`, `${where} became a plain <${tag}>, which takes no \`${name}\`${was ? ` — it read \`${was}\`` : ''}; put it on an <a> inside, or change the element`);
+        addTodo(ctx, path, `prop:${name}`, `${where} became a plain <${tag}>, which takes no \`${name}\`${was ? ` — it read \`${was}\`` : ''}; ${nestOrClick(tag, true)}, or change the element`);
         ctx.dirty = true;
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bestax-migrate",
-  "version": "2.3.2",
+  "version": "2.3.4",
   "description": "Codemods for migrating existing React apps from other Bulma libraries to @allxsmith/bestax-bulma",
   "type": "module",
   "bin": {
@@ -38,7 +38,7 @@
     "chalk": "^6.0.0",
     "commander": "^15.0.0",
     "jscodeshift": "^17.3.0",
-    "@allxsmith/bestax-bulma": "^5.15.1"
+    "@allxsmith/bestax-bulma": "^5.15.3"
   },
   "devDependencies": {
     "@jest/globals": "^30.0.0",