bestax-migrate 2.3.1 → 2.3.2

package/dist/sources/_shared/jsx-utils.d.ts

@@ -60,6 +60,13 @@ export type LiteralValue = {
 } | {
     kind: 'expression';
 };
+/**
+ * An attribute as the author wrote it, for a TODO that removes it. A dynamic
+ * value may be the only reference keeping an import alive, so the message has
+ * to carry it -- otherwise the destination is recoverable only from git.
+ * Returns '' if the printer cannot render the node.
+ */
+export declare function attrSource(j: JSCodeshift, attr: any): string;
 /** Extract the literal value of a JSX attribute, if it has one. */
 export declare function literalValueOf(attr: any): LiteralValue;
 /**

package/dist/sources/_shared/jsx-utils.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"jsx-utils.d.ts","sourceRoot":"","sources":["../../../src/sources/_shared/jsx-utils.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAEH,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,aAAa,CAAC;AAC/C,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,gBAAgB,CAAC;AAMpD,MAAM,WAAW,gBAAgB;IAC/B,CAAC,EAAE,WAAW,CAAC;IACf,IAAI,EAAE,MAAM,CAAC;IACb,SAAS,EAAE,aAAa,GAAG,SAAS,CAAC;IACrC,2EAA2E;IAC3E,QAAQ,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC;IACtB,8EAA8E;IAC9E,MAAM,EAAE,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IAC5B;;;;OAIG;IACH,OAAO,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,MAAM,CAAC;IAClC;;;;OAIG;IACH,SAAS,EAAE,OAAO,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACnC;;;OAGG;IACH,OAAO,CAAC,EAAE,CAAC,IAAI,EAAE,GAAG,KAAK,MAAM,EAAE,GAAG,IAAI,CAAC;IACzC,KAAK,EAAE,OAAO,CAAC;CAChB;AAED,2EAA2E;AAC3E,wBAAgB,YAAY,CAAC,IAAI,EAAE,GAAG,GAAG,MAAM,EAAE,GAAG,IAAI,CASvD;AAED,4EAA4E;AAC5E,wBAAgB,YAAY,CAAC,CAAC,EAAE,WAAW,EAAE,MAAM,EAAE,MAAM,GAAG,GAAG,CAOhE;AAED,kEAAkE;AAClE,wBAAgB,aAAa,CAC3B,CAAC,EAAE,WAAW,EACd,OAAO,EAAE,GAAG,EACZ,MAAM,EAAE,MAAM,GACb,IAAI,CAKN;AAED,2CAA2C;AAC3C,wBAAgB,YAAY,CAAC,OAAO,EAAE,GAAG,GAAG,GAAG,EAAE,CAIhD;AAED,wBAAgB,QAAQ,CAAC,OAAO,EAAE,GAAG,EAAE,IAAI,EAAE,MAAM,GAAG,GAAG,GAAG,SAAS,CAEpE;AAED,wBAAgB,UAAU,CAAC,OAAO,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,GAAG,IAAI,CAIxD;AAED,wBAAgB,OAAO,CAAC,OAAO,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,GAAG,IAAI,CAGrD;AAED,MAAM,MAAM,YAAY,GACpB;IAAE,IAAI,EAAE,SAAS,CAAC;IAAC,KAAK,EAAE,OAAO,CAAA;CAAE,GACnC;IAAE,IAAI,EAAE,QAAQ,CAAC;IAAC,KAAK,EAAE,MAAM,CAAA;CAAE,GACjC;IAAE,IAAI,EAAE,QAAQ,CAAC;IAAC,KAAK,EAAE,MAAM,CAAA;CAAE,GACjC;IAAE,IAAI,EAAE,YAAY,CAAA;CAAE,CAAC;AAE3B,mEAAmE;AACnE,wBAAgB,cAAc,CAAC,IAAI,EAAE,GAAG,GAAG,YAAY,CActD;AAED;;;;GAIG;AACH,wBAAgB,SAAS,CAAC,IAAI,EAAE,GAAG,GAAG,MAAM,GAAG,MAAM,GAAG,OAAO,GAAG,SAAS,CAM1E;AAED;;;GAGG;AACH,wBAAgB,SAAS,CAAC,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,GAAG,GAAG,GAAG,CAIxD;AAED,uFAAuF;AACvF,wBAAgB,OAAO,CAAC,IAAI,EAAE,GAAG,GAAG,MAAM,GAAG,SAAS,CAGrD;AAED,kEAAkE;AAClE,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,GAAG,GAAG,GAAG,GAAG,IAAI,CAKzD;AAED,iEAAiE;AACjE,wBAAgB,iBAAiB,CAAC,KAAK,EAAE,GAAG,GAAG,GAAG,GAAG,IAAI,CAKxD;AAED,MAAM,MAAM,UAAU,GAAG,QAAQ,GAAG,OAAO,GAAG,YAAY,CAAC;AAE3D;;;;;;;;;GASG;AACH,wBAAgB,iBAAiB,CAAC,IAAI,EAAE,GAAG,GAAG,UAAU,CAIvD;AAED,gEAAgE;AAChE,wBAAgB,QAAQ,CAAC,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,CAAC,EAAE,MAAM,GAAG,GAAG,CAK1E;AAED;;;;;GAKG;AACH,wBAAgB,OAAO,CACrB,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,IAAI,EAAE,MAAM,EACZ,OAAO,EAAE,MAAM,GACd,IAAI,CAuCN;AAED,uEAAuE;AACvE,wBAAgB,YAAY,CAC1B,CAAC,EAAE,WAAW,EACd,GAAG,EAAE,MAAM,EACX,SAAS,EAAE,MAAM,GAAG,SAAS,EAC7B,KAAK,EAAE,GAAG,EAAE,EACZ,QAAQ,EAAE,GAAG,EAAE,EACf,WAAW,UAAQ,GAClB,GAAG,CAsBL"}
+{"version":3,"file":"jsx-utils.d.ts","sourceRoot":"","sources":["../../../src/sources/_shared/jsx-utils.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG;AAEH,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,aAAa,CAAC;AAC/C,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,gBAAgB,CAAC;AAMpD,MAAM,WAAW,gBAAgB;IAC/B,CAAC,EAAE,WAAW,CAAC;IACf,IAAI,EAAE,MAAM,CAAC;IACb,SAAS,EAAE,aAAa,GAAG,SAAS,CAAC;IACrC,2EAA2E;IAC3E,QAAQ,EAAE,GAAG,CAAC,MAAM,CAAC,CAAC;IACtB,8EAA8E;IAC9E,MAAM,EAAE,GAAG,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IAC5B;;;;OAIG;IACH,OAAO,EAAE,CAAC,IAAI,EAAE,MAAM,KAAK,MAAM,CAAC;IAClC;;;;OAIG;IACH,SAAS,EAAE,OAAO,CAAC,MAAM,EAAE,MAAM,CAAC,CAAC;IACnC;;;OAGG;IACH,OAAO,CAAC,EAAE,CAAC,IAAI,EAAE,GAAG,KAAK,MAAM,EAAE,GAAG,IAAI,CAAC;IACzC,KAAK,EAAE,OAAO,CAAC;CAChB;AAED,2EAA2E;AAC3E,wBAAgB,YAAY,CAAC,IAAI,EAAE,GAAG,GAAG,MAAM,EAAE,GAAG,IAAI,CASvD;AAED,4EAA4E;AAC5E,wBAAgB,YAAY,CAAC,CAAC,EAAE,WAAW,EAAE,MAAM,EAAE,MAAM,GAAG,GAAG,CAOhE;AAED,kEAAkE;AAClE,wBAAgB,aAAa,CAC3B,CAAC,EAAE,WAAW,EACd,OAAO,EAAE,GAAG,EACZ,MAAM,EAAE,MAAM,GACb,IAAI,CAKN;AAED,2CAA2C;AAC3C,wBAAgB,YAAY,CAAC,OAAO,EAAE,GAAG,GAAG,GAAG,EAAE,CAIhD;AAED,wBAAgB,QAAQ,CAAC,OAAO,EAAE,GAAG,EAAE,IAAI,EAAE,MAAM,GAAG,GAAG,GAAG,SAAS,CAEpE;AAED,wBAAgB,UAAU,CAAC,OAAO,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,GAAG,IAAI,CAIxD;AAED,wBAAgB,OAAO,CAAC,OAAO,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,GAAG,IAAI,CAGrD;AAED,MAAM,MAAM,YAAY,GACpB;IAAE,IAAI,EAAE,SAAS,CAAC;IAAC,KAAK,EAAE,OAAO,CAAA;CAAE,GACnC;IAAE,IAAI,EAAE,QAAQ,CAAC;IAAC,KAAK,EAAE,MAAM,CAAA;CAAE,GACjC;IAAE,IAAI,EAAE,QAAQ,CAAC;IAAC,KAAK,EAAE,MAAM,CAAA;CAAE,GACjC;IAAE,IAAI,EAAE,YAAY,CAAA;CAAE,CAAC;AAE3B;;;;;GAKG;AACH,wBAAgB,UAAU,CAAC,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,GAAG,GAAG,MAAM,CAM5D;AAED,mEAAmE;AACnE,wBAAgB,cAAc,CAAC,IAAI,EAAE,GAAG,GAAG,YAAY,CActD;AAED;;;;GAIG;AACH,wBAAgB,SAAS,CAAC,IAAI,EAAE,GAAG,GAAG,MAAM,GAAG,MAAM,GAAG,OAAO,GAAG,SAAS,CAM1E;AAED;;;GAGG;AACH,wBAAgB,SAAS,CAAC,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,GAAG,GAAG,GAAG,CAIxD;AAED,uFAAuF;AACvF,wBAAgB,OAAO,CAAC,IAAI,EAAE,GAAG,GAAG,MAAM,GAAG,SAAS,CAGrD;AAED,kEAAkE;AAClE,wBAAgB,kBAAkB,CAAC,KAAK,EAAE,GAAG,GAAG,GAAG,GAAG,IAAI,CAKzD;AAED,iEAAiE;AACjE,wBAAgB,iBAAiB,CAAC,KAAK,EAAE,GAAG,GAAG,GAAG,GAAG,IAAI,CAKxD;AAED,MAAM,MAAM,UAAU,GAAG,QAAQ,GAAG,OAAO,GAAG,YAAY,CAAC;AAE3D;;;;;;;;;GASG;AACH,wBAAgB,iBAAiB,CAAC,IAAI,EAAE,GAAG,GAAG,UAAU,CAIvD;AAED,gEAAgE;AAChE,wBAAgB,QAAQ,CAAC,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,MAAM,EAAE,KAAK,CAAC,EAAE,MAAM,GAAG,GAAG,CAK1E;AAED;;;;;GAKG;AACH,wBAAgB,OAAO,CACrB,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,IAAI,EAAE,MAAM,EACZ,OAAO,EAAE,MAAM,GACd,IAAI,CAgDN;AAED,uEAAuE;AACvE,wBAAgB,YAAY,CAC1B,CAAC,EAAE,WAAW,EACd,GAAG,EAAE,MAAM,EACX,SAAS,EAAE,MAAM,GAAG,SAAS,EAC7B,KAAK,EAAE,GAAG,EAAE,EACZ,QAAQ,EAAE,GAAG,EAAE,EACf,WAAW,UAAQ,GAClB,GAAG,CAsBL"}

package/dist/sources/_shared/jsx-utils.js

@@ -54,6 +54,20 @@ export function addAttr(element, attr) {
     element.openingElement.attributes = element.openingElement.attributes ?? [];
     element.openingElement.attributes.push(attr);
 }
+/**
+ * An attribute as the author wrote it, for a TODO that removes it. A dynamic
+ * value may be the only reference keeping an import alive, so the message has
+ * to carry it -- otherwise the destination is recoverable only from git.
+ * Returns '' if the printer cannot render the node.
+ */
+export function attrSource(j, attr) {
+    try {
+        return j(attr).toSource();
+    }
+    catch {
+        return '';
+    }
+}
 /** Extract the literal value of a JSX attribute, if it has one. */
 export function literalValueOf(attr) {
     if (attr.value == null)
@@ -162,7 +176,16 @@ export function addTodo(ctx, path, rule, message) {
         /^Export(Named|Default)Declaration$/.test(statement.parent.node.type)) {
         statement = statement.parent;
     }
-    const text = ` TODO(bestax-migrate): ${message}`;
+    // A `//` comment ends at the first newline, so any line break inside the
+    // message would leave the rest of it as bare code and the file unparseable.
+    // Messages quote source text -- an attribute value, a tag name -- and JSX
+    // permits a newline inside both, so this is folded here rather than at each
+    // of the callers that interpolate one.
+    //
+    // Line terminators only. Collapsing all whitespace rewrote the very thing
+    // the quote exists to preserve: `href="/a  b"` came back as `href="/a b"`,
+    // a different URL.
+    const text = ` TODO(bestax-migrate): ${message.replace(/[\r\n\u2028\u2029]+/g, ' ').trim()}`;
     if (statement) {
         const node = statement.node;
         node.comments = node.comments ?? [];

package/dist/sources/_shared/polymorphic.d.ts

@@ -0,0 +1,92 @@
+/**
+ * bestax's DOM props follow `as`: an element's attributes are the attributes
+ * of whatever `as` renders, and a few components narrow `as` to a literal
+ * union of the elements Bulma's markup allows there. Every source library
+ * this package migrates from is looser — rbx and react-bulma-components take
+ * any tag, bloomer took any `tag` — so a faithful prop-for-prop rename emits
+ * shapes that do not compile against the library:
+ *
+ * - an `as` naming an element the bestax component does not offer;
+ * - an `href` beside an `as` that is not an `<a>`;
+ * - an `href` on a component that declares none at any `as`;
+ * - `target` and its siblings on an element, or a component, without them.
+ *
+ * All are dropped with a TODO rather than carried, because carrying them
+ * hands the user a project that does not typecheck, which is the one thing a
+ * codemod must not do.
+ *
+ * What that costs differs by case, and each TODO says so. Dropping an `href`
+ * or a `target` costs nothing the source had: they sat on a `<span>` or a
+ * `<div>`, where no browser acts on them. Dropping an `as` does change the
+ * element — every source here rendered the tag it was given, and bestax
+ * renders its own instead — so that TODO names the tag to restore rather than
+ * claiming nothing moved.
+ *
+ * Source-agnostic: what it knows is bestax's side of the rename, so all three
+ * sources run it over every element after their prop passes.
+ */
+import type { ASTPath } from 'jscodeshift';
+import { type TransformContext } from './jsx-utils.js';
+export declare const AS_UNIONS: Record<string, readonly string[]>;
+/** The targets whose `as` this pass may believe. */
+export declare function declaresAs(target: string): boolean;
+/** The rows the type test holds to the library. */
+export declare const HREF_TABLE: Record<string, string>;
+export declare const AS_ANY_TARGETS: readonly string[];
+/** The rows the type test holds to the library. */
+export declare const TARGET_LINK_ATTR_TABLE: Record<string, readonly string[]>;
+/**
+ * The intrinsic elements React types an `href` onto.
+ *
+ * Only relevant to plain markup. On a bestax component the anchor is the only
+ * `as` that keeps an `href`, because the components disagree about what they
+ * forward (see `ANCHOR` below) -- but a plain `<area href>` has no component
+ * in the way, and it is valid.
+ */
+export declare const HREF_ELEMENTS: readonly string[];
+/**
+ * The HTML half of `JSX.IntrinsicElements`, as of `@types/react` 19.
+ *
+ * Regenerate by reading the keys between `interface IntrinsicElements {` and
+ * the `// SVG` comment in `@types/react/index.d.ts`. `as-unions.test.ts`
+ * holds the link tables to this set, so it is checked rather than trusted.
+ *
+ * SVG is excluded deliberately: `SVGAttributes` declares `href`, `media` and
+ * `target`, so every SVG tag would join those rows. What that means for a
+ * plain rewrite is `tagRejectsHref`'s problem, not a reason to widen this.
+ */
+export declare const HTML_INTRINSICS: readonly string[];
+/**
+ * Whether a plain tag is known NOT to take an `href`.
+ *
+ * `HREF_ELEMENTS` is the HTML answer, and bloomer's `plainTag` can return any
+ * literal the source wrote -- including an SVG tag, where `SVGAttributes`
+ * declares `href`. Treating "not in the HTML list" as "takes no href" lost a
+ * working `href` off `<TabLink tag="use" href="#icon">`. An unrecognised tag
+ * is left alone: this pass removes attributes it can prove are dead, and it
+ * cannot prove that here.
+ */
+export declare function tagRejectsHref(tag: string): boolean;
+/** Whether `element` renders `attr` legally -- exported for the plain-markup path. */
+export declare function elementTakesLinkAttr(name: string, element: string): boolean;
+/** The link attributes, for callers that iterate them. */
+export declare const LINK_ATTRS: readonly string[];
+/** The rows the type test holds to React. */
+export declare const LINK_ATTR_TABLE: Record<string, readonly string[]>;
+/**
+ * The whole-element pass each source runs after its prop passes, once the
+ * bestax `target` and the final `as` are both known.
+ */
+export declare function enforcePolymorphicProps(ctx: TransformContext, path: ASTPath<any>, element: any, target: string, 
+/**
+ * Whether a spread on this element could be carrying an `as`.
+ *
+ * Only where the SOURCE spells its element prop `as`, which is rbx alone.
+ * bloomer's is `tag` and react-bulma-components' is `renderAs`, and the
+ * rename only ever touches a literal attribute -- a `renderAs` key inside
+ * `{...rest}` never becomes an `as`. Guessing `true` everywhere let
+ * `<Button renderAs="span" {...rest} href="/x">` through untouched, which
+ * is the shape this pass exists to remove.
+ */
+spreadCanCarryAs?: boolean): void;
+//# sourceMappingURL=polymorphic.d.ts.map

package/dist/sources/_shared/polymorphic.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"polymorphic.d.ts","sourceRoot":"","sources":["../../../src/sources/_shared/polymorphic.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;GA0BG;AAEH,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,aAAa,CAAC;AAC3C,OAAO,EAML,KAAK,gBAAgB,EACtB,MAAM,gBAAgB,CAAC;AA0BxB,eAAO,MAAM,SAAS,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAAkB,CAAC;AAsF3E,oDAAoD;AACpD,wBAAgB,UAAU,CAAC,MAAM,EAAE,MAAM,GAAG,OAAO,CAElD;AAQD,mDAAmD;AACnD,eAAO,MAAM,UAAU,EAAE,MAAM,CAAC,MAAM,EAAE,MAAM,CAAW,CAAC;AAC1D,eAAO,MAAM,cAAc,EAAE,SAAS,MAAM,EAAuB,CAAC;AAuEpE,mDAAmD;AACnD,eAAO,MAAM,sBAAsB,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAClD,CAAC;AAEpB;;;;;;;GAOG;AACH,eAAO,MAAM,aAAa,EAAE,SAAS,MAAM,EAAkC,CAAC;AAE9E;;;;;;;;;;GAUG;AACH,eAAO,MAAM,eAAe,EAAE,SAAS,MAAM,EAwH5C,CAAC;AAEF;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAAC,GAAG,EAAE,MAAM,GAAG,OAAO,CAEnD;AASD,sFAAsF;AACtF,wBAAgB,oBAAoB,CAAC,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,MAAM,GAAG,OAAO,CAG3E;AAED,0DAA0D;AAC1D,eAAO,MAAM,UAAU,EAAE,SAAS,MAAM,EAAoC,CAAC;AAE7E,6CAA6C;AAC7C,eAAO,MAAM,eAAe,EAAE,MAAM,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE,CAC1C,CAAC;AAuLrB;;;GAGG;AACH,wBAAgB,uBAAuB,CACrC,GAAG,EAAE,gBAAgB,EACrB,IAAI,EAAE,OAAO,CAAC,GAAG,CAAC,EAClB,OAAO,EAAE,GAAG,EACZ,MAAM,EAAE,MAAM;AACd;;;;;;;;;GASG;AACH,gBAAgB,UAAQ,GACvB,IAAI,CAsEN"}