bermudis-pi-goodies 0.23.2 → 0.23.3

package/README.md

@@ -25,7 +25,7 @@ extensions. One entry point, twelve independent features.
 After publishing the package to npm:
 
 ```bash
-pi install npm:bermudis-pi-goodies@0.23.2
+pi install npm:bermudis-pi-goodies@0.23.3
 ```
 
 Remove any old `bermudis-pi-goodies.ts` symlink before reloading Pi. Each
@@ -118,11 +118,12 @@ commands it is logged as a digest, never raw text.
 
 Two honest trade-offs:
 
-- **Separate opt-in, default off every launch.** A bash summary is one request per unique
+- **Separate opt-in, off until you enable it.** A bash summary is one request per unique
   command; a thinking summary recurs for as long as the model reasons.
-  Same provider, different volume — so `thinking-summaries on` asks for
-  that explicitly, for this pi run only (off again next launch, never saved).
-  It takes effect immediately, no `/reload`.
+  Same provider, different volume — so thinking summaries are a separate
+  toggle (`/goodies thinking-summaries on|off`), default off, persisted to
+  `goodies.json` like every other toggle. It takes effect immediately, no
+  `/reload`.
 - **It does not replace the `Thinking...` row itself.** Pi's only seam for
   that text is one global label applied to every assistant message at
   once — updating it mid-stream would rewrite every past thinking row, and

package/goodies.ts

@@ -8,8 +8,7 @@
  * State persists to ~/.pi/agent/goodies.json. Toggling a feature writes the
  * config but does NOT unload/reload the extension — every feature is registered
  * at load time, so a toggle needs `/reload` or a new session to take effect.
- * Exceptions read at request time: `summary-model`, and `thinking-summaries`
- * which is session-only (off on every pi launch, never persisted — token spend).
+ * Exceptions read at request time: `summary-model` and `thinking-summaries`.
  */
 import type { Api, Model } from "@earendil-works/pi-ai";
 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
@@ -26,16 +25,9 @@ import { rankCandidates } from "./vision-core.ts";
 
 let CONFIG_PATH = join(homedir(), ".pi", "agent", "goodies.json");
 
-/** Session-only flag: thinking summaries default off every pi launch. */
-let sessionThinkingEnabled = false;
-
 export function __setConfigPathForTesting(path: string): void {
   CONFIG_PATH = path;
   config = loadConfig();
-  // Thinking summaries are session-only (default off every pi launch), so a
-  // fresh config scope in tests also means a fresh flag — otherwise an
-  // earlier test's `on` would leak into later ones sharing the process.
-  sessionThinkingEnabled = false;
 }
 
 type FeatureName =
@@ -77,10 +69,10 @@ type Config = Partial<Record<FeatureName, boolean>> & {
    */
   "summary-model"?: string;
   /**
-   * Legacy persisted key. Thinking summaries are now session-only (off on
-   * every pi launch, on only when `/goodies thinking-summaries on` runs in
-   * that pi run) because they can add meaningful token spend. The file key
-   * is ignored; it is deleted on write for migration from older versions.
+   * Whether live thinking summaries are on. Persisted like every other
+   * toggle; read at request time so `/goodies thinking-summaries on|off`
+   * takes effect immediately. Unset means off — the volume (a request per
+   * reasoning run, not per command) is why the default stays off.
    */
   "thinking-summaries"?: boolean;
 };
@@ -185,20 +177,13 @@ export function setSummaryModel(model: string | undefined): void {
 }
 
 export function getThinkingSummariesEnabled(): boolean {
-  return sessionThinkingEnabled; // default off every pi launch
+  return config["thinking-summaries"] === true; // default off when unset
 }
 
 export function setThinkingSummariesEnabled(enabled: boolean): void {
-  sessionThinkingEnabled = enabled;
-  // Migration: drop any stale persisted key from older versions so it can
-  // never revive. Best-effort — a failure must not break the toggle.
-  try {
-    updateConfig((next) => {
-      delete next["thinking-summaries"];
-    });
-  } catch {
-    // ignore: the in-memory flag above already took effect
-  }
+  updateConfig((next) => {
+    next["thinking-summaries"] = enabled;
+  });
 }
 
 // ── Summary-model resolution against pi's model registry ────────────────────
@@ -563,7 +548,7 @@ export default function goodies(pi: ExtensionAPI): void {
         setThinkingSummariesEnabled(value === "on");
         const model = getSummaryModel();
         ctx.ui.notify(
-          `thinking summaries ${value} for this pi run only (off again next launch). ` +
+          `thinking summaries ${value} (persisted). ` +
             (value === "on" && !model
               ? `No summary model set yet — run /goodies summary-model <provider/model> or nothing will happen. `
               : "") +

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bermudis-pi-goodies",
-  "version": "0.23.2",
+  "version": "0.23.3",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/bermudi/agent-extensions.git",