benchforge 0.1.3 → 0.1.6

package/src/cli/RunBenchCLI.ts

@@ -7,12 +7,13 @@ import type {
 } from "../BenchMatrix.ts";
 import { runMatrix } from "../BenchMatrix.ts";
 import type { BenchGroup, BenchmarkSpec, BenchSuite } from "../Benchmark.ts";
-import type { BenchmarkReport, ReportGroup } from "../BenchmarkReport.ts";
+import type {
+  BenchmarkReport,
+  ReportGroup,
+  ResultsMapper,
+} from "../BenchmarkReport.ts";
 import { reportResults } from "../BenchmarkReport.ts";
-import {
-  type BrowserProfileResult,
-  profileBrowser,
-} from "../browser/BrowserHeapSampler.ts";
+import type { BrowserProfileResult } from "../browser/BrowserHeapSampler.ts";
 import { exportBenchmarkJson } from "../export/JsonExport.ts";
 import { exportPerfettoTrace } from "../export/PerfettoExport.ts";
 import type { GitVersion } from "../GitUtils.ts";
@@ -362,12 +363,13 @@ function buildReportSections(
   hasOptData: boolean,
 ) {
   const sections = adaptive
-    ? [adaptiveSection, runsSection, totalTimeSection]
-    : [timeSection, runsSection];
+    ? [adaptiveSection, totalTimeSection]
+    : [timeSection];
 
   if (gcStats) sections.push(gcStatsSection);
   if (hasCpuData) sections.push(cpuSection);
   if (hasOptData) sections.push(optSection);
+  sections.push(runsSection);
 
   return sections;
 }
@@ -386,6 +388,20 @@ export async function benchExports(
 /** Run browser profiling via Playwright + CDP, report with standard pipeline */
 export async function browserBenchExports(args: DefaultCliArgs): Promise<void> {
   warnBrowserFlags(args);
+
+  let profileBrowser: typeof import("../browser/BrowserHeapSampler.ts").profileBrowser;
+  try {
+    ({ profileBrowser } = await import("../browser/BrowserHeapSampler.ts"));
+  } catch {
+    throw new Error(
+      "playwright is required for browser benchmarking (--url).\n\n" +
+        "Quick start:  npx benchforge-browser --url <your-url>\n\n" +
+        "Or install manually:\n" +
+        "  npm install playwright\n" +
+        "  npx playwright install chromium",
+    );
+  }
+
   const url = args.url!;
   const { iterations, time } = args;
   const result = await profileBrowser({
@@ -396,7 +412,9 @@ export async function browserBenchExports(args: DefaultCliArgs): Promise<void> {
       stackDepth: args["heap-depth"],
     },
     headless: args.headless,
-    chromeArgs: args["chrome-args"]?.split(/\s+/).filter(Boolean),
+    chromeArgs: args["chrome-args"]
+      ?.flatMap(a => a.split(/\s+/))
+      .filter(Boolean),
     timeout: args.timeout,
     gcStats: args["gc-stats"],
     maxTime: iterations ? Number.MAX_SAFE_INTEGER : time * 1000,
@@ -404,28 +422,37 @@ export async function browserBenchExports(args: DefaultCliArgs): Promise<void> {
   });
 
   const name = new URL(url).pathname.split("/").pop() || "browser";
-  const hasSamples = result.samples && result.samples.length > 0;
   const results = browserResultGroups(name, result);
+  printBrowserReport(result, results, args);
+  await exportReports({ results, args });
+}
 
-  // Time report
+/** Print browser benchmark tables and heap reports */
+function printBrowserReport(
+  result: BrowserProfileResult,
+  results: ReportGroup[],
+  args: DefaultCliArgs,
+): void {
+  const hasSamples = result.samples && result.samples.length > 0;
+  const sections: ResultsMapper<any>[] = [];
   if (hasSamples || result.wallTimeMs != null) {
-    console.log(reportResults(results, [timeSection, runsSection]));
+    sections.push(timeSection);
   }
-
-  // GC stats table
   if (result.gcStats) {
-    console.log(reportResults(results, [browserGcStatsSection]));
+    sections.push(browserGcStatsSection);
+  }
+  if (hasSamples || result.wallTimeMs != null) {
+    sections.push(runsSection);
+  }
+  if (sections.length > 0) {
+    console.log(reportResults(results, sections));
   }
-
-  // Heap allocation report
   if (result.heapProfile) {
     printHeapReports(results, {
       ...cliHeapReportOptions(args),
       isUserCode: isBrowserUserCode,
     });
   }
-
-  await exportReports({ results, args });
 }
 
 /** Wrap browser profile result as ReportGroup[] for the standard pipeline */