bdy 1.25.20 → 1.25.21-dev

package/distTs/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bdy",
   "preferGlobal": false,
-  "version": "1.25.20",
+  "version": "1.25.21-dev",
   "type": "commonjs",
   "license": "MIT",
   "homepage": "https://buddy.works/docs/cli",

package/distTs/src/agent/manager.js

@@ -305,6 +305,17 @@ class AgentManagerClass {
         res.statusCode = 404;
         res.end('Not found');
     }
+    // The server is bound to loopback, but a web page open on this machine can still
+    // reach it: a no-cors POST or an <img> fires without a preflight, a WebSocket is
+    // never subject to CORS, and DNS rebinding lets a page read the responses. bdy
+    // sends no Origin and always targets 127.0.0.1, browsers always send Origin on
+    // those requests and keep the rebound name in Host - so refuse either.
+    isLocalRequest(req) {
+        if (req.headers.origin !== undefined)
+            return false;
+        const host = req.headers.host;
+        return (host === `127.0.0.1:${this.port}` || host === `localhost:${this.port}`);
+    }
     serverError(res, message) {
         res.statusCode = 400;
         res.end(JSON.stringify({
@@ -709,6 +720,11 @@ class AgentManagerClass {
     }
     async processRequest(req, res) {
         logger_1.default.debug(`MANAGER REQUEST: ${req.url}`);
+        if (!this.isLocalRequest(req)) {
+            res.statusCode = 403;
+            res.end('Forbidden');
+            return;
+        }
         if (req.url === '/status')
             return this.processStatus(res);
         if (req.url === '/target')
@@ -751,6 +767,10 @@ class AgentManagerClass {
     }
     processUpgrade(req, socket, head) {
         logger_1.default.debug(`MANAGER REQUEST: ${req.url}`);
+        if (!this.isLocalRequest(req)) {
+            socket.destroy();
+            return;
+        }
         const url = new URL(req.url || '', 'http://localhost');
         const id = url.searchParams.get('id');
         if (url.pathname === '/tunnel' && id && this.ws) {
@@ -801,7 +821,8 @@ class AgentManagerClass {
                 logger_1.default.error(err);
             }
         });
-        this.server.listen(this.port, () => {
+        // Loopback only: the API has no credentials, every caller is a local bdy.
+        this.server.listen(this.port ?? 0, '127.0.0.1', () => {
             logger_1.default.info(texts_1.LOG_AGENT_SERVER_STARTED);
         });
     }

package/distTs/src/tunnel/api/agent.js

@@ -10,7 +10,7 @@ const undici_1 = __importDefault(require("undici"));
 const TIMEOUT = 120000;
 const openSocket = (port, path) => {
     return new Promise((resolve, reject) => {
-        const ws = new ws_1.WebSocket(`ws://localhost:${port}${path}`);
+        const ws = new ws_1.WebSocket(`ws://127.0.0.1:${port}${path}`);
         ws.on('error', () => {
             reject(new Error(texts_1.ERR_FAILED_TO_CONNECT_TO_AGENT));
         });
@@ -26,7 +26,7 @@ const makeRequest = async (port, path, body) => {
     }, TIMEOUT);
     logger_1.default.debug(`TUNNEL API AGENT REQUEST: :${port}${path}`);
     logger_1.default.debug(body);
-    const response = await undici_1.default.fetch(`http://localhost:${port}${path}`, {
+    const response = await undici_1.default.fetch(`http://127.0.0.1:${port}${path}`, {
         body: body ? JSON.stringify(body) : null,
         headers: { 'Content-Type': 'application/json' },
         method: 'POST',

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bdy",
   "preferGlobal": false,
-  "version": "1.25.20",
+  "version": "1.25.21-dev",
   "type": "commonjs",
   "license": "MIT",
   "homepage": "https://buddy.works/docs/cli",