bdy 1.24.3-dev → 1.24.4-dev

package/distTs/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bdy",
   "preferGlobal": false,
-  "version": "1.24.3-dev",
+  "version": "1.24.4-dev",
   "type": "commonjs",
   "license": "MIT",
   "homepage": "https://buddy.works/docs/cli",

package/distTs/src/logger.js

@@ -12,6 +12,7 @@ class Logger {
     logPath = null;
     log1Path = null;
     logStream = null;
+    dest = null;
     p = null;
     ts = null;
     constructor() {
@@ -86,6 +87,24 @@ class Logger {
             if (this.logPath)
                 this.applyLogRights(this.logPath);
             const pino = require('pino');
+            // Not stdout as a fallback: it is machine-read by `--format json` and the mcp command.
+            // `sync`, which pino.destination(fd) does not default to: an asynchronous destination
+            // buffers the line and writes it from the threadpool, so the tail of the log is exactly
+            // what an agent killed by its service manager - or by the crash being logged - loses,
+            // and every descriptor it still holds has to outlive whoever closes it.
+            this.dest =
+                this.logStream === null
+                    ? { write: () => { } }
+                    : pino.destination({
+                        dest: this.logStream,
+                        sync: true,
+                        minLength: 0,
+                    });
+            // A line that could not be written is not worth taking the process down for. Pino's own
+            // handler swallows EPIPE and re-emits the rest, and an EventEmitter re-emitting 'error'
+            // with nobody listening throws - so an unwritable log used to arrive as a crash.
+            // (the ternary above assigns an untyped pino value, which does not narrow the field)
+            this.dest.on?.('error', () => { });
             this.p = pino({
                 level: this.debugOn ? 'debug' : 'info',
                 timestamp: () => `, "time": "${new Date().toISOString()}"`,
@@ -95,11 +114,7 @@ class Logger {
                         level: label.toUpperCase(),
                     }),
                 },
-            }, 
-            // Not stdout as a fallback: it is machine-read by `--format json` and the mcp command
-            this.logStream === null
-                ? { write: () => { } }
-                : pino.destination(this.logStream));
+            }, this.dest);
             this.checkLogSize();
             this.ts = setInterval(() => {
                 this.checkLogSize();
@@ -122,20 +137,36 @@ class Logger {
     stack() {
         this.getPino().info(new Error().stack);
     }
+    // The descriptor belongs to the destination from the moment pino is handed one, so the close
+    // goes through the stream rather than through the number: closeSync on the number leaves a
+    // live stream holding a descriptor the kernel is free to hand to the next open - an EBADF at
+    // best, a log line in an unrelated file at worst - and pino, for a destination it opened
+    // asynchronously, flushes it again on exit. Anything still queued goes out first.
+    closeDestination() {
+        const dest = this.dest;
+        this.dest = null;
+        this.logStream = null;
+        if (!dest)
+            return;
+        try {
+            dest.flushSync?.();
+        }
+        catch {
+            // a destination that never opened, or one with nothing left to write
+        }
+        try {
+            dest.destroy?.();
+        }
+        catch {
+            // do nothing
+        }
+    }
     changeRootPath(path) {
         if (this.ts) {
             clearInterval(this.ts);
             this.ts = null;
         }
-        if (this.logStream) {
-            try {
-                fs_1.default.closeSync(this.logStream);
-            }
-            catch {
-                // do nothing
-            }
-            this.logStream = null;
-        }
+        this.closeDestination();
         this.p = null;
         this.rootPath = path;
     }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bdy",
   "preferGlobal": false,
-  "version": "1.24.3-dev",
+  "version": "1.24.4-dev",
   "type": "commonjs",
   "license": "MIT",
   "homepage": "https://buddy.works/docs/cli",