bdy 1.23.11-stage → 1.23.13-beta

package/distTs/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bdy",
   "preferGlobal": false,
-  "version": "1.23.11-stage",
+  "version": "1.23.13-beta",
   "type": "commonjs",
   "license": "MIT",
   "homepage": "https://buddy.works/docs/cli",
@@ -51,7 +51,7 @@
     "@fastify/cors": "11.2.0",
     "@inquirer/prompts": "8.5.2",
     "@modelcontextprotocol/sdk": "1.30.0",
-    "@puppeteer/browsers": "2.13.0",
+    "@puppeteer/browsers": "3.2.0",
     "@scalar/json-magic": "0.12.16",
     "@scalar/openapi-parser": "0.28.7",
     "@scalar/openapi-types": "0.9.1",
@@ -79,7 +79,7 @@
     "picomatch": "4.0.4",
     "pino": "10.3.1",
     "punycode": "2.3.1",
-    "puppeteer-core": "23.11.1",
+    "puppeteer-core": "25.6.0",
     "range-parser": "1.2.1",
     "socket.io-client": "4.8.3",
     "ssh2": "1.17.0",

package/distTs/src/agent/manager.js

@@ -161,6 +161,10 @@ class AgentManagerClass {
             }
             const current = (0, utils_1.getVersion)();
             const latest = await (0, utils_1.getLatestVersion)();
+            // Equality only, deliberately not "is latest newer": this runs on an explicit remote
+            // update action, whose meaning is "match what the channel publishes". Refusing an
+            // older latest would take away the only rollback the fleet has - moving the channel
+            // pointer back after a bad release.
             if (!latest || latest === '0.0.0' || latest === current) {
                 logger_1.default.info((0, texts_1.LOG_AGENT_UPDATE_NOT_NEEDED)(current));
                 // Nothing to do is not a failure, and showing it as one would make an update of
@@ -174,12 +178,15 @@ class AgentManagerClass {
             // - this is the value that stays behind if the restart never lands.
             this.agent?.reportUpdateStatus(tunnel_1.TUNNEL_AGENT_UPDATE_STATUS.STARTED);
             this.agent?.flushUpdateStatus();
-            const target = latest.match(/^\d+\.\d+\.\d+/);
+            // getLatestVersion already refuses a version it cannot parse, so this is belt and
+            // braces - kept because the download url is built from the triple, and shipping a
+            // malformed one would fail much further away from the cause.
+            const target = (0, utils_1.parseVersion)(latest);
             if (!target) {
                 logger_1.default.error(texts_1.LOG_AGENT_UPDATE_FAILED);
                 return report(tunnel_1.TUNNEL_AGENT_UPDATE_STATUS.FAILED);
             }
-            const swapped = await this.system.swapBinaryToVersion(target[0]);
+            const swapped = await this.system.swapBinaryToVersion(target.version);
             if (!swapped) {
                 logger_1.default.error((0, texts_1.LOG_AGENT_UPDATE_BINARY_INVALID)(latest));
                 return report(tunnel_1.TUNNEL_AGENT_UPDATE_STATUS.FAILED);

package/distTs/src/command/pre.js

@@ -46,14 +46,15 @@ const commandPre = async (_, command) => {
     if (!output_1.default.isTTY() || command.hideVersionUpdate || ['json', 'jsonl'].includes(command.opts()?.format)) {
         return;
     }
-    const newCli = !!command.latestVersion && command.currentVersion !== command.latestVersion;
-    const newAgent = !!command.agentStatus && !!command.latestVersion &&
-        command.agentStatus.version !== command.latestVersion;
-    if ((0, utils_1.isDocker)() && newCli && command.latestVersion) {
-        output_1.default.newCliDockerVersion(command.latestVersion);
-    }
-    else if (newCli && command.latestVersion) {
-        output_1.default.newCliVersion(command.latestVersion);
+    // No truthiness guards on the versions: an empty or unparsable one is never newer
+    const latest = command.latestVersion || '';
+    const newCli = (0, utils_1.isVersionNewer)(latest, command.currentVersion || '');
+    const newAgent = !!command.agentStatus && (0, utils_1.isVersionNewer)(latest, command.agentStatus.version);
+    if ((0, utils_1.isDocker)() && newCli) {
+        output_1.default.newCliDockerVersion(latest);
+    }
+    else if (newCli) {
+        output_1.default.newCliVersion(latest);
     }
     else if (newAgent) {
         output_1.default.newAgentVersion();

package/distTs/src/command/version.js

@@ -78,7 +78,7 @@ commandVersion.action(async () => {
     const currVersion = commandVersion.currentVersion || '';
     const lastVersion = commandVersion.latestVersion || '';
     const env = commandVersion.env || '';
-    if (currVersion !== lastVersion) {
+    if ((0, utils_1.isVersionNewer)(lastVersion, currVersion)) {
         const platform = (0, utils_1.getPlatform)();
         const isMac = platform === 'darwin';
         const isWin = platform === 'win32';

package/distTs/src/logger.js

@@ -64,7 +64,13 @@ class Logger {
             this.logPath = (0, path_1.resolve)(this.rootPath, 'cli.log');
             this.log1Path = (0, path_1.resolve)(this.rootPath, 'cli.1.log');
             try {
-                this.logStream = fs_1.default.openSync(this.logPath, 'w');
+                // 'a', not 'w': every start used to truncate the log, so an agent that died and was
+                // restarted by its service manager came back having erased the only record of why -
+                // and a crash loop leaves nothing at all. Append also survives an external truncation
+                // (rotation, someone clearing the file) without the zero-padding a tracked write offset
+                // produces, because O_APPEND puts every write at the current end of the file.
+                // checkLogSize() below still bounds it at 5 MB.
+                this.logStream = fs_1.default.openSync(this.logPath, 'a');
             }
             catch {
                 // A log we cannot open is not a reason to fail the command - a read-only home, a full

package/distTs/src/tunnel/server/sftp.js

@@ -82,11 +82,19 @@ class ServerSftp {
                     s._protocol.exitStatus(s.outgoing.id, 0);
                     s._protocol.channelEOF(s.outgoing.id);
                 }
+                // origDestroy() inside the try, not after it: it sends CHANNEL_CLOSE, and a peer that
+                // simply vanished leaves the channel 'open' while ssh2 has already torn the connection
+                // down (Protocol.cleanup on socket close). With zlib@openssh.com negotiated - which the
+                // java client on the other end of a deployment always picks - that write reaches a
+                // destroyed zlib and throws 'Invalid Zlib instance' out of ZlibPacketWriter.finalize.
+                // It escaped from inside a 'close' handler, so it took down the whole tunnel and, past
+                // the agent's uncaughtException hook, the process with it. There is nothing to salvage
+                // by letting it out: the channel this belongs to is already gone.
+                return origDestroy();
             }
             catch {
-                // do nothing
+                return undefined;
             }
-            return origDestroy();
         };
         this.sftp.on('OPEN', (reqId, fileName, flags, attrs) => this.open(reqId, fileName, flags, attrs));
         this.sftp.on('READ', (reqId, handle, offset, length) => this.read(reqId, handle, offset, length));
@@ -604,13 +612,24 @@ class ServerSftp {
     }
     destroy() {
         if (this.sftp) {
-            this.sftp.removeAllListeners();
-            this.sftp.end();
+            try {
+                this.sftp.removeAllListeners();
+                // end() writes: EOF and CHANNEL_CLOSE go out through the connection this channel sits
+                // on, which on the teardown path is usually already gone. Whatever that write throws,
+                // the handles below still have to be released - and this runs from a 'close' handler,
+                // where an escaping error reaches uncaughtException.
+                this.sftp.end();
+            }
+            catch {
+                // do nothing
+            }
         }
         if (this.openHandlers) {
             this.openHandlers.forEach((fd, id) => {
                 try {
-                    fd.close();
+                    // FileHandle.close() and Dir.close() both return a promise. try/catch cannot see a
+                    // rejected one, and an unhandled rejection is as fatal to the agent as a throw.
+                    Promise.resolve(fd.close()).catch(() => { });
                 }
                 catch {
                     // do nothing

package/distTs/src/tunnel/ssh/client.js

@@ -16,6 +16,8 @@ class SshClient extends events_1.default {
     password;
     keepalive;
     client;
+    lastError;
+    openedAt;
     constructor(ip, port, username, password) {
         super();
         this.ip = ip;
@@ -23,8 +25,25 @@ class SshClient extends events_1.default {
         this.username = username;
         this.password = password;
         this.keepalive = false;
+        this.lastError = null;
+        this.openedAt = 0;
         logger_1.default.debug(`New ssh client: ${username}:${password}@${ip}:${port}`);
     }
+    // Why the tunnel connection went away, for the one line openKeepAlive logs on its way to
+    // reconnecting. ssh2 emits 'error' and destroys the socket itself on everything fatal - a
+    // keepalive timeout, a protocol error, a socket reset - so without keeping that error the
+    // 'close' that follows is indistinguishable from the peer hanging up on us, and a tunnel that
+    // drops mid-transfer looks like nothing happened at all.
+    closeReason() {
+        const err = this.lastError;
+        const reason = err
+            ? `${err.level ? `${err.level}: ` : ''}${err.message}`
+            : 'closed by peer or locally, no error reported';
+        if (!this.openedAt)
+            return `SSH client closed before it was ready (${reason})`;
+        const age = Math.round((Date.now() - this.openedAt) / 1000);
+        return `SSH client closed after ${age}s (${reason})`;
+    }
     async open() {
         return new Promise((resolve, reject) => {
             this.close();
@@ -33,8 +52,14 @@ class SshClient extends events_1.default {
             this.client.on('ready', () => {
                 if (this.client) {
                     this.client.removeAllListeners();
-                    this.client.on('error', () => { });
+                    // Kept rather than swallowed: this is the only place an error on a live tunnel
+                    // connection is ever seen. It must still not throw, so it stays a handler that only
+                    // records - closeReason() reads it once the 'close' lands.
+                    this.client.on('error', (err) => {
+                        this.lastError = err;
+                    });
                 }
+                this.openedAt = Date.now();
                 resolve();
             });
             this.client.once('error', (err) => {
@@ -223,20 +248,26 @@ class SshClient extends events_1.default {
     openKeepAlive() {
         logger_1.default.debug(`SSH client open`);
         this.keepalive = true;
+        this.lastError = null;
+        this.openedAt = 0;
         this.open()
             .then(() => {
             logger_1.default.debug(`SSH client opened`);
             this.emit(tunnel_1.TUNNEL_SSH_EVENT.CONNECTED);
             if (this.client) {
                 this.client.on('close', () => {
-                    logger_1.default.debug(`SSH client closed`);
+                    // info, not debug: a tunnel that drops takes every connection on it with it, and the
+                    // transfers that die with it are reported far from here - on the other side, as a
+                    // failed handshake. One line per drop, and the log says so without debug turned on.
+                    logger_1.default.info(this.closeReason());
                     if (this.keepalive)
                         this.openKeepAlive();
                 });
             }
         })
-            .catch(() => {
-            logger_1.default.debug(`SSH client closed`);
+            .catch((err) => {
+            this.lastError = err;
+            logger_1.default.info(this.closeReason());
             this.emit(tunnel_1.TUNNEL_SSH_EVENT.DISCONNECTED);
             setTimeout(() => {
                 if (this.keepalive)

package/distTs/src/utils.js

@@ -37,7 +37,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.isStringRegExp = exports.getWorkingDir = exports.getRootDir = exports.TARGET_ONLY_PORT_REGEX = exports.TARGET_HTTP_REGEX = exports.TARGET_TCP_TLS_REGEX = exports.ApiErrorTunnelsDisabled = exports.ApiErrorWorkspaceFlagged = exports.ApiErrorTunnelLimitReached = exports.ApiErrorAgentLimitReached = exports.ApiErrorDomainRestricted = exports.ApiErrorTargetInvalid = exports.ApiErrorWrongToken = exports.ApiErrorFailedToConnect = exports.ApiErrorAgentNotFound = exports.ARTIFACT_AUTH_TYPE = exports.ARTIFACT_TYPE = exports.SANDBOX_SNAPSHOT_STATUS = exports.SANDBOX_APP_STATUS = exports.SANDBOX_SETUP_STATUS = exports.SANDBOX_EXEC_STATUS = exports.SANDBOX_EXEC_RUNTIME = exports.SANDBOX_STATUS = exports.REST_API_ENDPOINT = exports.REST_API_REGION = exports.DEFAULT_SANDBOX_CP_USER = exports.ARTIFACT_DEFAULT_VERSION = exports.SUGGESTED_BROWSER_VERSION = exports.AGENT_UPDATE_STATUS_TTL_MS = exports.AGENT_UPDATE_PROBATION_MS = exports.AGENT_UPDATE_MAX_ATTEMPTS = exports.AGENT_FETCH_RETRY_MAX = exports.AGENT_FETCH_RETRY_MIN = exports.SSH_HANDSHAKE_TIMEOUT = exports.DEFAULT_TIMEOUT = exports.getSshIdent = exports.TUNNEL_SSH_IDENT_SHARED_H2 = exports.TUNNEL_CLIENT_IP_HEADER = exports.TUNNEL_HTTP2_SHED_LOG_INTERVAL = exports.TUNNEL_HTTP2_MAX_SESSIONS = exports.TUNNEL_HTTP2_SESSION_IDLE_TIMEOUT = exports.TUNNEL_HTTP_RETRY_AFTER = exports.TUNNEL_HTTP_MAX_INFLIGHT = exports.TUNNEL_HTTP_CB_MIN_REQUESTS = exports.TUNNEL_HTTP_CB_WINDOW = exports.TUNNEL_MAX_REQUEST_SIZE_TO_SYNC = exports.TUNNEL_HTTP_LOG_MAX_REQUESTS = exports.TUNNEL_HTTP_LOG_MAX_BODY = exports.TUNNEL_HTTP_RATE_WINDOW = exports.TUNNEL_HTTP_RATE_LIMIT = void 0;
-exports.getGitName = exports.getGitEmail = exports.MCP_TOOL_CATEGORIES = exports.getBasicCommandTls = exports.getBasicCommandHttp = exports.getBasicCommandSandboxEndpoint = exports.getBasicCommandTcp = exports.getCurrentUser = exports.getServiceUser = exports.getRealTargetHost = exports.isWindows = exports.isLinux = exports.isOsx = exports.isDocker = exports.sleep = exports.getLatestVersion = exports.getVersionEnv = exports.getCurrentVersionWithoutEnv = exports.getVersionWithoutEnv = exports.getVersion = exports.isInstalledByChoco = exports.isInstalledByApt = exports.isInstalledByBrew = exports.isInstalledByNpm = exports.isNpmGlobalWritable = exports.isPathWritable = exports.tryGetEmail = exports.execLocally = exports.getHomeDirectory = exports.HOME_DIR_NAME = exports.chownToHomeOwner = exports.isDomainAvailable = exports.newCommand = exports.formatBytes = exports.formatHelp = exports.getPlatform = exports.getHostname = void 0;
+exports.getGitName = exports.getGitEmail = exports.MCP_TOOL_CATEGORIES = exports.getBasicCommandTls = exports.getBasicCommandHttp = exports.getBasicCommandSandboxEndpoint = exports.getBasicCommandTcp = exports.getCurrentUser = exports.getServiceUser = exports.getRealTargetHost = exports.isWindows = exports.isLinux = exports.isOsx = exports.isDocker = exports.sleep = exports.getLatestVersion = exports.getVersionEnv = exports.getCurrentVersionWithoutEnv = exports.isVersionNewer = exports.getVersionWithoutEnv = exports.parseVersion = exports.getVersion = exports.isInstalledByChoco = exports.isInstalledByApt = exports.isInstalledByBrew = exports.isInstalledByNpm = exports.isNpmGlobalWritable = exports.isPathWritable = exports.tryGetEmail = exports.execLocally = exports.getHomeDirectory = exports.HOME_DIR_NAME = exports.chownToHomeOwner = exports.isDomainAvailable = exports.newCommand = exports.formatBytes = exports.formatHelp = exports.getPlatform = exports.getHostname = void 0;
 exports.apiErrorCodeToClass = apiErrorCodeToClass;
 exports.isFile = isFile;
 exports.getAppWorkspaceUrl = getAppWorkspaceUrl;
@@ -132,7 +132,7 @@ exports.AGENT_UPDATE_PROBATION_MS = 30 * 60 * 1000;
 // 15s; anything past it waits for the one at 60s, so a longer ttl here shows the outcome for
 // four times as long as it says.
 exports.AGENT_UPDATE_STATUS_TTL_MS = 10 * 1000;
-exports.SUGGESTED_BROWSER_VERSION = '130.0.6723.69';
+exports.SUGGESTED_BROWSER_VERSION = '151.0.7922.77';
 exports.ARTIFACT_DEFAULT_VERSION = 'latest';
 exports.DEFAULT_SANDBOX_CP_USER = 'buddy';
 var REST_API_REGION;
@@ -585,19 +585,44 @@ const getVersion = () => {
     return cachedVersion;
 };
 exports.getVersion = getVersion;
+// The one place that knows what a version string looks like: `x.y.z` optionally followed by
+// a channel suffix. AgentSystem.verifyBinary keeps a regex of its own on purpose - it fishes
+// a version out of selftest output rather than parsing one, so it must not be anchored.
+const parseVersion = (version) => {
+    const m = (version || '').match(/^(\d+)\.(\d+)\.(\d+)/);
+    if (!m)
+        return null;
+    return {
+        version: m[0],
+        major: Number(m[1]),
+        minor: Number(m[2]),
+        patch: Number(m[3]),
+    };
+};
+exports.parseVersion = parseVersion;
 const getVersionWithoutEnv = (version) => {
-    const m = version.match(/^\d+\.\d+\.\d+/);
-    if (m)
-        return m[0];
-    return '0.0.0';
+    return (0, exports.parseVersion)(version)?.version || '0.0.0';
 };
 exports.getVersionWithoutEnv = getVersionWithoutEnv;
+// An update is only an update when the other side is actually ahead. Comparing the strings
+// for inequality also fired on a build that is newer than what the channel publishes - a
+// local dev build, or a machine that got the release before es.buddy.works did - and told
+// the user to "update" to an older version. Both sides carry the same env suffix (latest is
+// fetched per env), so the numeric triple decides.
+const isVersionNewer = (version, than) => {
+    const a = (0, exports.parseVersion)(version);
+    const b = (0, exports.parseVersion)(than);
+    if (!a || !b)
+        return false;
+    if (a.major !== b.major)
+        return a.major > b.major;
+    if (a.minor !== b.minor)
+        return a.minor > b.minor;
+    return a.patch > b.patch;
+};
+exports.isVersionNewer = isVersionNewer;
 const getCurrentVersionWithoutEnv = () => {
-    const v = (0, exports.getVersion)();
-    const m = v.match(/^\d+\.\d+\.\d+/);
-    if (m)
-        return m[0];
-    return '0.0.0';
+    return (0, exports.getVersionWithoutEnv)((0, exports.getVersion)());
 };
 exports.getCurrentVersionWithoutEnv = getCurrentVersionWithoutEnv;
 const getVersionEnv = () => {
@@ -626,10 +651,20 @@ const getLatestVersion = async () => {
         });
         if (response.status === 200) {
             const data = await response.text();
-            const v = data.trim();
+            // A 200 whose body is not a version - a padded value, an error page from something in
+            // front of the bucket - is nothing a caller can act on, so it fails here rather than
+            // downstream, where every comparison would read it as "no update". The parsed triple
+            // is what gets returned, not the body: the regex is unanchored at the end, so a body
+            // that merely starts with a version would otherwise carry its tail into the banners,
+            // the update log and the equality test in AgentManager.remoteUpdate.
+            // Only the agent's remote update surfaces this - `commandPre` swallows it, so the CLI
+            // stays quiet about a channel it could not read.
+            const parsed = (0, exports.parseVersion)(data.trim());
+            if (!parsed)
+                throw new Error(texts_1.ERR_FETCH_VERSION);
             if (env === 'prod')
-                return v;
-            return `${v}-${env}`;
+                return parsed.version;
+            return `${parsed.version}-${env}`;
         }
         else {
             return '0.0.0';

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "bdy",
   "preferGlobal": false,
-  "version": "1.23.11-stage",
+  "version": "1.23.13-beta",
   "type": "commonjs",
   "license": "MIT",
   "homepage": "https://buddy.works/docs/cli",
@@ -51,7 +51,7 @@
     "@fastify/cors": "11.2.0",
     "@inquirer/prompts": "8.5.2",
     "@modelcontextprotocol/sdk": "1.30.0",
-    "@puppeteer/browsers": "2.13.0",
+    "@puppeteer/browsers": "3.2.0",
     "@scalar/json-magic": "0.12.16",
     "@scalar/openapi-parser": "0.28.7",
     "@scalar/openapi-types": "0.9.1",
@@ -79,7 +79,7 @@
     "picomatch": "4.0.4",
     "pino": "10.3.1",
     "punycode": "2.3.1",
-    "puppeteer-core": "23.11.1",
+    "puppeteer-core": "25.6.0",
     "range-parser": "1.2.1",
     "socket.io-client": "4.8.3",
     "ssh2": "1.17.0",