bdtui 0.7.0 → 0.7.1

package/CHANGELOG.md

@@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.
 
 ## [Unreleased]
 
+## [0.7.1] - 2026-06-21
+
+### Fixed
+
+- The **Keybindings** (`?`) help can now be dismissed after a mouse click moves focus to the Beads list or Detail pane. Its close keys were bound to the help box itself, so once a click stole focus the modal became unclosable (every global key is suppressed while a modal is open). `q`/`Esc`/`h` are now bound at the screen level and dismiss it regardless of which pane holds focus.
+- Reopening the Keybindings help with `?` works again. `?` is now a single open/close toggle, fixing a re-entrancy where the freshly-registered `?` close handler fired on the very keypress that opened the modal and slammed it shut.
+- The boot status bar no longer shows the `? help` hint twice. `setStatus` already appends it, so the redundant hint baked into the "Ready" message was removed.
+
 ## [0.7.0] - 2026-06-21
 
 ### Added

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bdtui",
-  "version": "0.7.0",
+  "version": "0.7.1",
   "description": "Terminal UI for the bd beads issue tracker",
   "type": "module",
   "bin": {

package/src/app.js

@@ -282,9 +282,19 @@ export async function run(cwd) {
     setStatus(defaultStatus());
   });
 
-  key(['?'], () => {
+  // '?' toggles the help modal. Registered directly (NOT through key(), which
+  // swallows every global while a modal is open) so the same key that opens the
+  // help can also close it. Driving open AND close from this one handler — kept
+  // out of showHelp's own close keys — avoids re-entrancy: a separate '?' close
+  // binding would fire on the very keypress that registered it and slam the
+  // modal shut again. closeHelp is non-null exactly while the help is open.
+  let closeHelp = null;
+  screen.key(['?'], () => {
+    if (closeHelp) { closeHelp(); return; }
+    if (modalOpen) return; // another modal (a picker) owns the screen
     modalOpen = true;
-    showHelp(screen, () => {
+    closeHelp = showHelp(screen, () => {
+      closeHelp = null;
       modalOpen = false;
       list.focus();
       screen.render();
@@ -564,5 +574,7 @@ export async function run(cwd) {
     setStatus(err.message, true);
   }
   render();
-  setStatus('Ready | ? help');
+  // setStatus already appends "? help · q quit"; defaultStatus() yields "Ready"
+  // (or the active-filter summary) without duplicating the help hint.
+  setStatus(defaultStatus());
 }

package/src/keys.js

@@ -65,11 +65,34 @@ export function showHelp(screen, onClose) {
   box.focus();
   screen.render();
 
+  // '?' is deliberately NOT a close key here — the caller (app.js) drives it as
+  // an open/close toggle. Binding '?' as a close key would re-enter on the very
+  // keypress that opens the modal: the toggle adds this listener mid-dispatch
+  // and blessed's emitter would then fire it in the same 'key ?' pass, slamming
+  // the help shut the instant it opened. q/Esc/h are safe — they never open the
+  // help, so they can only ever close it.
+  const CLOSE_KEYS = ['q', 'escape', 'h'];
+  let closed = false;
   const close = () => {
+    if (closed) return;
+    closed = true;
+    screen.unkey(CLOSE_KEYS, close);
     box.destroy();
     screen.render();
     onClose?.();
   };
 
-  box.key(['?', 'q', 'escape', 'h'], close);
+  // Bind the close keys on the screen, not the box. A box-level binding only
+  // fires while the box holds keyboard focus, but the Beads list and Detail
+  // pane are both mouse:true — a click on either steals focus from the help
+  // box. app.js suppresses every global key while a modal is open, so a
+  // focus-stealing click would otherwise leave the help permanently stuck
+  // open (its own close keys dead, every global key inert). Screen-level keys
+  // fire regardless of which pane holds focus, so q/Esc/h always dismiss it.
+  // unkey() on close keeps the binding from leaking across repeated opens.
+  screen.key(CLOSE_KEYS, close);
+
+  // Returned so the caller's '?' toggle can dismiss the help regardless of
+  // which pane currently holds focus.
+  return close;
 }