bc-code-intelligence-mcp 1.5.9 → 1.6.1

package/embedded-knowledge/workflows/code-review.yaml

@@ -0,0 +1,148 @@
+type: "code-review"
+name: "Business Central Code Review"
+description: "Systematic code review for AL extensions focusing on performance, security, and maintainability"
+specialist: "roger-reviewer"
+
+file_patterns:
+  - "**/*.al"
+file_exclusions:
+  - "**/test/**"
+  - "**/Test/**"
+  - "**/.altestrunner/**"
+  - "**/node_modules/**"
+
+phases:
+  - id: "inventory"
+    name: "File Inventory"
+    description: "Enumerate all AL files in scope"
+    required: true
+    mode: "autonomous"
+
+  - id: "preparation"
+    name: "Pre-Review Preparation"
+    description: "Verify tests pass, run static analysis, check formatting"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "inventory phase completed"
+    available_actions:
+      - "run_tests"
+      - "run_static_analysis"
+      - "check_formatting"
+
+  - id: "analysis"
+    name: "Code Analysis"
+    description: "Run analyze_al_code on each file, expand checklists with relevant topics"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "preparation phase completed"
+    available_actions:
+      - "analyze_file"
+      - "expand_checklist"
+      - "record_finding"
+
+  - id: "performance_review"
+    name: "Performance Analysis"
+    description: "Check SetLoadFields usage, query patterns, SIFT usage, loop efficiency"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "analysis phase completed"
+    available_actions:
+      - "check_setloadfields"
+      - "check_query_patterns"
+      - "check_sift_usage"
+      - "check_loop_efficiency"
+      - "record_finding"
+
+  - id: "security_review"
+    name: "Security & Validation"
+    description: "Validate input handling, permissions, error handling, data validation"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "performance_review phase completed"
+    available_actions:
+      - "check_input_validation"
+      - "check_permissions"
+      - "check_error_handling"
+      - "record_finding"
+
+  - id: "maintainability"
+    name: "Code Maintainability"
+    description: "Check naming conventions, complexity, commenting, testability"
+    required: false
+    mode: "guided"
+    entry_conditions:
+      - "security_review phase completed"
+    available_actions:
+      - "check_naming"
+      - "check_complexity"
+      - "check_documentation"
+      - "record_finding"
+
+  - id: "summary"
+    name: "Summary & Report"
+    description: "Generate final review report with findings and recommendations"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "security_review phase completed"
+
+per_file_checklist:
+  - id: "analyze"
+    type: "analysis"
+    description: "Run analyze_al_code to discover relevant topics"
+    required: true
+
+  - id: "setloadfields_check"
+    type: "topic_application"
+    description: "Check SetLoadFields usage before FindSet/FindFirst"
+    required: true
+    conditions:
+      content_pattern: "Find(Set|First|Last)\\s*\\("
+
+  - id: "query_patterns_check"
+    type: "topic_application"
+    description: "Verify efficient query patterns (SetRange, SetFilter, SetCurrentKey)"
+    required: true
+    conditions:
+      content_pattern: "SetRange|SetFilter|SetCurrentKey"
+
+  - id: "sift_check"
+    type: "topic_application"
+    description: "Validate SIFT usage for summations instead of manual loops"
+    required: true
+    conditions:
+      content_pattern: "CalcSums|CalcFields|repeat"
+
+  - id: "loop_efficiency_check"
+    type: "topic_application"
+    description: "Review loop efficiency and minimal processing inside repeat-until"
+    required: true
+    conditions:
+      content_pattern: "repeat"
+
+  - id: "error_handling_check"
+    type: "topic_application"
+    description: "Verify error handling patterns"
+    required: true
+    conditions:
+      content_pattern: "Error\\(|if.*then.*Error"
+
+  - id: "review_complete"
+    type: "validation"
+    description: "Mark review complete for this file"
+    required: true
+
+topic_discovery:
+  enabled: true
+  tool: "analyze_al_code"
+  auto_expand_checklist: true
+  min_relevance_score: 0.6
+
+completion_rules:
+  require_all_files: true
+  require_all_checklist_items: true
+  allow_skip_with_reason: true

package/embedded-knowledge/workflows/error-to-errorinfo-migration.yaml

@@ -0,0 +1,137 @@
+type: "error-to-errorinfo-migration"
+name: "Error to ErrorInfo Migration"
+description: "Convert legacy Error() calls to modern ErrorInfo pattern for better error handling"
+specialist: "eva-errors"
+
+file_patterns:
+  - "**/*.al"
+file_exclusions:
+  - "**/test/**"
+  - "**/Test/**"
+  - "**/.altestrunner/**"
+
+phases:
+  - id: "inventory"
+    name: "File Inventory"
+    description: "Enumerate all AL files"
+    required: true
+    mode: "autonomous"
+
+  - id: "pattern_scan"
+    name: "Pattern Scan"
+    description: "Scan all files for Error() patterns"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "inventory phase completed"
+    available_actions:
+      - "scan_file"
+      - "expand_checklist_with_instances"
+
+  - id: "batch_auto"
+    name: "Batch Auto-Fix"
+    description: "Apply automatic fixes to simple patterns (literal strings, StrSubstNo)"
+    required: false
+    mode: "autonomous"
+    entry_conditions:
+      - "pattern_scan phase completed"
+    available_actions:
+      - "batch_apply"
+      - "skip_batch"
+
+  - id: "manual_review"
+    name: "Manual Review"
+    description: "Review and convert complex patterns (text constants, function calls)"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "pattern_scan phase completed"
+    available_actions:
+      - "convert_instance"
+      - "skip_instance"
+      - "flag_for_later"
+
+  - id: "verification"
+    name: "Verification"
+    description: "Verify all conversions compile and work correctly"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "manual_review phase completed"
+    available_actions:
+      - "compile_check"
+      - "run_tests"
+
+  - id: "summary"
+    name: "Summary & Report"
+    description: "Generate migration report with statistics"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "verification phase completed"
+
+per_file_checklist:
+  - id: "scan"
+    type: "analysis"
+    description: "Scan for Error() patterns"
+    required: true
+
+  - id: "review_complete"
+    type: "validation"
+    description: "All Error() calls addressed"
+    required: true
+
+topic_discovery:
+  enabled: true
+  tool: "retrieve_bc_knowledge"
+  auto_expand_checklist: false
+  min_relevance_score: 0.8
+
+pattern_discovery:
+  enabled: true
+  create_instance_items: true
+  group_identical: true
+  specialist: "eva-errors"
+  patterns:
+    - id: "error-call"
+      name: "Error() Call"
+      description: "Legacy Error() function calls that should use ErrorInfo"
+      regex: "Error\\s*\\((?!\\s*ErrorInfo)[^)]+\\)"
+      regex_flags: "gi"
+      exclude_regex: "//.*Error|ErrorInfo\\.Create"
+      context_lines: 2
+      instance_classifier:
+        rules:
+          - name: "literal"
+            pattern: "Error\\s*\\(\\s*'[^']*'\\s*\\)"
+            suggested_action: "Wrap string in ErrorInfo.Create()"
+            auto_fixable: true
+          - name: "strsubstno"
+            pattern: "Error\\s*\\(\\s*StrSubstNo\\s*\\("
+            suggested_action: "Convert to ErrorInfo.Create(StrSubstNo(...))"
+            auto_fixable: true
+          - name: "text_constant"
+            pattern: "Error\\s*\\(\\s*[A-Z][A-Za-z0-9_]+Lbl\\s*\\)"
+            suggested_action: "Review text constant, then wrap in ErrorInfo.Create()"
+            auto_fixable: false
+          - name: "function_call"
+            pattern: "Error\\s*\\(\\s*[A-Z][A-Za-z0-9_]+\\s*\\("
+            suggested_action: "Analyze function return, may need ErrorInfo integration"
+            auto_fixable: false
+      transformations:
+        - instance_type: "literal"
+          template: "Error(ErrorInfo.Create({{original_string}}))"
+          requires_review: false
+        - instance_type: "strsubstno"
+          template: "Error(ErrorInfo.Create(StrSubstNo({{original_string}}, {{params}})))"
+          requires_review: false
+        - instance_type: "text_constant"
+          template: "Error(ErrorInfo.Create({{constant_name}}))"
+          requires_review: true
+      specialist: "eva-errors"
+      topic_id: "eva-errors/fielderror-method-syntax"
+
+completion_rules:
+  require_all_files: true
+  require_all_checklist_items: true
+  allow_skip_with_reason: true

package/embedded-knowledge/workflows/onboarding.yaml

@@ -0,0 +1,124 @@
+type: "onboarding"
+name: "Developer Onboarding"
+description: "Guide new developers through a Business Central codebase, explaining architecture, patterns, and conventions"
+specialist: "maya-mentor"
+
+file_patterns:
+  - "**/*.al"
+  - "**/app.json"
+  - "**/README.md"
+file_exclusions:
+  - "**/node_modules/**"
+  - "**/.altestrunner/**"
+
+phases:
+  - id: "project_overview"
+    name: "Project Overview"
+    description: "Understand project structure, app.json configuration, and high-level architecture"
+    required: true
+    mode: "guided"
+    available_actions:
+      - "read_app_json"
+      - "scan_folder_structure"
+      - "identify_modules"
+      - "explain_architecture"
+
+  - id: "table_discovery"
+    name: "Data Model Discovery"
+    description: "Explore table objects and understand the data model"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "project_overview phase completed"
+    available_actions:
+      - "list_tables"
+      - "explain_relationships"
+      - "identify_key_tables"
+
+  - id: "business_logic"
+    name: "Business Logic Exploration"
+    description: "Explore codeunits and understand core business logic"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "table_discovery phase completed"
+    available_actions:
+      - "list_codeunits"
+      - "explain_workflows"
+      - "identify_entry_points"
+
+  - id: "ui_exploration"
+    name: "UI Exploration"
+    description: "Explore pages and understand user interface patterns"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "business_logic phase completed"
+    available_actions:
+      - "list_pages"
+      - "explain_navigation"
+      - "identify_key_pages"
+
+  - id: "patterns_conventions"
+    name: "Patterns & Conventions"
+    description: "Identify coding patterns, naming conventions, and team standards"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "ui_exploration phase completed"
+    available_actions:
+      - "identify_patterns"
+      - "explain_conventions"
+      - "highlight_best_practices"
+
+  - id: "integration_points"
+    name: "Integration Points"
+    description: "Identify APIs, events, and integration touchpoints"
+    required: false
+    mode: "guided"
+    entry_conditions:
+      - "business_logic phase completed"
+    available_actions:
+      - "list_apis"
+      - "list_events"
+      - "explain_integrations"
+
+  - id: "summary"
+    name: "Onboarding Summary"
+    description: "Generate onboarding summary document with key learnings"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "patterns_conventions phase completed"
+
+per_file_checklist:
+  - id: "understand_purpose"
+    type: "analysis"
+    description: "Understand the purpose of this object"
+    required: true
+
+  - id: "identify_patterns"
+    type: "custom"
+    description: "Identify patterns used in this file"
+    required: false
+
+  - id: "note_conventions"
+    type: "custom"
+    description: "Note naming conventions and coding style"
+    required: false
+
+  - id: "explored"
+    type: "validation"
+    description: "File explored and understood"
+    required: true
+
+topic_discovery:
+  enabled: true
+  tool: "find_bc_knowledge"
+  auto_expand_checklist: false
+  min_relevance_score: 0.4
+
+completion_rules:
+  require_all_files: false
+  require_all_checklist_items: false
+  allow_skip_with_reason: true

package/embedded-knowledge/workflows/performance-audit.yaml

@@ -0,0 +1,148 @@
+type: "performance-audit"
+name: "Performance Audit"
+description: "Comprehensive performance analysis and optimization for Business Central AL code"
+specialist: "dean-debug"
+
+file_patterns:
+  - "**/*.al"
+file_exclusions:
+  - "**/test/**"
+  - "**/Test/**"
+  - "**/.altestrunner/**"
+
+phases:
+  - id: "inventory"
+    name: "File Inventory"
+    description: "Enumerate all AL files and assess codebase size"
+    required: true
+    mode: "autonomous"
+
+  - id: "analysis_quick"
+    name: "Quick Analysis"
+    description: "Rapid scan for common performance anti-patterns"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "inventory phase completed"
+    available_actions:
+      - "scan_patterns"
+      - "identify_hotspots"
+
+  - id: "analysis_full"
+    name: "Full Analysis"
+    description: "Deep analysis of all procedures for performance patterns"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "analysis_quick phase completed"
+    available_actions:
+      - "analyze_procedure"
+      - "check_all_patterns"
+      - "document_coverage"
+      - "cross_reference"
+
+  - id: "performance_quick"
+    name: "Quick Optimization"
+    description: "Apply straightforward optimizations (SetLoadFields, obvious SIFT)"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "analysis_full phase completed"
+    available_actions:
+      - "apply_setloadfields"
+      - "apply_sift"
+      - "optimize_loops"
+
+  - id: "performance_full"
+    name: "Full Optimization"
+    description: "Complex optimizations requiring architectural consideration"
+    required: false
+    mode: "agent_driven"
+    entry_conditions:
+      - "performance_quick phase completed"
+    available_actions:
+      - "redesign_query"
+      - "implement_caching"
+      - "batch_operations"
+      - "refactor_loops"
+
+  - id: "execution_validation"
+    name: "Execution Validation"
+    description: "Verify optimizations are correctly implemented and functional"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "performance_quick phase completed"
+    available_actions:
+      - "verify_changes"
+      - "test_compilation"
+      - "validate_logic"
+
+  - id: "verification"
+    name: "Coverage Verification"
+    description: "Ensure all files analyzed and no procedures missed"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "execution_validation phase completed"
+    available_actions:
+      - "validate_coverage"
+      - "detect_gaps"
+      - "generate_report"
+
+per_file_checklist:
+  - id: "scan"
+    type: "analysis"
+    description: "Scan for performance patterns"
+    required: true
+
+  - id: "setloadfields_check"
+    type: "topic_application"
+    description: "Check SetLoadFields before record operations"
+    required: true
+    conditions:
+      content_pattern: "Find(Set|First|Last)\\s*\\("
+
+  - id: "sift_check"
+    type: "topic_application"
+    description: "Check for manual summation that should use SIFT"
+    required: true
+    conditions:
+      content_pattern: "repeat.*\\+.*until|:=.*\\+.*;"
+
+  - id: "loop_check"
+    type: "topic_application"
+    description: "Check loop efficiency patterns"
+    required: true
+    conditions:
+      content_pattern: "repeat"
+
+  - id: "calcsums_check"
+    type: "topic_application"
+    description: "Verify CalcSums/CalcFields usage"
+    required: true
+    conditions:
+      content_pattern: "CalcSums|CalcFields"
+
+  - id: "deleteall_check"
+    type: "topic_application"
+    description: "Review DeleteAll usage and trigger implications"
+    required: true
+    conditions:
+      content_pattern: "DeleteAll"
+
+  - id: "optimization_complete"
+    type: "validation"
+    description: "All performance issues addressed"
+    required: true
+
+topic_discovery:
+  enabled: true
+  tool: "analyze_al_code"
+  auto_expand_checklist: true
+  min_relevance_score: 0.5
+
+completion_rules:
+  require_all_files: true
+  require_all_checklist_items: true
+  allow_skip_with_reason: true

package/embedded-knowledge/workflows/proposal-review.yaml

@@ -0,0 +1,117 @@
+type: "proposal-review"
+name: "Proposal Review Workflow"
+description: "Systematic approach to AI-assisted development that builds trust through transparent reasoning, reviewable proposals, and collaborative specialist validation"
+specialist: "parker-pragmatic"
+
+file_patterns:
+  - "**/*.al"
+  - "**/*.md"
+file_exclusions:
+  - "**/node_modules/**"
+  - "**/.parker-proposals/**"
+
+phases:
+  - id: "understanding"
+    name: "Understanding & Reasoning"
+    description: "Establish clear understanding of the request, explain AI reasoning, identify alternatives, state confidence level, recommend specialists"
+    required: true
+    mode: "guided"
+    available_actions:
+      - "restate_request"
+      - "explain_reasoning"
+      - "identify_alternatives"
+      - "state_confidence"
+      - "recommend_specialists"
+
+  - id: "proposal_creation"
+    name: "Proposal Creation"
+    description: "Generate complete, reviewable implementation in temporary sandbox location (.parker-proposals/)"
+    required: true
+    mode: "agent_driven"
+    entry_conditions:
+      - "understanding phase completed"
+    available_actions:
+      - "create_sandbox"
+      - "implement_solution"
+      - "add_documentation"
+      - "provide_comparison"
+      - "create_cleanup_instructions"
+
+  - id: "specialist_review"
+    name: "Specialist Review"
+    description: "Coordinate validation from relevant BC specialists before developer decides"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "proposal_creation phase completed"
+    available_actions:
+      - "identify_reviewers"
+      - "present_proposal"
+      - "gather_feedback"
+      - "synthesize_input"
+      - "revise_proposal"
+
+  - id: "developer_decision"
+    name: "Developer Decision"
+    description: "Present complete picture, explain trade-offs, respect developer choice, support implementation"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "specialist_review phase completed"
+    available_actions:
+      - "present_options"
+      - "explain_tradeoffs"
+      - "accept_proposal"
+      - "modify_proposal"
+      - "reject_proposal"
+
+  - id: "verification_cleanup"
+    name: "Verification & Cleanup"
+    description: "Confirm results match expectations and remove all temporary artifacts"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "developer_decision phase completed"
+    available_actions:
+      - "verify_implementation"
+      - "validate_assumptions"
+      - "check_performance"
+      - "remove_proposals"
+      - "document_learning"
+
+per_file_checklist:
+  - id: "understand_context"
+    type: "analysis"
+    description: "Analyze file context and identify relevant patterns"
+    required: true
+
+  - id: "create_proposal"
+    type: "custom"
+    description: "Create proposal with reasoning and alternatives"
+    required: true
+
+  - id: "specialist_validation"
+    type: "custom"
+    description: "Get specialist validation on proposed changes"
+    required: true
+
+  - id: "decision_recorded"
+    type: "validation"
+    description: "Developer decision recorded (accept/modify/reject)"
+    required: true
+
+  - id: "cleanup_complete"
+    type: "validation"
+    description: "All temporary artifacts removed"
+    required: true
+
+topic_discovery:
+  enabled: true
+  tool: "find_bc_knowledge"
+  auto_expand_checklist: false
+  min_relevance_score: 0.5
+
+completion_rules:
+  require_all_files: false
+  require_all_checklist_items: true
+  allow_skip_with_reason: true