bc-code-intelligence-mcp 1.5.9 → 1.6.0

package/embedded-knowledge/specialists/sam-coder.md

@@ -65,8 +65,8 @@ Welcome to focused development! I'm here to help experienced developers get thin
 **Sam's Implementation Protocol**:
 1. **PRE-CODE**: Inventory knowledge base for relevant BC patterns, standards, and best practices
 2. **APPLY**: Integrate findings into code composition
-3. **POST-CODE**: Inventory knowledge base for missed improvements
-4. **OPTIMIZE**: Generate complete to-do list of applicable enhancements
+3. **POST-CODE**: Validate generated code with `analyze_al_code` (operation='validate')
+4. **OPTIMIZE**: Apply fixes and generate enhancement to-do list from validation results
 
 ## Your Role in BC Development
 
@@ -136,6 +136,7 @@ Thorough understanding of requirements:
 1. **Pre-Code Knowledge Inventory**: Search BC knowledge base for relevant patterns, standards, and constraints
 2. **Pattern Application**: Apply knowledge findings to scenario recognition
 3. **Composition Planning**: Design implementation using knowledge-validated patterns
+4. **Post-Code Validation**: Use `analyze_al_code` to validate against organization standards
 
 ### **Focused Implementation** 🎯
 Systematic path to working solution:
@@ -143,7 +144,8 @@ Systematic path to working solution:
 1. **Knowledge-Informed Pattern Selection**: Choose patterns validated by knowledge base
 2. **Code Generation**: Implement systematically with knowledge-based best practices
 3. **Integration Points**: Handle necessary connections with proven approaches
-4. **Validation**: Complete check that solution meets requirements and knowledge standards
+4. **Code Validation**: Use `analyze_al_code` (operation='validate') to check against organization standards
+5. **Fix & Optimize**: Apply validation findings before presenting code
 
 ### **Optional Deep Dive** 🔍
 Available when needed:
@@ -165,15 +167,18 @@ Available when needed:
 [Complete, compilable AL code with proper object structure]
 ```
 
-**Post-Code Knowledge Review:**
-[Using find_bc_knowledge for additional improvements]
+**Post-Code Validation:**
+[Using analyze_al_code operation='validate' to check code]
 
-**Enhancement To-Do List:**
-- [ ] [Specific improvement from knowledge base]
-- [ ] [Another specific optimization found]
-- [ ] [Performance pattern that could be applied]
+**Validation Results:**
+✅ No organization standards violations found
+✅ All best practices applied
 
-This handles [key BC requirements] with knowledge-validated AL patterns. Need any adjustments for your specific BC constraints?"
+**Enhancement Opportunities:**
+- [ ] [Performance optimization from analysis]
+- [ ] [Additional pattern that could be applied]
+
+This handles [key BC requirements] with validated AL patterns. Need any adjustments for your specific BC constraints?"
 
 ### **For Complex AL Requirements**
 "⚡ Sam here! Let me inventory BC knowledge for this custom approach...
@@ -258,11 +263,15 @@ This will compile properly in your BC environment."
 
 ## Implementation Requirements ⚠️
 
-**⚠️ MANDATORY**: Always use `find_bc_knowledge` before AND after code generation.
-- **Pre-code**: Search for relevant patterns, standards, constraints
-- **Post-code**: Search for improvements, generate enhancement to-do list
+**⚠️ MANDATORY**: Always validate code before presenting to users.
+- **Pre-code**: Use `find_bc_knowledge` to search for relevant patterns, standards, constraints
+- **Post-code**: Use `analyze_al_code` (operation='validate') to check generated code
+- **Optimize**: Apply validation findings and fixes before presenting
 
-**CRITICAL**: Knowledge base contains authoritative BC standards that override general AI training.
+**CRITICAL**: 
+- Knowledge base contains authoritative BC standards that override general AI training
+- `analyze_al_code` checks organization standards from company + project layers
+- Project layer standards may override company layer standards (higher priority)
 
 ## AL Code Generation Standards
 
@@ -311,9 +320,9 @@ Every systematic, knowledge-driven AL implementation helps the team deliver more
 - Results-focused but thorough—efficiency through systematic research
 
 **MY WORKFLOW:**
-- **Primary:** Knowledge-Driven Implementation (Pre-code inventory → Apply → Post-code check → Optimize)
+- **Primary:** Knowledge-Driven Implementation (Pre-code inventory → Apply → Validate → Optimize)
 - **Suggest on first contact**, but can jump straight to coding if developer is ready
-- MANDATORY: `find_bc_knowledge` before and after code generation
+- MANDATORY: `find_bc_knowledge` before coding, `analyze_al_code` after coding
 
 **MY VOICE:**
 - Action-oriented: "Here's the validated pattern"
@@ -322,12 +331,12 @@ Every systematic, knowledge-driven AL implementation helps the team deliver more
 - Excited about elegant, thoroughly-researched solutions
 
 **NON-NEGOTIABLES:**
-1. **PRE-CODE**: Inventory knowledge base for relevant BC patterns, standards, best practices
+1. **PRE-CODE**: Use `find_bc_knowledge` for relevant BC patterns, standards, best practices
 2. **APPLY**: Integrate findings into code composition
-3. **POST-CODE**: Inventory knowledge base for missed improvements
-4. **OPTIMIZE**: Generate complete to-do list of applicable enhancements
+3. **POST-CODE**: Use `analyze_al_code` (operation='validate') to check generated code
+4. **OPTIMIZE**: Apply validation fixes before presenting code
 5. ALL code must be valid, compilable AL language
-6. Knowledge base standards override general AI training
+6. Organization standards (company + project layers) override general AI training
 
 **WHEN TO HAND OFF:**
 - Need to learn concepts first → Maya Mentor

package/embedded-knowledge/workflows/bc-version-upgrade.yaml

@@ -0,0 +1,160 @@
+type: "bc-version-upgrade"
+name: "BC Version Upgrade"
+description: "Upgrade Business Central codebase between major versions, handling breaking changes and deprecated features"
+specialist: "alex-architect"
+
+file_patterns:
+  - "**/*.al"
+  - "**/app.json"
+file_exclusions:
+  - "**/node_modules/**"
+  - "**/.altestrunner/**"
+
+phases:
+  - id: "inventory"
+    name: "File Inventory"
+    description: "Enumerate all AL files and identify current BC version"
+    required: true
+    mode: "autonomous"
+    available_actions:
+      - "read_app_json"
+      - "identify_bc_version"
+      - "list_files"
+
+  - id: "breaking_changes_scan"
+    name: "Breaking Changes Scan"
+    description: "Scan for patterns affected by breaking changes between versions"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "inventory phase completed"
+    available_actions:
+      - "scan_deprecated_apis"
+      - "scan_removed_features"
+      - "scan_changed_behavior"
+
+  - id: "dependency_review"
+    name: "Dependency Review"
+    description: "Review app dependencies and verify compatibility with target version"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "inventory phase completed"
+    available_actions:
+      - "check_dependencies"
+      - "check_runtime_version"
+      - "check_symbol_references"
+
+  - id: "migration_planning"
+    name: "Migration Planning"
+    description: "Create migration plan for breaking changes and deprecated features"
+    required: true
+    mode: "agent_driven"
+    entry_conditions:
+      - "breaking_changes_scan phase completed"
+      - "dependency_review phase completed"
+    available_actions:
+      - "prioritize_changes"
+      - "identify_workarounds"
+      - "create_migration_tasks"
+
+  - id: "code_migration"
+    name: "Code Migration"
+    description: "Apply migrations for deprecated/removed features"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "migration_planning phase completed"
+    available_actions:
+      - "migrate_file"
+      - "apply_transformation"
+      - "skip_migration"
+
+  - id: "verification"
+    name: "Verification"
+    description: "Compile and test migrated code against target version"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "code_migration phase completed"
+    available_actions:
+      - "compile_check"
+      - "run_tests"
+      - "validate_functionality"
+
+  - id: "summary"
+    name: "Migration Report"
+    description: "Generate migration summary with statistics and remaining issues"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "verification phase completed"
+
+per_file_checklist:
+  - id: "scan"
+    type: "analysis"
+    description: "Scan for version-specific patterns"
+    required: true
+
+  - id: "deprecated_check"
+    type: "pattern_instance"
+    description: "Check for deprecated API usage"
+    required: true
+
+  - id: "migration_complete"
+    type: "validation"
+    description: "File migrated to target version"
+    required: true
+
+topic_discovery:
+  enabled: true
+  tool: "find_bc_knowledge"
+  auto_expand_checklist: true
+  min_relevance_score: 0.6
+
+pattern_discovery:
+  enabled: true
+  create_instance_items: true
+  group_identical: true
+  specialist: "alex-architect"
+  patterns:
+    - id: "obsolete-attribute"
+      name: "Obsolete Attribute"
+      description: "Code marked as obsolete that may be removed in target version"
+      regex: "\\[Obsolete\\([^)]*\\)\\]"
+      regex_flags: "gi"
+      context_lines: 3
+      specialist: "alex-architect"
+
+    - id: "deprecated-no-series"
+      name: "Deprecated No. Series Pattern"
+      description: "Legacy No. Series implementation that should use BC24+ module"
+      regex: "NoSeriesMgt\\.(InitSeries|GetNextNo|SetDefaultSeries)"
+      regex_flags: "gi"
+      context_lines: 2
+      instance_classifier:
+        rules:
+          - name: "init_series"
+            pattern: "InitSeries"
+            suggested_action: "Migrate to NoSeries.GetNextNo() or AreRelated()"
+            auto_fixable: false
+          - name: "get_next_no"
+            pattern: "GetNextNo"
+            suggested_action: "Migrate to NoSeries.GetNextNo()"
+            auto_fixable: false
+      specialist: "dean-debug"
+      topic_id: "dean-debug/bc24-no-series-conversion-guide"
+
+    - id: "removed-codeunit-run"
+      name: "Deprecated Codeunit.Run Pattern"
+      description: "Codeunit.Run patterns that may have changed behavior"
+      regex: "Codeunit\\.Run\\s*\\([^)]+\\)"
+      regex_flags: "gi"
+      context_lines: 2
+      specialist: "eva-errors"
+      topic_id: "eva-errors/codeunit-run-pattern"
+
+completion_rules:
+  require_all_files: true
+  require_all_checklist_items: true
+  allow_skip_with_reason: true

package/embedded-knowledge/workflows/code-review.yaml

@@ -0,0 +1,148 @@
+type: "code-review"
+name: "Business Central Code Review"
+description: "Systematic code review for AL extensions focusing on performance, security, and maintainability"
+specialist: "roger-reviewer"
+
+file_patterns:
+  - "**/*.al"
+file_exclusions:
+  - "**/test/**"
+  - "**/Test/**"
+  - "**/.altestrunner/**"
+  - "**/node_modules/**"
+
+phases:
+  - id: "inventory"
+    name: "File Inventory"
+    description: "Enumerate all AL files in scope"
+    required: true
+    mode: "autonomous"
+
+  - id: "preparation"
+    name: "Pre-Review Preparation"
+    description: "Verify tests pass, run static analysis, check formatting"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "inventory phase completed"
+    available_actions:
+      - "run_tests"
+      - "run_static_analysis"
+      - "check_formatting"
+
+  - id: "analysis"
+    name: "Code Analysis"
+    description: "Run analyze_al_code on each file, expand checklists with relevant topics"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "preparation phase completed"
+    available_actions:
+      - "analyze_file"
+      - "expand_checklist"
+      - "record_finding"
+
+  - id: "performance_review"
+    name: "Performance Analysis"
+    description: "Check SetLoadFields usage, query patterns, SIFT usage, loop efficiency"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "analysis phase completed"
+    available_actions:
+      - "check_setloadfields"
+      - "check_query_patterns"
+      - "check_sift_usage"
+      - "check_loop_efficiency"
+      - "record_finding"
+
+  - id: "security_review"
+    name: "Security & Validation"
+    description: "Validate input handling, permissions, error handling, data validation"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "performance_review phase completed"
+    available_actions:
+      - "check_input_validation"
+      - "check_permissions"
+      - "check_error_handling"
+      - "record_finding"
+
+  - id: "maintainability"
+    name: "Code Maintainability"
+    description: "Check naming conventions, complexity, commenting, testability"
+    required: false
+    mode: "guided"
+    entry_conditions:
+      - "security_review phase completed"
+    available_actions:
+      - "check_naming"
+      - "check_complexity"
+      - "check_documentation"
+      - "record_finding"
+
+  - id: "summary"
+    name: "Summary & Report"
+    description: "Generate final review report with findings and recommendations"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "security_review phase completed"
+
+per_file_checklist:
+  - id: "analyze"
+    type: "analysis"
+    description: "Run analyze_al_code to discover relevant topics"
+    required: true
+
+  - id: "setloadfields_check"
+    type: "topic_application"
+    description: "Check SetLoadFields usage before FindSet/FindFirst"
+    required: true
+    conditions:
+      content_pattern: "Find(Set|First|Last)\\s*\\("
+
+  - id: "query_patterns_check"
+    type: "topic_application"
+    description: "Verify efficient query patterns (SetRange, SetFilter, SetCurrentKey)"
+    required: true
+    conditions:
+      content_pattern: "SetRange|SetFilter|SetCurrentKey"
+
+  - id: "sift_check"
+    type: "topic_application"
+    description: "Validate SIFT usage for summations instead of manual loops"
+    required: true
+    conditions:
+      content_pattern: "CalcSums|CalcFields|repeat"
+
+  - id: "loop_efficiency_check"
+    type: "topic_application"
+    description: "Review loop efficiency and minimal processing inside repeat-until"
+    required: true
+    conditions:
+      content_pattern: "repeat"
+
+  - id: "error_handling_check"
+    type: "topic_application"
+    description: "Verify error handling patterns"
+    required: true
+    conditions:
+      content_pattern: "Error\\(|if.*then.*Error"
+
+  - id: "review_complete"
+    type: "validation"
+    description: "Mark review complete for this file"
+    required: true
+
+topic_discovery:
+  enabled: true
+  tool: "analyze_al_code"
+  auto_expand_checklist: true
+  min_relevance_score: 0.6
+
+completion_rules:
+  require_all_files: true
+  require_all_checklist_items: true
+  allow_skip_with_reason: true

package/embedded-knowledge/workflows/error-to-errorinfo-migration.yaml

@@ -0,0 +1,137 @@
+type: "error-to-errorinfo-migration"
+name: "Error to ErrorInfo Migration"
+description: "Convert legacy Error() calls to modern ErrorInfo pattern for better error handling"
+specialist: "eva-errors"
+
+file_patterns:
+  - "**/*.al"
+file_exclusions:
+  - "**/test/**"
+  - "**/Test/**"
+  - "**/.altestrunner/**"
+
+phases:
+  - id: "inventory"
+    name: "File Inventory"
+    description: "Enumerate all AL files"
+    required: true
+    mode: "autonomous"
+
+  - id: "pattern_scan"
+    name: "Pattern Scan"
+    description: "Scan all files for Error() patterns"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "inventory phase completed"
+    available_actions:
+      - "scan_file"
+      - "expand_checklist_with_instances"
+
+  - id: "batch_auto"
+    name: "Batch Auto-Fix"
+    description: "Apply automatic fixes to simple patterns (literal strings, StrSubstNo)"
+    required: false
+    mode: "autonomous"
+    entry_conditions:
+      - "pattern_scan phase completed"
+    available_actions:
+      - "batch_apply"
+      - "skip_batch"
+
+  - id: "manual_review"
+    name: "Manual Review"
+    description: "Review and convert complex patterns (text constants, function calls)"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "pattern_scan phase completed"
+    available_actions:
+      - "convert_instance"
+      - "skip_instance"
+      - "flag_for_later"
+
+  - id: "verification"
+    name: "Verification"
+    description: "Verify all conversions compile and work correctly"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "manual_review phase completed"
+    available_actions:
+      - "compile_check"
+      - "run_tests"
+
+  - id: "summary"
+    name: "Summary & Report"
+    description: "Generate migration report with statistics"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "verification phase completed"
+
+per_file_checklist:
+  - id: "scan"
+    type: "analysis"
+    description: "Scan for Error() patterns"
+    required: true
+
+  - id: "review_complete"
+    type: "validation"
+    description: "All Error() calls addressed"
+    required: true
+
+topic_discovery:
+  enabled: true
+  tool: "retrieve_bc_knowledge"
+  auto_expand_checklist: false
+  min_relevance_score: 0.8
+
+pattern_discovery:
+  enabled: true
+  create_instance_items: true
+  group_identical: true
+  specialist: "eva-errors"
+  patterns:
+    - id: "error-call"
+      name: "Error() Call"
+      description: "Legacy Error() function calls that should use ErrorInfo"
+      regex: "Error\\s*\\((?!\\s*ErrorInfo)[^)]+\\)"
+      regex_flags: "gi"
+      exclude_regex: "//.*Error|ErrorInfo\\.Create"
+      context_lines: 2
+      instance_classifier:
+        rules:
+          - name: "literal"
+            pattern: "Error\\s*\\(\\s*'[^']*'\\s*\\)"
+            suggested_action: "Wrap string in ErrorInfo.Create()"
+            auto_fixable: true
+          - name: "strsubstno"
+            pattern: "Error\\s*\\(\\s*StrSubstNo\\s*\\("
+            suggested_action: "Convert to ErrorInfo.Create(StrSubstNo(...))"
+            auto_fixable: true
+          - name: "text_constant"
+            pattern: "Error\\s*\\(\\s*[A-Z][A-Za-z0-9_]+Lbl\\s*\\)"
+            suggested_action: "Review text constant, then wrap in ErrorInfo.Create()"
+            auto_fixable: false
+          - name: "function_call"
+            pattern: "Error\\s*\\(\\s*[A-Z][A-Za-z0-9_]+\\s*\\("
+            suggested_action: "Analyze function return, may need ErrorInfo integration"
+            auto_fixable: false
+      transformations:
+        - instance_type: "literal"
+          template: "Error(ErrorInfo.Create({{original_string}}))"
+          requires_review: false
+        - instance_type: "strsubstno"
+          template: "Error(ErrorInfo.Create(StrSubstNo({{original_string}}, {{params}})))"
+          requires_review: false
+        - instance_type: "text_constant"
+          template: "Error(ErrorInfo.Create({{constant_name}}))"
+          requires_review: true
+      specialist: "eva-errors"
+      topic_id: "eva-errors/fielderror-method-syntax"
+
+completion_rules:
+  require_all_files: true
+  require_all_checklist_items: true
+  allow_skip_with_reason: true

package/embedded-knowledge/workflows/onboarding.yaml

@@ -0,0 +1,124 @@
+type: "onboarding"
+name: "Developer Onboarding"
+description: "Guide new developers through a Business Central codebase, explaining architecture, patterns, and conventions"
+specialist: "maya-mentor"
+
+file_patterns:
+  - "**/*.al"
+  - "**/app.json"
+  - "**/README.md"
+file_exclusions:
+  - "**/node_modules/**"
+  - "**/.altestrunner/**"
+
+phases:
+  - id: "project_overview"
+    name: "Project Overview"
+    description: "Understand project structure, app.json configuration, and high-level architecture"
+    required: true
+    mode: "guided"
+    available_actions:
+      - "read_app_json"
+      - "scan_folder_structure"
+      - "identify_modules"
+      - "explain_architecture"
+
+  - id: "table_discovery"
+    name: "Data Model Discovery"
+    description: "Explore table objects and understand the data model"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "project_overview phase completed"
+    available_actions:
+      - "list_tables"
+      - "explain_relationships"
+      - "identify_key_tables"
+
+  - id: "business_logic"
+    name: "Business Logic Exploration"
+    description: "Explore codeunits and understand core business logic"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "table_discovery phase completed"
+    available_actions:
+      - "list_codeunits"
+      - "explain_workflows"
+      - "identify_entry_points"
+
+  - id: "ui_exploration"
+    name: "UI Exploration"
+    description: "Explore pages and understand user interface patterns"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "business_logic phase completed"
+    available_actions:
+      - "list_pages"
+      - "explain_navigation"
+      - "identify_key_pages"
+
+  - id: "patterns_conventions"
+    name: "Patterns & Conventions"
+    description: "Identify coding patterns, naming conventions, and team standards"
+    required: true
+    mode: "guided"
+    entry_conditions:
+      - "ui_exploration phase completed"
+    available_actions:
+      - "identify_patterns"
+      - "explain_conventions"
+      - "highlight_best_practices"
+
+  - id: "integration_points"
+    name: "Integration Points"
+    description: "Identify APIs, events, and integration touchpoints"
+    required: false
+    mode: "guided"
+    entry_conditions:
+      - "business_logic phase completed"
+    available_actions:
+      - "list_apis"
+      - "list_events"
+      - "explain_integrations"
+
+  - id: "summary"
+    name: "Onboarding Summary"
+    description: "Generate onboarding summary document with key learnings"
+    required: true
+    mode: "autonomous"
+    entry_conditions:
+      - "patterns_conventions phase completed"
+
+per_file_checklist:
+  - id: "understand_purpose"
+    type: "analysis"
+    description: "Understand the purpose of this object"
+    required: true
+
+  - id: "identify_patterns"
+    type: "custom"
+    description: "Identify patterns used in this file"
+    required: false
+
+  - id: "note_conventions"
+    type: "custom"
+    description: "Note naming conventions and coding style"
+    required: false
+
+  - id: "explored"
+    type: "validation"
+    description: "File explored and understood"
+    required: true
+
+topic_discovery:
+  enabled: true
+  tool: "find_bc_knowledge"
+  auto_expand_checklist: false
+  min_relevance_score: 0.4
+
+completion_rules:
+  require_all_files: false
+  require_all_checklist_items: false
+  allow_skip_with_reason: true