bc-code-intelligence-mcp 1.5.7 → 1.5.8

package/embedded-knowledge/methodologies/phases/verification-full.md

@@ -1,162 +1,162 @@
-# Verification Phase - Coverage Validation & Gap Resolution
-
-## Overview
-**Objective**: Ensure systematic completeness by validating that all planned analysis was completed and no critical optimizations were missed.
-
-**Key Principle**: No critical performance improvements should fall through coverage gaps. This phase serves as the final safety net to catch any missed files or patterns.
-
-## 🚨 MANDATORY PHASE - CANNOT BE SKIPPED
-**CRITICAL ENFORCEMENT**: This phase is REQUIRED for all optimization sessions. NO SESSION can be marked complete without successful verification phase completion.
-
-### Verification Phase Triggers Automatically When:
-- Performance phase claims completion
-- Optimization log contains completion markers
-- Session attempts to conclude without verification
-
-### Verification Phase BLOCKS Session Completion Until:
-- ✅ ALL files in scope verified as analyzed  
-- ✅ ALL claimed optimizations validated against actual files
-- ✅ ALL coverage gaps identified and resolved
-- ✅ NO phantom optimizations in documentation
-
----
-
-## Phase Execution Process
-
-### Step 1: Coverage Checklist Validation
-**CRITICAL**: Cross-reference planned vs actual analysis coverage to identify gaps.
-
-#### 🚨 CONTEXT-RESISTANT FILE REDISCOVERY (MANDATORY FIRST STEP)
-**CRITICAL**: Never trust chat memory or existing logs - Context compaction can corrupt file inventories!
-
-```bash
-# REQUIRED: Always start verification by independently rediscovering file scope
-find . -name "*.al" | wc -l                    # Count actual files in workspace
-find . -name "*.al" | sort > actual-files.tmp  # Create temporary sorted file list
-grep -c "\.al" OptimizationLog.md             # Count files claimed in optimization log
-ls -la *.al | wc -l 2>/dev/null || echo "0"   # Double-check with ls count
-
-# BLOCKING CONDITION: If counts don't match = INCOMPLETE WORK DETECTED
-echo "=== FILE COUNT COMPARISON ==="
-echo "Actual workspace files: $(find . -name '*.al' | wc -l)"
-echo "Files in optimization log: $(grep -c '\.al' OptimizationLog.md)"
-```
-
-#### 📋 File Coverage Validation (Using Rediscovered Files)
-- [ ] **Independent File Discovery** (ignore any chat memory or previous lists)
-  - [ ] Generate FRESH project file list using `find . -name "*.al"`
-  - [ ] Compare FRESH file list against optimization log entries
-  - [ ] Identify any files discovered but not appearing in optimization results
-  - [ ] **Red Flag**: Missing files from critical business domains (Analytics, Finance, Data Processing)
-
-#### 🔒 MANDATORY FILE VALIDATION GATES
-**CRITICAL**: These checks CANNOT be bypassed.
-
-- [ ] **Gate 1: Phantom File Detection**
-  - [ ] Cross-reference optimization log claims against actual project files
-  - [ ] **BLOCKING CONDITION**: Any claimed optimizations for non-existent files = INVALID SESSION
-  
-- [ ] **Gate 2: Missing File Detection**  
-  - [ ] Generate complete project file inventory using automated tools
-  - [ ] **BLOCKING CONDITION**: ANY files in scope missing from optimization log = INCOMPLETE SESSION
-  
-- [ ] **Gate 3: Coverage Accuracy Validation**
-  - [ ] Verify optimization claims match actual file contents
-  - [ ] **BLOCKING CONDITION**: False optimization claims = VERIFICATION RESTART REQUIRED
-
-#### 🔍 Pattern Coverage Validation  
-- [ ] **Review Pattern Detection Checklist**
-  - [ ] Verify each planned pattern was checked for each analyzed file
-  - [ ] Identify incomplete pattern coverage across file set
-  - [ ] **Red Flag**: Core patterns (Manual Summation, N+1 Queries) not checked consistently
-
-#### 📊 Coverage Reporting
-- [ ] **Generate Coverage Report**:
-  ```
-  PLANNED: 23 files across 4 modules for 17 patterns
-  ACTUAL: 22 files analyzed, 396 pattern checks completed
-  GAPS: 1 file missing (T4_BusinessIntelligence.Codeunit.al)
-  ```
-
-### Step 2: Gap Analysis & Risk Assessment
-**CRITICAL**: Assess impact of any identified coverage gaps.
-
-#### 🚨 Missing File Analysis
-For each identified missing file:
-- [ ] **Determine Business Criticality**
-  - High Risk: Analytics, Finance, Core Data Processing
-  - Medium Risk: Reporting, User Interface, Utilities  
-  - Low Risk: Configuration, Setup, Administrative functions
-
-- [ ] **Quick Pattern Scan** (for High/Medium risk files)
-  - [ ] Scan for manual summation loops (`repeat...until` with `+=`)
-  - [ ] Check for missing SetLoadFields optimizations
-  - [ ] Identify N+1 query anti-patterns (nested record loops)
-  - [ ] Look for FlowField vs CalcSums optimization opportunities
-
-#### ⚠️ Risk Classification
-- [ ] **CRITICAL**: High-risk files with confirmed performance anti-patterns
-- [ ] **MODERATE**: Medium-risk files with potential optimizations  
-- [ ] **MINOR**: Low-risk files or optimization patterns with minimal impact
-
-### Step 3: Automated Gap Resolution
-**CRITICAL**: Apply immediate fixes for critical gaps to prevent performance regressions.
-
-#### 🔥 Critical Gap Resolution
-For files classified as CRITICAL:
-- [ ] **Apply Standard Optimization Patterns**
-  - [ ] Replace manual summation with CalcSums operations
-  - [ ] Add SetLoadFields for selective field loading
-  - [ ] Eliminate N+1 query patterns with proper aggregation
-  - [ ] Apply database-first performance hierarchy principles
-
-- [ ] **Update Documentation**
-  - [ ] Add "VERIFICATION_PHASE" entries to optimization log
-  - [ ] Document pattern fixes and expected performance impact
-  - [ ] Update overall performance predictions
-
-#### 📋 Moderate Gap Documentation
-For files classified as MODERATE:
-- [ ] **Document for Future Analysis**
-  - [ ] Add to "Future Optimization Opportunities" section
-  - [ ] Note potential improvement areas for subsequent sessions
-  - [ ] Estimate impact and implementation effort
-
-### Step 4: Final Validation
-**CRITICAL**: Confirm systematic completeness before concluding optimization session.
-
-#### ✅ Completeness Checklist
-- [ ] **Coverage Validation Complete**: All planned files verified
-- [ ] **Critical Gaps Resolved**: High-risk missed optimizations applied
-- [ ] **Documentation Updated**: Optimization log reflects all changes
-- [ ] **Performance Predictions Revised**: Impact estimates include verification fixes
-
-#### 📊 Final Coverage Report
-- [ ] **Generate Final Summary**:
-  ```
-  VERIFICATION PHASE RESULTS:
-  - Files Analyzed: 23/23 (100% coverage achieved)
-  - Critical Gaps Found: 1 (T4_BusinessIntelligence.Codeunit.al)
-  - Critical Gaps Resolved: 1 (Manual summation → CalcSums conversion)
-  - Additional Optimizations Applied: 3 procedures optimized
-  - Updated Performance Prediction: +15% improvement from gap resolution
-  ```
-
----
-
-## Success Criteria
-✅ **Complete Coverage Achieved**: All files in scope verified as analyzed  
-✅ **Critical Gaps Resolved**: No high-risk performance anti-patterns remaining
-✅ **Documentation Complete**: All optimization work properly documented
-✅ **Risk Assessment**: Any remaining gaps classified and documented for future work
-
-## Quality Validation
-- **Coverage Completeness**: Did you verify every file in the analysis scope?
-- **Gap Resolution**: Were critical missed optimizations properly addressed?
-- **Documentation Accuracy**: Does the optimization log reflect all work completed?
-- **Risk Management**: Are any remaining gaps properly classified and documented?
-
----
-
-## Next Phase
+# Verification Phase - Coverage Validation & Gap Resolution
+
+## Overview
+**Objective**: Ensure systematic completeness by validating that all planned analysis was completed and no critical optimizations were missed.
+
+**Key Principle**: No critical performance improvements should fall through coverage gaps. This phase serves as the final safety net to catch any missed files or patterns.
+
+## 🚨 MANDATORY PHASE - CANNOT BE SKIPPED
+**CRITICAL ENFORCEMENT**: This phase is REQUIRED for all optimization sessions. NO SESSION can be marked complete without successful verification phase completion.
+
+### Verification Phase Triggers Automatically When:
+- Performance phase claims completion
+- Optimization log contains completion markers
+- Session attempts to conclude without verification
+
+### Verification Phase BLOCKS Session Completion Until:
+- ✅ ALL files in scope verified as analyzed  
+- ✅ ALL claimed optimizations validated against actual files
+- ✅ ALL coverage gaps identified and resolved
+- ✅ NO phantom optimizations in documentation
+
+---
+
+## Phase Execution Process
+
+### Step 1: Coverage Checklist Validation
+**CRITICAL**: Cross-reference planned vs actual analysis coverage to identify gaps.
+
+#### 🚨 CONTEXT-RESISTANT FILE REDISCOVERY (MANDATORY FIRST STEP)
+**CRITICAL**: Never trust chat memory or existing logs - Context compaction can corrupt file inventories!
+
+```bash
+# REQUIRED: Always start verification by independently rediscovering file scope
+find . -name "*.al" | wc -l                    # Count actual files in workspace
+find . -name "*.al" | sort > actual-files.tmp  # Create temporary sorted file list
+grep -c "\.al" OptimizationLog.md             # Count files claimed in optimization log
+ls -la *.al | wc -l 2>/dev/null || echo "0"   # Double-check with ls count
+
+# BLOCKING CONDITION: If counts don't match = INCOMPLETE WORK DETECTED
+echo "=== FILE COUNT COMPARISON ==="
+echo "Actual workspace files: $(find . -name '*.al' | wc -l)"
+echo "Files in optimization log: $(grep -c '\.al' OptimizationLog.md)"
+```
+
+#### 📋 File Coverage Validation (Using Rediscovered Files)
+- [ ] **Independent File Discovery** (ignore any chat memory or previous lists)
+  - [ ] Generate FRESH project file list using `find . -name "*.al"`
+  - [ ] Compare FRESH file list against optimization log entries
+  - [ ] Identify any files discovered but not appearing in optimization results
+  - [ ] **Red Flag**: Missing files from critical business domains (Analytics, Finance, Data Processing)
+
+#### 🔒 MANDATORY FILE VALIDATION GATES
+**CRITICAL**: These checks CANNOT be bypassed.
+
+- [ ] **Gate 1: Phantom File Detection**
+  - [ ] Cross-reference optimization log claims against actual project files
+  - [ ] **BLOCKING CONDITION**: Any claimed optimizations for non-existent files = INVALID SESSION
+  
+- [ ] **Gate 2: Missing File Detection**  
+  - [ ] Generate complete project file inventory using automated tools
+  - [ ] **BLOCKING CONDITION**: ANY files in scope missing from optimization log = INCOMPLETE SESSION
+  
+- [ ] **Gate 3: Coverage Accuracy Validation**
+  - [ ] Verify optimization claims match actual file contents
+  - [ ] **BLOCKING CONDITION**: False optimization claims = VERIFICATION RESTART REQUIRED
+
+#### 🔍 Pattern Coverage Validation  
+- [ ] **Review Pattern Detection Checklist**
+  - [ ] Verify each planned pattern was checked for each analyzed file
+  - [ ] Identify incomplete pattern coverage across file set
+  - [ ] **Red Flag**: Core patterns (Manual Summation, N+1 Queries) not checked consistently
+
+#### 📊 Coverage Reporting
+- [ ] **Generate Coverage Report**:
+  ```
+  PLANNED: 23 files across 4 modules for 17 patterns
+  ACTUAL: 22 files analyzed, 396 pattern checks completed
+  GAPS: 1 file missing (T4_BusinessIntelligence.Codeunit.al)
+  ```
+
+### Step 2: Gap Analysis & Risk Assessment
+**CRITICAL**: Assess impact of any identified coverage gaps.
+
+#### 🚨 Missing File Analysis
+For each identified missing file:
+- [ ] **Determine Business Criticality**
+  - High Risk: Analytics, Finance, Core Data Processing
+  - Medium Risk: Reporting, User Interface, Utilities  
+  - Low Risk: Configuration, Setup, Administrative functions
+
+- [ ] **Quick Pattern Scan** (for High/Medium risk files)
+  - [ ] Scan for manual summation loops (`repeat...until` with `+=`)
+  - [ ] Check for missing SetLoadFields optimizations
+  - [ ] Identify N+1 query anti-patterns (nested record loops)
+  - [ ] Look for FlowField vs CalcSums optimization opportunities
+
+#### ⚠️ Risk Classification
+- [ ] **CRITICAL**: High-risk files with confirmed performance anti-patterns
+- [ ] **MODERATE**: Medium-risk files with potential optimizations  
+- [ ] **MINOR**: Low-risk files or optimization patterns with minimal impact
+
+### Step 3: Automated Gap Resolution
+**CRITICAL**: Apply immediate fixes for critical gaps to prevent performance regressions.
+
+#### 🔥 Critical Gap Resolution
+For files classified as CRITICAL:
+- [ ] **Apply Standard Optimization Patterns**
+  - [ ] Replace manual summation with CalcSums operations
+  - [ ] Add SetLoadFields for selective field loading
+  - [ ] Eliminate N+1 query patterns with proper aggregation
+  - [ ] Apply database-first performance hierarchy principles
+
+- [ ] **Update Documentation**
+  - [ ] Add "VERIFICATION_PHASE" entries to optimization log
+  - [ ] Document pattern fixes and expected performance impact
+  - [ ] Update overall performance predictions
+
+#### 📋 Moderate Gap Documentation
+For files classified as MODERATE:
+- [ ] **Document for Future Analysis**
+  - [ ] Add to "Future Optimization Opportunities" section
+  - [ ] Note potential improvement areas for subsequent sessions
+  - [ ] Estimate impact and implementation effort
+
+### Step 4: Final Validation
+**CRITICAL**: Confirm systematic completeness before concluding optimization session.
+
+#### ✅ Completeness Checklist
+- [ ] **Coverage Validation Complete**: All planned files verified
+- [ ] **Critical Gaps Resolved**: High-risk missed optimizations applied
+- [ ] **Documentation Updated**: Optimization log reflects all changes
+- [ ] **Performance Predictions Revised**: Impact estimates include verification fixes
+
+#### 📊 Final Coverage Report
+- [ ] **Generate Final Summary**:
+  ```
+  VERIFICATION PHASE RESULTS:
+  - Files Analyzed: 23/23 (100% coverage achieved)
+  - Critical Gaps Found: 1 (T4_BusinessIntelligence.Codeunit.al)
+  - Critical Gaps Resolved: 1 (Manual summation → CalcSums conversion)
+  - Additional Optimizations Applied: 3 procedures optimized
+  - Updated Performance Prediction: +15% improvement from gap resolution
+  ```
+
+---
+
+## Success Criteria
+✅ **Complete Coverage Achieved**: All files in scope verified as analyzed  
+✅ **Critical Gaps Resolved**: No high-risk performance anti-patterns remaining
+✅ **Documentation Complete**: All optimization work properly documented
+✅ **Risk Assessment**: Any remaining gaps classified and documented for future work
+
+## Quality Validation
+- **Coverage Completeness**: Did you verify every file in the analysis scope?
+- **Gap Resolution**: Were critical missed optimizations properly addressed?
+- **Documentation Accuracy**: Does the optimization log reflect all work completed?
+- **Risk Management**: Are any remaining gaps properly classified and documented?
+
+---
+
+## Next Phase
 Upon completion, the optimization session is ready for **Testing & Validation Phase** with confidence that all critical performance improvements have been systematically applied.

package/embedded-knowledge/methodologies/phases/verification-quick.md

@@ -1,48 +1,48 @@
-# Verification Phase - Quick Reference
-
-## 📚 NEED MORE DETAIL?
-For detailed validation procedures and examples: `load_methodology verification-full`
-
-## 🎯 OBJECTIVE
-Final coverage audit to catch missed files and validate optimization completeness.
-
-## ⚡ CORE VERIFICATION
-
-### 🚨 CONTEXT-RESISTANT FILE REDISCOVERY (MANDATORY FIRST STEP)
-**CRITICAL**: Never trust chat memory or existing logs - always rediscover independently
-```bash
-# 1. Rediscover actual file scope in workspace
-find . -name "*.al" | wc -l
-find . -name "*.al" > actual-files.tmp
-
-# 2. Count files claimed in optimization log
-grep -c "\.al" OptimizationLog.md
-
-# 3. BLOCKING CONDITION: Mismatched counts = INCOMPLETE WORK
-```
-
-### Standard Verification Steps
-1. **File Coverage Audit**: Compare rediscovered files vs optimization log claims
-2. **Phantom File Detection**: Check for claimed work on non-existent files  
-3. **Missing File Detection**: Find actual files missing from optimization log
-4. **Gap Resolution**: Address ALL discovered coverage gaps
-5. **Accuracy Validation**: Cross-reference claims with actual file contents
-
-## 🚨 COVERAGE VALIDATION
-- **File Inventory vs Reality**: `find . -name "*.al"` vs analysis file list
-- **Modification Evidence**: All claimed files must show recent timestamps
-- **Pattern Verification**: `grep -l "CalcSums" *.al` must match optimization claims
-- **Anti-Pattern Check**: Claimed eliminated patterns must be gone
-
-## 🔧 GAP RESOLUTION PROTOCOL
-1. **Identify gaps** in coverage (missed files, phantom claims)
-2. **BLOCK completion** until all gaps resolved
-3. **Return to analysis/performance** for missed files
-4. **Re-validate** after gap resolution
-5. **Document accuracy** in final report
-
-## ✅ SUCCESS CRITERIA  
-Zero phantom files + Zero missing files + 100% claimed optimizations verified + All gaps resolved + Complete accuracy validation
-
-## 🏁 COMPLETION
+# Verification Phase - Quick Reference
+
+## 📚 NEED MORE DETAIL?
+For detailed validation procedures and examples: `load_methodology verification-full`
+
+## 🎯 OBJECTIVE
+Final coverage audit to catch missed files and validate optimization completeness.
+
+## ⚡ CORE VERIFICATION
+
+### 🚨 CONTEXT-RESISTANT FILE REDISCOVERY (MANDATORY FIRST STEP)
+**CRITICAL**: Never trust chat memory or existing logs - always rediscover independently
+```bash
+# 1. Rediscover actual file scope in workspace
+find . -name "*.al" | wc -l
+find . -name "*.al" > actual-files.tmp
+
+# 2. Count files claimed in optimization log
+grep -c "\.al" OptimizationLog.md
+
+# 3. BLOCKING CONDITION: Mismatched counts = INCOMPLETE WORK
+```
+
+### Standard Verification Steps
+1. **File Coverage Audit**: Compare rediscovered files vs optimization log claims
+2. **Phantom File Detection**: Check for claimed work on non-existent files  
+3. **Missing File Detection**: Find actual files missing from optimization log
+4. **Gap Resolution**: Address ALL discovered coverage gaps
+5. **Accuracy Validation**: Cross-reference claims with actual file contents
+
+## 🚨 COVERAGE VALIDATION
+- **File Inventory vs Reality**: `find . -name "*.al"` vs analysis file list
+- **Modification Evidence**: All claimed files must show recent timestamps
+- **Pattern Verification**: `grep -l "CalcSums" *.al` must match optimization claims
+- **Anti-Pattern Check**: Claimed eliminated patterns must be gone
+
+## 🔧 GAP RESOLUTION PROTOCOL
+1. **Identify gaps** in coverage (missed files, phantom claims)
+2. **BLOCK completion** until all gaps resolved
+3. **Return to analysis/performance** for missed files
+4. **Re-validate** after gap resolution
+5. **Document accuracy** in final report
+
+## ✅ SUCCESS CRITERIA  
+Zero phantom files + Zero missing files + 100% claimed optimizations verified + All gaps resolved + Complete accuracy validation
+
+## 🏁 COMPLETION
 Only mark complete when ALL verification checks pass - no exceptions