bc-code-intelligence-mcp 1.5.6 → 1.5.8

package/embedded-knowledge/methodologies/workflows/code-review-workflow.md

@@ -1,99 +1,99 @@
----
-type: workflow
-category: quality-assurance
-name: bc-code-review-workflow
-workflow_type: checklist
-phases:
-  - name: preparation
-    title: "Pre-Review Preparation"
-    required: true
-    tasks:
-      - "Ensure all tests pass"
-      - "Run static analysis tools"
-      - "Check code formatting compliance"
-      - "Verify documentation is updated"
-  - name: performance-review
-    title: "Performance Analysis"
-    required: true
-    tasks:
-      - "Check for SetLoadFields usage"
-      - "Verify efficient query patterns"
-      - "Validate SIFT usage for summations"
-      - "Review loop efficiency"
-      - "Check for unnecessary CalcFields calls"
-  - name: security-review
-    title: "Security & Validation"
-    required: true
-    tasks:
-      - "Validate user input handling"
-      - "Check permission requirements"
-      - "Review error handling"
-      - "Verify data validation"
-  - name: maintainability
-    title: "Code Maintainability"
-    required: false
-    tasks:
-      - "Check naming conventions"
-      - "Review code complexity"
-      - "Validate commenting"
-      - "Assess testability"
-related_topics:
-  - code-quality-standards
-  - performance-review-checklist
-  - security-best-practices
-domains: [quality-assurance, performance, security]
-difficulty: intermediate
-estimated_duration: "30-45 minutes"
-prerequisites: ["Basic AL knowledge", "Understanding of BC architecture"]
-tags: [workflow, code-review, quality-assurance, checklist]
----
-
-# Business Central Code Review Workflow
-
-## Overview
-A systematic approach to reviewing AL code for Business Central extensions, focusing on performance, security, and maintainability.
-
-## Workflow Phases
-
-### 1. Pre-Review Preparation (Required)
-Before starting the review, ensure:
-- [ ] All automated tests pass
-- [ ] Static analysis tools show no critical issues
-- [ ] Code follows formatting standards
-- [ ] Documentation reflects changes
-
-### 2. Performance Analysis (Required)
-Critical performance checks:
-- [ ] **SetLoadFields**: Used before FindSet() when only specific fields needed
-- [ ] **Query Patterns**: Efficient use of SetRange, SetFilter, SetCurrentKey
-- [ ] **SIFT Usage**: CalcSums instead of manual summation loops
-- [ ] **Loop Efficiency**: Minimal processing inside repeat-until loops
-- [ ] **CalcFields**: Batched rather than individual calls
-
-### 3. Security & Validation (Required)
-Security-focused review:
-- [ ] **Input Validation**: All user inputs properly validated
-- [ ] **Permissions**: Appropriate permission sets required
-- [ ] **Error Handling**: Graceful error handling without data exposure
-- [ ] **Data Validation**: Business rules properly enforced
-
-### 4. Code Maintainability (Optional)
-Quality improvements:
-- [ ] **Naming**: Clear, consistent naming conventions
-- [ ] **Complexity**: Functions under 50 lines, minimal nesting
-- [ ] **Comments**: Complex logic explained
-- [ ] **Testability**: Code structure supports unit testing
-
-## Review Checklist Tools
-Use these questions for each phase:
-
-**Performance**: "Will this code perform well with 10,000+ records?"
-**Security**: "What happens if a malicious user provides unexpected input?"
-**Maintainability**: "Can another developer understand this in 6 months?"
-
-## Common Issues to Flag
-- Manual summation loops (use CalcSums)
-- Missing SetLoadFields on large datasets
-- Hardcoded values that should be configurable
-- Missing error handling on external calls
+---
+type: workflow
+category: quality-assurance
+name: bc-code-review-workflow
+workflow_type: checklist
+phases:
+  - name: preparation
+    title: "Pre-Review Preparation"
+    required: true
+    tasks:
+      - "Ensure all tests pass"
+      - "Run static analysis tools"
+      - "Check code formatting compliance"
+      - "Verify documentation is updated"
+  - name: performance-review
+    title: "Performance Analysis"
+    required: true
+    tasks:
+      - "Check for SetLoadFields usage"
+      - "Verify efficient query patterns"
+      - "Validate SIFT usage for summations"
+      - "Review loop efficiency"
+      - "Check for unnecessary CalcFields calls"
+  - name: security-review
+    title: "Security & Validation"
+    required: true
+    tasks:
+      - "Validate user input handling"
+      - "Check permission requirements"
+      - "Review error handling"
+      - "Verify data validation"
+  - name: maintainability
+    title: "Code Maintainability"
+    required: false
+    tasks:
+      - "Check naming conventions"
+      - "Review code complexity"
+      - "Validate commenting"
+      - "Assess testability"
+related_topics:
+  - code-quality-standards
+  - performance-review-checklist
+  - security-best-practices
+domains: [quality-assurance, performance, security]
+difficulty: intermediate
+estimated_duration: "30-45 minutes"
+prerequisites: ["Basic AL knowledge", "Understanding of BC architecture"]
+tags: [workflow, code-review, quality-assurance, checklist]
+---
+
+# Business Central Code Review Workflow
+
+## Overview
+A systematic approach to reviewing AL code for Business Central extensions, focusing on performance, security, and maintainability.
+
+## Workflow Phases
+
+### 1. Pre-Review Preparation (Required)
+Before starting the review, ensure:
+- [ ] All automated tests pass
+- [ ] Static analysis tools show no critical issues
+- [ ] Code follows formatting standards
+- [ ] Documentation reflects changes
+
+### 2. Performance Analysis (Required)
+Critical performance checks:
+- [ ] **SetLoadFields**: Used before FindSet() when only specific fields needed
+- [ ] **Query Patterns**: Efficient use of SetRange, SetFilter, SetCurrentKey
+- [ ] **SIFT Usage**: CalcSums instead of manual summation loops
+- [ ] **Loop Efficiency**: Minimal processing inside repeat-until loops
+- [ ] **CalcFields**: Batched rather than individual calls
+
+### 3. Security & Validation (Required)
+Security-focused review:
+- [ ] **Input Validation**: All user inputs properly validated
+- [ ] **Permissions**: Appropriate permission sets required
+- [ ] **Error Handling**: Graceful error handling without data exposure
+- [ ] **Data Validation**: Business rules properly enforced
+
+### 4. Code Maintainability (Optional)
+Quality improvements:
+- [ ] **Naming**: Clear, consistent naming conventions
+- [ ] **Complexity**: Functions under 50 lines, minimal nesting
+- [ ] **Comments**: Complex logic explained
+- [ ] **Testability**: Code structure supports unit testing
+
+## Review Checklist Tools
+Use these questions for each phase:
+
+**Performance**: "Will this code perform well with 10,000+ records?"
+**Security**: "What happens if a malicious user provides unexpected input?"
+**Maintainability**: "Can another developer understand this in 6 months?"
+
+## Common Issues to Flag
+- Manual summation loops (use CalcSums)
+- Missing SetLoadFields on large datasets
+- Hardcoded values that should be configurable
+- Missing error handling on external calls
 - Complex nested logic without comments

package/package.json

@@ -1,81 +1,81 @@
-{
-  "name": "bc-code-intelligence-mcp",
-  "version": "1.5.6",
-  "description": "BC Code Intelligence MCP Server - Complete Specialist Bundle with AI-driven expert consultation, seamless handoffs, and context-preserving workflows",
-  "main": "dist/index.js",
-  "type": "module",
-  "files": [
-    "dist/",
-    "embedded-knowledge/"
-  ],
-  "bin": {
-    "bc-code-intel": "dist/cli/bc-code-intel-cli.js",
-    "bc-code-intel-server": "dist/index.js",
-    "bc-code-intelligence-mcp": "dist/index.js"
-  },
-  "scripts": {
-    "build": "tsc",
-    "dev": "tsx src/index.ts",
-    "start": "node dist/index.js",
-    "test": "npm run test:all",
-    "test:contracts": "tsx scripts/validate-contracts.ts",
-    "test:unit": "vitest run --config vitest.unit.config.ts",
-    "test:integration": "vitest run --config vitest.integration.config.ts",
-    "test:prompts": "vitest run --config vitest.config.ts tests/prompt-validation",
-    "test:coverage": "vitest run --coverage",
-    "test:all": "npm run test:contracts && npm run test:unit && npm run test:integration && npm run test:prompts",
-    "validate:contracts": "tsx scripts/validate-contracts.ts",
-    "prepublishOnly": "npm run validate:contracts && npm run build",
-    "lint": "eslint src/**/*.ts",
-    "format": "prettier --write src/**/*.ts",
-    "prepare": "npm run build"
-  },
-  "keywords": [
-    "business-central",
-    "al-language",
-    "performance",
-    "mcp",
-    "model-context-protocol",
-    "ai-tools",
-    "github-copilot",
-    "knowledge-base",
-    "bc-code-intelligence"
-  ],
-  "author": "BC Code Intelligence",
-  "license": "MIT",
-  "dependencies": {
-    "@modelcontextprotocol/sdk": "^0.4.0",
-    "chokidar": "^4.0.3",
-    "commander": "^14.0.1",
-    "fast-glob": "^3.3.2",
-    "fuse.js": "^7.0.0",
-    "marked": "^11.1.1",
-    "simple-git": "^3.28.0",
-    "tslib": "^2.8.1",
-    "yaml": "^2.3.4",
-    "zod": "^3.25.76"
-  },
-  "devDependencies": {
-    "@types/node": "^20.19.14",
-    "@typescript-eslint/eslint-plugin": "^7.18.0",
-    "@typescript-eslint/parser": "^7.18.0",
-    "@vitest/coverage-v8": "^3.2.4",
-    "eslint": "^8.57.1",
-    "prettier": "^3.1.1",
-    "tsx": "^4.7.0",
-    "typescript": "^5.3.3",
-    "vitest": "^3.2.4"
-  },
-  "engines": {
-    "node": ">=20.0.0"
-  },
-  "preferGlobal": false,
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/JeremyVyska/bc-code-intelligence-mcp.git"
-  },
-  "bugs": {
-    "url": "https://github.com/JeremyVyska/bc-code-intelligence-mcp/issues"
-  },
-  "homepage": "https://github.com/JeremyVyska/bc-code-intelligence-mcp"
-}
+{
+  "name": "bc-code-intelligence-mcp",
+  "version": "1.5.8",
+  "description": "BC Code Intelligence MCP Server - Complete Specialist Bundle with AI-driven expert consultation, seamless handoffs, and context-preserving workflows",
+  "main": "dist/index.js",
+  "type": "module",
+  "files": [
+    "dist/",
+    "embedded-knowledge/"
+  ],
+  "bin": {
+    "bc-code-intel": "dist/cli/bc-code-intel-cli.js",
+    "bc-code-intel-server": "dist/index.js",
+    "bc-code-intelligence-mcp": "dist/index.js"
+  },
+  "scripts": {
+    "build": "tsc",
+    "dev": "tsx src/index.ts",
+    "start": "node dist/index.js",
+    "test": "npm run test:all",
+    "test:contracts": "tsx scripts/validate-contracts.ts",
+    "test:unit": "vitest run --config vitest.unit.config.ts",
+    "test:integration": "vitest run --config vitest.integration.config.ts",
+    "test:prompts": "vitest run --config vitest.config.ts tests/prompt-validation",
+    "test:coverage": "vitest run --coverage",
+    "test:all": "npm run test:contracts && npm run test:unit && npm run test:integration && npm run test:prompts",
+    "validate:contracts": "tsx scripts/validate-contracts.ts",
+    "prepublishOnly": "npm run validate:contracts && npm run build",
+    "lint": "eslint src/**/*.ts",
+    "format": "prettier --write src/**/*.ts",
+    "prepare": "npm run build"
+  },
+  "keywords": [
+    "business-central",
+    "al-language",
+    "performance",
+    "mcp",
+    "model-context-protocol",
+    "ai-tools",
+    "github-copilot",
+    "knowledge-base",
+    "bc-code-intelligence"
+  ],
+  "author": "BC Code Intelligence",
+  "license": "MIT",
+  "dependencies": {
+    "@modelcontextprotocol/sdk": "^1.24.3",
+    "chokidar": "^4.0.3",
+    "commander": "^14.0.1",
+    "fast-glob": "^3.3.2",
+    "fuse.js": "^7.0.0",
+    "marked": "^11.1.1",
+    "simple-git": "^3.28.0",
+    "tslib": "^2.8.1",
+    "yaml": "^2.3.4",
+    "zod": "^3.25.76"
+  },
+  "devDependencies": {
+    "@types/node": "^20.19.14",
+    "@typescript-eslint/eslint-plugin": "^7.18.0",
+    "@typescript-eslint/parser": "^7.18.0",
+    "@vitest/coverage-v8": "^3.2.4",
+    "eslint": "^8.57.1",
+    "prettier": "^3.1.1",
+    "tsx": "^4.7.0",
+    "typescript": "^5.3.3",
+    "vitest": "^3.2.4"
+  },
+  "engines": {
+    "node": ">=20.0.0"
+  },
+  "preferGlobal": false,
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/JeremyVyska/bc-code-intelligence-mcp.git"
+  },
+  "bugs": {
+    "url": "https://github.com/JeremyVyska/bc-code-intelligence-mcp/issues"
+  },
+  "homepage": "https://github.com/JeremyVyska/bc-code-intelligence-mcp"
+}