bbk-cli 1.1.2 → 1.2.0

package/tests/integration/cli-integration.test.ts

@@ -1,9 +1,9 @@
 import fs from 'fs';
-import os from 'os';
-import path from 'path';
-import { beforeEach, describe, expect, it, vi } from 'vitest';
+import os from 'node:os';
+import path from 'node:path';
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 
-// Mock the Bitbucket API functions
+// Mock the Bitbucket API functions - must be at top level but without external references
 vi.mock('../../src/utils/bitbucket-client.js', () => ({
   listRepositories: vi.fn(),
   getRepository: vi.fn(),
@@ -21,52 +21,37 @@ vi.mock('../../src/utils/bitbucket-client.js', () => ({
   clearClients: vi.fn(),
 }));
 
-// Mock helper functions - only where we need to spy on them
-vi.mock('../../src/commands/helpers.js', async () => {
-  const actual = await vi.importActual('../../src/commands/helpers.js');
-  return {
-    ...actual,
-    printAvailableCommands: vi.fn(actual.printAvailableCommands),
-    printCommandDetail: vi.fn(actual.printCommandDetail),
-    getCurrentVersion: vi.fn(() => '0.0.0'),
-  };
-});
-
-// Mock config-loader to spy on loadConfig
-vi.mock('../../src/utils/config-loader.js', async () => {
-  const actual = await vi.importActual('../../src/utils/config-loader.js');
-  return {
-    ...actual,
-    loadConfig: vi.fn(actual.loadConfig),
-  };
-});
+// Mock helper functions
+vi.mock('../../src/commands/helpers.js', () => ({
+  printAvailableCommands: vi.fn(),
+  printCommandDetail: vi.fn(),
+  getCurrentVersion: vi.fn(() => '0.0.0'),
+}));
 
 // Integration tests that test the entire flow through multiple modules
 
 describe('CLI Integration', () => {
-  let testDir: string;
+  let testConfigDir: string;
+  let homedirSpy: vi.SpyInstance;
   let configPath: string;
 
   beforeEach(() => {
-    testDir = fs.mkdtempSync(path.join(os.tmpdir(), 'bbk-cli-integration-'));
-    fs.mkdirSync(path.join(testDir, '.claude'));
-    configPath = path.join(testDir, '.claude', 'bitbucket-config.local.md');
-
-    // Write valid config
-    const configContent = `---
-profiles:
-  cloud:
-    email: test@test.com
-    apiToken: test_token_123
-  staging:
-    email: staging@test.com
-    apiToken: staging_token_456
-
-defaultProfile: cloud
-defaultFormat: json
----
-
-# Test Config`;
+    testConfigDir = fs.mkdtempSync(path.join(os.tmpdir(), 'bbk-cli-integration-'));
+
+    // Spy on os.homedir() to return test directory (works on all platforms)
+    homedirSpy = vi.spyOn(os, 'homedir').mockReturnValue(testConfigDir);
+
+    configPath = path.join(testConfigDir, '.bbkcli');
+
+    // Write valid INI config
+    const configContent = `[auth]
+email=test@test.com
+api_token=test_token_123
+
+[defaults]
+workspace=testworkspace
+format=json
+`;
     fs.writeFileSync(configPath, configContent);
 
     // Clear all mocks before each test
@@ -74,59 +59,49 @@ defaultFormat: json
   });
 
   afterEach(() => {
-    fs.rmSync(testDir, { recursive: true, force: true });
+    fs.rmSync(testConfigDir, { recursive: true, force: true });
+
+    // Restore original os.homedir()
+    homedirSpy.mockRestore();
   });
 
   describe('Config Loading Integration', () => {
     it('should load and parse configuration file', async () => {
-      process.env.CLAUDE_PROJECT_ROOT = testDir;
-
       const { loadConfig } = await import('../../src/utils/config-loader.js');
-      const config = await loadConfig(testDir);
+      const config = await loadConfig();
 
       expect(config).toBeDefined();
-      expect(config.profiles).toBeDefined();
-      expect(config.profiles.cloud).toBeDefined();
-      expect(config.profiles.cloud.email).toBe('test@test.com');
-      expect(config.profiles.cloud.apiToken).toBe('test_token_123');
-      expect(config.defaultProfile).toBe('cloud');
+      expect(config.email).toBe('test@test.com');
+      expect(config.apiToken).toBe('test_token_123');
+      expect(config.defaultWorkspace).toBe('testworkspace');
       expect(config.defaultFormat).toBe('json');
     });
 
-    it('should support multiple profiles', async () => {
-      const { loadConfig } = await import('../../src/utils/config-loader.js');
-      const config = await loadConfig(testDir);
-
-      expect(Object.keys(config.profiles)).toHaveLength(2);
-      expect(config.profiles.cloud).toBeDefined();
-      expect(config.profiles.staging).toBeDefined();
-    });
-
-    it('should validate required profile fields', async () => {
-      const invalidConfig = `---
-profiles:
-  incomplete:
-    email: test@test.com
-    # Missing apiToken
----
+    it('should load config without optional fields', async () => {
+      // Write minimal config
+      const minimalConfig = `[auth]
+email=minimal@test.com
+api_token=minimal_token
 `;
-      fs.writeFileSync(configPath, invalidConfig);
+      fs.writeFileSync(configPath, minimalConfig);
 
       const { loadConfig } = await import('../../src/utils/config-loader.js');
+      const config = await loadConfig();
 
-      expect(() => loadConfig(testDir)).toThrow('must have both "email" and "apiToken"');
+      expect(config.email).toBe('minimal@test.com');
+      expect(config.apiToken).toBe('minimal_token');
+      expect(config.defaultWorkspace).toBeUndefined();
+      expect(config.defaultFormat).toBe('json'); // Default format
     });
   });
 
   describe('Command Runner Integration', () => {
     it('should parse command line arguments and execute', async () => {
-      process.env.CLAUDE_PROJECT_ROOT = testDir;
-
       const { parseArguments } = await import('../../src/utils/arg-parser.js');
       const { listRepositories } = await import('../../src/utils/bitbucket-client.js');
 
       // Mock the Bitbucket API call
-      listRepositories.mockResolvedValue({
+      vi.mocked(listRepositories).mockResolvedValue({
         success: true,
         result: JSON.stringify({ repositories: [{ slug: 'my-repo', name: 'My Repository' }] }),
       });
@@ -212,105 +187,22 @@ profiles:
     });
   });
 
-  describe('Bitbucket API Integration', () => {
-    it('should initialize Bitbucket client with profile', async () => {
-      process.env.CLAUDE_PROJECT_ROOT = testDir;
-
-      const { getBitbucketClientOptions } = await import('../../src/utils/config-loader.js');
-      const { loadConfig } = await import('../../src/utils/config-loader.js');
-
-      const config = await loadConfig(testDir);
-      const options = getBitbucketClientOptions(config, 'cloud');
-
-      expect(options.auth).toBeDefined();
-      expect(options.auth?.email).toBe('test@test.com');
-      expect(options.auth?.apiToken).toBe('test_token_123');
-    });
-
-    it('should handle different profiles', async () => {
-      const { getBitbucketClientOptions } = await import('../../src/utils/config-loader.js');
-      const { loadConfig } = await import('../../src/utils/config-loader.js');
-
-      const config = await loadConfig(testDir);
-      const cloudOptions = getBitbucketClientOptions(config, 'cloud');
-      const stagingOptions = getBitbucketClientOptions(config, 'staging');
-
-      expect(cloudOptions.auth?.email).toBe('test@test.com');
-      expect(stagingOptions.auth?.email).toBe('staging@test.com');
-      expect(cloudOptions).not.toEqual(stagingOptions);
-    });
-  });
-
-  describe('Command Help Integration', () => {
-    it('should display all available commands', async () => {
-      const { printAvailableCommands } = await import('../../src/commands/helpers.js');
-      const { COMMANDS } = await import('../../src/config/constants.js');
-
-      const consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
-
-      printAvailableCommands();
-
-      expect(consoleLogSpy).toHaveBeenCalledWith('\nAvailable commands:');
-      expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining(`1. ${COMMANDS[0]}`));
-      expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining(`10. ${COMMANDS[9]}`));
-
-      consoleLogSpy.mockRestore();
-    });
-
-    it('should display detailed help for each command', async () => {
-      const { printCommandDetail } = await import('../../src/commands/helpers.js');
-      const { COMMANDS, COMMANDS_INFO } = await import('../../src/config/constants.js');
-
-      const consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
-
-      COMMANDS.forEach((command, index) => {
-        consoleLogSpy.mockClear();
-        printCommandDetail(command);
-
-        expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining(command));
-        expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining(COMMANDS_INFO[index]));
-      });
-
-      consoleLogSpy.mockRestore();
-    });
-  });
-
   describe('CLI Wrapper Integration', () => {
     it('should initialize CLI with config', async () => {
-      process.env.CLAUDE_PROJECT_ROOT = testDir;
-
       const { wrapper } = await import('../../src/cli/wrapper.js');
-      const { loadConfig } = await import('../../src/utils/config-loader.js');
-
-      const cli = new wrapper();
-
-      await cli.connect();
-
-      expect(loadConfig).toHaveBeenCalledWith(testDir);
-    });
-
-    it('should handle profile switching', async () => {
-      process.env.CLAUDE_PROJECT_ROOT = testDir;
 
-      const { wrapper } = await import('../../src/cli/wrapper.js');
       const cli = new wrapper();
 
       await cli.connect();
 
-      // Simulate profile switch
-      const handleCommand = cli['handleCommand'].bind(cli);
-      const consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
-
-      await handleCommand('profile staging');
-
-      expect(consoleLogSpy).toHaveBeenCalledWith('Switched to profile: staging');
-
-      consoleLogSpy.mockRestore();
+      // Config should be loaded
+      // @ts-expect-error - accessing private property for testing
+      expect(cli.config).toBeDefined();
+      // @ts-expect-error - accessing private property for testing
+      expect(cli.config?.email).toBe('test@test.com');
     });
 
     it('should handle format switching', async () => {
-      process.env.CLAUDE_PROJECT_ROOT = testDir;
-
       const { wrapper } = await import('../../src/cli/wrapper.js');
       const cli = new wrapper();
 
@@ -328,61 +220,26 @@ profiles:
   });
 
   describe('Error Handling Integration', () => {
-    it('should handle missing config file', async () => {
-      fs.rmSync(configPath);
-
-      process.env.CLAUDE_PROJECT_ROOT = testDir;
-
-      const { loadConfig } = await import('../../src/utils/config-loader.js');
-
-      expect(() => loadConfig(testDir)).toThrow('Configuration file not found');
-    });
-
-    it('should handle invalid config format', async () => {
-      const invalidConfig = `# Invalid Config
-
-This is just markdown without frontmatter
-`;
-      fs.writeFileSync(configPath, invalidConfig);
-
-      const { loadConfig } = await import('../../src/utils/config-loader.js');
-
-      expect(() => loadConfig(testDir)).toThrow('Invalid configuration file format');
-    });
-
-    it('should handle missing profile', async () => {
-      const { getBitbucketClientOptions } = await import('../../src/utils/config-loader.js');
-      const { loadConfig } = await import('../../src/utils/config-loader.js');
-
-      const config = await loadConfig(testDir);
-
-      expect(() => getBitbucketClientOptions(config, 'nonexistent')).toThrow('Profile "nonexistent" not found');
-    });
-
     it('should handle invalid email format', async () => {
-      const invalidConfig = `---
-profiles:
-  invalid:
-    email: invalid-email
-    apiToken: token
----
+      // Write config with invalid email
+      const invalidConfig = `[auth]
+email=invalid-email
+api_token=test_token
 `;
       fs.writeFileSync(configPath, invalidConfig);
 
-      const { loadConfig } = await import('../../src/utils/config-loader.js');
+      const { loadConfig } = await import('../../src/utils/index.js');
 
-      expect(() => loadConfig(testDir)).toThrow('Profile "invalid" has invalid email format: "invalid-email"');
+      expect(() => loadConfig()).toThrow(/Invalid email/);
     });
   });
 
   describe('End-to-End Workflows', () => {
     it('should execute list-repositories workflow', async () => {
-      process.env.CLAUDE_PROJECT_ROOT = testDir;
-
       const { runCommand } = await import('../../src/commands/runner.js');
       const { listRepositories } = await import('../../src/utils/bitbucket-client.js');
 
-      listRepositories.mockResolvedValue({
+      vi.mocked(listRepositories).mockResolvedValue({
         success: true,
         result: JSON.stringify({
           repositories: [
@@ -403,7 +260,7 @@ profiles:
         // Expected
       }
 
-      expect(listRepositories).toHaveBeenCalledWith('cloud', 'test-workspace', 'json');
+      expect(listRepositories).toHaveBeenCalledWith('test-workspace', 'json');
       expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('docs-repo'));
       expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('Engineering'));
 
@@ -412,12 +269,10 @@ profiles:
     });
 
     it('should execute create-issue workflow', async () => {
-      process.env.CLAUDE_PROJECT_ROOT = testDir;
-
       const { runCommand } = await import('../../src/commands/runner.js');
       const { createIssue } = await import('../../src/utils/bitbucket-client.js');
 
-      createIssue.mockResolvedValue({
+      vi.mocked(createIssue).mockResolvedValue({
         success: true,
         result: JSON.stringify({
           id: '12345',
@@ -447,7 +302,6 @@ profiles:
       }
 
       expect(createIssue).toHaveBeenCalledWith(
-        'cloud',
         'test-workspace',
         'my-repo',
         'New Issue',
@@ -463,12 +317,10 @@ profiles:
     });
 
     it('should execute get-user workflow', async () => {
-      process.env.CLAUDE_PROJECT_ROOT = testDir;
-
       const { runCommand } = await import('../../src/commands/runner.js');
       const { getUser } = await import('../../src/utils/bitbucket-client.js');
 
-      getUser.mockResolvedValue({
+      vi.mocked(getUser).mockResolvedValue({
         success: true,
         result: JSON.stringify({
           uuid: '{5b10a2844c20165700ede21g}',
@@ -488,7 +340,7 @@ profiles:
         // Expected
       }
 
-      expect(getUser).toHaveBeenCalledWith('cloud', '5b10a2844c20165700ede21g', 'json');
+      expect(getUser).toHaveBeenCalledWith('5b10a2844c20165700ede21g', 'json');
       expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('John Doe'));
 
       exitSpy.mockRestore();
@@ -496,14 +348,12 @@ profiles:
     });
 
     it('should execute test-connection workflow', async () => {
-      process.env.CLAUDE_PROJECT_ROOT = testDir;
-
       const { runCommand } = await import('../../src/commands/runner.js');
       const { testConnection } = await import('../../src/utils/bitbucket-client.js');
 
-      testConnection.mockResolvedValue({
+      vi.mocked(testConnection).mockResolvedValue({
         success: true,
-        result: 'Connection successful!\n\nProfile: cloud\nLogged in as: John Doe (johndoe)',
+        result: 'Connection successful!\n\nLogged in as: John Doe (johndoe)',
       });
 
       const consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
@@ -517,7 +367,7 @@ profiles:
         // Expected
       }
 
-      expect(testConnection).toHaveBeenCalledWith('cloud');
+      expect(testConnection).toHaveBeenCalled();
       expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('Connection successful'));
       expect(consoleLogSpy).toHaveBeenCalledWith(expect.stringContaining('John Doe'));
 
@@ -525,4 +375,33 @@ profiles:
       consoleLogSpy.mockRestore();
     });
   });
+
+  describe('Default Workspace Resolution', () => {
+    it('should override default workspace when specified', async () => {
+      const { runCommand } = await import('../../src/commands/runner.js');
+      const { listRepositories } = await import('../../src/utils/bitbucket-client.js');
+
+      vi.mocked(listRepositories).mockResolvedValue({
+        success: true,
+        result: JSON.stringify({ repositories: [] }),
+      });
+
+      const consoleLogSpy = vi.spyOn(console, 'log').mockImplementation(() => {});
+      const exitSpy = vi.spyOn(process, 'exit').mockImplementation(() => {
+        throw new Error('process.exit called');
+      });
+
+      try {
+        await runCommand('list-repositories', '{"workspace":"custom-workspace"}', null);
+      } catch {
+        // Expected
+      }
+
+      // Should use the specified workspace, not the default
+      expect(listRepositories).toHaveBeenCalledWith('custom-workspace', 'json');
+
+      exitSpy.mockRestore();
+      consoleLogSpy.mockRestore();
+    });
+  });
 });