baxian 2.0.17 → 2.0.19

package/dist/agent/manager.js

@@ -12,13 +12,14 @@ import { versionTimeOf } from '../platform/row-schema.js';
 import { checkOpenPrBinding, checkPrBinding } from '../platform/pr-binding.js';
 import { collectPendingFeedback, scanCommentSourcesOnce } from '../platform/feedback.js';
 import { prReviewCacheRevision } from '../platform/pr-conversation-cache.js';
-import { deadTokens, recheckPassProvenance } from '../platform/verdict-engine.js';
+import { deadTokens, liveVerdictVeto } from '../platform/verdict-engine.js';
 import { platformBindingMismatch, taskNeedsPlatformBindingAudit, } from '../platform/startup.js';
 import { AGENT_STORE_NOOP } from '../state/agent-store.js';
 import { createRunner, LocalRunner, shellQuote, resolveAgentHost, workdirHostGroupKey, } from './runner.js';
 import { isTransientNetworkFailure } from './net-exec.js';
+import { classifyScreen, isMenuRule } from './detect/classify.js';
 import { imageFilename, agentHostPath, writeImageToHost } from './image-input.js';
-import { TmuxManager, ReplNotReadyError, detectStartupDialog, detectRuntimeMenu, runtimeBusyCheck, hasRuntimeReadyView, hasReplProcTitle, isShellProcTitle, hasOscTitleWorking, hasOscTitleIdle, screenAllowsTitleIdle, PaneGoneError, } from './tmux.js';
+import { TmuxManager, ReplNotReadyError, detectStartupDialog, hasRuntimeReadyView, hasReplProcTitle, isShellProcTitle, PaneGoneError, } from './tmux.js';
 import { BranchManager, DirtyWorkdirError, ReviewHeadMismatchError, isAutoDeletableTaskBranch, } from './branch.js';
 import { RepoStore, createRepoStoreCache } from './repo-store.js';
 import { PhaseSignalWatcher, } from './phase-signal-watcher.js';
@@ -45,7 +46,6 @@ function samePassProvenance(left, right) {
         && right !== undefined
         && left.sourceKey === right.sourceKey
         && left.id === right.id
-        && left.bodyDigest === right.bodyDigest
         && left.token === right.token
         && left.failToken === right.failToken
         && left.anchorSha === right.anchorSha;
@@ -1296,7 +1296,7 @@ export class AgentManager {
                 fresh.paneId !== state.paneId) {
                 continue;
             }
-            const onMenu = detectRuntimeMenu(stripped);
+            const onMenu = isMenuRule(cfg.runtime, classifyScreen(cfg.runtime, stripped).matchedRuleId);
             if (onMenu && !pendingMenu) {
                 pendingMenu = true;
                 await this.emitIntervention(fresh.projectId, agentId, fresh.taskId, {
@@ -2982,36 +2982,49 @@ export class AgentManager {
     }
     async paneHasLiveTurn(tmux, pane, runtime) {
         const paneId = pane.paneId;
-        let first;
-        let firstTitle;
-        try {
-            first = await tmux.capturePaneById(pane, { ansi: false, scrollback: 0 });
-            firstTitle = await tmux.readPaneTitle(pane);
-        }
-        catch (err) {
-            console.warn(`[AgentManager] interruptPaneAndWaitReady: liveness capture failed for pane ${paneId}:`, err);
-            return true;
-        }
-        for (let i = 1; i < RUNTIME_LIVENESS_SAMPLES; i++) {
-            await new Promise(r => setTimeout(r, this.runtimeLivenessProbeMs));
-            let frame;
-            let title;
+        const sample = async (phase) => {
             try {
-                frame = await tmux.capturePaneById(pane, { ansi: false, scrollback: 0 });
-                title = await tmux.readPaneTitle(pane);
+                return {
+                    frame: await tmux.capturePaneById(pane, { ansi: false, scrollback: 0 }),
+                    title: await tmux.readPaneTitle(pane),
+                };
             }
             catch (err) {
-                console.warn(`[AgentManager] interruptPaneAndWaitReady: liveness re-capture failed for pane ${paneId}:`, err);
-                return true;
+                console.warn(`[AgentManager] interruptPaneAndWaitReady: liveness ${phase} failed for pane ${paneId}:`, err);
+                return null;
             }
-            if (title !== firstTitle && hasOscTitleWorking(title))
+        };
+        const first = await sample('capture');
+        if (!first)
+            return true;
+        // 空屏幕 = 只让标题规则说话:标题相对首帧变了且判 working,说明 turn 还活着
+        const titleTurnedWorking = (title) => title !== first.title && classifyScreen(runtime, '', title).state === 'working';
+        let prev = first.frame;
+        let settledSinceChange = true;
+        for (let i = 1; i < RUNTIME_LIVENESS_SAMPLES; i++) {
+            await new Promise(r => setTimeout(r, this.runtimeLivenessProbeMs));
+            const next = await sample('re-capture');
+            if (!next)
                 return true;
-            if (hasRuntimeReadyView(frame, runtime))
-                return false;
-            if (frame !== first)
+            if (titleTurnedWorking(next.title))
                 return true;
+            if (next.frame === prev) {
+                settledSinceChange = true;
+                continue;
+            }
+            if (!hasRuntimeReadyView(next.frame, runtime))
+                return true;
+            // working→idle 的最新帧已 ready:不能仅凭帧差判 live,需再观察一拍确认它稳定
+            prev = next.frame;
+            settledSinceChange = false;
         }
-        return false;
+        if (settledSinceChange)
+            return false;
+        await new Promise(r => setTimeout(r, this.runtimeLivenessProbeMs));
+        const confirm = await sample('confirm capture');
+        if (!confirm)
+            return true;
+        return titleTurnedWorking(confirm.title) || confirm.frame !== prev;
     }
     async paneRunsRuntime(tmux, pane, runtime) {
         const paneId = pane.paneId;
@@ -5419,25 +5432,16 @@ export class AgentManager {
         const { task, driver } = await this.platformTaskAndDriver(taskId);
         if (task.prNumber === undefined)
             return { kind: 'provenance-invalid', reason: 'no bound PR' };
-        const provenance = task.passProvenance;
-        if (!provenance)
+        if (!task.passProvenance)
             return { kind: 'provenance-invalid', reason: 'no accepted pass provenance' };
         const scans = await this.platformScanComments(driver, task.prNumber);
-        const recheck = recheckPassProvenance({
-            token: provenance.token,
-            failToken: provenance.failToken,
-            anchorSha: provenance.anchorSha,
-            carrier: { sourceKey: provenance.sourceKey, id: provenance.id, bodyDigest: provenance.bodyDigest },
-        }, scans);
-        if (!recheck.ok) {
-            return recheck.reason === 'source-scan-incomplete'
-                ? { kind: 'retryable', reason: recheck.reason }
-                : { kind: 'provenance-invalid', reason: `provenance ${recheck.reason}` };
-        }
         const pending = collectPendingFeedback(scans);
         if (!pending.allSourcesOk)
             return { kind: 'retryable', reason: 'source scan incomplete' };
-        return { kind: 'valid', pendingCount: pending.pending.size };
+        const veto = liveVerdictVeto(task.passProvenance, scans);
+        if (veto)
+            return { kind: 'provenance-invalid', reason: `provenance ${veto}` };
+        return { kind: 'valid', pending: pending.pending };
     }
     async platformPendingFeedback(taskId) {
         const { task, driver } = await this.platformTaskAndDriver(taskId);
@@ -5470,24 +5474,14 @@ export class AgentManager {
             if (provenance.anchorSha.toLowerCase() !== opts.expectedHeadSha.toLowerCase()) {
                 throw new PlatformMergeRecheckError('provenance-invalid', `pass provenance anchors ${provenance.anchorSha}, not the merge head ${opts.expectedHeadSha}`);
             }
-            const scans = await this.platformScanComments(driver, prNumber);
-            const recheck = recheckPassProvenance({
-                token: provenance.token,
-                failToken: provenance.failToken,
-                anchorSha: provenance.anchorSha,
-                carrier: { sourceKey: provenance.sourceKey, id: provenance.id, bodyDigest: provenance.bodyDigest },
-            }, scans);
-            if (!recheck.ok) {
-                if (recheck.reason === 'source-scan-incomplete') {
-                    throw new Error('merge blocked: provenance source-scan-incomplete');
-                }
-                throw new PlatformMergeRecheckError('provenance-invalid', `provenance ${recheck.reason}`);
-            }
-            const pending = collectPendingFeedback(scans);
-            if (!pending.allSourcesOk)
+            const verified = await this.platformVerifyAcceptedPass(taskId);
+            if (verified.kind === 'retryable')
                 throw new Error('merge blocked: pending-feedback scan incomplete');
-            if (pending.pending.size > 0) {
-                throw new PlatformMergeRecheckError('pending-feedback', `${pending.pending.size} pending feedback revision(s) without ack`);
+            if (verified.kind === 'provenance-invalid') {
+                throw new PlatformMergeRecheckError('provenance-invalid', verified.reason);
+            }
+            if (verified.pending.size > 0) {
+                throw new PlatformMergeRecheckError('pending-feedback', `${verified.pending.size} pending feedback comment(s) without ack`);
             }
         }
         const fresh = await this.taskStore.get(taskId);
@@ -7007,12 +7001,12 @@ export class AgentManager {
         const paneId = pane.paneId;
         const preTitle = await tmux.readPaneTitle(pane);
         const preFrame = await tmux.capturePaneById(pane, { ansi: false, scrollback: 0 });
-        const staticBusy = hasOscTitleWorking(preTitle)
-            ? (runtimeBusyCheck(preFrame, runtime) || !hasRuntimeReadyView(preFrame, runtime))
-            : runtimeBusyCheck(preFrame, runtime);
-        if (staticBusy && await this.paneHasLiveTurn(tmux, pane, runtime)) {
-            throw new ReplNotReadyError(paneId, runtime, preFrame, `pre-inject busy check: pane ${paneId} is still running a turn; dispatch aborted`);
+        const preDetection = classifyScreen(runtime, preFrame, preTitle);
+        if (preDetection.state === 'pending') {
+            throw new ReplNotReadyError(paneId, runtime, preFrame, `pre-inject check: pane ${paneId} shows a blocker; dispatch aborted`);
         }
+        // working pane 上清稿的 C-c 会打断进行中的 turn
+        const paneWorking = preDetection.state === 'working';
         await revalidate?.();
         if (guardBeforePaste) {
             if (!(await guardBeforePaste())) {
@@ -7024,7 +7018,8 @@ export class AgentManager {
                 pasted = await this.withTaskLock(async () => {
                     if (!(await guardBeforePaste()))
                         return false;
-                    await tmux.clearComposerDraft(pane);
+                    if (!paneWorking)
+                        await tmux.clearComposerDraft(pane);
                     await tmux.pasteStagedBuffer(paneId, staged.buf);
                     return true;
                 });
@@ -7039,6 +7034,10 @@ export class AgentManager {
                     console.warn(`[AgentManager] staged buffer ${staged.buf} not confirmed dropped after failed paste (missing or unprobeable); failing closed to a composer scrub:`, dropErr);
                 }
                 if (bufferConsumed) {
+                    const message = pasteErr instanceof Error ? pasteErr.message : String(pasteErr);
+                    if (paneWorking) {
+                        throw new DispatchTerminalError('ack_unknown', `paste outcome unknown on working pane ${paneId}; composer left untouched to keep the live turn intact: ${message}`);
+                    }
                     try {
                         await tmux.clearComposerDraft(pane);
                     }
@@ -7059,7 +7058,8 @@ export class AgentManager {
             }
         }
         else {
-            await tmux.clearComposerDraft(pane);
+            if (!paneWorking)
+                await tmux.clearComposerDraft(pane);
             await revalidate?.();
             await tmux.injectPrompt(pane, prompt, agentId);
         }
@@ -7076,6 +7076,9 @@ export class AgentManager {
                     return true;
                 });
                 if (!submitted) {
+                    if (paneWorking) {
+                        throw new Error(`fence-rejected prompt stays in the composer of working pane ${paneId}`);
+                    }
                     try {
                         await tmux.clearComposerDraft(pane);
                     }
@@ -7091,11 +7094,18 @@ export class AgentManager {
             }
         }
         catch (preAckErr) {
+            const message = preAckErr instanceof Error ? preAckErr.message : String(preAckErr);
+            // working pane 上 scrub 的 C-c 会打断进行中的 turn:交人工核验,不动 composer
+            if (paneWorking) {
+                throw new DispatchTerminalError('ack_unknown', `pre-ack failure left an unconfirmed composer on working pane ${paneId}: ${message}`);
+            }
             if (await this.clearComposerForReuse(tmux, pane, agentId))
                 throw preAckErr;
-            const message = preAckErr instanceof Error ? preAckErr.message : String(preAckErr);
             throw new DispatchTerminalError('ack_unknown', `pre-ack failure left an unconfirmed composer on live pane ${paneId}: ${message}`);
         }
+        // 判据必须取自粘贴之前:粘贴后的基线含提示词正文,会自匹配 working 规则
+        if (paneWorking)
+            return { acked: true, composerDelivered: true };
         let staleDuringResend = false;
         try {
             await tmux.waitSubmitAck(pane, baseline, runtime, {
@@ -7142,8 +7152,7 @@ export class AgentManager {
                     'baxian intentionally did NOT send C-c — the input may still be queued. ' +
                     'Attach via web terminal to verify and resolve.',
             });
-            const composerDelivered = !/pane already busy at baseline/.test(message);
-            return { acked: false, composerDelivered };
+            return { acked: false, composerDelivered: true };
         }
     }
     async clearComposerForReuse(tmux, pane, agentId) {
@@ -7291,6 +7300,7 @@ export class AgentManager {
                 ...(platform ? { platform } : {}),
                 ...(signalToken ? { signalToken } : {}),
                 ...(imagePaths.length ? { imagePaths } : {}),
+                ...(opts.pendingFeedback?.length ? { pendingFeedback: opts.pendingFeedback } : {}),
             });
         }
         catch (err) {
@@ -8379,7 +8389,7 @@ export class AgentManager {
         if (accepted.kind !== 'valid') {
             throw new ApiError(409, `Cannot restore task ${task.id}: ${accepted.reason}`);
         }
-        if (accepted.pendingCount > 0) {
+        if (accepted.pending.size > 0) {
             throw new ApiError(409, `Cannot restore task ${task.id}: the accepted pass has pending feedback`);
         }
         const reviewedPass = task.passProvenance;
@@ -8880,17 +8890,8 @@ export class AgentManager {
         });
         await new Promise(r => setTimeout(r, this.compactIdlePollMs));
         while (true) {
-            const current = await tmux.displayMessage(pane, '#{pane_current_command}');
-            if (!hasReplProcTitle(current, runtime)) {
-                throw new Error(`waitForReplPromptReady: pane ${paneId} pane_current_command=${current.trim()} (not runtime, REPL may have exited)`);
-            }
-            const cap = await tmux.capturePaneById(pane, { ansi: false, scrollback: 0 });
-            const ready = hasRuntimeReadyView(cap, runtime)
-                || (screenAllowsTitleIdle(cap, runtime) && hasOscTitleIdle(await tmux.readPaneTitle(pane), runtime));
-            if (detectRuntimeMenu(cap) || (!ready && detectStartupDialog(cap, runtime))) {
-                throw new Error(`waitForReplPromptReady: pane ${paneId} shows menu/dialog, not a ready REPL prompt`);
-            }
-            if (!runtimeBusyCheck(cap, runtime)) {
+            const { cap, ready, working } = await this.probeReplPrompt(tmux, pane, runtime);
+            if (!working) {
                 if (!ready) {
                     throw new Error(`waitForReplPromptReady: pane ${paneId} observed idle but no ready anchor (stale frame?)`);
                 }
@@ -8902,6 +8903,23 @@ export class AgentManager {
             await new Promise(r => setTimeout(r, this.compactIdlePollMs));
         }
     }
+    async probeReplPrompt(tmux, pane, runtime) {
+        const paneId = pane.paneId;
+        const current = await tmux.displayMessage(pane, '#{pane_current_command}');
+        if (!hasReplProcTitle(current, runtime)) {
+            throw new Error(`waitForReplPromptReady: pane ${paneId} pane_current_command=${current.trim()} (not runtime, REPL may have exited)`);
+        }
+        const cap = await tmux.capturePaneById(pane, { ansi: false, scrollback: 0 });
+        let detection = classifyScreen(runtime, cap);
+        // 标题规则优先级最高:屏幕判 idle 不作数,必须带标题复核
+        if (detection.state === 'idle')
+            detection = classifyScreen(runtime, cap, await tmux.readPaneTitle(pane));
+        const ready = hasRuntimeReadyView(cap, runtime, detection);
+        if (detection.state === 'pending' || detection.skipStateUpdate || detectStartupDialog(cap, runtime)) {
+            throw new Error(`waitForReplPromptReady: pane ${paneId} shows menu/dialog, not a ready REPL prompt`);
+        }
+        return { cap, ready, working: detection.state === 'working' };
+    }
     async waitForReplPromptStableIdle(tmux, pane, runtime, timeoutMs) {
         const paneId = pane.paneId;
         const samples = Math.max(1, this.readyStableSamples);
@@ -8909,17 +8927,8 @@ export class AgentManager {
         const deadline = Date.now() + timeoutMs + (samples - 1) * spacing;
         let streak = 0;
         while (true) {
-            const current = await tmux.displayMessage(pane, '#{pane_current_command}');
-            if (!hasReplProcTitle(current, runtime)) {
-                throw new Error(`waitForReplPromptReady: pane ${paneId} pane_current_command=${current.trim()} (not runtime, REPL may have exited)`);
-            }
-            const cap = await tmux.capturePaneById(pane, { ansi: false, scrollback: 0 });
-            const ready = hasRuntimeReadyView(cap, runtime)
-                || (screenAllowsTitleIdle(cap, runtime) && hasOscTitleIdle(await tmux.readPaneTitle(pane), runtime));
-            if (detectRuntimeMenu(cap) || (!ready && detectStartupDialog(cap, runtime))) {
-                throw new Error(`waitForReplPromptReady: pane ${paneId} shows menu/dialog, not a ready REPL prompt`);
-            }
-            streak = ready && !runtimeBusyCheck(cap, runtime) ? streak + 1 : 0;
+            const { cap, ready } = await this.probeReplPrompt(tmux, pane, runtime);
+            streak = ready ? streak + 1 : 0;
             if (streak >= samples)
                 return;
             if (Date.now() >= deadline) {