basalt-ui 1.26.0 → 1.28.0

package/src/dashboard/settings-section.tsx

@@ -31,8 +31,11 @@
 import { Card, Stack } from '@mantine/core'
 import type { ReactNode } from 'react'
 import { WidgetHeader } from '../widget-header'
+import type { WidgetHeaderTitleProps } from '../widget-header'
 import { CtlSlot } from '../theme'
 import { alpha, VX } from '../tokens'
+import { cx } from '../common/props'
+import type { BasaltProps, SlotStylesProps } from '../common/props'
 import classes from './settings-section.module.css'
 
 const eyebrowStyle = {
@@ -44,78 +47,131 @@ const eyebrowStyle = {
   color: VX.status.bad,
 }
 
-export type SettingsSectionProps = {
-  /** Head-font section title, rendered via `WidgetHeader tier="section"`. */
-  title: string
-  /** Optional 13px muted description below the title. */
-  subtitle?: string
-  /** Header-right slot — wrapped in `CtlSlot` (C1/C5). */
-  actions?: ReactNode
-  /** Section body — typically a stack of `SettingsRow`s. */
-  children: ReactNode
-}
+/** The three boxes `SettingsSection`/`DangerZone` paint (`common/props.ts`). */
+export type SettingsSectionSlot = 'root' | 'header' | 'body'
+
+/**
+ * Composed from the named `WidgetHeaderTitleProps` slice (audit B #2) rather than a hand-picked
+ * `title`/`subtitle` pair — which is why `icon` and `info` now reach the header too. `value`/`delta`
+ * are deliberately NOT taken: a settings section groups controls, it states no metric.
+ *
+ * `Section` and `ChartCard` still cut their own ad-hoc subsets; both should move onto the same
+ * slices.
+ */
+export type SettingsSectionProps = BasaltProps &
+  SlotStylesProps<SettingsSectionSlot> &
+  WidgetHeaderTitleProps & {
+    /** Header-right slot — wrapped in `CtlSlot` (C1/C5). */
+    actions?: ReactNode
+    /** Section body — typically a stack of `SettingsRow`s. */
+    children: ReactNode
+  }
 
-export function SettingsSection({ title, subtitle, actions, children }: SettingsSectionProps) {
+export function SettingsSection({
+  title,
+  icon,
+  subtitle,
+  info,
+  actions,
+  children,
+  className,
+  style,
+  classNames,
+}: SettingsSectionProps) {
   return (
-    <Card style={{ padding: 'var(--mantine-spacing-xs) var(--mantine-spacing-sm)' }}>
-      <div className={classes.header}>
+    <Card
+      className={cx(classNames?.root, className)}
+      style={{ padding: 'var(--mantine-spacing-xs) var(--mantine-spacing-sm)', ...style }}
+    >
+      <div className={cx(classes.header, classNames?.header)}>
         <WidgetHeader
           tier="section"
           title={title}
+          {...(icon !== undefined && { icon })}
           {...(subtitle !== undefined && { subtitle })}
+          {...(info !== undefined && { info })}
           {...(actions !== undefined && { actions: <CtlSlot>{actions}</CtlSlot> })}
         />
       </div>
-      <div className={classes.rows}>{children}</div>
+      <div className={cx(classes.rows, classNames?.body)}>{children}</div>
     </Card>
   )
 }
 
-export type SettingsRowProps = {
-  /** 13px ink label on the left. */
-  label: string
-  /** Optional 12.5px muted description under the label. */
-  description?: string
-  /** Right-aligned control (input/switch/button). */
-  control?: ReactNode
-  /** Alternative to `control` for a fully custom right-hand region. */
-  children?: ReactNode
-}
+/** The three boxes `SettingsRow` paints (`common/props.ts`). */
+export type SettingsRowSlot = 'root' | 'label' | 'control'
 
-export function SettingsRow({ label, description, control, children }: SettingsRowProps) {
+export type SettingsRowProps = BasaltProps &
+  SlotStylesProps<SettingsRowSlot> & {
+    /** 13px ink label on the left. */
+    label: string
+    /** Optional 12.5px muted description under the label. */
+    description?: string
+    /** Right-aligned control (input/switch/button). */
+    control?: ReactNode
+    /** Alternative to `control` for a fully custom right-hand region. */
+    children?: ReactNode
+  }
+
+export function SettingsRow({
+  label,
+  description,
+  control,
+  children,
+  className,
+  style,
+  classNames,
+}: SettingsRowProps) {
   return (
-    <div className={classes.row}>
-      <Stack gap={2}>
+    <div
+      className={cx(classes.row, classNames?.root, className)}
+      {...(style !== undefined && { style })}
+    >
+      <Stack gap={2} {...(classNames?.label !== undefined && { className: classNames.label })}>
         <span style={{ fontSize: VX.text.md, color: VX.ink }}>{label}</span>
         {description && (
           <span style={{ fontSize: VX.text.sm, color: VX.muted }}>{description}</span>
         )}
       </Stack>
-      <div className={classes.control}>{control ?? children}</div>
+      <div className={cx(classes.control, classNames?.control)}>{control ?? children}</div>
     </div>
   )
 }
 
 export type DangerZoneProps = SettingsSectionProps
 
-export function DangerZone({ title, subtitle, actions, children }: DangerZoneProps) {
+export function DangerZone({
+  title,
+  icon,
+  subtitle,
+  info,
+  actions,
+  children,
+  className,
+  style,
+  classNames,
+}: DangerZoneProps) {
   return (
     <Card
+      className={cx(classNames?.root, className)}
       style={{
         padding: 'var(--mantine-spacing-xs) var(--mantine-spacing-sm)',
         boxShadow: `${VX.shadowCard}, 0 0 0 1px ${alpha(VX.status.bad, 0.25)}`,
+        ...style,
       }}
     >
-      <div className={classes.header}>
+      <div className={cx(classes.header, classNames?.header)}>
         <span style={eyebrowStyle}>Danger Zone</span>
         <WidgetHeader
           tier="section"
           title={title}
+          {...(icon !== undefined && { icon })}
           {...(subtitle !== undefined && { subtitle })}
+          {...(info !== undefined && { info })}
           {...(actions !== undefined && { actions: <CtlSlot>{actions}</CtlSlot> })}
         />
       </div>
-      <div className={classes.rows}>{children}</div>
+      <div className={cx(classes.rows, classNames?.body)}>{children}</div>
     </Card>
   )
 }

package/src/dashboard/stat-card.module.css

@@ -2,9 +2,10 @@
  * StatCard's sparkline placement (docs/CONTROLS-SPEC.md §2.2). `bleed` (default) keeps the historic
  * full-width row beneath the hero value, bled past the card's own inset padding — same negative
  * margins the pre-WidgetHeader version drew inline. `right` sits the sparkline beside the
- * `WidgetHeader`'s hero-value row instead, the reference-design look, and collapses back to
- * `bleed`'s stacked layout below `sm` — CSS only, no JS branch (`47.99375em` is Mantine's own
- * complement of `min-width: 48em`, same value `content/prose.module.css` derives it from).
+ * BREAKDOWN row instead, the reference-design look, and collapses back to `bleed`'s stacked layout
+ * below `sm` — CSS only for the sparkline's own box, `.metricsRow` below for the row it sits in
+ * (`47.99375em` is Mantine's own complement of `min-width: 48em`, same value
+ * `content/prose.module.css` derives it from).
  */
 
 .body {
@@ -14,34 +15,115 @@
   height: 100%;
 }
 
+.header {
+  min-width: 0;
+}
+
 /*
- * `flex-end`, not `center`: the sparkline belongs to the HERO ROW, and the hero row is the header
- * block's last line. Centred against the whole body it floated between the title and the value,
- * which reads as a third, unrelated element; bottom-aligned to the header block it sits beside the
- * number it describes, the reference layout. `gap` is the card's own control gap so the trend never
- * touches a long value.
+ * `right` placement's second row (measured defect: the "···" actions trigger, and the "Data"
+ * select, sat ~74-88px in from the card's right edge — a phone-only 13px is correct). The cause was
+ * `.body[data-placement='right']` making the WHOLE header (title row, actions included) share a row
+ * with the sparkline, so the header's own right edge — where `.actions` lives — stopped wherever the
+ * sparkline began, not at the card. `.header` is no longer placement-scoped at all now: `.body` stays
+ * a COLUMN in both placements (its base rule above), so `.header` gets the FULL card width for free
+ * via the column's default `align-items: stretch` — the actions slot's own `margin-inline-start:
+ * auto` (`widget-header.module.css`) now resolves against the true card edge. Only the breakdown —
+ * the one text `StatCard` renders itself, outside `WidgetHeader`'s box, and the one piece the
+ * `docs/CONTROLS-SPEC.md` `breakdown` doc calls "the parts the hero number is made of" — shares this
+ * row with the sparkline; `justify-content: flex-end` is what still right-aligns the sparkline on a
+ * card with no breakdown, where this row's only child.
  */
-.body[data-placement='right'] {
+.metricsRow {
+  display: flex;
   flex-direction: row;
-  align-items: flex-end;
+  align-items: flex-start;
+  justify-content: flex-end;
   gap: var(--vx-space-control-gap);
+  min-width: 0;
 }
 
-.header {
+/*
+ * The `breakdown` rows — the two or three parts a hero number is made of, under it.
+ *
+ * NO hairline, anywhere in this block, and that is a law rather than a taste: `docs/CONTROLS-SPEC.md`
+ * §2.1 puts a horizontal rule between OPTION rows and nowhere else, and `theme/divider-law.test.ts`
+ * inventories every one basalt draws. Three rules inside a KPI card would read as a table wearing a
+ * card's clothes. The rows are separated by the stack rhythm and by weight — a muted label against
+ * an ink value — which is the same separation the sheet's own field groups use.
+ */
+.breakdown {
+  display: flex;
+  flex-direction: column;
+  margin: var(--vx-space-stack-sm) 0 0;
+  padding: 0;
+  min-width: 0;
+}
+
+/* Inside `.metricsRow` (`right` placement) the breakdown is no longer stacked directly under
+ * `WidgetHeader`'s own metric row in the SAME box — `.body`'s own `gap` already separates `.header`
+ * from `.metricsRow`, so the `margin-top` above would double that spacing. It also takes the row's
+ * remaining width (`flex: 1 1 auto`) so the sparkline — fixed to its own slot width — gets pushed to
+ * the row's end instead of sitting immediately after a shrink-wrapped breakdown column. */
+.metricsRow .breakdown {
+  margin-top: 0;
+  flex: 1 1 auto;
   min-width: 0;
 }
 
 /*
- * `flex-shrink: 0` on the header, `1` on the sparkline slot below: the hero value and its delta keep
- * their width and the TREND gives ground. The other way round, a 4-up KPI grid on a 1440 viewport
- * ellipsized `$1,294,900` to `$1294.…` in order to keep 72px of bars intact, which is the wrong
- * thing to protect. The value still carries `overflow: hidden` as the last resort, and `Card` clips.
+ * One row, one line, at the TAG tier (`controlHeightTag`, 20px at level 0) — the smallest control
+ * step basalt declares, and a token rather than a literal so the rows track the density knob with
+ * everything else. `justify-content: space-between` is what makes the pair read as a row without a
+ * grid: the label leads, the value trails, and neither needs a column to align against because
+ * every row in one card is the same box.
  */
-.body[data-placement='right'] .header {
-  flex: 1 0 auto;
+.breakdownRow {
+  display: flex;
+  align-items: center;
+  justify-content: space-between;
+  gap: var(--vx-space-control-gap);
+  min-height: var(--vx-space-control-height-tag);
   min-width: 0;
 }
 
+.breakdownLabel {
+  overflow: hidden;
+  text-overflow: ellipsis;
+  white-space: nowrap;
+  font-size: var(--vx-text-sm);
+  color: var(--vx-muted);
+}
+
+/* Mono and ink — a breakdown value is a number, and it is the half of the row worth reading. Never
+ * shrinks: the LABEL is the prose half and the one that may ellipsize. */
+.breakdownValue {
+  flex-shrink: 0;
+  margin: 0;
+  font-family: var(--basalt-font-mono);
+  font-size: var(--vx-text-sm);
+  font-weight: 500;
+  color: var(--vx-ink);
+}
+
+/*
+ * A row past a threshold. Same vocabulary and the same per-scheme solids as the card's own tone rail
+ * (`stat-card.tsx`'s `VX.status[tone]`), so a row saying `bad` and a rail saying `bad` are one claim
+ * at two scales. Colour is not the only carrier at the CARD level (the rail ships a
+ * `VisuallyHidden` verdict); at the ROW level the label is the carrier — a row reading
+ * `Paid · 1,204` states its own subject either way, and the tint only ranks it.
+ */
+.breakdownRow[data-tone='good'] .breakdownValue {
+  color: var(--vx-status-good);
+}
+
+.breakdownRow[data-tone='warn'] .breakdownValue {
+  color: var(--vx-status-warn);
+}
+
+.breakdownRow[data-tone='bad'] .breakdownValue {
+  color: var(--vx-status-bad);
+}
+
 .sparklineBleed {
   margin-top: auto;
   margin-inline: calc(-1 * var(--mantine-spacing-sm));
@@ -49,32 +131,36 @@
 }
 
 /* Asks for `StatCard`'s `SPARKLINE_RIGHT_WIDTH`/`_HEIGHT` (handed down as custom properties, so this
- * rule and the `< sm` reset below can both reach them) and shrinks below the width before the hero
- * row does — see the `.header` note above. `min-width: 0` is what lets it. */
+ * rule and the `< sm` reset below can both reach them). `align-self: flex-end` is the one alignment
+ * this restructure keeps at the SPARKLINE's own level rather than the row's: `.metricsRow` does not
+ * set `align-items: flex-end` itself, because a card with no breakdown would then need nothing to
+ * anchor against — only the sparkline opts into sitting at the row's bottom edge, which matters once
+ * a breakdown taller than the trend's own 26px is the row's other child. */
 .sparklineRight {
   display: flex;
   flex: 0 1 var(--basalt-stat-sparkline-w, 4.5rem);
   min-width: 0;
   height: var(--basalt-stat-sparkline-h, 1.625rem);
   align-items: flex-end;
+  align-self: flex-end;
   overflow: hidden;
 }
 
 @media (max-width: 47.99375em) {
-  .body[data-placement='right'] {
+  .metricsRow {
     flex-direction: column;
     align-items: stretch;
-  }
-
-  .body[data-placement='right'] .header {
-    flex: initial;
+    justify-content: flex-start;
   }
 
   /* The row became a COLUMN, so `flex-basis` is now the main-axis HEIGHT — the 72px width would
    * become a 72px-tall box around 26px of bars. `flex: none` + the height keeps the bled trend the
-   * same 26px it is beside a hero row. */
-  .body[data-placement='right'] .sparklineRight {
+   * same 26px it is beside a hero row. `align-self: stretch` resets the row-only `flex-end` above:
+   * the cross axis is horizontal now, and this slot must fill the card's width like `.sparklineBleed`
+   * does, not shrink to its content and sit flush right. */
+  .metricsRow .sparklineRight {
     flex: none;
+    align-self: stretch;
     margin-top: auto;
     margin-inline: calc(-1 * var(--mantine-spacing-sm));
     margin-bottom: calc(-1 * var(--mantine-spacing-xs));

package/src/dashboard/stat-card.module.css.d.ts

@@ -5,6 +5,11 @@
 declare const classes: {
   readonly body: string
   readonly header: string
+  readonly metricsRow: string
+  readonly breakdown: string
+  readonly breakdownRow: string
+  readonly breakdownLabel: string
+  readonly breakdownValue: string
   readonly sparklineBleed: string
   readonly sparklineRight: string
 }