basalt-ui 1.25.0 → 1.27.0

package/src/surfaces.ts

@@ -9,26 +9,61 @@ import type { GuardKind } from './guard/types'
 
 // ── Scalar types ──────────────────────────────────────────────────────────────────────────────────
 
-/** The 13 on-disk rule names (agent/rules/basalt-{name}.md — the set-equality target).
+/** The 6 on-disk rule names (agent/rules/basalt-{name}.md — the set-equality target).
+ *
+ * One rule file per DOCTRINE, not per subpath: `state` also owns the router bridge's placement law
+ * (the two were one argument split across two files), and `batteries` owns every adapter surface
+ * whose doctrine is "use the shipped thing" — query, forms, notifications, commands, data, content,
+ * agent and the app-global layer. Thirteen files carried 4,177 lines, 55% of it with no guard
+ * behind it and the identity paragraph restated six times (`docs/CONTROLS-SPEC.md` §7).
  *
  * @example
  * const r: RuleName = 'tokens' // ok
  * // const bad: RuleName = 'overlays' // tsc error — not in the union
  */
-export type RuleName =
-  | 'tokens'
-  | 'charts'
-  | 'mantine'
-  | 'router'
-  | 'query'
-  | 'state'
-  | 'forms'
-  | 'notifications'
-  | 'commands'
-  | 'data'
-  | 'agent'
-  | 'content'
-  | 'app'
+export type RuleName = 'tokens' | 'charts' | 'mantine' | 'state' | 'controls' | 'batteries'
+
+/**
+ * Every rule the shipped oxlint JS plugin registers (`configs/oxlint-plugin.js` → `rules`), as one
+ * literal union AND one runtime list — the type and the list are the same declaration, so they
+ * cannot drift from each other. What they CAN drift from is the plugin itself, which this module
+ * must not import (it is a standalone `.js` loaded through `jsPlugins` out of a consumer's
+ * node_modules, and `surfaces.ts` is dependency-free by contract). `oxlint-plugin.test.ts` closes
+ * that gap: it asserts this list is EXACTLY the plugin's own rule keys, and `check-coverage`
+ * asserts every id here maps to exactly one surface.
+ *
+ * @example
+ * const id: PluginRuleId = 'hand-rolled-filter' // ok
+ * // const bad: PluginRuleId = 'hand-rolled-filters' // tsc error
+ */
+export const PLUGIN_RULE_ID_LIST = [
+  'no-raw-font-size',
+  'raw-size-literal',
+  'card-inset',
+  'chart-in-raw-surface',
+  'hand-rolled-plot',
+  'chart-legend-literal',
+  'shadow-basalt-export',
+  'hand-rolled-shell',
+  'raw-scroll-container',
+  'hand-rolled-filter',
+  'control-outside-home',
+  'control-size-literal',
+  'page-bar-budget',
+  'in-body-page-title',
+  'responsive-twin',
+  'search-literal-link',
+  'use-search-from-literal',
+  'visx-boundary',
+  'visx-tooltip',
+  'token-layer-boundary',
+  'agent-resume-guard',
+  'agent-no-raw-usechat',
+  'ai-sdk-major',
+] as const
+
+/** One registered oxlint plugin rule id — the literal union of {@link PLUGIN_RULE_ID_LIST}. */
+export type PluginRuleId = (typeof PLUGIN_RULE_ID_LIST)[number]
 
 /** The 3 shipped skill names (agent/skills/basalt-{name}/SKILL.md, placed into a consumer's
  * .claude/skills/ by `basalt-ui init`/`sync` — the same managed path the rules take).
@@ -112,15 +147,33 @@ type BaseSurface = {
  *
  * @example
  * const s: DoctrineSpec = { kind: 'doctrine', layer: 'headless', rule: 'tokens',
- *   skill: ['basalt-design'], guardKinds: ['raw-hex'], forbiddenImports: [] }
+ *   skill: ['basalt-design'], guardKinds: ['raw-hex'], pluginRules: ['no-raw-font-size'],
+ *   forbiddenImports: [] }
  */
 export type DoctrineSpec = BaseSurface & {
   readonly kind: 'doctrine'
   readonly rule: RuleName
   /** A LIST (skill↔surface is many-to-one — basalt-design covers tokens AND mantine AND state). */
   readonly skill: readonly SkillName[]
-  /** Required, but [] is legal for advisory surfaces (router/query: rule only, no guard). */
+  /** Required, but [] is legal for advisory surfaces (the batteries: rule only, no guard). */
   readonly guardKinds: readonly GuardKind[]
+  /**
+   * The oxlint plugin rules this surface's doctrine is enforced by — the AST half of the same seam
+   * `guardKinds` covers with text scans. Required (`[]` is legal, and says "no AST rule guards
+   * this"), because the ABSENCE of the field is what let the generated coverage headers claim a
+   * rule was "backed by" a guard kind while the plugin rule doing the real work went unnamed (D8).
+   *
+   * Every id in {@link PLUGIN_RULE_ID_LIST} maps to EXACTLY ONE surface — asserted by
+   * `check-coverage` and by `oxlint-plugin.test.ts`, so a new plugin rule cannot ship without a
+   * home, and one rule cannot be counted as coverage for two surfaces.
+   */
+  readonly pluginRules: readonly PluginRuleId[]
+  /**
+   * Laws this surface states but nothing enforces — printed under `not guarded:` in the generated
+   * `<!-- basalt:coverage -->` header. The honest half of the block: claiming coverage that does
+   * not exist is D8, and the only way a reader can tell is if the doc says so itself.
+   */
+  readonly advisoryLaws?: readonly string[]
 }
 
 /**
@@ -136,6 +189,8 @@ export type ToolingSpec = BaseSurface & {
   readonly rule?: never
   readonly skill?: never
   readonly guardKinds?: never
+  readonly pluginRules?: never
+  readonly advisoryLaws?: never
 }
 
 /** The discriminated union — the SURFACES registry value type. */
@@ -192,9 +247,29 @@ export const SURFACES = {
       'raw-form-control',
       'sub-16-input-font',
       'mantine-shade-index',
+      // The text lane of the kinds whose remedy IS a Mantine primitive or a Mantine-owned prop:
+      // C8's page title (same id as the plugin rule, so one annotation waives both lanes), the
+      // spacing props, and the layout primitives an inline `display`/raw element replaces.
+      'in-body-page-title',
+      'raw-spacing',
+      'inline-spacing',
+      'inline-display',
+      'raw-html-layout',
+      'hidden-inline-style',
+    ],
+    // The chrome half of the plugin: the shell, the card idiom, the page title and the scroll
+    // doctrine. `hand-rolled-shell` sits here rather than on a shell-shaped surface because
+    // `BasaltShell` IS the root barrel's promise (docs/CONTROLS-SPEC.md §6 wave 6).
+    pluginRules: [
+      'hand-rolled-shell',
+      'card-inset',
+      'in-body-page-title',
+      'raw-scroll-container',
+      'page-bar-budget',
+      'shadow-basalt-export',
     ],
     description:
-      'BasaltProvider, createBasaltTheme, BasaltShell + sidebar/mobile-nav/breadcrumbs, NavCountBadge, ThemeToggle, ThreadWorkspace + thread-chat components, dashboard composites (DeltaBadge, StatCard with threshold tone, EmptyState, QueryState/LoadingState/ErrorState, SettingsSection/SettingsRow/DangerZone)',
+      'BasaltProvider, createBasaltTheme, BasaltShell + sidebar/mobile-nav/breadcrumbs, PageBar, NavCountBadge, ThemeToggle, ThreadWorkspace + thread-chat components, WidgetHeader, dashboard composites (DeltaBadge, StatCard with threshold tone, EmptyState, QueryState/LoadingState/ErrorState, SettingsSection/SettingsRow/DangerZone)',
     optionalPeers: [
       'react-markdown',
       'remark-gfm',
@@ -210,7 +285,20 @@ export const SURFACES = {
     layer: 'headless',
     rule: 'charts',
     skill: ['basalt-charts'],
-    guardKinds: ['raw-hex', 'raw-color-fn', 'raw-visx-axis', 'unframed-chart'],
+    guardKinds: [
+      'raw-hex',
+      'raw-color-fn',
+      'raw-visx-axis',
+      'unframed-chart',
+      'chart-missing-aria-label',
+    ],
+    pluginRules: [
+      'hand-rolled-plot',
+      'chart-legend-literal',
+      'chart-in-raw-surface',
+      'visx-boundary',
+      'visx-tooltip',
+    ],
     description:
       'CartesianChart + visx chart primitives, kinds, sparklines, hooks, and token re-exports (Mantine-free)',
     globs: {
@@ -229,7 +317,28 @@ export const SURFACES = {
     layer: 'headless',
     rule: 'tokens',
     skill: ['basalt-design', 'basalt-charts'],
-    guardKinds: ['raw-hex', 'raw-color-fn', 'off-identity-accent', 'off-system-surface-var'],
+    guardKinds: [
+      'raw-hex',
+      'raw-color-fn',
+      'off-identity-accent',
+      'off-system-surface-var',
+      // The rest of the value lane: every kind whose remedy is a `--vx-*` token or a theme knob,
+      // in TSX and in kebab CSS alike.
+      'raw-font-family',
+      'raw-radius',
+      'raw-surface',
+      'inline-font-size',
+      'css-raw-surface',
+      'surface-shadow-override',
+      // Not a token kind — the kind that judges the ANNOTATION rather than the code. It lands here
+      // because `agent/rules/basalt-tokens.md` is where the `theme-allow` grammar is documented
+      // (said once, on purpose), so this is the header that must name its enforcement.
+      'theme-allow-unscoped',
+    ],
+    // The type-scale rules live with the tokens, not with `.`: both police a value that left the
+    // `--vx-*` system, which is this surface's whole subject. `token-layer-boundary` is the
+    // repo-local-only rule that keeps the layer upstream of Mantine (see below).
+    pluginRules: ['no-raw-font-size', 'raw-size-literal', 'token-layer-boundary'],
     description:
       'VX token refs, buildPaletteCss, defineSeries, seriesTokens, groupTokens, alpha (Mantine-free)',
     globs: {
@@ -269,9 +378,10 @@ export const SURFACES = {
   './query': {
     kind: 'doctrine',
     layer: 'headless',
-    rule: 'query',
+    rule: 'batteries',
     skill: ['basalt-app'],
     guardKinds: [],
+    pluginRules: [],
     description: 'createBasaltQueryClient, transport-agnostic unwrap, lazy BasaltQueryDevtools',
     optionalPeers: ['@tanstack/react-query-devtools'],
     globs: {
@@ -284,11 +394,13 @@ export const SURFACES = {
   './router-tanstack': {
     kind: 'doctrine',
     layer: 'headless',
-    rule: 'router',
+    rule: 'state',
     skill: ['basalt-app'],
     guardKinds: [],
+    // Law C10 — a nav link's `search` and a reader's `from` are both this bridge's contract.
+    pluginRules: ['search-literal-link', 'use-search-from-literal'],
     description:
-      'TanStack Router bridge: defineNav/navGroup/navTarget (one typed nav definition) + useNav (sections + mobileNav, spread onto BasaltShell) + useBasaltNav (active route) + useRouterBreadcrumbs + createSearchParamStore (single-select URL-state store) + createMultiSearchParamStore (multi-select URL-state store)',
+      'TanStack Router bridge: defineNav/navGroup/navTarget (one typed nav definition) + useNav (sections + mobileNav, spread onto BasaltShell) + useBasaltNav (active route) + useRouterBreadcrumbs + createSearchStore (typed URL > localStorage > fallback store over field.enum/multi/range/number/boolean/string; deprecated createSearchParamStore/createMultiSearchParamStore wrappers until 1.29.0)',
     optionalPeers: ['@tanstack/react-router'],
     globs: {
       shipped: [],
@@ -300,9 +412,10 @@ export const SURFACES = {
   './forms': {
     kind: 'doctrine',
     layer: 'mantine-coupled',
-    rule: 'forms',
+    rule: 'batteries',
     skill: ['basalt-design'],
     guardKinds: [],
+    pluginRules: [],
     description:
       'Mantine form adapter: useBasaltForm, field, FormErrorSummary, useFormDraft (Standard Schema)',
     optionalPeers: ['@mantine/form'],
@@ -311,9 +424,10 @@ export const SURFACES = {
   './notifications': {
     kind: 'doctrine',
     layer: 'mantine-coupled',
-    rule: 'notifications',
+    rule: 'batteries',
     skill: ['basalt-app'],
     guardKinds: [],
+    pluginRules: [],
     description:
       'Mantine notifications: notify helpers, typed registry, persisted history, NotificationBell, NotificationCenter',
     optionalPeers: ['@mantine/notifications'],
@@ -322,9 +436,10 @@ export const SURFACES = {
   './commands': {
     kind: 'doctrine',
     layer: 'mantine-coupled',
-    rule: 'commands',
+    rule: 'batteries',
     skill: ['basalt-app'],
     guardKinds: [],
+    pluginRules: [],
     description:
       'typed command bus + overlay controller, toSpotlightActions, ShortcutsHelp, BasaltOverlays',
     optionalPeers: ['@mantine/spotlight', '@mantine/modals', '@tanstack/react-hotkeys'],
@@ -333,9 +448,10 @@ export const SURFACES = {
   './data': {
     kind: 'doctrine',
     layer: 'mantine-coupled',
-    rule: 'data',
+    rule: 'batteries',
     skill: ['basalt-design'],
     guardKinds: [],
+    pluginRules: [],
     description:
       'Convenience barrel pulling both TanStack Table + Virtual peer groups: BasaltDataTable, BasaltVirtualList (Mantine-rendered) — prefer ./data/table or ./data/virtual for per-feature opt-in',
     optionalPeers: ['@tanstack/react-table', '@tanstack/react-virtual'],
@@ -344,9 +460,10 @@ export const SURFACES = {
   './data/table': {
     kind: 'doctrine',
     layer: 'mantine-coupled',
-    rule: 'data',
+    rule: 'batteries',
     skill: ['basalt-design'],
     guardKinds: [],
+    pluginRules: [],
     description:
       'BasaltDataTable: a sortable data table over TanStack Table, rendered with Mantine (Mantine-rendered)',
     optionalPeers: ['@tanstack/react-table'],
@@ -355,9 +472,10 @@ export const SURFACES = {
   './data/virtual': {
     kind: 'doctrine',
     layer: 'mantine-coupled',
-    rule: 'data',
+    rule: 'batteries',
     skill: ['basalt-design'],
     guardKinds: [],
+    pluginRules: [],
     description:
       'BasaltVirtualList: a windowed virtual list over TanStack Virtual, rendered with Mantine (Mantine-rendered)',
     optionalPeers: ['@tanstack/react-virtual'],
@@ -366,9 +484,11 @@ export const SURFACES = {
   './agent': {
     kind: 'doctrine',
     layer: 'headless',
-    rule: 'agent',
+    rule: 'batteries',
     skill: ['basalt-app'],
     guardKinds: [],
+    // The three agent-chat correctness rules — they honour `basalt-agent-allow`, not `theme-allow`.
+    pluginRules: ['agent-resume-guard', 'agent-no-raw-usechat', 'ai-sdk-major'],
     description:
       'Headless streaming-chat layer: useAgentStream, aiSdkTransport (recommended default) + edenTransport, isResumable/ResumableAgentTransport (stream-resumption seam), PartList, coalesceParts, the ForeignPart/definePartRenderers/narrowAgentPart open part-registry seam, plus the multi-thread createThreadsStore + useAgentThreadRuns + outcome-resolver seam (Mantine-free)',
     optionalPeers: ['ai', 'use-stick-to-bottom'],
@@ -382,9 +502,10 @@ export const SURFACES = {
   './agent-chat': {
     kind: 'doctrine',
     layer: 'mantine-coupled',
-    rule: 'agent',
+    rule: 'batteries',
     skill: ['basalt-app'],
     guardKinds: [],
+    pluginRules: [],
     description:
       'Mantine-styled thread-chat components over basalt-ui/agent: ThreadWorkspace, ThreadFeed (variant/renderRow), ThreadFeedRow (inline-expanding Slack row, lazily mounted + kept mounted), ThreadOutcomeCard, ThreadDetailPanel, Composer, ThreadTranscript (open part-renderer registry via its renderers/fallbackRenderer props, per-message MessageAffordances, groupConsecutive, and an optional virtualize/height windowing mode whose VirtualizeOptions carry overscan/estimateSize/initialScroll — a virtualized transcript opens scrolled to the newest message unless initialScroll is "start"), threadPartRenderers, ToolChip (Mantine-coupled). motion is required, not optional — ThreadFeed/ThreadDetailPanel import motion/react eagerly, so this subpath fails to resolve without it installed even though peerDependenciesMeta marks it optional (npm has no per-subpath optionality). remend is genuinely optional here — ThreadTranscript reaches it only through the lazy dynamic import() inside content/markdown.tsx, and @tanstack/react-virtual the same way through the lazy import() behind ThreadTranscript virtualize (absent peer degrades to an unwindowed, height-bound pane).',
     optionalPeers: [
@@ -405,11 +526,12 @@ export const SURFACES = {
   './content': {
     kind: 'doctrine',
     layer: 'mantine-coupled',
-    rule: 'content',
+    rule: 'batteries',
     skill: ['basalt-design'],
     guardKinds: [],
+    pluginRules: [],
     description:
-      'Prose (article/chat typography), CodeBlock (shiki, optional peer), Callout, TableOfContents, ReadingProgress, Markdown (react-markdown + remark-gfm, optional peers; `streaming` is a rendering mode ONLY — `contentTrust` is the independent security input, and any surface rendering agent/model output must pin `contentTrust="untrusted"`, the sole input to the image-origin allowlist; a `fenceRenderers` registry — settledOnly/FenceRenderer/FenceRenderers/FenceRenderContext; `sanitizeSchema`, an additions-only SanitizeSchemaExtension merged over BASALT_SANITIZE_SCHEMA via mergeSanitizeSchema; the remend streaming-repair pass is now a lazy optional peer), MermaidDiagram (beautiful-mermaid, optional peer), mdxComponents/createMdxComponents, ArticleLayout (docs-page frame), ArticleCard/ArticleGrid (overview cards), Article model (sortArticles/filterArticles/formatArticleDate), ArticleFilterBar (category/tags filter UI), toArticleActions (Spotlight projector, @mantine/spotlight type-only), GuideLink/GuideDrawer (contextual-help drawer) — the content/prose surface',
+      'Prose (article/chat typography), CodeBlock (shiki, optional peer), Callout, TableOfContents, ReadingProgress, Markdown (react-markdown + remark-gfm, optional peers; `streaming` is a rendering mode ONLY — `contentTrust` is the independent security input, and any surface rendering agent/model output must pin `contentTrust="untrusted"`, the sole input to the image-origin allowlist; a `fenceRenderers` registry — settledOnly/FenceRenderer/FenceRenderers/FenceRenderContext; `sanitizeSchema`, an additions-only SanitizeSchemaExtension merged over BASALT_SANITIZE_SCHEMA via mergeSanitizeSchema; the remend streaming-repair pass is now a lazy optional peer), MermaidDiagram (beautiful-mermaid, optional peer), mdxComponents/createMdxComponents, ArticleLayout (docs-page frame), ArticleCard/ArticleGrid (overview cards), Article model (sortArticles/filterArticles/formatArticleDate), FilterSet/ViewTabs/MultiSelectFilter re-exported from ./controls (they replaced the controlled ArticleFilterBar), toArticleActions (Spotlight projector, @mantine/spotlight type-only), GuideLink/GuideDrawer (contextual-help drawer) — the content/prose surface',
     optionalPeers: [
       'shiki',
       '@shikijs/langs',
@@ -423,14 +545,58 @@ export const SURFACES = {
     ],
     forbiddenImports: [],
   },
+  './controls': {
+    kind: 'doctrine',
+    layer: 'mantine-coupled',
+    rule: 'controls',
+    skill: ['basalt-design'],
+    // The text lane of law C1 — the plugin's `control-outside-home` seen through a 12-line host-tag
+    // window, since a regex scan has no ancestry. Same law, same wave, same promotion.
+    guardKinds: ['raw-selection-control'],
+    // The control tier itself (laws C1/C3/C5/C9). `hand-rolled-filter`, `control-size-literal` and
+    // `responsive-twin` all ship `error`; `control-outside-home` is the one grace entry left in
+    // `PLUGIN_RULE_GRACE`, re-dated to 1.28.0 against the wave-7 measurement (see its `why`).
+    // The budget rules live on `.` with `PageBar` itself.
+    pluginRules: [
+      'hand-rolled-filter',
+      'control-outside-home',
+      'control-size-literal',
+      'responsive-twin',
+    ],
+    // docs/CONTROLS-SPEC.md §6 "Honest coverage" — verbatim, because a generated header claiming
+    // otherwise is D8 again.
+    advisoryLaws: [
+      'C1 as a cross-file law (a control placed in one file, its home declared in another)',
+      'hand-rolled section headings (argo writes `<Text fw={600} size="sm">` + children, which no AST heuristic matches without false positives)',
+      'C11 — a table/list stating its count when it is not a BasaltDataTable',
+      'C12 — one shape for refresh/sync (SyncButton); only the alias table sees a renamed copy',
+    ],
+    description:
+      'The control tier (docs/CONTROLS-SPEC.md §3): FilterSet (nowrap row + measured +N fold + the mobile Filters (n) sheet), RangeFilter/CompareFilter/SelectFilter/MultiSelectFilter/NumberFilter/SearchFilter/ToggleFilter (each bound to a FieldHandle — no value/onChange/size, law C2/C5; NumberFilter is the field.number lane, a radio list over `options` or a stepper without), ViewTabs, and the action/sync family (ActionGroup, OverflowMenu, SyncButton, BarAction/GlobalAction). Every control owns its own desktop/mobile swap in CSS (C9) and renders size="ctl" internally. Resolves and renders with NO @mantine/dates installed — the custom date picker is injected through RangeFilter.customPicker from ./controls-dates.',
+    optionalPeers: [],
+    forbiddenImports: [],
+  },
+  './controls-dates': {
+    kind: 'doctrine',
+    layer: 'mantine-coupled',
+    rule: 'controls',
+    skill: ['basalt-design'],
+    guardKinds: [],
+    pluginRules: [],
+    description:
+      "DateRangePicker — the @mantine/dates implementation of RangeFilter's customPicker seam. Its own subpath because @mantine/dates is an optional peer and basaltViteConfig pre-bundles the whole @mantine scope, so a consumer without the peer (linewatch) must never resolve it: nothing under src/controls may import it, statically or lazily (docs/CONTROLS-SPEC.md §3).",
+    optionalPeers: ['@mantine/dates'],
+    forbiddenImports: [],
+  },
   './state': {
     kind: 'doctrine',
     layer: 'headless',
     rule: 'state',
     skill: ['basalt-design'],
     guardKinds: ['localstorage-theme'],
+    pluginRules: [],
     description:
-      'createPersistedState (versioned localStorage) + useOnlineStatus — Mantine-free state primitives',
+      'createPersistedState (versioned localStorage) + the store field vocabulary (field.enum/multi/range/number/boolean/string, FieldHandle, lanes) + createLocalStore, the router-free store — Mantine-free state primitives',
     optionalPeers: [],
     // Consumers import basalt-ui/state from node_modules (lint-ignored), so there is nothing to
     // enforce consumer-side, and a shipped **/state* glob would wrongly hit consumers' own
@@ -449,6 +615,7 @@ export const SURFACES = {
     rule: 'mantine',
     skill: ['basalt-app'],
     guardKinds: [],
+    pluginRules: [],
     description:
       'ConnectivityProvider (aggregates browser online/offline, React Query onlineManager, SSE, and health-check pings into one status), useConnectivity, and ConnectivityIndicator — auto-mounted by BasaltProvider',
     optionalPeers: [],
@@ -490,9 +657,10 @@ export const SURFACES = {
     // synthetic global app-wide ban layer — the src/**+app/** glob
     kind: 'doctrine',
     layer: 'app-global',
-    rule: 'app',
+    rule: 'batteries',
     skill: ['basalt-app'],
     guardKinds: [],
+    pluginRules: [],
     globs: {
       // Shipped is a catch-all (not just src/**+app/**) so consumer code under components/, lib/,
       // features/, etc. is also covered. The @visx/*-only-in-charts and Mantine-free charts/tokens
@@ -523,7 +691,7 @@ export const SURFACES = {
 
 /**
  * Derived, deduped set of doctrine rule names. Projection 1 of SURFACES.
- * → ['mantine', 'charts', 'tokens', 'query', 'router', 'forms', 'notifications', 'commands', 'data', 'agent', 'content', 'state', 'app'] (order is insertion order of Set)
+ * → ['mantine', 'charts', 'tokens', 'batteries', 'state', 'controls'] (order is insertion order of Set)
  *
  * @example
  * RULE_NAMES.includes('tokens') // true

package/src/theme/controls.module.css

@@ -204,7 +204,8 @@ html[data-mantine-color-scheme] .inputWrapper[data-variant='default']:not([data-
 /*
  * Reduced motion drops the fade, never the shadow: a static shadow is not motion, and removing it
  * would strip the very hierarchy this pass exists to establish from the users who asked for less
- * animation. `subtle`'s hover depth still lands — it just lands instantly.
+ * animation. `default`/`filled`/`light`/`outline`'s hover depth still lands — it just lands
+ * instantly. `subtle` stays flat regardless, as it does in every other state (see above).
  */
 @media (prefers-reduced-motion: reduce) {
   .buttonRoot,
@@ -282,3 +283,17 @@ html[data-mantine-color-scheme] .tabsRoot {
 html .tableRoot {
   --table-border-color: var(--vx-surface-hairline);
 }
+
+/*
+ * The LAST row's separator is dropped — exactly the rule (and exactly the reasoning) the Accordion
+ * above already carries: a separator BETWEEN items is information, and the same line drawn after the
+ * final item is an outer border pretending to be one. It mattered more once `BasaltDataTable`'s
+ * `withTableBorder` went to `false` by default, because the two used to sit on top of each other and
+ * the doubling hid which of them was drawing the line.
+ *
+ * Scoped to `tbody`: a `tfoot` (a totals row) is separated FROM the body by the rule above it, which
+ * is a between rule and stays.
+ */
+html .tableRoot tbody tr:last-of-type {
+  border-bottom: none;
+}