basalt-ui 1.11.0 → 1.13.0

package/src/theme/contrast.test.ts

@@ -263,8 +263,7 @@ describe('the accent is single-sourced: Mantine chrome is bridged to --vx-*', ()
 })
 
 describe('the variant resolver hands off to CSS, never to a baked color', () => {
-  const resolve = (color: string) =>
-    theme.variantColorResolver({ color, theme, variant: 'filled', gradient: undefined })
+  const resolve = (color: string) => theme.variantColorResolver({ color, theme, variant: 'filled' })
 
   for (const color of COLORS) {
     test(`filled ${color} resolves to var(--vx-on-${color})`, () => {
@@ -288,7 +287,6 @@ describe('the variant resolver hands off to CSS, never to a baked color', () =>
       color: 'blue',
       theme,
       variant: 'filled',
-      gradient: undefined,
       autoContrast: false,
     })
     expect(color).toBe('var(--mantine-color-white)')
@@ -317,7 +315,6 @@ describe('doctrine inversion #1 reaches every default-variant CONTROL, not just
       color: theme.primaryColor,
       theme,
       variant: 'default',
-      gradient: undefined,
     })
     expect(border).toContain('solid var(--mantine-color-default-border)')
     expect(border).not.toContain('surface-border')

package/src/theme/density-relations.test.ts

@@ -67,8 +67,10 @@ describe('Fix 1 — input height, button height, and ActionIcon size never drift
     }
     for (const level of ALL_LEVELS) {
       const { anchors } = deriveSpacing(level)
-      expect(anchors.inputHeight).toBe(expected[level])
-      expect(anchors.controlHeight).toBe(expected[level])
+      const expectedHeight = expected[level]
+      if (expectedHeight === undefined) throw new Error(`no expected height for level ${level}`)
+      expect(anchors.inputHeight).toBe(expectedHeight)
+      expect(anchors.controlHeight).toBe(expectedHeight)
     }
   })
 

package/src/theme/fonts-option.test.ts

@@ -5,6 +5,7 @@
  */
 import { describe, expect, test } from 'bun:test'
 import { baseTheme, createBasaltTheme } from './index'
+import type { BasaltFontsConfig } from './index'
 
 describe('the default path carries no theme.other.basaltFonts', () => {
   test('createBasaltTheme() carries no basaltFonts', () => {
@@ -26,7 +27,12 @@ describe('an empty fonts object is treated as absent — stays on the static bas
   })
 
   test('an all-undefined-keys fonts object is also treated as absent', () => {
-    const theme = createBasaltTheme(undefined, { fonts: { sans: undefined } })
+    // Deliberately constructs a key explicitly set to undefined — exactOptionalPropertyTypes
+    // correctly forbids this as a static shape, but the whole point of the test is verifying
+    // createBasaltTheme's RUNTIME handling of that wire shape (a caller spreading in an
+    // undefined value), hence the cast.
+    const fonts = { sans: undefined } as unknown as BasaltFontsConfig
+    const theme = createBasaltTheme(undefined, { fonts })
     expect(theme).toBe(baseTheme)
     expect(theme.other?.['basaltFonts']).toBeUndefined()
   })

package/src/theme/shadow-surfaces.test.ts

@@ -140,8 +140,10 @@ function cssShadowSites(relPath: string, text: string): ShadowSite[] {
   const RULE = /([^{}]+)\{([^{}]*)\}/g
   let match: RegExpExecArray | null
   while ((match = RULE.exec(clean))) {
-    const selector = match[1].trim().replace(/\s+/g, ' ')
-    const body = match[2]
+    // Both capture groups are non-optional in RULE — a successful match always populates them;
+    // the `!` documents that (matches the same idiom in vite-color-mix.ts's splitColorAndPercent).
+    const selector = match[1]!.trim().replace(/\s+/g, ' ')
+    const body = match[2]!
     if (CSS_SHADOW_TOKEN.test(body)) sites.push({ file: relPath, site: selector })
   }
   return sites
@@ -165,16 +167,20 @@ function tsShadowSites(relPath: string, text: string): ShadowSite[] {
     let slot: string | null = null
     let component: string | null = null
     for (let j = i - 1; j >= 0 && j >= i - LOOKBACK; j--) {
+      // `j` is bounded by the loop condition (`j >= 0`) to a valid index of `lines` — the `!`
+      // documents that, not a mis-indexed fixture.
+      const jLine = lines[j]!
       if (slot === null) {
-        const slotMatch = SLOT.exec(lines[j])
+        const slotMatch = SLOT.exec(jLine)
         if (slotMatch) {
-          slot = slotMatch[1]
+          // SLOT's one capture group is non-optional — a successful match always populates it.
+          slot = slotMatch[1]!
           continue
         }
       }
-      const componentMatch = COMPONENT.exec(lines[j])
+      const componentMatch = COMPONENT.exec(jLine)
       if (componentMatch) {
-        component = componentMatch[1]
+        component = componentMatch[1]!
         break
       }
     }
@@ -380,6 +386,15 @@ export const SHADOW_SURFACES: readonly ShadowSurfaceEntry[] = [
     site: 'default',
     roundedBy: 'borderRadius: VX.radiusCard (co-declared in the same inline style object).',
   },
+  {
+    file: 'agent-chat/thread-feed-row.tsx',
+    site: 'default',
+    roundedBy:
+      'borderRadius: VX.radiusCard (co-declared in the same inline style object as the shadow). ' +
+      'This box also carries overflow: hidden, which is what lets the header button and the ' +
+      'expanded body square off against the row’s rounded corners; an element’s own overflow ' +
+      'never clips its own ring, so the shadow is unaffected.',
+  },
   // ── agent ────────────────────────────────────────────────────────────────────────────────────
   {
     file: 'agent/stick-to-bottom.tsx',

package/src/theme/use-basalt-spacing.test.tsx

@@ -28,7 +28,8 @@ function readBasaltSpacing(theme?: MantineProviderProps['theme']) {
     return null
   }
   renderToStaticMarkup(
-    <MantineProvider theme={theme}>
+    // exactOptionalPropertyTypes forbids an explicit theme={undefined} — spread only when set
+    <MantineProvider {...(theme !== undefined ? { theme } : {})}>
       <Probe />
     </MantineProvider>,
   )