barebrowse 0.17.0 → 0.19.1

package/types/dialog.d.ts

@@ -0,0 +1,44 @@
+/**
+ * dialog.js — Shared JS-dialog decision core for both engines.
+ *
+ * A JS dialog (alert/confirm/prompt/beforeunload) surfaces differently per
+ * protocol — CDP's `Page.javascriptDialogOpening` vs BiDi's
+ * `browsingContext.userPromptOpened` — but the *decision* (accept? what prompt
+ * text?) and the log entry are identical. This module single-sources both so
+ * the CDP path (index.js) and the BiDi path (firefox-page.js) can't drift
+ * (code-review Phase-3 finding #5).
+ */
+/**
+ * Build a dialogLog entry from a normalized dialog descriptor.
+ * @param {string} type - 'alert' | 'confirm' | 'prompt' | 'beforeunload'
+ * @param {string} [message]
+ * @returns {{type: string, message: string, timestamp: string}}
+ */
+export function dialogLogEntry(type: string, message?: string): {
+    type: string;
+    message: string;
+    timestamp: string;
+};
+/**
+ * Decide how to answer a JS dialog. Default policy (both engines): accept
+ * everything except `beforeunload` (dismiss = stay on page); a `prompt`
+ * returns its default text. A caller-installed handler may override via
+ * `{ accept, promptText }`; if the handler throws we keep the defaults so the
+ * page never hangs waiting for a reply that never arrives.
+ *
+ * @param {{type: string, message?: string, defaultPrompt?: string}} dialog
+ * @param {?(function({type,message,defaultPrompt}): (object|Promise<object>))} handler
+ * @returns {Promise<{accept: boolean, promptText: string}>}
+ */
+export function decideDialog({ type, message, defaultPrompt }: {
+    type: string;
+    message?: string;
+    defaultPrompt?: string;
+}, handler: ((arg0: {
+    type: any;
+    message: any;
+    defaultPrompt: any;
+}) => (object | Promise<object>)) | null): Promise<{
+    accept: boolean;
+    promptText: string;
+}>;

package/types/firefox-page.d.ts

@@ -7,6 +7,9 @@
  * @param {string} [opts.uploadDir] - When set, upload() rejects files outside this dir.
  * @param {boolean} [opts.incognito=false] - Clean session: injectCookies() is a no-op.
  * @param {boolean} [opts.consent=true] - Auto-dismiss cookie consent dialogs after goto().
+ * @param {boolean} [opts.hybrid=false] - Relaunch headed on a bot-challenge page and retry.
+ * @param {boolean} [opts.headed=false] - Whether the browser was launched headed (skips hybrid fallback).
+ * @param {?function(): Promise<{bidi: object, topContext: string}>} [opts.relaunchHeaded] - Hybrid relaunch hook (from connectFirefox).
  * @returns {Promise<object>} page object
  */
 export function createFirefoxPage(bidi: object, opts?: {
@@ -18,4 +21,10 @@ export function createFirefoxPage(bidi: object, opts?: {
     uploadDir?: string | undefined;
     incognito?: boolean | undefined;
     consent?: boolean | undefined;
+    hybrid?: boolean | undefined;
+    headed?: boolean | undefined;
+    relaunchHeaded?: (() => Promise<{
+        bidi: object;
+        topContext: string;
+    }>) | null | undefined;
 }): Promise<object>;

package/types/firefox.d.ts

@@ -14,6 +14,7 @@ export function findFirefox(): string;
  * @param {string} [opts.proxy] - Proxy 'host:port' or 'scheme://host:port'
  *   (http/https → HTTP+SSL proxy; socks/socks5/socks4 → SOCKS), via prefs
  * @param {{width:number,height:number}} [opts.viewport] - Initial window size
+ * @param {string} [opts.downloadDir] - Route downloads here (throwaway dir), no prompt
  * @returns {Promise<{wsUrl: string, process: import('node:child_process').ChildProcess, port: number, ownedProfileDir: string}>}
  */
 export function launchFirefox(opts?: {
@@ -25,6 +26,7 @@ export function launchFirefox(opts?: {
         width: number;
         height: number;
     } | undefined;
+    downloadDir?: string | undefined;
 }): Promise<{
     wsUrl: string;
     process: import("node:child_process").ChildProcess;

package/types/index.d.ts

@@ -129,21 +129,5 @@ export function connect(opts?: {
 export function applyBlocklist(session: any, pageOpts: any): Promise<void>;
 /** Test-only: reset the warn-once flag. Not part of the public API. */
 export function _resetBlocklistWarning(): void;
-/**
- * Detect if a page is a bot-challenge page (Cloudflare, hCaptcha, etc.).
- *
- * Pre-H9 this was over-aggressive: `nodeCount < 50` alone fired on any
- * legitimate small page (404s, simple landings, error pages), and generic
- * phrases like "access denied" / "unknown error" / "permission denied"
- * triggered on real HTTP 4xx/5xx pages, kicking hybrid mode into a costly
- * headed fallback for nothing.
- *
- * H9 split: STRONG_PHRASES are essentially-unambiguous challenge UI and
- * fire regardless of page size; WEAK_PHRASES only fire when the page is
- * ALSO tiny (so a legitimate-looking error page with "access denied" in
- * its body doesn't trip the fallback).
- *
- * @param {object} tree - Nested ARIA tree (from buildTree)
- * @param {number} [nodeCount] - Raw CDP node count (from Accessibility.getFullAXTree)
- */
-export function isChallengePage(tree: object, nodeCount?: number): boolean;
+export { isChallengePage };
+import { isChallengePage } from './challenge.js';