bare-url 2.1.4 → 2.1.6

package/CMakeLists.txt

@@ -5,8 +5,8 @@ find_package(cmake-fetch REQUIRED PATHS node_modules/cmake-fetch)
 
 project(bare_url C)
 
-fetch_package("github:holepunchto/libutf#65b6ba0")
-fetch_package("github:holepunchto/liburl#54406f0")
+fetch_package("github:holepunchto/libutf#9c5d642")
+fetch_package("github:holepunchto/liburl#03f1488")
 
 add_bare_module(bare_url)
 

package/binding.c

@@ -165,47 +165,6 @@ bare_url_can_parse (js_env_t *env, js_callback_info_t *info) {
   return result;
 }
 
-static js_value_t *
-bare_url_tag (js_env_t *env, js_callback_info_t *info) {
-  int err;
-
-  size_t argc = 1;
-  js_value_t *argv[1];
-
-  err = js_get_callback_info(env, info, &argc, argv, NULL, NULL);
-  assert(err == 0);
-
-  assert(argc == 1);
-
-  err = js_add_type_tag(env, argv[0], &bare_url__tag);
-  assert(err == 0);
-
-  return NULL;
-}
-
-static js_value_t *
-bare_url_is_tagged (js_env_t *env, js_callback_info_t *info) {
-  int err;
-
-  size_t argc = 1;
-  js_value_t *argv[1];
-
-  err = js_get_callback_info(env, info, &argc, argv, NULL, NULL);
-  assert(err == 0);
-
-  assert(argc == 1);
-
-  bool is_url;
-  err = js_check_type_tag(env, argv[0], &bare_url__tag, &is_url);
-  assert(err == 0);
-
-  js_value_t *result;
-  err = js_get_boolean(env, is_url, &result);
-  assert(err == 0);
-
-  return result;
-}
-
 static js_value_t *
 bare_url_exports (js_env_t *env, js_value_t *exports) {
   int err;
@@ -221,8 +180,6 @@ bare_url_exports (js_env_t *env, js_value_t *exports) {
 
   V("parse", bare_url_parse)
   V("canParse", bare_url_can_parse)
-  V("tag", bare_url_tag)
-  V("isTagged", bare_url_is_tagged)
 #undef V
 
   return exports;

package/index.js

@@ -2,11 +2,13 @@ const path = require('bare-path')
 const binding = require('./binding')
 const errors = require('./lib/errors')
 
+const kind = Symbol.for('bare.url.kind')
+
 const isWindows = Bare.platform === 'win32'
 
 module.exports = exports = class URL {
-  static {
-    binding.tag(this)
+  static get [kind]() {
+    return 0 // Compatibility version
   }
 
   constructor(input, base, opts = {}) {
@@ -21,6 +23,10 @@ module.exports = exports = class URL {
     this._parse(input, base, opts.throw !== false)
   }
 
+  get [kind]() {
+    return URL[kind]
+  }
+
   // https://url.spec.whatwg.org/#dom-url-href
 
   get href() {
@@ -277,17 +283,11 @@ exports.URL = URL // For Node.js compatibility
 exports.errors = errors
 
 exports.isURL = function isURL(value) {
-  if (typeof value !== 'object' || value === null) return false
-
-  let constructor = value.constructor
-
-  while (typeof constructor === 'function') {
-    if (binding.isTagged(constructor)) return true
-
-    constructor = Reflect.getPrototypeOf(constructor)
-  }
+  if (value instanceof URL) return true
 
-  return false
+  return (
+    typeof value === 'object' && value !== null && value[kind] === URL[kind]
+  )
 }
 
 exports.parse = function parse(input, base) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bare-url",
-  "version": "2.1.4",
+  "version": "2.1.6",
   "description": "WHATWG URL implementation for JavaScript",
   "exports": {
     "./package": "./package.json",