bare-module 4.8.2 → 4.8.4

package/binding.c

@@ -282,9 +282,11 @@ bare_module_create_function(js_env_t *env, js_callback_info_t *info) {
 
   js_value_t **args = malloc(sizeof(js_value_t *) * args_len);
 
-  for (int i = 0; i < args_len; i++) {
-    err = js_get_element(env, argv[1], i, &args[i]);
-    if (err < 0) goto err;
+  uint32_t fetched;
+  err = js_get_array_elements(env, argv[1], args, args_len, 0, &fetched);
+
+  if (err < 0 || fetched != args_len) {
+    goto err;
   }
 
   js_value_t *source = argv[2];
@@ -368,9 +370,11 @@ bare_module_create_synthetic_module(js_env_t *env, js_callback_info_t *info) {
 
   js_value_t **export_names = malloc(sizeof(js_value_t *) * names_len);
 
-  for (int i = 0; i < names_len; i++) {
-    err = js_get_element(env, argv[1], i, &export_names[i]);
-    if (err < 0) goto err;
+  uint32_t fetched;
+  err = js_get_array_elements(env, argv[1], export_names, names_len, 0, &fetched);
+
+  if (err < 0 || fetched != names_len) {
+    goto err;
   }
 
   bare_module_context_t *context;

package/index.js

@@ -501,6 +501,8 @@ module.exports = exports = class Module {
 
     if (resolution) return protocol.postresolve(resolution)
 
+    const candidates = []
+
     for (const resolution of resolve(
       resolved,
       parentURL,
@@ -516,6 +518,8 @@ module.exports = exports = class Module {
       },
       readPackage
     )) {
+      candidates.push(resolution)
+
       switch (resolution.protocol) {
         case 'builtin:':
           return resolution
@@ -526,9 +530,14 @@ module.exports = exports = class Module {
       }
     }
 
-    throw errors.MODULE_NOT_FOUND(
-      `Cannot find module '${specifier}' imported from '${parentURL.href}'`
-    )
+    let message = `Cannot find module '${specifier}' imported from '${parentURL.href}`
+
+    if (candidates.length > 0) {
+      message += '\nCandidates:'
+      message += '\n' + candidates.map((url) => '- ' + url.href).join('\n')
+    }
+
+    throw errors.MODULE_NOT_FOUND(message, candidates)
 
     function readPackage(packageURL) {
       if (protocol.exists(packageURL, constants.types.JSON)) {

package/lib/errors.js

@@ -12,12 +12,16 @@ module.exports = class ModuleError extends Error {
     return 'ModuleError'
   }
 
-  static MODULE_NOT_FOUND(msg) {
-    return new ModuleError(
+  static MODULE_NOT_FOUND(msg, candidates = []) {
+    const err = new ModuleError(
       msg,
       'MODULE_NOT_FOUND',
       ModuleError.MODULE_NOT_FOUND
     )
+
+    err.candidates = candidates
+
+    return err
   }
 
   static ASSET_NOT_FOUND(msg) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bare-module",
-  "version": "4.8.2",
+  "version": "4.8.4",
   "description": "Module support for JavaScript",
   "exports": {
     ".": {
@@ -32,6 +32,9 @@
     "url": "https://github.com/holepunchto/bare-module/issues"
   },
   "homepage": "https://github.com/holepunchto/bare-module#readme",
+  "engines": {
+    "bare": ">=1.16.0"
+  },
   "dependencies": {
     "bare-bundle": "^1.3.0",
     "bare-module-lexer": "^1.0.0",