bare-module 3.1.14 → 3.2.0

package/README.md

@@ -163,6 +163,18 @@ If a package defines only a single export, `"."`, it may leave out the subpath e
 
 ##### Private imports
 
+#### `"engines"`
+
+```json
+{
+  "engines": {
+    "bare": ">=1.0.5"
+  }
+}
+```
+
+The engine requirements of the package. During module resolution, the versions declared by `Bare.versions` will be tested against the requirements declared by the package and resolution fail if they're not satisfied.
+
 ## API
 
 #### `Module.constants`

package/binding.c

@@ -474,28 +474,30 @@ bare_module_run_module (js_env_t *env, js_callback_info_t *info) {
     err = js_get_promise_state(env, promise, &state);
     assert(err == 0);
 
+    js_value_t *reason;
+
     if (state == js_promise_rejected) {
-      js_value_t *reason;
       err = js_get_promise_result(env, promise, &reason);
       if (err < 0) return NULL;
-
-      js_value_t *exception;
-      err = js_get_and_clear_last_exception(env, &exception);
+    } else {
+      err = js_get_null(env, &reason);
       assert(err == 0);
+    }
 
-      js_value_t *ctx;
-      err = js_get_reference_value(env, context->ctx, &ctx);
-      assert(err == 0);
+    js_value_t *exception;
+    err = js_get_and_clear_last_exception(env, &exception);
+    assert(err == 0);
 
-      js_value_t *args[3] = {reason, promise, exception};
+    js_value_t *ctx;
+    err = js_get_reference_value(env, context->ctx, &ctx);
+    assert(err == 0);
 
-      js_call_function(env, ctx, argv[2], 3, args, NULL);
+    js_value_t *args[3] = {reason, promise, exception};
 
-      return NULL;
-    }
+    js_call_function(env, ctx, argv[2], 3, args, NULL);
   }
 
-  return promise;
+  return NULL;
 }
 
 static js_value_t *

package/index.js

@@ -180,7 +180,7 @@ const Module = module.exports = exports = class Module {
   }
 
   _run () {
-    binding.runModule(this._handle, Module._handle, Module._onrejection)
+    binding.runModule(this._handle, Module._handle, Module._onrun)
   }
 
   _evaluate (eagerRun = false) {
@@ -343,10 +343,14 @@ const Module = module.exports = exports = class Module {
     }
   }
 
-  static _onrejection (reason, promise, err = reason) {
-    promise.catch(() => {}) // Don't leak the rejection
+  static _onrun (reason, promise, err = reason) {
+    if (err) {
+      promise.catch(() => {}) // Don't leak the rejection
 
-    throw err
+      throw err
+    } else {
+      promise.catch((err) => queueMicrotask(() => { throw err }))
+    }
   }
 
   static Protocol = Protocol
@@ -449,6 +453,9 @@ const Module = module.exports = exports = class Module {
       imports,
       resolutions,
       builtins: builtins ? Object.keys(builtins) : [],
+      engines: {
+        ...Bare.versions
+      },
       extensions: [
         '.js',
         '.cjs',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bare-module",
-  "version": "3.1.14",
+  "version": "3.2.0",
   "description": "Module support for JavaScript",
   "main": "index.js",
   "files": [
@@ -27,7 +27,7 @@
   "homepage": "https://github.com/holepunchto/bare-module#readme",
   "dependencies": {
     "bare-bundle": "^1.0.0",
-    "bare-module-resolve": "^1.4.4",
+    "bare-module-resolve": "^1.6.0",
     "bare-path": "^2.0.0",
     "cjs-module-lexer": "^1.2.3",
     "url-file-url": "^1.0.2"