bare-http1 4.1.1 → 4.1.3

package/index.d.ts

@@ -8,11 +8,7 @@ import {
 } from 'bare-tcp'
 import Buffer from 'bare-buffer'
 import URL from 'bare-url'
-import constants, {
-  HTTPMethod,
-  HTTPStatusCode,
-  HTTPStatusMessage
-} from './lib/constants'
+import constants, { HTTPMethod, HTTPStatusCode, HTTPStatusMessage } from './lib/constants'
 import HTTPError from './lib/errors'
 
 export {
@@ -111,18 +107,13 @@ export interface HTTPAgent {
 
   getName(opts: { host: string; port: number }): string
 
-  addRequest(
-    req: HTTPClientRequest,
-    opts: TCPSocketOptions & TCPSocketConnectOptions
-  ): void
+  addRequest(req: HTTPClientRequest, opts: TCPSocketOptions & TCPSocketConnectOptions): void
 
   destroy(): void
 }
 
 export class HTTPAgent {
-  constructor(
-    opts?: HTTPAgentOptions & TCPSocketOptions & TCPSocketConnectOptions
-  )
+  constructor(opts?: HTTPAgentOptions & TCPSocketOptions & TCPSocketConnectOptions)
 
   static global: HTTPAgent
 }
@@ -137,8 +128,7 @@ export interface HTTPServerEvents extends TCPServerEvents {
   timeout: [socket: TCPSocket]
 }
 
-export interface HTTPServer<M extends HTTPServerEvents = HTTPServerEvents>
-  extends TCPServer<M> {
+export interface HTTPServer<M extends HTTPServerEvents = HTTPServerEvents> extends TCPServer<M> {
   readonly timeout: number | undefined
 
   setTimeout(ms: number, ontimeout?: () => void): this
@@ -150,9 +140,7 @@ export class HTTPServer {
     onrequest?: (req: HTTPIncomingMessage, res: HTTPServerResponse) => void
   )
 
-  constructor(
-    onrequest: (req: HTTPIncomingMessage, res: HTTPServerResponse) => void
-  )
+  constructor(onrequest: (req: HTTPIncomingMessage, res: HTTPServerResponse) => void)
 }
 
 export { HTTPServer as Server }
@@ -168,10 +156,7 @@ export interface HTTPServerResponse extends HTTPOutgoingMessage {
     headers?: Record<string, string | number>
   ): void
 
-  writeHead(
-    statusCode: HTTPStatusCode,
-    headers?: Record<string, string | number>
-  ): void
+  writeHead(statusCode: HTTPStatusCode, headers?: Record<string, string | number>): void
 }
 
 export class HTTPServerResponse {
@@ -191,16 +176,10 @@ export interface HTTPServerConnection {
 
   readonly req: HTTPIncomingMessage | null
   readonly res: HTTPServerResponse | null
-
-  readonly idle: boolean
 }
 
 export class HTTPServerConnection {
-  constructor(
-    server: HTTPServer,
-    socket: TCPSocket,
-    opts?: HTTPServerConnectionOptions
-  )
+  constructor(server: HTTPServer, socket: TCPSocket, opts?: HTTPServerConnectionOptions)
 
   static for(socket: TCPSocket): HTTPServerConnection
 }
@@ -219,9 +198,8 @@ export interface HTTPClientRequestOptions extends TCPSocketConnectOptions {
   path?: string
 }
 
-export interface HTTPClientRequest<
-  M extends HTTPClientRequestEvents = HTTPClientRequestEvents
-> extends HTTPOutgoingMessage<M> {
+export interface HTTPClientRequest<M extends HTTPClientRequestEvents = HTTPClientRequestEvents>
+  extends HTTPOutgoingMessage<M> {
   readonly method: HTTPMethod
   readonly path: string
   readonly headers: Record<string, string | number>
@@ -253,10 +231,7 @@ export class HTTPClientConnection {
 
   static for(socket: TCPSocket): HTTPClientConnection | null
 
-  static from(
-    socket: TCPSocket,
-    opts?: HTTPClientConnectionOptions
-  ): HTTPClientConnection
+  static from(socket: TCPSocket, opts?: HTTPClientConnectionOptions): HTTPClientConnection
 }
 
 export { HTTPClientConnection as ClientConnection }

package/index.js

@@ -40,10 +40,12 @@ exports.request = function request(url, opts, onresponse) {
 
     // For Node.js compatibility
     opts.host = opts.hostname || opts.host
-    opts.port =
-      typeof opts.port === 'string' ? parseInt(opts.port, 10) : opts.port
+    opts.port = typeof opts.port === 'string' ? parseInt(opts.port, 10) : opts.port
   }
 
+  // TODO: Renable the default global agent when hangs have been sorted
+  opts.agent = opts.agent || new exports.Agent()
+
   return new exports.ClientRequest(opts, onresponse)
 }
 

package/lib/agent.js

@@ -12,12 +12,7 @@ module.exports = class HTTPAgent extends EventEmitter {
     this._sockets = new Map()
     this._freeSockets = new Map()
 
-    this._keepAlive =
-      typeof keepAlive === 'number'
-        ? keepAlive
-        : keepAlive
-          ? keepAliveMsecs
-          : -1
+    this._keepAlive = typeof keepAlive === 'number' ? keepAlive : keepAlive ? keepAliveMsecs : -1
 
     this._opts = { ...opts }
   }
@@ -108,9 +103,7 @@ module.exports = class HTTPAgent extends EventEmitter {
   }
 
   _onremove(socket, name, all = true) {
-    for (const set of all
-      ? [this._sockets, this._freeSockets]
-      : [this._sockets]) {
+    for (const set of all ? [this._sockets, this._freeSockets] : [this._sockets]) {
       const sockets = set.get(name)
       if (sockets === undefined) continue
 

package/lib/client-connection.js

@@ -1,8 +1,12 @@
+const HTTPParser = require('bare-http-parser')
 const HTTPIncomingMessage = require('./incoming-message')
-const constants = require('./constants')
 const errors = require('./errors')
 
-const empty = Buffer.alloc(0)
+const {
+  constants: { RESPONSE, DATA, END }
+} = HTTPParser
+
+const EMPTY = Buffer.alloc(0)
 
 module.exports = class HTTPClientConnection {
   static _connections = new WeakMap()
@@ -25,10 +29,7 @@ module.exports = class HTTPClientConnection {
 
     this._IncomingMessage = IncomingMessage
 
-    this._state = constants.state.BEFORE_HEAD
-    this._length = -1
-    this._read = 0
-    this._buffer = null
+    this._parser = new HTTPParser()
     this._idle = true
 
     this._onerror = this._onerror.bind(this)
@@ -68,154 +69,50 @@ module.exports = class HTTPClientConnection {
   _ondata(data) {
     this._idle = false
 
-    if (this._state === constants.state.IN_BODY) return this._onbody(data)
-
-    if (this._buffer !== null) {
-      this._buffer = Buffer.concat([this._buffer, data])
-    } else {
-      this._buffer = data
-    }
-
-    let hits = 0
-
-    for (let i = 0; i < this._buffer.byteLength; i++) {
-      const b = this._buffer[i]
-
-      if (hits === 0 && b === 13) {
-        hits++
-      } else if (hits === 1 && b === 10) {
-        hits++
-
-        if (this._state === constants.state.BEFORE_CHUNK) {
-          const head = this._buffer.subarray(0, i - 1)
-          this._buffer =
-            i + 1 === this._buffer.byteLength
-              ? null
-              : this._buffer.subarray(i + 1)
-          i = 0
-          hits = 0
-          this._onchunklength(head)
-
-          if (this._buffer === null) break
-        } else if (this._state === constants.state.IN_CHUNK) {
-          const chunk = this._buffer.subarray(0, i - 1)
-
-          if (chunk.byteLength !== this._length) {
-            hits = 0
-            continue
-          }
-
-          this._buffer =
-            i + 1 === this._buffer.byteLength
-              ? null
-              : this._buffer.subarray(i + 1)
-          i = 0
-          hits = 0
-          this._onchunk(chunk)
-
-          if (this._buffer === null) break
-        }
-      } else if (hits === 2 && b === 13) {
-        hits++
-      } else if (hits === 3 && b === 10) {
-        if (this._state === constants.state.BEFORE_HEAD) {
-          const head = this._buffer.subarray(0, i - 3)
-          this._buffer =
-            i + 1 === this._buffer.byteLength
-              ? null
-              : this._buffer.subarray(i + 1)
-          i = 0
-          hits = 0
-          this._onhead(head)
-
-          if (this._buffer === null) break
-        }
-      } else {
-        hits = 0
-      }
-    }
-  }
+    try {
+      for (const op of this._parser.push(data)) {
+        switch (op.type) {
+          case RESPONSE:
+            this.req.on('close', () => {
+              this.req = null
+            })
 
-  _onhead(data) {
-    this._state = constants.state.IN_HEAD
+            this.res = new this._IncomingMessage(this.socket, op.headers, {
+              statusCode: op.code,
+              statusMessage: op.reason
+            })
 
-    const r = data.toString().split('\r\n')
-    if (r.length === 0) return this.socket.destroy()
+            this.res.on('close', () => {
+              this.res = null
 
-    const [, statusCode, ...statusMessage] = r[0].split(' ')
-    if (!statusCode || !statusMessage.length) return this.socket.destroy()
+              this._idle = true
 
-    const headers = {}
+              this.socket.emit('free')
+            })
 
-    for (let i = 1; i < r.length; i++) {
-      const [name, value] = splitHeader(r[i])
-      if (name === null) return this.socket.destroy()
-      headers[name.toLowerCase()] = value
-    }
+            if (op.headers.connection && op.headers.connection.toLowerCase() === 'upgrade') {
+              return this._onupgrade(this._parser.end())
+            }
 
-    this.req.on('close', () => {
-      this.req = null
-    })
+            this.req.emit('response', this.res)
+            break
 
-    this.res = new this._IncomingMessage(this.socket, headers, {
-      statusCode: parseInt(statusCode, 10),
-      statusMessage: statusMessage.join(' ')
-    })
+          case DATA:
+            this.res.push(op.data)
+            break
 
-    this.res.on('close', () => {
-      this.res = null
-      this._onreset()
-    })
-
-    if (headers.connection && headers.connection.toLowerCase() === 'upgrade') {
-      const head = this._buffer
-      this._buffer = null
-      return this._onupgrade(head)
-    }
-
-    this.req.emit('response', this.res)
-
-    if (headers['transfer-encoding'] === 'chunked') {
-      this._state = constants.state.BEFORE_CHUNK
-    } else {
-      this._length = parseInt(headers['content-length'], 10) || 0
-
-      if (this._length === 0) return this._onfinished()
-
-      this._state = constants.state.IN_BODY
-
-      if (this._buffer) {
-        const body = this._buffer
-        this._buffer = null
-        this._onbody(body)
+          case END:
+            if (this.res) this.res.push(null)
+            if (this.req) this.req._continueFinal()
+            break
+        }
       }
+    } catch (err) {
+      this.socket.destroy(err)
     }
   }
 
-  _onchunklength(data) {
-    this._length = parseInt(data.toString(), 16)
-
-    if (this._length === 0) this._onfinished()
-    else this._state = constants.state.IN_CHUNK
-  }
-
-  _onchunk(data) {
-    this._read += data.byteLength
-
-    this.res.push(data)
-
-    this._state = constants.state.BEFORE_CHUNK
-  }
-
-  _onbody(data) {
-    this._read += data.byteLength
-
-    this.res.push(data)
-
-    if (this._read === this._length) this._onfinished()
-  }
-
-  _onupgrade(head) {
+  _onupgrade(data) {
     this._ondetach()
 
     const req = this.req
@@ -223,7 +120,7 @@ module.exports = class HTTPClientConnection {
     req.upgrade = true
     req.destroy()
 
-    if (req.emit('upgrade', this.res, this.socket, head || empty)) return
+    if (req.emit('upgrade', this.res, this.socket, data || EMPTY)) return
 
     this.socket.destroy()
   }
@@ -232,21 +129,6 @@ module.exports = class HTTPClientConnection {
     if (this.req) this.req.emit('timeout')
   }
 
-  _onfinished() {
-    if (this.res) this.res.push(null)
-    if (this.req) this.req._continueFinal()
-  }
-
-  _onreset() {
-    this._state = constants.state.BEFORE_HEAD
-    this._length = -1
-    this._read = 0
-    this._buffer = null
-    this._idle = true
-
-    this.socket.emit('free')
-  }
-
   _ondrain() {
     if (this.req) this.req._continueWrite()
   }
@@ -263,9 +145,3 @@ module.exports = class HTTPClientConnection {
     HTTPClientConnection._connections.delete(this.socket)
   }
 }
-
-function splitHeader(s) {
-  const i = s.indexOf(': ')
-  if (i === -1) return [null, null]
-  return [s.slice(0, i), s.slice(i + 2)]
-}

package/lib/client-request.js

@@ -13,8 +13,7 @@ module.exports = class HTTPClientRequest extends HTTPOutgoingMessage {
 
     opts = opts ? { ...opts } : {}
 
-    const agent =
-      opts.agent === false ? new HTTPAgent() : opts.agent || HTTPAgent.global
+    const agent = opts.agent === false ? new HTTPAgent() : opts.agent || HTTPAgent.global
     const method = opts.method || 'GET'
     const path = opts.path || '/'
     const host = (opts.host = opts.host || 'localhost')
@@ -50,8 +49,7 @@ module.exports = class HTTPClientRequest extends HTTPOutgoingMessage {
       const v = this.headers[name]
 
       if (n === 'content-length') this._chunked = false
-      if (n === 'connection' && v && v.toLowerCase() === 'upgrade')
-        upgrade = true
+      if (n === 'connection' && v && v.toLowerCase() === 'upgrade') upgrade = true
 
       h += `${httpCase(n)}: ${v}\r\n`
     }

package/lib/constants.d.ts

@@ -1,11 +1,4 @@
 declare const constants: {
-  state: {
-    BEFORE_HEAD: number
-    IN_HEAD: number
-    IN_BODY: number
-    BEFORE_CHUNK: number
-    IN_CHUNK: number
-  }
   method: {
     GET: 'GET'
     HEAD: 'HEAD'

package/lib/constants.js

@@ -1,11 +1,4 @@
 module.exports = {
-  state: {
-    BEFORE_HEAD: 1,
-    IN_HEAD: 2,
-    IN_BODY: 3,
-    BEFORE_CHUNK: 4,
-    IN_CHUNK: 5
-  },
   method: {
     GET: 'GET',
     HEAD: 'HEAD',

package/lib/errors.d.ts

@@ -1,5 +1,5 @@
 declare class HTTPError extends Error {
-  constructor(msg: string, code: string, fn: Error)
+  private constructor()
 
   static NOT_IMPLEMENTED(msg?: string): HTTPError
   static CONNECTION_LOST(msg?: string): HTTPError

package/lib/errors.js

@@ -1,5 +1,5 @@
 module.exports = class HTTPError extends Error {
-  constructor(msg, code, fn = HTTPError) {
+  constructor(msg, fn = HTTPError, code = fn.name) {
     super(`${code}: ${msg}`)
     this.code = code
 
@@ -13,10 +13,10 @@ module.exports = class HTTPError extends Error {
   }
 
   static NOT_IMPLEMENTED(msg = 'Method not implemented') {
-    return new HTTPError(msg, 'NOT_IMPLEMENTED', HTTPError.NOT_IMPLEMENTED)
+    return new HTTPError(msg, HTTPError.NOT_IMPLEMENTED)
   }
 
   static CONNECTION_LOST(msg = 'Socket hung up') {
-    return new HTTPError(msg, 'CONNECTION_LOST', HTTPError.CONNECTION_LOST)
+    return new HTTPError(msg, HTTPError.CONNECTION_LOST)
   }
 }

package/lib/server-connection.js

@@ -1,10 +1,14 @@
 const tcp = require('bare-tcp')
 const { isEnded, isFinished, getStreamError } = require('bare-stream')
+const HTTPParser = require('bare-http-parser')
 const HTTPIncomingMessage = require('./incoming-message')
 const HTTPServerResponse = require('./server-response')
-const constants = require('./constants')
 
-const empty = Buffer.alloc(0)
+const {
+  constants: { REQUEST, DATA, END }
+} = HTTPParser
+
+const EMPTY = Buffer.alloc(0)
 
 module.exports = class HTTPServerConnection {
   static _connections = new WeakMap()
@@ -14,10 +18,7 @@ module.exports = class HTTPServerConnection {
   }
 
   constructor(server, socket, opts = {}) {
-    const {
-      IncomingMessage = HTTPIncomingMessage,
-      ServerResponse = HTTPServerResponse
-    } = opts
+    const { IncomingMessage = HTTPIncomingMessage, ServerResponse = HTTPServerResponse } = opts
 
     this.server = server
     this.socket = socket
@@ -28,10 +29,7 @@ module.exports = class HTTPServerConnection {
     this._IncomingMessage = IncomingMessage
     this._ServerResponse = ServerResponse
 
-    this._state = constants.state.BEFORE_HEAD
-    this._length = -1
-    this._read = 0
-    this._buffer = null
+    this._parser = new HTTPParser()
     this._idle = true
 
     this._onclose = this._onclose.bind(this)
@@ -65,161 +63,61 @@ module.exports = class HTTPServerConnection {
   _ondata(data) {
     this._idle = false
 
-    if (this._state === constants.state.IN_BODY) return this._onbody(data)
-
-    if (this._buffer !== null) {
-      this._buffer = Buffer.concat([this._buffer, data])
-    } else {
-      this._buffer = data
-    }
-
-    let hits = 0
-
-    for (let i = 0; i < this._buffer.byteLength; i++) {
-      const b = this._buffer[i]
-
-      if (hits === 0 && b === 13) {
-        hits++
-      } else if (hits === 1 && b === 10) {
-        hits++
-
-        if (this._state === constants.state.BEFORE_CHUNK) {
-          const head = this._buffer.subarray(0, i - 1)
-          this._buffer =
-            i + 1 === this._buffer.byteLength
-              ? null
-              : this._buffer.subarray(i + 1)
-          i = 0
-          hits = 0
-          this._onchunklength(head)
-
-          if (this._buffer === null) break
-        } else if (this._state === constants.state.IN_CHUNK) {
-          const chunk = this._buffer.subarray(0, i - 1)
-
-          if (chunk.byteLength !== this._length) {
-            hits = 0
-            continue
-          }
-
-          this._buffer =
-            i + 1 === this._buffer.byteLength
-              ? null
-              : this._buffer.subarray(i + 1)
-          i = 0
-          hits = 0
-          this._onchunk(chunk)
-
-          if (this._buffer === null) break
-        }
-      } else if (hits === 2 && b === 13) {
-        hits++
-      } else if (hits === 3 && b === 10) {
-        if (this._state === constants.state.BEFORE_HEAD) {
-          const head = this._buffer.subarray(0, i - 3)
-          this._buffer =
-            i + 1 === this._buffer.byteLength
-              ? null
-              : this._buffer.subarray(i + 1)
-          i = 0
-          hits = 0
-          this._onhead(head)
-
-          if (this._buffer === null) break
+    try {
+      for (const op of this._parser.push(data)) {
+        switch (op.type) {
+          case REQUEST:
+            this.req = new this._IncomingMessage(this.socket, op.headers, {
+              method: op.method,
+              url: op.url
+            })
+
+            this.req.on('close', () => {
+              this.req = null
+
+              this._idle = true
+
+              if (this.server._state & tcp.constants.state.CLOSING) {
+                this.socket.destroy()
+              }
+            })
+
+            // Eagerly open the request stream
+            this.req.resume()
+            this.req.pause()
+
+            if (op.headers.connection && op.headers.connection.toLowerCase() === 'upgrade') {
+              return this._onupgrade(this._parser.end())
+            }
+
+            this.res = new this._ServerResponse(
+              this.socket,
+              this.req,
+              op.headers.connection === 'close'
+            )
+
+            this.res.on('close', () => {
+              this.res = null
+            })
+
+            this.server.emit('request', this.req, this.res)
+            break
+
+          case DATA:
+            this.req.push(op.data)
+            break
+
+          case END:
+            if (this.req) this.req.push(null)
+            break
         }
-      } else {
-        hits = 0
-      }
-    }
-  }
-
-  _onhead(data) {
-    this._state = constants.state.IN_HEAD
-
-    const r = data.toString().split('\r\n')
-    if (r.length === 0) return this.socket.destroy()
-
-    const [method, url] = r[0].split(' ')
-    if (!method || !url) return this.socket.destroy()
-
-    const headers = {}
-
-    for (let i = 1; i < r.length; i++) {
-      const [name, value] = splitHeader(r[i])
-      if (name === null) return this.socket.destroy()
-      headers[name.toLowerCase()] = value
-    }
-
-    this.req = new this._IncomingMessage(this.socket, headers, { method, url })
-
-    this.req.on('close', () => {
-      this.req = null
-      this._onreset()
-    })
-
-    // Eagerly open the request stream
-    this.req.resume()
-    this.req.pause()
-
-    if (headers.connection && headers.connection.toLowerCase() === 'upgrade') {
-      const head = this._buffer
-      this._buffer = null
-      return this._onupgrade(head)
-    }
-
-    this.res = new this._ServerResponse(
-      this.socket,
-      this.req,
-      headers.connection === 'close'
-    )
-
-    this.res.on('close', () => {
-      this.res = null
-    })
-
-    this.server.emit('request', this.req, this.res)
-
-    if (headers['transfer-encoding'] === 'chunked') {
-      this._state = constants.state.BEFORE_CHUNK
-    } else {
-      this._length = parseInt(headers['content-length'], 10) || 0
-
-      if (this._length === 0) return this._onfinished()
-
-      this._state = constants.state.IN_BODY
-
-      if (this._buffer) {
-        const body = this._buffer
-        this._buffer = null
-        this._onbody(body)
       }
+    } catch (err) {
+      this.socket.destroy(err)
     }
   }
 
-  _onchunklength(data) {
-    this._length = parseInt(data.toString(), 16)
-
-    if (this._length === 0) this._onfinished()
-    else this._state = constants.state.IN_CHUNK
-  }
-
-  _onchunk(data) {
-    this._read += data.byteLength
-
-    this.req.push(data)
-
-    this._state = constants.state.BEFORE_CHUNK
-  }
-
-  _onbody(data) {
-    this._read += data.byteLength
-
-    this.req.push(data)
-
-    if (this._read === this._length) this._onfinished()
-  }
-
-  _onupgrade(head) {
+  _onupgrade(data) {
     this._ondetach()
 
     const req = this.req
@@ -227,7 +125,7 @@ module.exports = class HTTPServerConnection {
     req.upgrade = true
     req.destroy()
 
-    this.server.emit('upgrade', req, this.socket, head || empty)
+    this.server.emit('upgrade', req, this.socket, data || EMPTY)
   }
 
   _ontimeout() {
@@ -238,22 +136,6 @@ module.exports = class HTTPServerConnection {
     if (!reqTimeout && !resTimeout && !serverTimeout) this.socket.destroy()
   }
 
-  _onfinished() {
-    if (this.req) this.req.push(null)
-  }
-
-  _onreset() {
-    this._state = constants.state.BEFORE_HEAD
-    this._length = -1
-    this._read = 0
-    this._buffer = null
-    this._idle = true
-
-    if (this.server._state & tcp.constants.state.CLOSING) {
-      this.socket.destroy()
-    }
-  }
-
   _ondrain() {
     if (this.res) this.res._continueWrite()
   }
@@ -271,9 +153,3 @@ module.exports = class HTTPServerConnection {
 }
 
 function noop() {}
-
-function splitHeader(s) {
-  const i = s.indexOf(': ')
-  if (i === -1) return [null, null]
-  return [s.slice(0, i), s.slice(i + 2)]
-}

package/lib/server-response.js

@@ -42,9 +42,7 @@ module.exports = class HTTPServerResponse extends HTTPOutgoingMessage {
       'HTTP/1.1 ' +
       this.statusCode +
       ' ' +
-      (this.statusMessage === null
-        ? constants.status[this.statusCode]
-        : this.statusMessage) +
+      (this.statusMessage === null ? constants.status[this.statusCode] : this.statusMessage) +
       '\r\n'
 
     for (const name of Object.keys(this.headers)) {
@@ -52,8 +50,7 @@ module.exports = class HTTPServerResponse extends HTTPOutgoingMessage {
       const v = this.headers[name]
 
       if (n === 'content-length') this._chunked = false
-      if (n === 'connection' && v && v.toLowerCase() === 'close')
-        this._close = true
+      if (n === 'connection' && v && v.toLowerCase() === 'close') this._close = true
 
       h += httpCase(n) + ': ' + v + '\r\n'
     }

package/lib/server.js

@@ -12,10 +12,7 @@ module.exports = class HTTPServer extends TCPServer {
 
     this._timeout = 0
 
-    this.on(
-      'connection',
-      (socket) => new HTTPServerConnection(this, socket, opts)
-    )
+    this.on('connection', (socket) => new HTTPServerConnection(this, socket, opts))
 
     if (onrequest) this.on('request', onrequest)
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bare-http1",
-  "version": "4.1.1",
+  "version": "4.1.3",
   "description": "Native HTTP/1 library for JavaScript",
   "exports": {
     "./package": "./package.json",
@@ -37,6 +37,7 @@
   "homepage": "https://github.com/holepunchto/bare-http1#readme",
   "dependencies": {
     "bare-events": "^2.6.0",
+    "bare-http-parser": "^1.0.0",
     "bare-stream": "^2.3.0",
     "bare-tcp": "^2.0.3"
   },
@@ -45,7 +46,7 @@
     "bare-url": "^2.1.3",
     "brittle": "^3.3.0",
     "prettier": "^3.4.1",
-    "prettier-config-standard": "^7.0.0"
+    "prettier-config-holepunch": "^2.0.0"
   },
   "peerDependencies": {
     "bare-buffer": "*",