bare-http1 4.0.4 → 4.1.1

package/index.d.ts

@@ -24,6 +24,7 @@ export {
   HTTPError as errors
 }
 
+export const METHODS: HTTPMethod[]
 export const STATUS_CODES: typeof constants.status
 
 export interface HTTPIncomingMessageEvents extends ReadableEvents {

package/index.js

@@ -14,6 +14,7 @@ exports.ClientConnection = require('./lib/client-connection')
 exports.constants = require('./lib/constants')
 exports.errors = require('./lib/errors')
 
+exports.METHODS = Object.values(exports.constants.method) // For Node.js compatibility
 exports.STATUS_CODES = exports.constants.status // For Node.js compatibility
 
 exports.createServer = function createServer(opts, onrequest) {

package/lib/client-request.js

@@ -1,6 +1,9 @@
 const HTTPAgent = require('./agent')
 const HTTPOutgoingMessage = require('./outgoing-message')
 
+const CHUNK_DELIMITER = Buffer.from('\r\n')
+const CHUNK_TERMINATOR = Buffer.from('0\r\n\r\n')
+
 module.exports = class HTTPClientRequest extends HTTPOutgoingMessage {
   constructor(opts = {}, onresponse = null) {
     if (typeof opts === 'function') {
@@ -32,6 +35,11 @@ module.exports = class HTTPClientRequest extends HTTPOutgoingMessage {
     if (onresponse) this.once('response', onresponse)
   }
 
+  // For Node.js compatibility
+  abort() {
+    return this.destroy()
+  }
+
   _header() {
     let h = `${this.method} ${this.path} HTTP/1.1\r\n`
 
@@ -61,21 +69,22 @@ module.exports = class HTTPClientRequest extends HTTPOutgoingMessage {
     if (this.headersSent === false) this.flushHeaders()
 
     if (this._chunked) {
-      data = Buffer.concat([
-        Buffer.from('' + data.byteLength.toString(16) + '\r\n'),
-        data,
-        Buffer.from('\r\n')
-      ])
+      this.socket.write(Buffer.from(data.byteLength.toString(16)))
+      this.socket.write(CHUNK_DELIMITER)
     }
 
-    if (this.socket.write(data)) cb(null)
+    let flushed = this.socket.write(data)
+
+    if (this._chunked) flushed = this.socket.write(CHUNK_DELIMITER)
+
+    if (flushed) cb(null)
     else this._pendingWrite = cb
   }
 
   _final(cb) {
     if (this.headersSent === false) this.flushHeaders()
 
-    if (this._chunked) this.socket.write(Buffer.from('0\r\n\r\n'))
+    if (this._chunked) this.socket.write(CHUNK_TERMINATOR)
 
     this._pendingFinal = cb
   }

package/lib/server-response.js

@@ -1,6 +1,9 @@
 const HTTPOutgoingMessage = require('./outgoing-message')
 const constants = require('./constants')
 
+const CHUNK_DELIMITER = Buffer.from('\r\n')
+const CHUNK_TERMINATOR = Buffer.from('0\r\n\r\n')
+
 module.exports = class HTTPServerResponse extends HTTPOutgoingMessage {
   constructor(socket, req, close) {
     super(socket)
@@ -77,14 +80,15 @@ module.exports = class HTTPServerResponse extends HTTPOutgoingMessage {
     if (this._onlyHeaders === true) return cb(null)
 
     if (this._chunked) {
-      data = Buffer.concat([
-        Buffer.from('' + data.byteLength.toString(16) + '\r\n'),
-        data,
-        Buffer.from('\r\n')
-      ])
+      this.socket.write(Buffer.from(data.byteLength.toString(16)))
+      this.socket.write(CHUNK_DELIMITER)
     }
 
-    if (this.socket.write(data)) cb(null)
+    let flushed = this.socket.write(data)
+
+    if (this._chunked) flushed = this.socket.write(CHUNK_DELIMITER)
+
+    if (flushed) cb(null)
     else this._pendingWrite = cb
   }
 
@@ -94,8 +98,10 @@ module.exports = class HTTPServerResponse extends HTTPOutgoingMessage {
       this.flushHeaders()
     }
 
-    if (this._chunked && this._onlyHeaders === false)
-      this.socket.write(Buffer.from('0\r\n\r\n'))
+    if (this._chunked && this._onlyHeaders === false) {
+      this.socket.write(CHUNK_TERMINATOR)
+    }
+
     if (this._close) this.socket.end()
 
     cb(null)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bare-http1",
-  "version": "4.0.4",
+  "version": "4.1.1",
   "description": "Native HTTP/1 library for JavaScript",
   "exports": {
     "./package": "./package.json",