bare-http1 3.5.0 → 3.5.2

package/lib/client-connection.js

@@ -2,6 +2,8 @@ const HTTPIncomingMessage = require('./incoming-message')
 const constants = require('./constants')
 const errors = require('./errors')
 
+const empty = Buffer.alloc(0)
+
 module.exports = class HTTPClientConnection {
   constructor (socket, opts = {}) {
     const {
@@ -189,7 +191,7 @@ module.exports = class HTTPClientConnection {
     req.upgrade = true
     req.destroy()
 
-    if (req.emit('upgrade', this.res, this.socket, head)) return
+    if (req.emit('upgrade', this.res, this.socket, head || empty)) return
 
     this.socket.destroy()
   }

package/lib/client-request.js

@@ -56,7 +56,7 @@ module.exports = class HTTPClientRequest extends HTTPOutgoingMessage {
     return h
   }
 
-  _write (data, cb) {
+  _write (data, encoding, cb) {
     if (this.headersSent === false) this.flushHeaders()
 
     if (this._chunked) {

package/lib/outgoing-message.js

@@ -3,7 +3,7 @@ const errors = require('./errors')
 
 module.exports = class HTTPOutgoingMessage extends Writable {
   constructor (socket) {
-    super({ mapWritable })
+    super()
 
     this.socket = socket
     this.headers = {}
@@ -42,7 +42,3 @@ module.exports = class HTTPOutgoingMessage extends Writable {
     if (this.upgrade === false) this.socket.destroy()
   }
 }
-
-function mapWritable (data) {
-  return typeof data === 'string' ? Buffer.from(data) : data
-}

package/lib/server-connection.js

@@ -2,6 +2,8 @@ const HTTPIncomingMessage = require('./incoming-message')
 const HTTPServerResponse = require('./server-response')
 const constants = require('./constants')
 
+const empty = Buffer.alloc(0)
+
 module.exports = class HTTPServerConnection {
   constructor (server, socket, opts = {}) {
     const {
@@ -180,7 +182,7 @@ module.exports = class HTTPServerConnection {
     req.upgrade = true
     req.destroy()
 
-    this.server.emit('upgrade', req, this.socket, head)
+    this.server.emit('upgrade', req, this.socket, head || empty)
   }
 
   _onfinished () {

package/lib/server-response.js

@@ -54,7 +54,7 @@ module.exports = class HTTPServerResponse extends HTTPOutgoingMessage {
     return h
   }
 
-  _write (data, cb) {
+  _write (data, encoding, cb) {
     if (this.headersSent === false) {
       if (this._finishing) {
         this.setHeader('Content-Length', (data.byteLength + this._writableState.buffered).toString())

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bare-http1",
-  "version": "3.5.0",
+  "version": "3.5.2",
   "description": "Native HTTP/1 library for JavaScript",
   "exports": {
     ".": "./index.js",
@@ -26,7 +26,7 @@
   "homepage": "https://github.com/holepunchto/bare-http1#readme",
   "dependencies": {
     "bare-events": "^2.0.0",
-    "bare-stream": "^1.0.0",
+    "bare-stream": "^2.0.0",
     "bare-tcp": "^1.1.2"
   },
   "devDependencies": {