bare-buffer 3.1.3 → 3.1.4

package/binding.c

@@ -7,8 +7,6 @@
 #include <string.h>
 #include <utf.h>
 
-static js_type_tag_t bare_buffer__tag = {0xfea3e944b70b0812, 0xe53bb5c343c040b6};
-
 static inline int
 bare_buffer__memcmp(void *a, size_t a_len, void *b, size_t b_len) {
   int r = memcmp(a, b, a_len < b_len ? a_len : b_len);
@@ -663,47 +661,6 @@ bare_buffer_compare(js_env_t *env, js_callback_info_t *info) {
   return result;
 }
 
-static js_value_t *
-bare_buffer_tag(js_env_t *env, js_callback_info_t *info) {
-  int err;
-
-  size_t argc = 1;
-  js_value_t *argv[1];
-
-  err = js_get_callback_info(env, info, &argc, argv, NULL, NULL);
-  assert(err == 0);
-
-  assert(argc == 1);
-
-  err = js_add_type_tag(env, argv[0], &bare_buffer__tag);
-  assert(err == 0);
-
-  return NULL;
-}
-
-static js_value_t *
-bare_buffer_is_tagged(js_env_t *env, js_callback_info_t *info) {
-  int err;
-
-  size_t argc = 1;
-  js_value_t *argv[1];
-
-  err = js_get_callback_info(env, info, &argc, argv, NULL, NULL);
-  assert(err == 0);
-
-  assert(argc == 1);
-
-  bool is_tagged;
-  err = js_check_type_tag(env, argv[0], &bare_buffer__tag, &is_tagged);
-  assert(err == 0);
-
-  js_value_t *result;
-  err = js_get_boolean(env, is_tagged, &result);
-  assert(err == 0);
-
-  return result;
-}
-
 static js_value_t *
 bare_buffer_exports(js_env_t *env, js_value_t *exports) {
   int err;
@@ -850,10 +807,6 @@ bare_buffer_exports(js_env_t *env, js_value_t *exports) {
     }),
     bare_buffer_typed_compare
   );
-
-  V("tag", bare_buffer_tag, NULL, NULL);
-
-  V("isTagged", bare_buffer_is_tagged, NULL, NULL);
 #undef V
 
   return exports;

package/index.js

@@ -7,11 +7,13 @@ const utf16le = require('./lib/utf16le')
 const latin1 = require('./lib/latin1')
 const binding = require('./binding')
 
+const kind = Symbol.for('bare.buffer.kind')
+
 let poolSize = 0
 
 module.exports = exports = class Buffer extends Uint8Array {
-  static {
-    binding.tag(this)
+  static get [kind]() {
+    return 0 // Compatibility version
   }
 
   static get poolSize() {
@@ -60,8 +62,8 @@ module.exports = exports = class Buffer extends Uint8Array {
     super(arrayBuffer, offset, length)
   }
 
-  [Symbol.species]() {
-    return Buffer
+  get [kind]() {
+    return Buffer[kind]
   }
 
   copy(target, targetStart = 0, sourceStart = 0, sourceEnd = this.byteLength) {
@@ -562,17 +564,10 @@ function viewOf(buffer) {
 
 exports.isBuffer = function isBuffer(value) {
   if (value instanceof Buffer) return true
-  if (typeof value !== 'object' || value === null) return false
-
-  let constructor = value.constructor
-
-  while (typeof constructor === 'function') {
-    if (binding.isTagged(constructor)) return true
 
-    constructor = Reflect.getPrototypeOf(constructor)
-  }
-
-  return false
+  return (
+    typeof value === 'object' && value !== null && value[kind] === Buffer[kind]
+  )
 }
 
 exports.isEncoding = function isEncoding(encoding) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bare-buffer",
-  "version": "3.1.3",
+  "version": "3.1.4",
   "description": "Native buffers for JavaScript",
   "exports": {
     "./package": "./package.json",