bard-legends-framework 0.10.8 → 0.11.0

package/dist/game-entities/view/view.test.js

@@ -1,50 +1,24 @@
 "use strict";
-var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    var desc = Object.getOwnPropertyDescriptor(m, k);
-    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
-      desc = { enumerable: true, get: function() { return m[k]; } };
-    }
-    Object.defineProperty(o, k2, desc);
-}) : (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    o[k2] = m[k];
-}));
-var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
-    Object.defineProperty(o, "default", { enumerable: true, value: v });
-}) : function(o, v) {
-    o["default"] = v;
-});
 var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
     var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
     if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
     else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
     return c > 3 && r && Object.defineProperty(target, key, r), r;
 };
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
-    __setModuleDefault(result, mod);
-    return result;
-};
 var __metadata = (this && this.__metadata) || function (k, v) {
     if (typeof Reflect === "object" && typeof Reflect.metadata === "function") return Reflect.metadata(k, v);
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-const ActionsLib = __importStar(require("actions-lib"));
 const actions_lib_1 = require("actions-lib");
-const helpers_lib_1 = require("helpers-lib");
 const vitest_1 = require("vitest");
-const decorate_actions_lib_1 = require("../base/helpers/decorate-actions-lib");
 const entity_1 = require("../entity/entity");
 const scene_1 = require("../scene/scene");
+const unit_test_helper_1 = require("../unit-test.helper");
 const update_cycle_1 = require("../update-cycle");
 const view_1 = require("./view");
-decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
 (0, vitest_1.describe)('VIEW', () => {
     (0, vitest_1.beforeEach)(() => {
-        update_cycle_1.UpdateCycle.hardResetAction.trigger();
+        unit_test_helper_1.UnitTestHelper.hardReset();
         let SampleScene = class SampleScene extends scene_1.Scene {
             async init() { }
             update() { }
@@ -64,57 +38,13 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
         ], Sample);
         let SampleView = class SampleView extends view_1.View {
             static { SampleView_1 = this; }
-            constructor(entity) {
-                super();
-                SampleView_1.viewInstance = this;
-            }
-        };
-        SampleView = SampleView_1 = __decorate([
-            (0, view_1.ViewDecorator)({ entity: Sample }),
-            __metadata("design:paramtypes", [Sample])
-        ], SampleView);
-        new Sample().attach(scene_1.Scene.getActiveSceneOrFail());
-        (0, vitest_1.expect)(SampleView.viewInstance).toBeDefined();
-    });
-    (0, vitest_1.test)('class names should be unique', () => {
-        let Sample = class Sample extends entity_1.Entity {
-        };
-        Sample = __decorate([
-            (0, entity_1.EntityDecorator)()
-        ], Sample);
-        (0, vitest_1.expect)(() => {
-            {
-                let _SampleView = class _SampleView extends view_1.View {
-                };
-                _SampleView = __decorate([
-                    (0, view_1.ViewDecorator)({ entity: Sample })
-                ], _SampleView);
-            }
-            {
-                let _SampleView = class _SampleView extends view_1.View {
-                };
-                _SampleView = __decorate([
-                    (0, view_1.ViewDecorator)({ entity: Sample })
-                ], _SampleView);
-            }
-        }).toThrow();
-    });
-    (0, vitest_1.test)('entity creation should create related view once', () => {
-        var SampleView_2;
-        let Sample = class Sample extends entity_1.Entity {
-        };
-        Sample = __decorate([
-            (0, entity_1.EntityDecorator)()
-        ], Sample);
-        let SampleView = class SampleView extends view_1.View {
-            static { SampleView_2 = this; }
             static { this.viewCall = 0; }
             constructor(entity) {
                 super();
-                SampleView_2.viewCall++;
+                SampleView_1.viewCall++;
             }
         };
-        SampleView = SampleView_2 = __decorate([
+        SampleView = SampleView_1 = __decorate([
             (0, view_1.ViewDecorator)({ entity: Sample }),
             __metadata("design:paramtypes", [Sample])
         ], SampleView);
@@ -122,7 +52,7 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
         (0, vitest_1.expect)(SampleView.viewCall).toEqual(1);
     });
     (0, vitest_1.test)('entities should not destroy each others views on destroy', async () => {
-        var SampleView_3;
+        var SampleView_2;
         let BaseEntity = class BaseEntity extends entity_1.Entity {
         };
         BaseEntity = __decorate([
@@ -135,17 +65,20 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
             (0, entity_1.EntityDecorator)()
         ], Sample);
         let SampleView = class SampleView extends view_1.View {
-            static { SampleView_3 = this; }
+            static { SampleView_2 = this; }
             static { this.viewInstanceCount = 0; }
             constructor(entity) {
                 super();
-                SampleView_3.viewInstanceCount++;
+                SampleView_2.viewInstanceCount++;
             }
-            afterDestroy() {
-                SampleView_3.viewInstanceCount--;
+            destroy() {
+                if (!this.destroyed) {
+                    SampleView_2.viewInstanceCount--;
+                    super.destroy();
+                }
             }
         };
-        SampleView = SampleView_3 = __decorate([
+        SampleView = SampleView_2 = __decorate([
             (0, view_1.ViewDecorator)({ entity: Sample }),
             __metadata("design:paramtypes", [Sample])
         ], SampleView);
@@ -153,10 +86,8 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
         let entity2 = new Sample().attach(baseEntity);
         (0, vitest_1.expect)(SampleView.viewInstanceCount).toEqual(2);
         entity1.destroy();
-        await update_cycle_1.UpdateCycle.triggerUpdateTick(1); // Update cycle should take place to destroy functions to be called
         (0, vitest_1.expect)(SampleView.viewInstanceCount).toEqual(1);
         entity2.destroy();
-        await update_cycle_1.UpdateCycle.triggerUpdateTick(1); // Update cycle should take place to destroy functions to be called
         (0, vitest_1.expect)(SampleView.viewInstanceCount).toEqual(0);
     });
     (0, vitest_1.test)('entity destruction should destroy related views', async () => {
@@ -167,8 +98,11 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
             (0, entity_1.EntityDecorator)()
         ], Sample);
         let _SampleView = class _SampleView extends view_1.View {
-            afterDestroy() {
-                viewDestroyCount++;
+            destroy() {
+                if (!this.destroyed) {
+                    viewDestroyCount++;
+                    super.destroy();
+                }
             }
         };
         _SampleView = __decorate([
@@ -176,58 +110,6 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
         ], _SampleView);
         let entity = new Sample().attach(scene_1.Scene.getActiveSceneOrFail());
         entity.destroy();
-        await update_cycle_1.UpdateCycle.triggerUpdateTick(1); // Update cycle should take place to destroy functions to be called
-        (0, vitest_1.expect)(viewDestroyCount).toEqual(1);
-    });
-    (0, vitest_1.test)('view destruction should destroy attached items', async () => {
-        let viewDestroyCount = 0;
-        let Sample = class Sample extends entity_1.Entity {
-        };
-        Sample = __decorate([
-            (0, entity_1.EntityDecorator)()
-        ], Sample);
-        let Sample2 = class Sample2 extends entity_1.Entity {
-            afterDestroy() {
-                viewDestroyCount++;
-            }
-        };
-        Sample2 = __decorate([
-            (0, entity_1.EntityDecorator)()
-        ], Sample2);
-        let _SampleView = class _SampleView extends view_1.View {
-            constructor(entity) {
-                super();
-                new Sample2().attach(this);
-            }
-        };
-        _SampleView = __decorate([
-            (0, view_1.ViewDecorator)({ entity: Sample }),
-            __metadata("design:paramtypes", [Sample])
-        ], _SampleView);
-        let entity = new Sample().attach(scene_1.Scene.getActiveSceneOrFail());
-        entity.destroy();
-        await update_cycle_1.UpdateCycle.triggerUpdateTick(1); // Update cycle should take place to destroy functions to be called
-        (0, vitest_1.expect)(viewDestroyCount).toEqual(1);
-    });
-    (0, vitest_1.test)('triggering destroy() multiple times should not take effect multiply', async () => {
-        let viewDestroyCount = 0;
-        let Sample = class Sample extends entity_1.Entity {
-        };
-        Sample = __decorate([
-            (0, entity_1.EntityDecorator)()
-        ], Sample);
-        let _SampleView = class _SampleView extends view_1.View {
-            afterDestroy() {
-                viewDestroyCount++;
-            }
-        };
-        _SampleView = __decorate([
-            (0, view_1.ViewDecorator)({ entity: Sample })
-        ], _SampleView);
-        let entity = new Sample().attach(scene_1.Scene.getActiveSceneOrFail());
-        entity.destroy();
-        entity.destroy();
-        await update_cycle_1.UpdateCycle.triggerUpdateTick(1); // Update cycle should take place to destroy functions to be called
         (0, vitest_1.expect)(viewDestroyCount).toEqual(1);
     });
     (0, vitest_1.test)('update tick should update view', async () => {
@@ -250,42 +132,27 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
             __metadata("design:paramtypes", [Sample])
         ], _SampleView);
         new Sample().attach(scene_1.Scene.getActiveSceneOrFail());
-        await (0, helpers_lib_1.Wait)(); // wait for async view init to be completed, so views can listen update ticks
         (0, vitest_1.expect)(viewUpdateCount).toEqual(0);
         update_cycle_1.UpdateCycle.triggerUpdateTick(1);
         (0, vitest_1.expect)(viewUpdateCount).toEqual(1);
         update_cycle_1.UpdateCycle.triggerUpdateTick(1);
         (0, vitest_1.expect)(viewUpdateCount).toEqual(2);
     });
-    (0, vitest_1.test)('decorator should not effect static variables', () => {
-        let BaseEntity = class BaseEntity extends entity_1.Entity {
-        };
-        BaseEntity = __decorate([
-            (0, entity_1.EntityDecorator)()
-        ], BaseEntity);
-        let SampleView = class SampleView extends view_1.View {
-            static { this.test = 'test'; }
-        };
-        SampleView = __decorate([
-            (0, view_1.ViewDecorator)({ entity: BaseEntity })
-        ], SampleView);
-        (0, vitest_1.expect)(SampleView.test).toEqual('test');
-    });
-    (0, vitest_1.test)('getInstance should wait until creation and return the view object after', () => {
-        var SampleView_4;
+    (0, vitest_1.test)('getInstance should return the view object', () => {
+        var SampleView_3;
         let BaseEntity = class BaseEntity extends entity_1.Entity {
         };
         BaseEntity = __decorate([
             (0, entity_1.EntityDecorator)()
         ], BaseEntity);
         let SampleView = class SampleView extends view_1.View {
-            static { SampleView_4 = this; }
+            static { SampleView_3 = this; }
             constructor(entity) {
                 super();
-                SampleView_4.instance = this;
+                SampleView_3.instance = this;
             }
         };
-        SampleView = SampleView_4 = __decorate([
+        SampleView = SampleView_3 = __decorate([
             (0, view_1.ViewDecorator)({ entity: BaseEntity }),
             __metadata("design:paramtypes", [BaseEntity])
         ], SampleView);
@@ -295,93 +162,31 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
         (0, vitest_1.expect)(SampleView.instance).toEqual(view);
     });
     (0, vitest_1.test)('getInstance should return undefined if entity get destroyed', async () => {
-        var SampleView_5;
+        var SampleView_4;
         let BaseEntity = class BaseEntity extends entity_1.Entity {
         };
         BaseEntity = __decorate([
             (0, entity_1.EntityDecorator)()
         ], BaseEntity);
         let SampleView = class SampleView extends view_1.View {
-            static { SampleView_5 = this; }
+            static { SampleView_4 = this; }
             constructor(entity) {
                 super();
-                SampleView_5.instance = this;
+                SampleView_4.instance = this;
             }
         };
-        SampleView = SampleView_5 = __decorate([
+        SampleView = SampleView_4 = __decorate([
             (0, view_1.ViewDecorator)({ entity: BaseEntity }),
             __metadata("design:paramtypes", [BaseEntity])
         ], SampleView);
         let baseEntity = new BaseEntity().attach(scene_1.Scene.getActiveSceneOrFail());
         baseEntity.destroy();
-        await update_cycle_1.UpdateCycle.triggerUpdateTick(1); // Update cycle should take place to destroy functions to be called
         let view = SampleView.getInstance(baseEntity.id);
         (0, vitest_1.expect)(SampleView.instance).toBeDefined();
         (0, vitest_1.expect)(view).toBe(undefined);
     });
-    (0, vitest_1.test)('getInstanceOrFail should wait until creation and return the view object after', () => {
-        var SampleView_6;
-        let BaseEntity = class BaseEntity extends entity_1.Entity {
-        };
-        BaseEntity = __decorate([
-            (0, entity_1.EntityDecorator)()
-        ], BaseEntity);
-        let SampleView = class SampleView extends view_1.View {
-            static { SampleView_6 = this; }
-            constructor(entity) {
-                super();
-                SampleView_6.instance = this;
-            }
-        };
-        SampleView = SampleView_6 = __decorate([
-            (0, view_1.ViewDecorator)({ entity: BaseEntity }),
-            __metadata("design:paramtypes", [BaseEntity])
-        ], SampleView);
-        let baseEntity = new BaseEntity().attach(scene_1.Scene.getActiveSceneOrFail());
-        let view = SampleView.getInstanceOrFail(baseEntity.id);
-        (0, vitest_1.expect)(SampleView.instance).toBeDefined();
-        (0, vitest_1.expect)(SampleView.instance).toEqual(view);
-    });
-    (0, vitest_1.test)('should wait until creation and return the view object after in other views init', () => {
-        var SampleView1_1;
-        let BaseEntity = class BaseEntity extends entity_1.Entity {
-        };
-        BaseEntity = __decorate([
-            (0, entity_1.EntityDecorator)()
-        ], BaseEntity);
-        let _SampleView2 = class _SampleView2 extends view_1.View {
-            constructor(entity) {
-                super();
-                this.entity = entity;
-            }
-            async init() {
-                let view = SampleView1.getInstanceOrFail(this.entity.id);
-                (0, vitest_1.expect)(SampleView1.instance).toBeDefined();
-                (0, vitest_1.expect)(SampleView1.instance).toEqual(view);
-            }
-        };
-        _SampleView2 = __decorate([
-            (0, view_1.ViewDecorator)({ entity: BaseEntity }),
-            __metadata("design:paramtypes", [BaseEntity])
-        ], _SampleView2);
-        let SampleView1 = class SampleView1 extends view_1.View {
-            static { SampleView1_1 = this; }
-            constructor(entity) {
-                super();
-                SampleView1_1.instance = this;
-            }
-            async init() {
-                await (0, helpers_lib_1.Wait)();
-            }
-        };
-        SampleView1 = SampleView1_1 = __decorate([
-            (0, view_1.ViewDecorator)({ entity: BaseEntity }),
-            __metadata("design:paramtypes", [BaseEntity])
-        ], SampleView1);
-        new BaseEntity().attach(scene_1.Scene.getActiveSceneOrFail());
-    });
-    (0, vitest_1.test)('should wait until creation and return the view object after, case entity get created before the view definition', () => {
-        var SampleView_7;
+    (0, vitest_1.test)('view getInstanceOrFail should return the view object', () => {
+        var SampleView_5;
         let BaseEntity = class BaseEntity extends entity_1.Entity {
         };
         BaseEntity = __decorate([
@@ -389,13 +194,13 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
         ], BaseEntity);
         let baseEntity = new BaseEntity().attach(scene_1.Scene.getActiveSceneOrFail());
         let SampleView = class SampleView extends view_1.View {
-            static { SampleView_7 = this; }
+            static { SampleView_5 = this; }
             constructor(entity) {
                 super();
-                SampleView_7.instance = this;
+                SampleView_5.instance = this;
             }
         };
-        SampleView = SampleView_7 = __decorate([
+        SampleView = SampleView_5 = __decorate([
             (0, view_1.ViewDecorator)({ entity: BaseEntity }),
             __metadata("design:paramtypes", [BaseEntity])
         ], SampleView);
@@ -404,7 +209,7 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
         (0, vitest_1.expect)(SampleView.instance).toEqual(view);
     });
     (0, vitest_1.test)('should throw error if the entity id is belonging to another entity', () => {
-        var SampleView_8;
+        var SampleView_6;
         let BaseEntity = class BaseEntity extends entity_1.Entity {
         };
         BaseEntity = __decorate([
@@ -418,20 +223,20 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
         ], SampleEntity);
         let sampleEntity = new SampleEntity().attach(baseEntity);
         let SampleView = class SampleView extends view_1.View {
-            static { SampleView_8 = this; }
+            static { SampleView_6 = this; }
             constructor(entity) {
                 super();
-                SampleView_8.instance = this;
+                SampleView_6.instance = this;
             }
         };
-        SampleView = SampleView_8 = __decorate([
+        SampleView = SampleView_6 = __decorate([
             (0, view_1.ViewDecorator)({ entity: BaseEntity }),
             __metadata("design:paramtypes", [BaseEntity])
         ], SampleView);
-        (0, vitest_1.expect)(() => SampleView.getInstanceOrFail(sampleEntity.id)).toThrowError();
+        (0, vitest_1.expect)(() => SampleView.getInstanceOrFail(sampleEntity.id)).toThrow('View: getInstance is called with entity id: "3:1", that is not belonging to the class:');
     });
     (0, vitest_1.test)('destroying entity should not prevent subscription of the view', async () => {
-        var Sample_1, SampleView_9;
+        var Sample_1, SampleView_7;
         let sampleAction = new actions_lib_1.Action();
         let Sample = class Sample extends entity_1.Entity {
             static { Sample_1 = this; }
@@ -451,18 +256,18 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
             __metadata("design:paramtypes", [])
         ], Sample);
         let SampleView = class SampleView extends view_1.View {
-            static { SampleView_9 = this; }
+            static { SampleView_7 = this; }
             static { this.triggered = false; }
             constructor(entity) {
                 super();
                 sampleAction
                     .subscribe(() => {
-                    SampleView_9.triggered = true;
+                    SampleView_7.triggered = true;
                 })
                     .attach(this);
             }
         };
-        SampleView = SampleView_9 = __decorate([
+        SampleView = SampleView_7 = __decorate([
             (0, view_1.ViewDecorator)({ entity: Sample }),
             __metadata("design:paramtypes", [Sample])
         ], SampleView);
@@ -472,34 +277,39 @@ decorate_actions_lib_1.ActionsLibDecorator.decorate(ActionsLib);
         (0, vitest_1.expect)(SampleView.triggered).toEqual(true);
     });
     (0, vitest_1.test)('if view destroys the entity, the view should also be destroyed', async () => {
-        var Sample_2, SampleView_10;
+        var Sample_2, SampleView_8;
         let Sample = class Sample extends entity_1.Entity {
             static { Sample_2 = this; }
             static { this.destroyed = false; }
-            afterDestroy() {
-                Sample_2.destroyed = true;
+            destroy() {
+                if (!this.destroyed) {
+                    Sample_2.destroyed = true;
+                    super.destroy();
+                }
             }
         };
         Sample = Sample_2 = __decorate([
             (0, entity_1.EntityDecorator)()
         ], Sample);
         let SampleView = class SampleView extends view_1.View {
-            static { SampleView_10 = this; }
+            static { SampleView_8 = this; }
             static { this.destroyed = false; }
             constructor(entity) {
                 super();
                 entity.destroy();
             }
-            afterDestroy() {
-                SampleView_10.destroyed = true;
+            destroy() {
+                if (!this.destroyed) {
+                    SampleView_8.destroyed = true;
+                    super.destroy();
+                }
             }
         };
-        SampleView = SampleView_10 = __decorate([
+        SampleView = SampleView_8 = __decorate([
             (0, view_1.ViewDecorator)({ entity: Sample }),
             __metadata("design:paramtypes", [Sample])
         ], SampleView);
         new Sample().attach(scene_1.Scene.getActiveSceneOrFail());
-        await update_cycle_1.UpdateCycle.triggerUpdateTick(1); // Update cycle should take place to destroy functions to be called
         (0, vitest_1.expect)(Sample.destroyed).toEqual(true);
         (0, vitest_1.expect)(SampleView.destroyed).toEqual(true);
     });

package/dist/physics/entity-types/immovable-physics-entity.d.ts

@@ -1,11 +1,9 @@
-import { Action } from 'actions-lib';
 import { Radian, Vector } from 'helpers-lib';
-import { CollisionReport, PhysicsBodyDTO, PhysicsEntityDefinition } from '../interfaces';
+import { PhysicsBodyDTO, PhysicsEntityDefinition } from '../interfaces';
 import { PhysicsEntity } from './physics-entity';
 export declare abstract class ImmovablePhysicsEntity extends PhysicsEntity {
     readonly position: Vector;
     readonly rotation: Radian;
-    readonly onCollision: Action<CollisionReport[]>;
     constructor(physicsWorldId: string, physicsEntityDefinition: PhysicsEntityDefinition);
     convertToDTO(): PhysicsBodyDTO;
 }

package/dist/physics/entity-types/immovable-physics-entity.js

@@ -1,21 +1,19 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.ImmovablePhysicsEntity = void 0;
-const actions_lib_1 = require("actions-lib");
 const helpers_lib_1 = require("helpers-lib");
 const p2js_helper_1 = require("../libs/p2js.helper");
 const physics_entity_1 = require("./physics-entity");
 class ImmovablePhysicsEntity extends physics_entity_1.PhysicsEntity {
     constructor(physicsWorldId, physicsEntityDefinition) {
         super(physicsWorldId, physicsEntityDefinition, 'static');
-        this.onCollision = new actions_lib_1.Action();
         this.position = p2js_helper_1.P2JSHelper.arrayToVector(this.p2Body.position);
         this.rotation = new helpers_lib_1.Radian(this.p2Body.angle);
     }
     convertToDTO() {
         return {
             entityId: this.id,
-            entityClassName: this.constructor.name,
+            classId: this.classId,
             position: this.position,
             rotation: this.rotation,
             velocity: helpers_lib_1.Vector.zero,

package/dist/physics/entity-types/movable-entity.js

@@ -7,10 +7,10 @@ const game_entities_1 = require("../../game-entities");
 class MovableEntity extends game_entities_1.Entity {
     constructor() {
         super();
-        this.position = new actions_lib_1.Variable().set(helpers_lib_1.Vector.zero);
-        this.rotation = new actions_lib_1.Variable().set(helpers_lib_1.Radian.get0);
-        this.velocity = new actions_lib_1.Variable().set(helpers_lib_1.Vector.zero);
-        this.rotationalSpeed = new actions_lib_1.Variable().set(0);
+        this.position = new actions_lib_1.Variable(helpers_lib_1.Vector.zero);
+        this.rotation = new actions_lib_1.Variable(helpers_lib_1.Radian.get0);
+        this.velocity = new actions_lib_1.Variable(helpers_lib_1.Vector.zero);
+        this.rotationalSpeed = new actions_lib_1.Variable(0);
         game_entities_1.UpdateCycle.beforeSceneUpdateAction
             .subscribe(({ time, delta }) => {
             this.step(time, delta);

package/dist/physics/entity-types/movable-physics-entity.d.ts

@@ -1,13 +1,12 @@
-import { Action, Variable } from 'actions-lib';
+import { Variable } from 'actions-lib';
 import { Radian, Vector } from 'helpers-lib';
-import { CollisionReport, PhysicsBodyDTO, PhysicsEntityDefinition } from '../interfaces';
+import { PhysicsBodyDTO, PhysicsEntityDefinition } from '../interfaces';
 import { PhysicsEntity } from './physics-entity';
 export declare abstract class MovablePhysicsEntity extends PhysicsEntity {
     readonly position: Variable<Vector>;
     readonly rotation: Variable<Radian>;
     readonly velocity: Variable<Vector>;
     readonly rotationalSpeed: Variable<number>;
-    readonly onCollision: Action<CollisionReport[]>;
     private ignorePositionUpdate;
     private ignoreRotationUpdate;
     private ignoreVelocityUpdate;

package/dist/physics/entity-types/movable-physics-entity.js

@@ -10,11 +10,10 @@ const physics_entity_1 = require("./physics-entity");
 class MovablePhysicsEntity extends physics_entity_1.PhysicsEntity {
     constructor(physicsWorldId, physicsEntityDefinition) {
         super(physicsWorldId, physicsEntityDefinition, 'dynamic');
-        this.position = new actions_lib_1.Variable().set(helpers_lib_1.Vector.zero);
-        this.rotation = new actions_lib_1.Variable().set(helpers_lib_1.Radian.get0);
-        this.velocity = new actions_lib_1.Variable().set(helpers_lib_1.Vector.zero);
-        this.rotationalSpeed = new actions_lib_1.Variable().set(0);
-        this.onCollision = new actions_lib_1.Action();
+        this.position = new actions_lib_1.Variable(helpers_lib_1.Vector.zero);
+        this.rotation = new actions_lib_1.Variable(helpers_lib_1.Radian.get0);
+        this.velocity = new actions_lib_1.Variable(helpers_lib_1.Vector.zero);
+        this.rotationalSpeed = new actions_lib_1.Variable(0);
         this.ignorePositionUpdate = false;
         this.ignoreRotationUpdate = false;
         this.ignoreVelocityUpdate = false;
@@ -28,7 +27,7 @@ class MovablePhysicsEntity extends physics_entity_1.PhysicsEntity {
     convertToDTO() {
         return {
             entityId: this.id,
-            entityClassName: this.constructor.name,
+            classId: this.classId,
             position: this.position.value,
             rotation: this.rotation.value,
             velocity: this.velocity.value,

package/dist/physics/entity-types/physics-entity.d.ts

@@ -10,7 +10,8 @@ export declare abstract class PhysicsEntity extends Entity {
     static getFromP2BodyIdOrFail(p2BodyId: number): PhysicsEntity;
     static getPhysicsInstanceOrFail(id: string): PhysicsEntity;
     static getPhysicsEntities(): PhysicsEntity[];
-    readonly onCollision: Action<readonly CollisionReport[]>;
+    readonly _onCollision: Action<readonly CollisionReport[]>;
+    readonly onCollision: import("actions-lib").Notifier<readonly CollisionReport[]>;
     get area(): number;
     get mass(): number;
     get collisions(): readonly CollisionReport[];
@@ -27,7 +28,7 @@ export declare abstract class PhysicsEntity extends Entity {
     private _collisions;
     constructor(physicsWorldId: string, physicsEntityDefinition: PhysicsEntityDefinition, type: 'dynamic' | 'static');
     abstract convertToDTO(): PhysicsBodyDTO;
-    protected destroySelf(): void;
+    destroy(): void;
     canCollideWith(target: PhysicsEntity): boolean;
     protected setCollisionReports(collisionReports: CollisionReport[]): void;
 }

package/dist/physics/entity-types/physics-entity.js

@@ -39,7 +39,8 @@ class PhysicsEntity extends game_entities_1.Entity {
     }
     constructor(physicsWorldId, physicsEntityDefinition, type) {
         super();
-        this.onCollision = new actions_lib_1.Action();
+        this._onCollision = new actions_lib_1.Action();
+        this.onCollision = this._onCollision.notifier;
         this.type = 'dynamic';
         this._area = 0;
         this._mass = 0;
@@ -65,11 +66,13 @@ class PhysicsEntity extends game_entities_1.Entity {
         PhysicsEntity.p2BodyIdToPhysicsBody.set(this.p2Body.id, this);
         PhysicsEntity.physicsEntities.set(this.id, this);
     }
-    destroySelf() {
-        super.destroySelf();
-        this.physicsInternalGateway.removeBody(this.physicsWorldId, this.p2Body);
-        PhysicsEntity.p2BodyIdToPhysicsBody.delete(this.p2Body.id);
-        PhysicsEntity.physicsEntities.delete(this.id);
+    destroy() {
+        if (!this.destroyed) {
+            this.physicsInternalGateway.removeBody(this.physicsWorldId, this.p2Body);
+            PhysicsEntity.p2BodyIdToPhysicsBody.delete(this.p2Body.id);
+            PhysicsEntity.physicsEntities.delete(this.id);
+            super.destroy();
+        }
     }
     canCollideWith(target) {
         return p2js_helper_1.P2JSHelper.arePhysicsGroupsCollidable(this.physicsGroup, this.physicsMask, target.physicsGroup, target.physicsMask);
@@ -78,7 +81,7 @@ class PhysicsEntity extends game_entities_1.Entity {
     setCollisionReports(collisionReports) {
         this._collisions = collisionReports;
         if (collisionReports.length > 0) {
-            this.onCollision.trigger(collisionReports);
+            this._onCollision.trigger(collisionReports);
         }
     }
 }

package/dist/physics/interfaces.d.ts

@@ -5,7 +5,7 @@ export declare const SPEED_LIMIT = 10.8;
 export declare const ROTATIONAL_SPEED_LIMIT = 10.01;
 export interface PhysicsBodyDTO {
     readonly entityId: string;
-    readonly entityClassName: string;
+    readonly classId: string;
     readonly position: Vector;
     readonly rotation: Radian;
     readonly velocity: Vector;