bambu-printer-mcp 1.1.29 → 1.1.31

package/CONTRIBUTORS.md

@@ -6,7 +6,7 @@ Thank you to everyone who builds, tests, reports problems, and shares real print
 
 | Contributor | Contribution |
 | --- | --- |
-| [mygrexit](https://github.com/mygrexit) | Contributes pinned x86-64 Linux X2D native setup, emergency routing and one-shot cleanup in [#56](https://github.com/DMontgomery40/bambu-printer-mcp/pull/56), checked Orca/time-lapse G-code forms in [#57](https://github.com/DMontgomery40/bambu-printer-mcp/pull/57), and model-specific hidden-HMS notices in [#58](https://github.com/DMontgomery40/bambu-printer-mcp/pull/58). Supplies regressions, review corrections, and contributor-reported Debian/X2D read-only, heater-off and print-start evidence in [#55](https://github.com/DMontgomery40/bambu-printer-mcp/issues/55); maintainer validation is offline and mocked. |
+| [mygrexit](https://github.com/mygrexit) | Contributes pinned x86-64 Linux X2D native setup, emergency routing and one-shot cleanup in [#56](https://github.com/DMontgomery40/bambu-printer-mcp/pull/56), checked Orca/time-lapse G-code forms in [#57](https://github.com/DMontgomery40/bambu-printer-mcp/pull/57), and model-specific hidden-HMS notices in [#58](https://github.com/DMontgomery40/bambu-printer-mcp/pull/58). Supplies regressions, review corrections, and contributor-reported Debian/X2D read-only, heater-off and print-start evidence in [#55](https://github.com/DMontgomery40/bambu-printer-mcp/issues/55); maintainer validation is offline and mocked. Also reports and fixes hanging Linux X2D stop/heater-off calls in [#61](https://github.com/DMontgomery40/bambu-printer-mcp/pull/61), with never-connecting transport and helper-exit regressions; the release adds protection against expired commands dispatching after reconnection. |
 | [patrikmadoran-cyber](https://github.com/patrikmadoran-cyber) | Adds explicit Standard/High Flow nozzle selection across slicing and print auto-slicing in [#54](https://github.com/DMontgomery40/bambu-printer-mcp/pull/54), with unsupported-variant regressions and real Windows BambuStudio 02.06.00.51 H2S 0.6 slicing evidence. No physical print is claimed. |
 | [Patrick Juchli (@patrickjuchli)](https://github.com/patrickjuchli) | Maintains basic-ftp and supplies the 6.2.3 fixes for rejected-command recovery, asynchronous credential-error crashes, and password redaction used by direct FTPS transfers. |
 | [Aleksei Popovich (alexpapay)](https://github.com/alexpapay) | Fixes cross-platform AMS profile resolution and packed P2S chamber status in [#43](https://github.com/DMontgomery40/bambu-printer-mcp/pull/43), contributes regressions, and supplies read-only Windows P2S/AMS 2 Pro status and local slicing evidence. No physical print is claimed for this contribution. |
@@ -46,3 +46,5 @@ See the [full contribution history](https://github.com/DMontgomery40/bambu-print
 Special thanks to [FULU Foundation](https://www.fulu.org/), [Louis Rossmann](https://www.youtube.com/watch?v=1jhRqgHxEP8), and the [OrcaSlicer-bambulab contributors](https://github.com/FULU-Foundation/OrcaSlicer-bambulab) for their work supporting user control and interoperable tools. We support open-source software, repair rights, and a local print workflow that does not require Bambu Studio, Bambu Connect, or Bambu Cloud.
 
 This is community recognition, separate from code authorship in this repository. The optional FULU bridge uses Bambu's networking runtime; see the [FULU setup guide](./docs/FULU.md) for the direct LAN alternative and current validation limits.
+
+Thanks to the [MQTT.js contributors](https://github.com/mqttjs/MQTT.js/releases/tag/v5.16.1), [proxy-addr maintainers](https://github.com/jshttp/proxy-addr/releases/tag/v2.0.8), and [source-map-js maintainers](https://github.com/7rulnik/source-map-js) for the reconnect and security fixes incorporated in 1.1.31. This recognizes upstream dependency work separately from authorship in this repository.

package/README.md

@@ -966,7 +966,7 @@ Use the same package version as the server, for example `bambu-printer-mcp@1.2.3
 
 `--check-update` asks Bambu's plug-in service for the newest Linux plug-in and compares the `PrintParams` layout in the matching Bambu Studio header with the helper. It reports only: the setup never installs an unpinned plug-in, because a changed layout would send wrong print parameters. A pin is raised by a package release after the check passes and a hardware test.
 
-Once the helper, plug-in and certificates are installed, X2D printing, upload and controls use the same routing, safety checks and authorization handshake described for macOS above. On Linux, stop and heater-off go out over the native route and MQTT at the same time, so a stuck helper cannot delay them. MQTT is sent again once every older print or heating helper for that printer has exited, so none can dispatch after it; either the native route or that later MQTT send succeeding counts, and the result lists all sends under `routes`. A repeated stop or heater-off is harmless. macOS keeps its native-only route. The server accepts only the pinned plug-in checksums; `BAMBU_NATIVE_ALLOW_UNPINNED_PLUGIN=1` is a trusted override for testing another build at your own risk. Without a complete installation, Linux keeps its previous behavior: X2D status and slicing work, stop, pause and heater-off use MQTT, and native print requests name the setup command before contacting the printer. Bambu publishes the Linux plug-in for x86-64 only; other architectures keep the MQTT behavior.
+Once the helper, plug-in and certificates are installed, X2D printing, upload and controls use the same routing, safety checks and authorization handshake described for macOS above. On Linux, stop and heater-off go out over the native route and MQTT at the same time, so a stuck helper cannot delay them. MQTT is sent again once every older print or heating helper for that printer has exited and the immediate MQTT attempt has settled, so none can dispatch after it; either the native route or that later MQTT send succeeding counts, and the result lists all sends under `routes`. Each MQTT send gives up after 15 seconds (`BAMBU_EMERGENCY_MQTT_TIMEOUT_MS`), so an unreachable MQTT connection cannot hold back a stop the native route already sent. A connection completing after that deadline cannot dispatch its expired command; an already queued MQTT publish is discarded by force-closing and invalidating that client. A repeated stop or heater-off is harmless. macOS keeps its native-only route. The server accepts only the pinned plug-in checksums; `BAMBU_NATIVE_ALLOW_UNPINNED_PLUGIN=1` is a trusted override for testing another build at your own risk. Without a complete installation, Linux keeps its previous behavior: X2D status and slicing work, stop, pause and heater-off use MQTT, and native print requests name the setup command before contacting the printer. Bambu publishes the Linux plug-in for x86-64 only; other architectures keep the MQTT behavior.
 
 #### x2d_native_control
 

package/dist/index.js

@@ -52,6 +52,21 @@ const DEFAULT_BAMBU_MODEL = process.env.BAMBU_PRINTER_MODEL?.trim().toLowerCase(
 const DEFAULT_BAMBU_CONNECTION_MODE = process.env.BAMBU_DEFAULT_CONNECTION_MODE?.trim().toLowerCase() || "";
 const DEFAULT_BED_TYPE = process.env.BED_TYPE?.trim().toLowerCase() || "textured_plate";
 const DEFAULT_NOZZLE_DIAMETER = process.env.NOZZLE_DIAMETER?.trim() || "0.4";
+/** Bound for each Linux X2D emergency MQTT send (BAMBU_EMERGENCY_MQTT_TIMEOUT_MS, 1–60000 ms). */
+function withEmergencyMqttTimeout(send) {
+    const raw = Number(process.env.BAMBU_EMERGENCY_MQTT_TIMEOUT_MS?.trim() || 15000);
+    const ms = Number.isInteger(raw) && raw >= 1 && raw <= 60000 ? raw : 15000;
+    const controller = new AbortController();
+    let timer;
+    const timeout = new Promise((_, reject) => {
+        timer = setTimeout(() => {
+            const error = new Error(`no MQTT confirmation within ${ms / 1000} s`);
+            controller.abort(error);
+            reject(error);
+        }, ms);
+    });
+    return Promise.race([Promise.resolve().then(() => send(controller.signal)), timeout]).finally(() => clearTimeout(timer));
+}
 function requestedPrintNozzles(args) {
     if (args.nozzle_diameters !== undefined && args.nozzle_diameter !== undefined) {
         throw new Error("Supply nozzle_diameters or nozzle_diameter, not both.");
@@ -2676,10 +2691,19 @@ class BambuPrinterMCPServer {
             const linuxEmergency = (native, mqtt) => async () => {
                 if (process.platform !== "linux")
                     return native();
+                // An unreachable printer makes the MQTT connect retry forever; bound each
+                // MQTT send so it cannot hold back a stop the native route already sent.
+                const immediate = withEmergencyMqttTimeout(mqtt);
                 const [nativeResult, immediateResult, mqttResult] = await Promise.allSettled([
                     native(),
-                    mqtt(),
-                    interruptNativeOperations(bambuSerial).then(() => mqtt()),
+                    immediate,
+                    // Finish the first attempt before reusing its cached publisher: its
+                    // expiry must never close the later, counted send's transport.
+                    Promise.allSettled([interruptNativeOperations(bambuSerial), immediate]).then(results => {
+                        if (results[0].status === "rejected")
+                            throw results[0].reason;
+                        return withEmergencyMqttTimeout(mqtt);
+                    }),
                 ]);
                 const reason = (result) => result.status === "rejected" ? (result.reason instanceof Error ? result.reason.message : String(result.reason)) : undefined;
                 if (nativeResult.status === "rejected" && mqttResult.status === "rejected") {
@@ -2896,7 +2920,7 @@ class BambuPrinterMCPServer {
                     case "cancel_print":
                         result = await this.bambu.cancelJob(host, bambuSerial, bambuToken, nativeControls()
                             ? linuxEmergency(() => sendNativeCommand({ host, serial: bambuSerial, token: bambuToken,
-                                messageJson: JSON.stringify({ print: { command: "stop", param: "", sequence_id: String(Date.now()) } }), qos: 1 }), () => this.bambu.sendStopOverMqtt(host, bambuSerial, bambuToken))
+                                messageJson: JSON.stringify({ print: { command: "stop", param: "", sequence_id: String(Date.now()) } }), qos: 1 }), signal => this.bambu.sendStopOverMqtt(host, bambuSerial, bambuToken, signal))
                             : undefined);
                         break;
                     case "pause_print":
@@ -3036,7 +3060,7 @@ class BambuPrinterMCPServer {
                                 const native = () => sendNativeCommand({ host, serial: bambuSerial, token: bambuToken,
                                     messageJson: buildBambuNativeTemperatureCommand(heater, target).messageJson }, { signal: extra.signal, assertActive, beforeDispatch });
                                 return target === 0
-                                    ? linuxEmergency(native, () => this.bambu.sendHeaterOffOverMqtt(host, bambuSerial, bambuToken, heater))()
+                                    ? linuxEmergency(native, signal => this.bambu.sendHeaterOffOverMqtt(host, bambuSerial, bambuToken, heater, signal))()
                                     : native();
                             }
                             : undefined);

package/dist/printers/bambu.d.ts

@@ -60,10 +60,11 @@ export declare class BambuImplementation {
     print3mf(host: string, serial: string, token: string, options: BambuPrintOptionsInternal): Promise<any>;
     private print3mfPrepared;
     cancelJob(host: string, serial: string, token: string, dispatch?: () => Promise<any>): Promise<any>;
+    private invokeEmergencyCommand;
     /** Raw MQTT stop for routes that already ran the shared cancellation steps. */
-    sendStopOverMqtt(host: string, serial: string, token: string): Promise<any>;
+    sendStopOverMqtt(host: string, serial: string, token: string, signal?: AbortSignal): Promise<any>;
     /** Raw MQTT heater-off; switching off needs no material or model declaration. */
-    sendHeaterOffOverMqtt(host: string, serial: string, token: string, heater: "bed" | "nozzle"): Promise<any>;
+    sendHeaterOffOverMqtt(host: string, serial: string, token: string, heater: "bed" | "nozzle", signal?: AbortSignal): Promise<any>;
     pauseJob(host: string, serial: string, token: string, dispatch?: () => Promise<any>): Promise<any>;
     resumeJob(host: string, serial: string, token: string, dispatch?: (assertActive: () => void, beforeDispatch: () => Promise<void>) => Promise<any>): Promise<any>;
     clearHmsErrors(host: string, serial: string, token: string, dispatch?: (assertActive: () => void, beforeDispatch: () => Promise<void>) => Promise<any>): Promise<any>;

package/dist/printers/bambu.js

@@ -356,6 +356,12 @@ class BambuClientStore {
             throw error;
         }
     }
+    forgetPrinter(printer) {
+        for (const [key, cached] of this.printers) {
+            if (cached === printer)
+                this.clearPrinterState(key);
+        }
+    }
     async disconnectAll() {
         const disconnectPromises = [];
         for (const printer of this.printers.values()) {
@@ -836,17 +842,48 @@ export class BambuImplementation {
             throw new Error(`Failed to cancel print: ${error.message}`);
         }
     }
+    async invokeEmergencyCommand(printer, command, signal) {
+        if (!signal)
+            return invokeWithoutAck(printer, command);
+        let onAbort;
+        try {
+            await new Promise((resolve, reject) => {
+                onAbort = () => {
+                    // Force-close the actual transport: a raced publish may be queued
+                    // inside MQTT.js and otherwise dispatch after a later reconnect.
+                    this.printerStore.forgetPrinter(printer);
+                    void printer.disconnect(true).catch(() => {
+                        console.error("Failed to close an expired emergency MQTT client.");
+                    });
+                    reject(signal.reason);
+                };
+                signal.addEventListener("abort", onAbort, { once: true });
+                if (signal.aborted)
+                    onAbort();
+                else
+                    command.invoke(printer).then(resolve, reject);
+            });
+        }
+        finally {
+            signal.removeEventListener("abort", onAbort);
+        }
+        await sleep(COMMAND_SETTLE_MS);
+    }
     /** Raw MQTT stop for routes that already ran the shared cancellation steps. */
-    async sendStopOverMqtt(host, serial, token) {
+    async sendStopOverMqtt(host, serial, token, signal) {
+        signal?.throwIfAborted();
         const printer = await this.getPrinter(host, serial, token);
-        await invokeWithoutAck(printer, new UpdateStateCommand({ state: "stop" }));
+        signal?.throwIfAborted();
+        await this.invokeEmergencyCommand(printer, new UpdateStateCommand({ state: "stop" }), signal);
         return { status: "success", message: "Cancel command sent over MQTT." };
     }
     /** Raw MQTT heater-off; switching off needs no material or model declaration. */
-    async sendHeaterOffOverMqtt(host, serial, token, heater) {
+    async sendHeaterOffOverMqtt(host, serial, token, heater, signal) {
+        signal?.throwIfAborted();
         const printer = await this.getPrinter(host, serial, token);
+        signal?.throwIfAborted();
         const gcode = `${heater === "bed" ? "M140" : "M104"} S0`;
-        await invokeWithoutAck(printer, new GCodeLineCommand({ gcodes: [gcode] }));
+        await this.invokeEmergencyCommand(printer, new GCodeLineCommand({ gcodes: [gcode] }), signal);
         return { status: "success", message: `Heater-off sent over MQTT for ${heater}.`, command: gcode };
     }
     async pauseJob(host, serial, token, dispatch) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bambu-printer-mcp",
-  "version": "1.1.29",
+  "version": "1.1.31",
   "description": "MCP server for Bambu Lab 3D printers with STL manipulation, slicing, and print management",
   "main": "dist/index.js",
   "repository": {
@@ -54,7 +54,7 @@
     "basic-ftp": "^6.2.3",
     "dotenv": "^16.3.1",
     "jszip": "^3.10.2",
-    "mqtt": "^5.16.0",
+    "mqtt": "^5.16.1",
     "patch-package": "8.0.1",
     "three": "^0.173.0",
     "xml2js": "^0.6.2"

package/src/index.ts

@@ -85,6 +85,22 @@ const DEFAULT_BAMBU_CONNECTION_MODE =
 const DEFAULT_BED_TYPE = process.env.BED_TYPE?.trim().toLowerCase() || "textured_plate";
 const DEFAULT_NOZZLE_DIAMETER = process.env.NOZZLE_DIAMETER?.trim() || "0.4";
 
+/** Bound for each Linux X2D emergency MQTT send (BAMBU_EMERGENCY_MQTT_TIMEOUT_MS, 1–60000 ms). */
+function withEmergencyMqttTimeout<T>(send: (signal: AbortSignal) => Promise<T>): Promise<T> {
+  const raw = Number(process.env.BAMBU_EMERGENCY_MQTT_TIMEOUT_MS?.trim() || 15_000);
+  const ms = Number.isInteger(raw) && raw >= 1 && raw <= 60_000 ? raw : 15_000;
+  const controller = new AbortController();
+  let timer: ReturnType<typeof setTimeout> | undefined;
+  const timeout = new Promise<never>((_, reject) => {
+    timer = setTimeout(() => {
+      const error = new Error(`no MQTT confirmation within ${ms / 1000} s`);
+      controller.abort(error);
+      reject(error);
+    }, ms);
+  });
+  return Promise.race([Promise.resolve().then(() => send(controller.signal)), timeout]).finally(() => clearTimeout(timer));
+}
+
 function requestedPrintNozzles(args: Record<string, any>): number[] | undefined {
   if (args.nozzle_diameters !== undefined && args.nozzle_diameter !== undefined) {
     throw new Error("Supply nozzle_diameters or nozzle_diameter, not both.");
@@ -3208,12 +3224,20 @@ class BambuPrinterMCPServer {
       // again once every older helper for this printer has exited, and only
       // that send counts. Either counted route succeeding is success. macOS
       // stays native-only.
-      const linuxEmergency = (native: () => Promise<any>, mqtt: () => Promise<any>) => async () => {
+      const linuxEmergency = (native: () => Promise<any>, mqtt: (signal: AbortSignal) => Promise<any>) => async () => {
         if (process.platform !== "linux") return native();
+        // An unreachable printer makes the MQTT connect retry forever; bound each
+        // MQTT send so it cannot hold back a stop the native route already sent.
+        const immediate = withEmergencyMqttTimeout(mqtt);
         const [nativeResult, immediateResult, mqttResult] = await Promise.allSettled([
           native(),
-          mqtt(),
-          interruptNativeOperations(bambuSerial).then(() => mqtt()),
+          immediate,
+          // Finish the first attempt before reusing its cached publisher: its
+          // expiry must never close the later, counted send's transport.
+          Promise.allSettled([interruptNativeOperations(bambuSerial), immediate]).then(results => {
+            if (results[0].status === "rejected") throw results[0].reason;
+            return withEmergencyMqttTimeout(mqtt);
+          }),
         ]);
         const reason = (result: PromiseSettledResult<any>) =>
           result.status === "rejected" ? (result.reason instanceof Error ? result.reason.message : String(result.reason)) : undefined;
@@ -3487,7 +3511,7 @@ class BambuPrinterMCPServer {
                 ? linuxEmergency(
                     () => sendNativeCommand({ host, serial: bambuSerial, token: bambuToken,
                       messageJson: JSON.stringify({ print: { command: "stop", param: "", sequence_id: String(Date.now()) } }), qos: 1 }),
-                    () => this.bambu.sendStopOverMqtt(host, bambuSerial, bambuToken))
+                    signal => this.bambu.sendStopOverMqtt(host, bambuSerial, bambuToken, signal))
                 : undefined);
             break;
 
@@ -3647,7 +3671,7 @@ class BambuPrinterMCPServer {
                     const native = () => sendNativeCommand({ host, serial: bambuSerial, token: bambuToken,
                       messageJson: buildBambuNativeTemperatureCommand(heater, target).messageJson }, { signal: extra.signal, assertActive, beforeDispatch });
                     return target === 0
-                      ? linuxEmergency(native, () => this.bambu.sendHeaterOffOverMqtt(host, bambuSerial, bambuToken, heater))()
+                      ? linuxEmergency(native, signal => this.bambu.sendHeaterOffOverMqtt(host, bambuSerial, bambuToken, heater, signal))()
                       : native();
                   }
                 : undefined

package/src/printers/bambu.ts

@@ -438,6 +438,12 @@ class BambuClientStore {
     }
   }
 
+  forgetPrinter(printer: BambuClient): void {
+    for (const [key, cached] of this.printers) {
+      if (cached === printer) this.clearPrinterState(key);
+    }
+  }
+
   async disconnectAll(): Promise<void> {
     const disconnectPromises: Promise<void>[] = [];
 
@@ -964,18 +970,50 @@ export class BambuImplementation {
     }
   }
 
+  private async invokeEmergencyCommand(
+    printer: BambuClient,
+    command: { invoke(client: BambuClient): Promise<void> },
+    signal?: AbortSignal
+  ): Promise<void> {
+    if (!signal) return invokeWithoutAck(printer, command);
+    let onAbort: () => void;
+    try {
+      await new Promise<void>((resolve, reject) => {
+        onAbort = () => {
+          // Force-close the actual transport: a raced publish may be queued
+          // inside MQTT.js and otherwise dispatch after a later reconnect.
+          this.printerStore.forgetPrinter(printer);
+          void printer.disconnect(true).catch(() => {
+            console.error("Failed to close an expired emergency MQTT client.");
+          });
+          reject(signal.reason);
+        };
+        signal.addEventListener("abort", onAbort, { once: true });
+        if (signal.aborted) onAbort();
+        else command.invoke(printer).then(resolve, reject);
+      });
+    } finally {
+      signal.removeEventListener("abort", onAbort!);
+    }
+    await sleep(COMMAND_SETTLE_MS);
+  }
+
   /** Raw MQTT stop for routes that already ran the shared cancellation steps. */
-  async sendStopOverMqtt(host: string, serial: string, token: string): Promise<any> {
+  async sendStopOverMqtt(host: string, serial: string, token: string, signal?: AbortSignal): Promise<any> {
+    signal?.throwIfAborted();
     const printer = await this.getPrinter(host, serial, token);
-    await invokeWithoutAck(printer, new UpdateStateCommand({ state: "stop" }));
+    signal?.throwIfAborted();
+    await this.invokeEmergencyCommand(printer, new UpdateStateCommand({ state: "stop" }), signal);
     return { status: "success", message: "Cancel command sent over MQTT." };
   }
 
   /** Raw MQTT heater-off; switching off needs no material or model declaration. */
-  async sendHeaterOffOverMqtt(host: string, serial: string, token: string, heater: "bed" | "nozzle"): Promise<any> {
+  async sendHeaterOffOverMqtt(host: string, serial: string, token: string, heater: "bed" | "nozzle", signal?: AbortSignal): Promise<any> {
+    signal?.throwIfAborted();
     const printer = await this.getPrinter(host, serial, token);
+    signal?.throwIfAborted();
     const gcode = `${heater === "bed" ? "M140" : "M104"} S0`;
-    await invokeWithoutAck(printer, new GCodeLineCommand({ gcodes: [gcode] }));
+    await this.invokeEmergencyCommand(printer, new GCodeLineCommand({ gcodes: [gcode] }), signal);
     return { status: "success", message: `Heater-off sent over MQTT for ${heater}.`, command: gcode };
   }