bambu-printer-mcp 1.1.18 → 1.1.20

package/CONTRIBUTORS.md

@@ -6,6 +6,7 @@ Thank you to everyone who builds, tests, reports problems, and shares real print
 
 | Contributor | Contribution |
 | --- | --- |
+| [Izzy Mansurov (sapoepsilon)](https://github.com/sapoepsilon) | Fixes Bambu Studio 02.08 P2S extruder-variant metadata and airduct-command inspection in [#33](https://github.com/DMontgomery40/bambu-printer-mcp/pull/33). Supplies regression tests and offline inspection evidence from four real P2S 0.6 mm PLA/PETG jobs and unsafe mutated copies; this contribution does not claim a physical print. |
 | [Boardy (@boardyai)](https://x.com/boardyai) | Raises the nozzle-verification question that informs the added printer safety checks. |
 | Fable red-team review, shared by David Montgomery | Supplies archive-ambiguity reproductions and hardware-safety review findings used for plate binding, upload checks, temperature policy, and human preflight. Network/security suggestions remain outside this hardware-safety release. |
 | [Sebastian (sebas1986)](https://github.com/sebas1986) | Isolates the multi-filament CLI crash with real BambuStudio bisection, contributes per-slot colours and multi-nozzle prime-tower placement, and verifies X2D identification, status, and slicing in [#18](https://github.com/DMontgomery40/bambu-printer-mcp/pull/18). Also isolates FTPS session-host identity and supplies physical X2D USB upload/size/deletion evidence in [#24](https://github.com/DMontgomery40/bambu-printer-mcp/pull/24); that test does not establish MQTT print dispatch. |

package/dist/safety/print-file.js

@@ -206,12 +206,13 @@ export async function inspectPrintFile(filePath, options) {
     if (/[\x00-\x08\x0b\x0c\x0e-\x1f\ufffd]/.test(source))
         return fail('binary or malformed G-code is not supported');
     const lines = source.split(/\r\n|\n|\r/);
-    const metadata = [project];
+    const headers = [];
     for (const line of lines) {
         const match = line.match(/^\s*;\s*([a-z_][a-z0-9_]*(?:\s+used\s+\[(?:g|mm)\])?)\s*(?:=|:)\s*(.*?)\s*$/i);
         if (match)
-            metadata.push({ [match[1].toLowerCase()]: match[2] });
+            headers.push({ [match[1].toLowerCase()]: match[2] });
     }
+    const metadata = [project, ...headers];
     validateFffJob([...metadata, plate]);
     const declaredModel = consistent(metadataValues(metadata, ['printer_model']), normalizeModel, 'printer model');
     if (declaredModel !== model)
@@ -234,6 +235,20 @@ export async function inspectPrintFile(filePath, options) {
         const entries = list(value).map(entry => entry.toLowerCase().replace(/[\s_-]+/g, '_'));
         return entries.length && entries.every(Boolean) ? entries : undefined;
     };
+    // Bambu Studio writes printer_extruder_id/printer_extruder_variant to
+    // project_settings.config as the full per-variant table, but to the plate
+    // G-code header as the per-physical-extruder selection it sliced with (for
+    // example ["1","1","1"] vs "1" on a single-nozzle P2S). Preserve the source:
+    // a plate header can never substitute a full table for its selected values.
+    const variantTable = (key, rows, convert) => {
+        const field = key.replace(/_/g, ' ');
+        const tableValues = metadataValues([project], [key]);
+        const selectedValues = metadataValues(headers, [key]);
+        if (tableValues.some(value => list(value).length !== rows) || selectedValues.some(value => list(value).length !== nozzleDiameters.length))
+            return fail(`unknown or malformed ${field} metadata`);
+        const table = consistent(tableValues, convert, field);
+        return { table, selected: selectedValues.length ? consistent(selectedValues, convert, `selected ${field}`) : undefined };
+    };
     const nozzleMetadata = (keys, variantRows = false) => {
         const values = metadataValues(metadata, keys);
         return values.length ? consistent(values, value => {
@@ -247,24 +262,34 @@ export async function inspectPrintFile(filePath, options) {
             // Bambu GUI projects may store nozzle types per extruder variant, while
             // diameters and selected flow types are per physical extruder. Never truncate
             // that variant table or mistake its rows for filament/nozzle positions.
-            const ids = consistent(metadataValues(metadata, ['printer_extruder_id']), value => {
+            const { table: ids, selected: selectedIds } = variantTable('printer_extruder_id', entries.length, value => {
                 const ids = list(value);
-                return ids.length === entries.length && ids.every(id => /^[1-9]\d*$/.test(id) && Number(id) <= nozzleDiameters.length) ? ids.map(Number) : undefined;
-            }, 'printer extruder id');
+                return ids.length > 0 && ids.every(id => /^[1-9]\d*$/.test(id) && Number(id) <= nozzleDiameters.length) ? ids.map(Number) : undefined;
+            });
+            // The selected form names each physical extruder once, in order.
+            if (selectedIds && selectedIds.some((id, index) => id !== index + 1))
+                return undefined;
+            const variants = metadataValues(metadata, ['printer_extruder_variant']).length
+                ? variantTable('printer_extruder_variant', entries.length, normalizedEntries) : undefined;
+            const extruders = variants ? consistent(metadataValues(metadata, ['extruder_type']), normalizedEntries, 'extruder type') : undefined;
             const resolved = [];
             for (let index = 0; index < nozzleDiameters.length; index++) {
                 const rows = ids.flatMap((id, row) => id === index + 1 ? [row] : []);
                 if (!rows.length)
                     return undefined;
-                if (rows.every(row => entries[row] === entries[rows[0]])) {
+                if (!variants) {
+                    if (!rows.every(row => entries[row] === entries[rows[0]]))
+                        return undefined;
                     resolved.push(entries[rows[0]]);
                     continue;
                 }
-                const variants = consistent(metadataValues(metadata, ['printer_extruder_variant']), normalizedEntries, 'printer extruder variant');
-                const extruders = consistent(metadataValues(metadata, ['extruder_type']), normalizedEntries, 'extruder type');
-                if (variants.length !== entries.length || extruders.length !== nozzleDiameters.length || !nozzleFlows)
+                // Validate declared variants even when all rows use the same material.
+                if (!extruders || extruders.length !== nozzleDiameters.length || !nozzleFlows)
+                    return undefined;
+                const variant = `${extruders[index]}_${nozzleFlows[index]}`;
+                if (variants.selected && variants.selected[index] !== variant)
                     return undefined;
-                const selected = rows.filter(row => variants[row] === `${extruders[index]}_${nozzleFlows[index]}`);
+                const selected = rows.filter(row => variants.table[row] === variant);
                 if (selected.length !== 1)
                     return undefined;
                 resolved.push(entries[selected[0]]);
@@ -487,8 +512,11 @@ export async function inspectPrintFile(filePath, options) {
                 fail(`unsupported thermal-affecting filament command ${code}`);
             }
             else if (code === 'M145') {
+                // Airduct mode switch (P0 cooling, P1 heating) in the official H2-series,
+                // X2D and P2S start/end G-code; it sets no heater target. Other forms and
+                // models without a switchable airduct stay rejected.
                 const args = parameters(argumentsText);
-                if (args.size !== 1 || !args.has('P') || ![0, 1].includes(args.get('P')) || !['h2d', 'h2dpro', 'h2c', 'h2s', 'x2d'].includes(model))
+                if (args.size !== 1 || !args.has('P') || ![0, 1].includes(args.get('P')) || !['h2d', 'h2dpro', 'h2c', 'h2s', 'x2d', 'p2s'].includes(model))
                     fail('unsupported thermal-affecting M145 parameters');
             }
             else if (code === 'M142') {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "bambu-printer-mcp",
-  "version": "1.1.18",
+  "version": "1.1.20",
   "description": "MCP server for Bambu Lab 3D printers with STL manipulation, slicing, and print management",
   "main": "dist/index.js",
   "repository": {

package/src/safety/print-file.ts

@@ -154,11 +154,12 @@ export async function inspectPrintFile(filePath: string, options: {model:string;
     if(plateIndex!==0) return fail('raw G-code has only plate index 0');source=bytes.toString('utf8');
   } else return fail('unsupported printable artifact; use a sliced .3mf or textual .gcode file');
   if(/[\x00-\x08\x0b\x0c\x0e-\x1f\ufffd]/.test(source)) return fail('binary or malformed G-code is not supported');
-  const lines=source.split(/\r\n|\n|\r/);const metadata:Metadata[]=[project];
+  const lines=source.split(/\r\n|\n|\r/);const headers:Metadata[]=[];
   for(const line of lines) {
     const match=line.match(/^\s*;\s*([a-z_][a-z0-9_]*(?:\s+used\s+\[(?:g|mm)\])?)\s*(?:=|:)\s*(.*?)\s*$/i);
-    if(match) metadata.push({[match[1].toLowerCase()]:match[2]});
+    if(match) headers.push({[match[1].toLowerCase()]:match[2]});
   }
+  const metadata:Metadata[]=[project,...headers];
   validateFffJob([...metadata,plate]);
   const declaredModel=consistent(metadataValues(metadata,['printer_model']),normalizeModel,'printer model');
   if(declaredModel!==model) return fail(`file model ${declaredModel} contradicts requested model ${model}`);
@@ -178,6 +179,17 @@ export async function inspectPrintFile(filePath: string, options: {model:string;
     const entries=list(value).map(entry=>entry.toLowerCase().replace(/[\s_-]+/g,'_'));
     return entries.length && entries.every(Boolean)?entries:undefined;
   };
+  // Bambu Studio writes printer_extruder_id/printer_extruder_variant to
+  // project_settings.config as the full per-variant table, but to the plate
+  // G-code header as the per-physical-extruder selection it sliced with (for
+  // example ["1","1","1"] vs "1" on a single-nozzle P2S). Preserve the source:
+  // a plate header can never substitute a full table for its selected values.
+  const variantTable=<T>(key:string,rows:number,convert:(value:unknown)=>T[]|undefined):{table:T[];selected?:T[]}=>{
+    const field=key.replace(/_/g,' ');const tableValues=metadataValues([project],[key]);const selectedValues=metadataValues(headers,[key]);
+    if(tableValues.some(value=>list(value).length!==rows) || selectedValues.some(value=>list(value).length!==nozzleDiameters.length)) return fail(`unknown or malformed ${field} metadata`);
+    const table=consistent(tableValues,convert,field);
+    return {table,selected:selectedValues.length?consistent(selectedValues,convert,`selected ${field}`):undefined};
+  };
   const nozzleMetadata=(keys:string[],variantRows=false):string[]|undefined=>{
     const values=metadataValues(metadata,keys);
     return values.length ? consistent(values,value=>{
@@ -188,18 +200,27 @@ export async function inspectPrintFile(filePath: string, options: {model:string;
       // Bambu GUI projects may store nozzle types per extruder variant, while
       // diameters and selected flow types are per physical extruder. Never truncate
       // that variant table or mistake its rows for filament/nozzle positions.
-      const ids=consistent(metadataValues(metadata,['printer_extruder_id']),value=>{
-        const ids=list(value);return ids.length===entries.length && ids.every(id=>/^[1-9]\d*$/.test(id) && Number(id)<=nozzleDiameters.length)?ids.map(Number):undefined;
-      },'printer extruder id');
+      const {table:ids,selected:selectedIds}=variantTable('printer_extruder_id',entries.length,value=>{
+        const ids=list(value);return ids.length>0 && ids.every(id=>/^[1-9]\d*$/.test(id) && Number(id)<=nozzleDiameters.length)?ids.map(Number):undefined;
+      });
+      // The selected form names each physical extruder once, in order.
+      if(selectedIds && selectedIds.some((id,index)=>id!==index+1)) return undefined;
+      const variants=metadataValues(metadata,['printer_extruder_variant']).length
+        ? variantTable('printer_extruder_variant',entries.length,normalizedEntries):undefined;
+      const extruders=variants ? consistent(metadataValues(metadata,['extruder_type']),normalizedEntries,'extruder type'):undefined;
       const resolved:string[]=[];
       for(let index=0;index<nozzleDiameters.length;index++) {
         const rows=ids.flatMap((id,row)=>id===index+1?[row]:[]);
         if(!rows.length) return undefined;
-        if(rows.every(row=>entries[row]===entries[rows[0]])) {resolved.push(entries[rows[0]]);continue;}
-        const variants=consistent(metadataValues(metadata,['printer_extruder_variant']),normalizedEntries,'printer extruder variant');
-        const extruders=consistent(metadataValues(metadata,['extruder_type']),normalizedEntries,'extruder type');
-        if(variants.length!==entries.length || extruders.length!==nozzleDiameters.length || !nozzleFlows) return undefined;
-        const selected=rows.filter(row=>variants[row]===`${extruders[index]}_${nozzleFlows[index]}`);
+        if(!variants) {
+          if(!rows.every(row=>entries[row]===entries[rows[0]])) return undefined;
+          resolved.push(entries[rows[0]]);continue;
+        }
+        // Validate declared variants even when all rows use the same material.
+        if(!extruders || extruders.length!==nozzleDiameters.length || !nozzleFlows) return undefined;
+        const variant=`${extruders[index]}_${nozzleFlows[index]}`;
+        if(variants.selected && variants.selected[index]!==variant) return undefined;
+        const selected=rows.filter(row=>variants.table[row]===variant);
         if(selected.length!==1) return undefined;
         resolved.push(entries[selected[0]]);
       }
@@ -336,8 +357,11 @@ export async function inspectPrintFile(filePath: string, options: {model:string;
       } else if((/^M620\./.test(code) && !['M620.3','M620.6','M620.11'].includes(code)) || /^M621\./.test(code)) {
         fail(`unsupported thermal-affecting filament command ${code}`);
       } else if(code==='M145') {
+        // Airduct mode switch (P0 cooling, P1 heating) in the official H2-series,
+        // X2D and P2S start/end G-code; it sets no heater target. Other forms and
+        // models without a switchable airduct stay rejected.
         const args=parameters(argumentsText);
-        if(args.size!==1 || !args.has('P') || ![0,1].includes(args.get('P')!) || !['h2d','h2dpro','h2c','h2s','x2d'].includes(model)) fail('unsupported thermal-affecting M145 parameters');
+        if(args.size!==1 || !args.has('P') || ![0,1].includes(args.get('P')!) || !['h2d','h2dpro','h2c','h2s','x2d','p2s'].includes(model)) fail('unsupported thermal-affecting M145 parameters');
       } else if(code==='M142') {
         // Bambu chamber fan regulation thresholds, not an active heater command.
         const args=parameters(argumentsText);for(const key of ['S','R']) if(args.has(key) && (!Number.isFinite(args.get(key)) || args.get(key)!<0 || args.get(key)!>65)) fail('unsupported chamber fan temperature threshold');