ballerina-core 1.0.194 → 1.0.195

package/src/forms/domains/dispatched-forms/runner/domains/abstract-renderers/one/coroutines/_initializeOne.ts

@@ -14,7 +14,6 @@ import {
   Option,
 } from "../../../../../../../../../main";
 import { InitializeCo } from "./builder";
-import { initializeStream } from "./_initializeStream";
 
 export const initializeOne = <
   CustomPresentationContext = Unit,
@@ -23,11 +22,6 @@ export const initializeOne = <
   InitializeCo<CustomPresentationContext, ExtraContext>()
     .GetState()
     .then((current) => {
-      const InstantiatedInitializeCo = InitializeCo<
-        CustomPresentationContext,
-        ExtraContext
-      >();
-
       const maybeId = OneAbstractRendererState.Operations.GetIdFromContext(
         current,
       ).MapErrors((_) =>
@@ -38,71 +32,41 @@ export const initializeOne = <
 
       if (maybeId.kind === "errors") {
         console.error(maybeId.errors.join("\n"));
-        return InstantiatedInitializeCo.Wait(0);
-      }
-
-      const initializationCompletedCo = InitializeCo<
-        CustomPresentationContext,
-        ExtraContext
-      >().Seq([
-        InstantiatedInitializeCo.SetState(
-          current.customFormState.status == "open"
-            ? OneAbstractRendererState.Updaters.Core.customFormState.children.stream(
-                Sum.Updaters.left(
-                  ValueInfiniteStreamState.Updaters.Template.loadMore(),
-                ),
-              )
-            : IdUpdater,
-        ),
-      ]);
-
-      const hasInitialValue =
-        (PredicateValue.Operations.IsOption(current.value) &&
-          current.value.isSome) ||
-        PredicateValue.Operations.IsUnit(current.value);
-
-      if (hasInitialValue) {
-        return InstantiatedInitializeCo.Seq([initializationCompletedCo]);
+        return InitializeCo<CustomPresentationContext, ExtraContext>().Wait(0);
       }
 
-      const initializeValueCo = InitializeCo<
-        CustomPresentationContext,
-        ExtraContext
-      >()
+      return InitializeCo<CustomPresentationContext, ExtraContext>()
         .Await(
-          () => current.getApi(maybeId.value),
+          // get Api being defined is in the run condition and is a sign that this could be lazy loaded
+          () => current.getApi!(maybeId.value),
           (_) => console.error("error while getting api value for the one", _),
         )
         .then((value) =>
-          InstantiatedInitializeCo.Do(() => {
-            return current.fromApiParser(value.value).Then((result) => {
-              const updater = replaceWith<ValueOption | ValueUnit>(
-                ValueOption.Default.some(result),
-              );
-              const delta: DispatchDelta<BaseFlags> = {
-                kind: "OneReplace",
-                replace: result,
-                flags: {
-                  kind: "localOnly",
-                },
-                type: current.type,
-                sourceAncestorLookupTypeNames: current.lookupTypeAncestorNames,
-              };
-              current.onChange(Option.Default.some(updater), delta);
+          InitializeCo<CustomPresentationContext, ExtraContext>().Do(() => {
+            current
+              .fromApiParser(value.value)
+              .Then((result) => {
+                const updater = replaceWith<ValueOption | ValueUnit>(
+                  ValueOption.Default.some(result),
+                );
+                const delta: DispatchDelta<BaseFlags> = {
+                  kind: "OneReplace",
+                  replace: result,
+                  flags: {
+                    kind: "localOnly",
+                  },
+                  type: current.type,
+                  sourceAncestorLookupTypeNames:
+                    current.lookupTypeAncestorNames,
+                };
+                current.onChange(Option.Default.some(updater), delta);
 
-              return ValueOrErrors.Default.return(result);
-            });
+                return ValueOrErrors.Default.return(result);
+              })
+              .MapErrors((_) => {
+                console.error("error while parsing api value for the one", _);
+                return _;
+              });
           }),
         );
-
-      const initializeStreamCo = initializeStream<
-        CustomPresentationContext,
-        ExtraContext
-      >();
-
-      return InstantiatedInitializeCo.Seq([
-        initializeValueCo,
-        initializeStreamCo,
-        initializationCompletedCo,
-      ]);
     });

package/src/forms/domains/dispatched-forms/runner/domains/abstract-renderers/one/coroutines/_initializeStream.ts

@@ -30,7 +30,8 @@ export const initializeStream = <
             Sum.Default.left(
               ValueInfiniteStreamState.Default(
                 100,
-                current.customFormState.getChunkWithParams(maybeId.value)(
+                // safe because we check for undefined in the runFilter
+                current.customFormState.getChunkWithParams!(maybeId.value)(
                   current.customFormState.streamParams.value,
                 ),
               ),

package/src/forms/domains/dispatched-forms/runner/domains/abstract-renderers/one/coroutines/runner.ts

@@ -33,7 +33,9 @@ export const initializeOneRunner = <
       // if the value is some, we already have something to pass to the renderers
       // -> we don't have to run the initialization coroutine
       // if the inner value is unit, we are rendering a partial one
-      props.context.value.kind === "option" && !props.context.value.isSome,
+      props.context.value.kind === "option" &&
+      !props.context.value.isSome &&
+      props.context.getApi != undefined,
   });
 
 export const initializeStreamRunner = <
@@ -45,7 +47,9 @@ export const initializeStreamRunner = <
     OneAbstractRendererForeignMutationsExpected<Flags>
   >(initializeStream<CustomPresentationContext, ExtraContext>(), {
     interval: 15,
-    runFilter: (props) => props.context.customFormState.stream.kind === "r",
+    runFilter: (props) =>
+      props.context.customFormState.stream.kind === "r" &&
+      props.context.customFormState.getChunkWithParams !== undefined,
   });
 
 export const oneTableDebouncerRunner = <
@@ -60,7 +64,7 @@ export const oneTableDebouncerRunner = <
     runFilter: (props) =>
       Debounced.Operations.shouldCoroutineRun(
         props.context.customFormState.streamParams,
-      ),
+      ) && props.context.customFormState.getChunkWithParams !== undefined,
   });
 
 export const oneTableLoaderRunner = <

package/src/forms/domains/dispatched-forms/runner/domains/abstract-renderers/one/state.ts

@@ -43,7 +43,7 @@ export type OneAbstractRendererReadonlyContext<
   CustomPresentationContext,
   ExtraContext
 > & {
-  getApi: BasicFun<Guid, Promise<unknown>>;
+  getApi?: BasicFun<Guid, Promise<unknown>>;
   fromApiParser: (value: unknown) => ValueOrErrors<ValueRecord, string>;
   remoteEntityVersionIdentifier: string;
 };
@@ -55,19 +55,23 @@ export type OneAbstractRendererState = CommonAbstractRendererState & {
     streamParams: Debounced<Value<Map<string, string>>>;
     status: "open" | "closed";
     stream: Sum<ValueInfiniteStreamState, "not initialized">;
-    getChunkWithParams: BasicFun<
-      string,
-      BasicFun<Map<string, string>, ValueInfiniteStreamState["getChunk"]>
-    >;
+    getChunkWithParams:
+      | BasicFun<
+          string,
+          BasicFun<Map<string, string>, ValueInfiniteStreamState["getChunk"]>
+        >
+      | undefined;
   };
 };
 
 export const OneAbstractRendererState = {
   Default: (
-    getChunk: BasicFun<
-      string,
-      BasicFun<Map<string, string>, ValueInfiniteStreamState["getChunk"]>
-    >,
+    getChunk:
+      | BasicFun<
+          string,
+          BasicFun<Map<string, string>, ValueInfiniteStreamState["getChunk"]>
+        >
+      | undefined,
   ): OneAbstractRendererState => ({
     ...CommonAbstractRendererState.Default(),
     customFormState: {

package/src/forms/domains/dispatched-forms/runner/domains/abstract-renderers/one/template.tsx

@@ -450,7 +450,8 @@ export const OneAbstractRenderer = <
             OneAbstractRendererState.Updaters.Core.customFormState.children.stream(
               Sum.Updaters.left(
                 ValueInfiniteStreamState.Updaters.Template.reload(
-                  props.context.customFormState.getChunkWithParams(
+                  // safe because we check for undefined in the runFilter
+                  props.context.customFormState.getChunkWithParams!(
                     maybeId.value,
                   )(props.context.customFormState.streamParams.value),
                 ),

package/src/forms/domains/dispatched-forms/runner/domains/dispatcher/domains/one/state.ts

@@ -45,39 +45,46 @@ export const OneDispatcher = {
       CustomPresentationContexts,
       ExtraContext,
     >(
-      api: string | string[],
+      api: string[],
       dispatcherContext: DispatcherContext<
         any,
         Flags,
         CustomPresentationContexts,
         ExtraContext
       >,
-    ): ValueOrErrors<BasicFun<Guid, Promise<any>>, string> =>
-      typeof api == "string"
-        ? ValueOrErrors.Default.throwOne(
-            `Attempted to use a table API for a one, this is not allowed`,
-          )
-        : Array.isArray(api) &&
-            api.length == 2 &&
-            api.every((_) => typeof _ == "string")
-          ? dispatcherContext.lookupSources == undefined
-            ? ValueOrErrors.Default.throwOne(`lookup apis are undefined`)
-            : dispatcherContext
-                .lookupSources(api[0])
-                .Then((lookupSource) =>
-                  lookupSource.one == undefined
-                    ? ValueOrErrors.Default.throwOne(
-                        `lookup source missing "one" api`,
+    ): ValueOrErrors<BasicFun<Guid, Promise<any>> | undefined, string> =>
+      Array.isArray(api) &&
+      api.length == 2 &&
+      api.every((_) => typeof _ == "string")
+        ? dispatcherContext.specApis.lookups == undefined
+          ? ValueOrErrors.Default.return(undefined)
+          : dispatcherContext.specApis.lookups.get(api[0]) == undefined
+            ? ValueOrErrors.Default.return(undefined)
+            : dispatcherContext.specApis.lookups.get(api[0])?.one == undefined
+              ? ValueOrErrors.Default.return(undefined)
+              : dispatcherContext.specApis.lookups.get(api[0])?.one.get(api[1])
+                    ?.methods.get == false
+                ? ValueOrErrors.Default.return(undefined)
+                : dispatcherContext.lookupSources == undefined
+                  ? ValueOrErrors.Default.throwOne(
+                      `lookup api sources are undefined`,
+                    )
+                  : dispatcherContext
+                      .lookupSources(api[0])
+                      .Then((lookupSource) =>
+                        lookupSource.one == undefined
+                          ? ValueOrErrors.Default.throwOne(
+                              `lookup source missing "one" api`,
+                            )
+                          : lookupSource
+                              .one(api[1])
+                              .Then((source) =>
+                                ValueOrErrors.Default.return(source.get),
+                              ),
                       )
-                    : lookupSource
-                        .one(api[1])
-                        .Then((source) =>
-                          ValueOrErrors.Default.return(source.get),
-                        ),
-                )
-          : ValueOrErrors.Default.throwOne(
-              `api must be a string or an array of strings`,
-            ),
+        : ValueOrErrors.Default.throwOne(
+            `api must be a string or an array of strings`,
+          ),
     Dispatch: <
       T extends DispatchInjectablesTypes<T>,
       Flags,